From: Marc Zyngier <maz@kernel.org>
To: Pavel Machek <pavel@denx.de>
Cc: Sasha Levin <sashal@kernel.org>,
linux-kernel@vger.kernel.org, stable@vger.kernel.org,
Oliver Upton <oliver.upton@linux.dev>,
pbonzini@redhat.com, shuah@kernel.org,
linux-arm-kernel@lists.infradead.org, kvmarm@lists.linux.dev,
kvm@vger.kernel.org, linux-kselftest@vger.kernel.org
Subject: Re: [PATCH AUTOSEL 6.1 08/25] KVM: selftests: Add test for uaccesses to non-existent vgic-v2 CPUIF
Date: Mon, 13 May 2024 09:27:57 +0100 [thread overview]
Message-ID: <86zfsum7zm.wl-maz@kernel.org> (raw)
In-Reply-To: <ZkHNVtwcrf91k+dR@duo.ucw.cz>
On Mon, 13 May 2024 09:20:38 +0100,
Pavel Machek <pavel@denx.de> wrote:
>
> Hi!
>
> > Assert that accesses to a non-existent vgic-v2 CPU interface
> > consistently fail across the various KVM device attr ioctls. This also
> > serves as a regression test for a bug wherein KVM hits a NULL
> > dereference when the CPUID specified in the ioctl is invalid.
> >
> > Note that there is no need to print the observed errno, as TEST_ASSERT()
> > will take care of it.
>
> I don't think this fixes the bug... and thus we should not need it in
> stable.
Given that this goes together with an actually bug fix that was
backported, it *is*, for once, actually useful to have it in stable.
M.
--
Without deviation from the norm, progress is not possible.
WARNING: multiple messages have this Message-ID (diff)
From: Marc Zyngier <maz@kernel.org>
To: Pavel Machek <pavel@denx.de>
Cc: Sasha Levin <sashal@kernel.org>,
linux-kernel@vger.kernel.org, stable@vger.kernel.org,
Oliver Upton <oliver.upton@linux.dev>,
pbonzini@redhat.com, shuah@kernel.org,
linux-arm-kernel@lists.infradead.org, kvmarm@lists.linux.dev,
kvm@vger.kernel.org, linux-kselftest@vger.kernel.org
Subject: Re: [PATCH AUTOSEL 6.1 08/25] KVM: selftests: Add test for uaccesses to non-existent vgic-v2 CPUIF
Date: Mon, 13 May 2024 09:27:57 +0100 [thread overview]
Message-ID: <86zfsum7zm.wl-maz@kernel.org> (raw)
In-Reply-To: <ZkHNVtwcrf91k+dR@duo.ucw.cz>
On Mon, 13 May 2024 09:20:38 +0100,
Pavel Machek <pavel@denx.de> wrote:
>
> Hi!
>
> > Assert that accesses to a non-existent vgic-v2 CPU interface
> > consistently fail across the various KVM device attr ioctls. This also
> > serves as a regression test for a bug wherein KVM hits a NULL
> > dereference when the CPUID specified in the ioctl is invalid.
> >
> > Note that there is no need to print the observed errno, as TEST_ASSERT()
> > will take care of it.
>
> I don't think this fixes the bug... and thus we should not need it in
> stable.
Given that this goes together with an actually bug fix that was
backported, it *is*, for once, actually useful to have it in stable.
M.
--
Without deviation from the norm, progress is not possible.
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2024-05-13 8:28 UTC|newest]
Thread overview: 34+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-05-07 23:11 [PATCH AUTOSEL 6.1 01/25] ASoC: Intel: bytcr_rt5640: Apply Asus T100TA quirk to Asus T100TAM too Sasha Levin
2024-05-07 23:11 ` [PATCH AUTOSEL 6.1 02/25] regulator: irq_helpers: duplicate IRQ name Sasha Levin
2024-05-13 8:19 ` Pavel Machek
2024-05-07 23:11 ` [PATCH AUTOSEL 6.1 03/25] ASoC: rt5645: Fix the electric noise due to the CBJ contacts floating Sasha Levin
2024-05-13 8:14 ` Pavel Machek
2024-05-07 23:11 ` [PATCH AUTOSEL 6.1 04/25] ASoC: dt-bindings: rt5645: add cbj sleeve gpio property Sasha Levin
2024-05-13 8:16 ` Pavel Machek
2024-05-07 23:11 ` [PATCH AUTOSEL 6.1 05/25] regulator: vqmmc-ipq4019: fix module autoloading Sasha Levin
2024-05-07 23:11 ` [PATCH AUTOSEL 6.1 06/25] ASoC: rt715: add vendor clear control register Sasha Levin
2024-05-07 23:11 ` [PATCH AUTOSEL 6.1 07/25] ASoC: rt715-sdca: volume step modification Sasha Levin
2024-05-07 23:11 ` [PATCH AUTOSEL 6.1 08/25] KVM: selftests: Add test for uaccesses to non-existent vgic-v2 CPUIF Sasha Levin
2024-05-07 23:11 ` Sasha Levin
2024-05-13 8:20 ` Pavel Machek
2024-05-13 8:20 ` Pavel Machek
2024-05-13 8:27 ` Marc Zyngier [this message]
2024-05-13 8:27 ` Marc Zyngier
2024-05-07 23:11 ` [PATCH AUTOSEL 6.1 09/25] fpga: dfl-pci: add PCI subdevice ID for Intel D5005 card Sasha Levin
2024-05-07 23:11 ` [PATCH AUTOSEL 6.1 10/25] softirq: Fix suspicious RCU usage in __do_softirq() Sasha Levin
2024-05-07 23:11 ` [PATCH AUTOSEL 6.1 11/25] net: qede: sanitize 'rc' in qede_add_tc_flower_fltr() Sasha Levin
2024-05-07 23:11 ` [PATCH AUTOSEL 6.1 12/25] firewire: nosy: ensure user_length is taken into account when fetching packet contents Sasha Levin
2024-05-07 23:12 ` [PATCH AUTOSEL 6.1 13/25] ASoC: da7219-aad: fix usage of device_get_named_child_node() Sasha Levin
2024-05-07 23:12 ` [PATCH AUTOSEL 6.1 14/25] ALSA: hda: intel-dsp-config: harden I2C/I2S codec detection Sasha Levin
2024-05-07 23:12 ` [PATCH AUTOSEL 6.1 15/25] drm/amd/display: Add dtbclk access to dcn315 Sasha Levin
2024-05-07 23:12 ` [PATCH AUTOSEL 6.1 16/25] drm/amd/display: Atom Integrated System Info v2_2 for DCN35 Sasha Levin
2024-05-07 23:12 ` [PATCH AUTOSEL 6.1 17/25] drm/amd/display: Add VCO speed parameter for DCN31 FPU Sasha Levin
2024-05-07 23:12 ` [PATCH AUTOSEL 6.1 18/25] drm/amdkfd: Flush the process wq before creating a kfd_process Sasha Levin
2024-05-07 23:12 ` [PATCH AUTOSEL 6.1 19/25] x86/mm: Remove broken vsyscall emulation code from the page fault code Sasha Levin
2024-05-13 8:22 ` Pavel Machek
2024-05-07 23:12 ` [PATCH AUTOSEL 6.1 20/25] nvme: find numa distance only if controller has valid numa id Sasha Levin
2024-05-07 23:12 ` [PATCH AUTOSEL 6.1 21/25] nvmet-auth: return the error code to the nvmet_auth_host_hash() callers Sasha Levin
2024-05-07 23:12 ` [PATCH AUTOSEL 6.1 22/25] nvmet-auth: replace pr_debug() with pr_err() to report an error Sasha Levin
2024-05-07 23:12 ` [PATCH AUTOSEL 6.1 23/25] nvmet-tcp: fix possible memory leak when tearing down a controller Sasha Levin
2024-05-07 23:12 ` [PATCH AUTOSEL 6.1 24/25] nvmet: fix nvme status code when namespace is disabled Sasha Levin
2024-05-07 23:12 ` [PATCH AUTOSEL 6.1 25/25] epoll: be better about file lifetimes Sasha Levin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=86zfsum7zm.wl-maz@kernel.org \
--to=maz@kernel.org \
--cc=kvm@vger.kernel.org \
--cc=kvmarm@lists.linux.dev \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=oliver.upton@linux.dev \
--cc=pavel@denx.de \
--cc=pbonzini@redhat.com \
--cc=sashal@kernel.org \
--cc=shuah@kernel.org \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.