[Buildroot] [PATCH 1/1] package/spirv-llvm-translator: propagate llvm depends on wchar

[Buildroot] [PATCH 1/1] package/spirv-llvm-translator: propagate llvm depends on wchar

[Julien Olivain]

The target package spirv-llvm-translator was instroduced in Buildroot
commit [1] without propagating the llvm dependency on toolchains with
wchar support.

This commit fixes this issue.

Fixes:

    WARNING: unmet direct dependencies detected for BR2_PACKAGE_LLVM
      Depends on [n]: BR2_PACKAGE_LLVM_ARCH_SUPPORTS [=y] && BR2_TOOLCHAIN_GCC_AT_LEAST_7 [=y] && BR2_TOOLCHAIN_HAS_THREADS [=y] && BR2_INSTALL_LIBSTDCPP [=y] && !BR2_TOOLCHAIN_HAS_GCC_BUG_64735 [=n] && !BR2_STATIC_LIBS [=n] && BR2_USE_WCHAR [=n] && BR2_HOST_GCC_AT_LEAST_7 [=y]
      Selected by [y]:
      - BR2_PACKAGE_SPIRV_LLVM_TRANSLATOR [=y] && BR2_PACKAGE_LLVM_ARCH_SUPPORTS [=y] && BR2_TOOLCHAIN_GCC_AT_LEAST_7 [=y] && BR2_TOOLCHAIN_HAS_THREADS [=y] && BR2_INSTALL_LIBSTDCPP [=y] && !BR2_STATIC_LIBS [=n] && BR2_HOST_GCC_AT_LEAST_7 [=y]

[1] https://gitlab.com/buildroot.org/buildroot/-/commit/58f9c7b83c86b06e1a086dbe884e216799410118

Cc: Romain Naour <romain.naour@smile.fr>
Signed-off-by: Julien Olivain <ju.o@free.fr>
---
 package/spirv-llvm-translator/Config.in | 8 +++++---
 1 file changed, 5 insertions(+), 3 deletions(-)

diff --git a/package/spirv-llvm-translator/Config.in b/package/spirv-llvm-translator/Config.in
index 73ca787d8a..91bd7f5ba3 100644
--- a/package/spirv-llvm-translator/Config.in
+++ b/package/spirv-llvm-translator/Config.in
@@ -5,6 +5,7 @@ config BR2_PACKAGE_SPIRV_LLVM_TRANSLATOR
 	depends on BR2_TOOLCHAIN_HAS_THREADS
 	depends on BR2_INSTALL_LIBSTDCPP
 	depends on !BR2_STATIC_LIBS
+	depends on BR2_USE_WCHAR # llvm
 	depends on BR2_HOST_GCC_AT_LEAST_7 # host-llvm
 	select BR2_PACKAGE_LLVM
 	select BR2_PACKAGE_SPIRV_HEADERS
@@ -15,8 +16,9 @@ config BR2_PACKAGE_SPIRV_LLVM_TRANSLATOR
 
 	  https://github.com/khronosGroup/SPIRV-LLVM-Translator
 
-comment "spirv-translator needs a toolchain w/ threads, C++, gcc >= 7, dynamic library, host gcc >= 7"
+comment "spirv-translator needs a toolchain w/ wchar, threads, C++, gcc >= 7, dynamic library, host gcc >= 7"
 	depends on BR2_PACKAGE_LLVM_ARCH_SUPPORTS
 	depends on !BR2_TOOLCHAIN_HAS_THREADS || !BR2_INSTALL_LIBSTDCPP || \
-		!BR2_TOOLCHAIN_GCC_AT_LEAST_7 \
-		|| BR2_STATIC_LIBS || !BR2_HOST_GCC_AT_LEAST_7
+		!BR2_TOOLCHAIN_GCC_AT_LEAST_7 || \
+		BR2_STATIC_LIBS || !BR2_USE_WCHAR || \
+		!BR2_HOST_GCC_AT_LEAST_7
-- 
2.49.0

_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

Re: [Buildroot] [PATCH 1/1] package/spirv-llvm-translator: propagate llvm depends on wchar

[Peter Korsgaard]

>>>>> "Julien" == Julien Olivain <ju.o@free.fr> writes:

 > The target package spirv-llvm-translator was instroduced in Buildroot

s/instroduced/introduced/

Committed, thanks.

-- 
Bye, Peter Korsgaard
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot