All of lore.kernel.org
 help / color / mirror / Atom feed
From: Miquel Raynal <miquel.raynal@bootlin.com>
To: "Álvaro Fernández Rojas" <noltari@gmail.com>
Cc: linux-mtd@lists.infradead.org,  dregan@broadcom.com,
	bcm-kernel-feedback-list@broadcom.com,
	 florian.fainelli@broadcom.com, rafal@milecki.pl,
	 computersforpeace@gmail.com,  kamal.dasu@broadcom.com,
	dan.beygelman@broadcom.com,  william.zhang@broadcom.com,
	frieder.schrempf@kontron.de,  linux-kernel@vger.kernel.org,
	vigneshr@ti.com,  richard@nod.at,  bbrezillon@kernel.org,
	kdasu.kdev@gmail.com,  jaimeliao.tw@gmail.com,
	 kilobyte@angband.pl, jonas.gorski@gmail.com,  dgcbueu@gmail.com
Subject: Re: [PATCH v5] mtd: rawnand: brcmnand: legacy exec_op implementation
Date: Mon, 26 May 2025 11:33:33 +0200	[thread overview]
Message-ID: <871psb1zte.fsf@bootlin.com> (raw)
In-Reply-To: <874ix74yrh.fsf@bootlin.com> (Miquel Raynal's message of "Mon, 26 May 2025 09:28:02 +0200")

Hello,

>> AFAIK, the legacy functions were only using it for
>> NAND_CMD_SET_FEATURES, which we don't support:
>> https://github.com/torvalds/linux/blob/c86b63b82fde4f96ee94dde827a5f28ff5adeb57/drivers/mtd/nand/raw/brcmnand/brcmnand.c#L1922-L1938
>>
>> The other uses I could find are already covered by our
>> chip->ecc.read/write functions.
>>
>> In any case I've tested the patch for reading, erasing and writing the
>> NAND and so far I haven't found any unsupported error apart from
>> NAND_CMD_GET_FEATURES with a Macronix NAND in the Sercom H500-s
>> (BCM63268).
>> I believe it's used for unlocking the NAND, which isn't needed in that
>> device.
>
> Well, you are restoring an old behavior so I won't ask for a better
> support, but you should normally allow software ECC engines (and even no
> engine at all) and in this case the core will require a write path. I
> honestly think it is not very complex to implement but if someone is
> lacking this feature it can be added later.
>
> Please just fix the braces in the for loop that was reported, but no
> hurry, I'll only take this after -rc1.

Nevermind, I'm applying now. You can send a follow-up patch for -rc1 if
you want.

______________________________________________________
Linux MTD discussion mailing list
http://lists.infradead.org/mailman/listinfo/linux-mtd/

WARNING: multiple messages have this Message-ID (diff)
From: Miquel Raynal <miquel.raynal@bootlin.com>
To: "Álvaro Fernández Rojas" <noltari@gmail.com>
Cc: linux-mtd@lists.infradead.org,  dregan@broadcom.com,
	bcm-kernel-feedback-list@broadcom.com,
	 florian.fainelli@broadcom.com, rafal@milecki.pl,
	 computersforpeace@gmail.com,  kamal.dasu@broadcom.com,
	dan.beygelman@broadcom.com,  william.zhang@broadcom.com,
	frieder.schrempf@kontron.de,  linux-kernel@vger.kernel.org,
	vigneshr@ti.com,  richard@nod.at,  bbrezillon@kernel.org,
	kdasu.kdev@gmail.com,  jaimeliao.tw@gmail.com,
	 kilobyte@angband.pl, jonas.gorski@gmail.com,  dgcbueu@gmail.com
Subject: Re: [PATCH v5] mtd: rawnand: brcmnand: legacy exec_op implementation
Date: Mon, 26 May 2025 11:33:33 +0200	[thread overview]
Message-ID: <871psb1zte.fsf@bootlin.com> (raw)
In-Reply-To: <874ix74yrh.fsf@bootlin.com> (Miquel Raynal's message of "Mon, 26 May 2025 09:28:02 +0200")

Hello,

>> AFAIK, the legacy functions were only using it for
>> NAND_CMD_SET_FEATURES, which we don't support:
>> https://github.com/torvalds/linux/blob/c86b63b82fde4f96ee94dde827a5f28ff5adeb57/drivers/mtd/nand/raw/brcmnand/brcmnand.c#L1922-L1938
>>
>> The other uses I could find are already covered by our
>> chip->ecc.read/write functions.
>>
>> In any case I've tested the patch for reading, erasing and writing the
>> NAND and so far I haven't found any unsupported error apart from
>> NAND_CMD_GET_FEATURES with a Macronix NAND in the Sercom H500-s
>> (BCM63268).
>> I believe it's used for unlocking the NAND, which isn't needed in that
>> device.
>
> Well, you are restoring an old behavior so I won't ask for a better
> support, but you should normally allow software ECC engines (and even no
> engine at all) and in this case the core will require a write path. I
> honestly think it is not very complex to implement but if someone is
> lacking this feature it can be added later.
>
> Please just fix the braces in the for loop that was reported, but no
> hurry, I'll only take this after -rc1.

Nevermind, I'm applying now. You can send a follow-up patch for -rc1 if
you want.

  reply	other threads:[~2025-05-26  9:37 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-05-21  8:03 [PATCH v5] mtd: rawnand: brcmnand: legacy exec_op implementation Álvaro Fernández Rojas
2025-05-21  8:03 ` Álvaro Fernández Rojas
2025-05-22 20:21 ` Florian Fainelli
2025-05-22 20:21   ` Florian Fainelli
2025-05-23  0:03 ` William Zhang
2025-05-23  0:03   ` William Zhang
2025-05-23  0:54 ` David Regan
2025-05-23  0:54   ` David Regan
2025-05-23 14:41 ` Miquel Raynal
2025-05-23 14:41   ` Miquel Raynal
2025-05-23 18:08   ` Álvaro Fernández Rojas
2025-05-23 18:08     ` Álvaro Fernández Rojas
2025-05-26  7:28     ` Miquel Raynal
2025-05-26  7:28       ` Miquel Raynal
2025-05-26  9:33       ` Miquel Raynal [this message]
2025-05-26  9:33         ` Miquel Raynal
2025-05-23 17:02 ` David Regan
2025-05-23 17:02   ` David Regan

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=871psb1zte.fsf@bootlin.com \
    --to=miquel.raynal@bootlin.com \
    --cc=bbrezillon@kernel.org \
    --cc=bcm-kernel-feedback-list@broadcom.com \
    --cc=computersforpeace@gmail.com \
    --cc=dan.beygelman@broadcom.com \
    --cc=dgcbueu@gmail.com \
    --cc=dregan@broadcom.com \
    --cc=florian.fainelli@broadcom.com \
    --cc=frieder.schrempf@kontron.de \
    --cc=jaimeliao.tw@gmail.com \
    --cc=jonas.gorski@gmail.com \
    --cc=kamal.dasu@broadcom.com \
    --cc=kdasu.kdev@gmail.com \
    --cc=kilobyte@angband.pl \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mtd@lists.infradead.org \
    --cc=noltari@gmail.com \
    --cc=rafal@milecki.pl \
    --cc=richard@nod.at \
    --cc=vigneshr@ti.com \
    --cc=william.zhang@broadcom.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.