* [PATCH] drm: Remove redundant statement in drm_crtc_helper_set_mode()
@ 2024-11-11 13:21 Huacai Chen
2024-11-11 14:41 ` Jani Nikula
0 siblings, 1 reply; 6+ messages in thread
From: Huacai Chen @ 2024-11-11 13:21 UTC (permalink / raw)
To: David Airlie, Daniel Vetter, Huacai Chen; +Cc: dri-devel, Huacai Chen, stable
Commit dbbfaf5f2641a ("drm: Remove bridge support from legacy helpers")
removes the drm_bridge_mode_fixup() call in drm_crtc_helper_set_mode(),
which makes the subsequent "encoder_funcs = encoder->helper_private" be
redundant, so remove it.
Cc: stable@vger.kernel.org
Fixes: dbbfaf5f2641a ("drm: Remove bridge support from legacy helpers")
Signed-off-by: Huacai Chen <chenhuacai@loongson.cn>
---
drivers/gpu/drm/drm_crtc_helper.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/gpu/drm/drm_crtc_helper.c b/drivers/gpu/drm/drm_crtc_helper.c
index 0955f1c385dd..39497493f74c 100644
--- a/drivers/gpu/drm/drm_crtc_helper.c
+++ b/drivers/gpu/drm/drm_crtc_helper.c
@@ -334,7 +334,6 @@ bool drm_crtc_helper_set_mode(struct drm_crtc *crtc,
if (!encoder_funcs)
continue;
- encoder_funcs = encoder->helper_private;
if (encoder_funcs->mode_fixup) {
if (!(ret = encoder_funcs->mode_fixup(encoder, mode,
adjusted_mode))) {
--
2.43.5
^ permalink raw reply related [flat|nested] 6+ messages in thread* Re: [PATCH] drm: Remove redundant statement in drm_crtc_helper_set_mode() 2024-11-11 13:21 [PATCH] drm: Remove redundant statement in drm_crtc_helper_set_mode() Huacai Chen @ 2024-11-11 14:41 ` Jani Nikula 2024-11-25 6:00 ` Huacai Chen 0 siblings, 1 reply; 6+ messages in thread From: Jani Nikula @ 2024-11-11 14:41 UTC (permalink / raw) To: Huacai Chen, David Airlie, Daniel Vetter, Huacai Chen Cc: dri-devel, Huacai Chen, stable On Mon, 11 Nov 2024, Huacai Chen <chenhuacai@loongson.cn> wrote: > Commit dbbfaf5f2641a ("drm: Remove bridge support from legacy helpers") > removes the drm_bridge_mode_fixup() call in drm_crtc_helper_set_mode(), > which makes the subsequent "encoder_funcs = encoder->helper_private" be > redundant, so remove it. > > Cc: stable@vger.kernel.org > Fixes: dbbfaf5f2641a ("drm: Remove bridge support from legacy helpers") IMO not necessary because nothing's broken, it's just redundant. Reviewed-by: Jani Nikula <jani.nikula@intel.com> > Signed-off-by: Huacai Chen <chenhuacai@loongson.cn> > --- > drivers/gpu/drm/drm_crtc_helper.c | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/drivers/gpu/drm/drm_crtc_helper.c b/drivers/gpu/drm/drm_crtc_helper.c > index 0955f1c385dd..39497493f74c 100644 > --- a/drivers/gpu/drm/drm_crtc_helper.c > +++ b/drivers/gpu/drm/drm_crtc_helper.c > @@ -334,7 +334,6 @@ bool drm_crtc_helper_set_mode(struct drm_crtc *crtc, > if (!encoder_funcs) > continue; > > - encoder_funcs = encoder->helper_private; > if (encoder_funcs->mode_fixup) { > if (!(ret = encoder_funcs->mode_fixup(encoder, mode, > adjusted_mode))) { -- Jani Nikula, Intel ^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] drm: Remove redundant statement in drm_crtc_helper_set_mode() 2024-11-11 14:41 ` Jani Nikula @ 2024-11-25 6:00 ` Huacai Chen 2025-01-13 14:13 ` Huacai Chen 0 siblings, 1 reply; 6+ messages in thread From: Huacai Chen @ 2024-11-25 6:00 UTC (permalink / raw) To: Jani Nikula; +Cc: Huacai Chen, David Airlie, Daniel Vetter, dri-devel, stable On Mon, Nov 11, 2024 at 10:41 PM Jani Nikula <jani.nikula@linux.intel.com> wrote: > > On Mon, 11 Nov 2024, Huacai Chen <chenhuacai@loongson.cn> wrote: > > Commit dbbfaf5f2641a ("drm: Remove bridge support from legacy helpers") > > removes the drm_bridge_mode_fixup() call in drm_crtc_helper_set_mode(), > > which makes the subsequent "encoder_funcs = encoder->helper_private" be > > redundant, so remove it. > > > > Cc: stable@vger.kernel.org > > Fixes: dbbfaf5f2641a ("drm: Remove bridge support from legacy helpers") > > IMO not necessary because nothing's broken, it's just redundant. Maintainer is free to keep or remove the Cc and Fixes tag. :) Huacai > > Reviewed-by: Jani Nikula <jani.nikula@intel.com> > > > Signed-off-by: Huacai Chen <chenhuacai@loongson.cn> > > --- > > drivers/gpu/drm/drm_crtc_helper.c | 1 - > > 1 file changed, 1 deletion(-) > > > > diff --git a/drivers/gpu/drm/drm_crtc_helper.c b/drivers/gpu/drm/drm_crtc_helper.c > > index 0955f1c385dd..39497493f74c 100644 > > --- a/drivers/gpu/drm/drm_crtc_helper.c > > +++ b/drivers/gpu/drm/drm_crtc_helper.c > > @@ -334,7 +334,6 @@ bool drm_crtc_helper_set_mode(struct drm_crtc *crtc, > > if (!encoder_funcs) > > continue; > > > > - encoder_funcs = encoder->helper_private; > > if (encoder_funcs->mode_fixup) { > > if (!(ret = encoder_funcs->mode_fixup(encoder, mode, > > adjusted_mode))) { > > -- > Jani Nikula, Intel ^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] drm: Remove redundant statement in drm_crtc_helper_set_mode() 2024-11-25 6:00 ` Huacai Chen @ 2025-01-13 14:13 ` Huacai Chen 2025-03-26 14:02 ` Huacai Chen 0 siblings, 1 reply; 6+ messages in thread From: Huacai Chen @ 2025-01-13 14:13 UTC (permalink / raw) To: Jani Nikula; +Cc: Huacai Chen, David Airlie, Daniel Vetter, dri-devel, stable Hi, Dave, Gentle ping, can this patch be merged into 6.14? Huacai On Mon, Nov 25, 2024 at 2:00 PM Huacai Chen <chenhuacai@kernel.org> wrote: > > On Mon, Nov 11, 2024 at 10:41 PM Jani Nikula > <jani.nikula@linux.intel.com> wrote: > > > > On Mon, 11 Nov 2024, Huacai Chen <chenhuacai@loongson.cn> wrote: > > > Commit dbbfaf5f2641a ("drm: Remove bridge support from legacy helpers") > > > removes the drm_bridge_mode_fixup() call in drm_crtc_helper_set_mode(), > > > which makes the subsequent "encoder_funcs = encoder->helper_private" be > > > redundant, so remove it. > > > > > > Cc: stable@vger.kernel.org > > > Fixes: dbbfaf5f2641a ("drm: Remove bridge support from legacy helpers") > > > > IMO not necessary because nothing's broken, it's just redundant. > Maintainer is free to keep or remove the Cc and Fixes tag. :) > > Huacai > > > > > Reviewed-by: Jani Nikula <jani.nikula@intel.com> > > > > > Signed-off-by: Huacai Chen <chenhuacai@loongson.cn> > > > --- > > > drivers/gpu/drm/drm_crtc_helper.c | 1 - > > > 1 file changed, 1 deletion(-) > > > > > > diff --git a/drivers/gpu/drm/drm_crtc_helper.c b/drivers/gpu/drm/drm_crtc_helper.c > > > index 0955f1c385dd..39497493f74c 100644 > > > --- a/drivers/gpu/drm/drm_crtc_helper.c > > > +++ b/drivers/gpu/drm/drm_crtc_helper.c > > > @@ -334,7 +334,6 @@ bool drm_crtc_helper_set_mode(struct drm_crtc *crtc, > > > if (!encoder_funcs) > > > continue; > > > > > > - encoder_funcs = encoder->helper_private; > > > if (encoder_funcs->mode_fixup) { > > > if (!(ret = encoder_funcs->mode_fixup(encoder, mode, > > > adjusted_mode))) { > > > > -- > > Jani Nikula, Intel ^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] drm: Remove redundant statement in drm_crtc_helper_set_mode() 2025-01-13 14:13 ` Huacai Chen @ 2025-03-26 14:02 ` Huacai Chen 2025-03-27 12:05 ` Jani Nikula 0 siblings, 1 reply; 6+ messages in thread From: Huacai Chen @ 2025-03-26 14:02 UTC (permalink / raw) To: Jani Nikula; +Cc: Huacai Chen, David Airlie, Daniel Vetter, dri-devel, stable Hi, Dave, Gentle ping, can this patch be merged into 6.15? Huacai On Mon, Jan 13, 2025 at 10:13 PM Huacai Chen <chenhuacai@kernel.org> wrote: > > Hi, Dave, > > Gentle ping, can this patch be merged into 6.14? > > Huacai > > On Mon, Nov 25, 2024 at 2:00 PM Huacai Chen <chenhuacai@kernel.org> wrote: > > > > On Mon, Nov 11, 2024 at 10:41 PM Jani Nikula > > <jani.nikula@linux.intel.com> wrote: > > > > > > On Mon, 11 Nov 2024, Huacai Chen <chenhuacai@loongson.cn> wrote: > > > > Commit dbbfaf5f2641a ("drm: Remove bridge support from legacy helpers") > > > > removes the drm_bridge_mode_fixup() call in drm_crtc_helper_set_mode(), > > > > which makes the subsequent "encoder_funcs = encoder->helper_private" be > > > > redundant, so remove it. > > > > > > > > Cc: stable@vger.kernel.org > > > > Fixes: dbbfaf5f2641a ("drm: Remove bridge support from legacy helpers") > > > > > > IMO not necessary because nothing's broken, it's just redundant. > > Maintainer is free to keep or remove the Cc and Fixes tag. :) > > > > Huacai > > > > > > > > Reviewed-by: Jani Nikula <jani.nikula@intel.com> > > > > > > > Signed-off-by: Huacai Chen <chenhuacai@loongson.cn> > > > > --- > > > > drivers/gpu/drm/drm_crtc_helper.c | 1 - > > > > 1 file changed, 1 deletion(-) > > > > > > > > diff --git a/drivers/gpu/drm/drm_crtc_helper.c b/drivers/gpu/drm/drm_crtc_helper.c > > > > index 0955f1c385dd..39497493f74c 100644 > > > > --- a/drivers/gpu/drm/drm_crtc_helper.c > > > > +++ b/drivers/gpu/drm/drm_crtc_helper.c > > > > @@ -334,7 +334,6 @@ bool drm_crtc_helper_set_mode(struct drm_crtc *crtc, > > > > if (!encoder_funcs) > > > > continue; > > > > > > > > - encoder_funcs = encoder->helper_private; > > > > if (encoder_funcs->mode_fixup) { > > > > if (!(ret = encoder_funcs->mode_fixup(encoder, mode, > > > > adjusted_mode))) { > > > > > > -- > > > Jani Nikula, Intel ^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] drm: Remove redundant statement in drm_crtc_helper_set_mode() 2025-03-26 14:02 ` Huacai Chen @ 2025-03-27 12:05 ` Jani Nikula 0 siblings, 0 replies; 6+ messages in thread From: Jani Nikula @ 2025-03-27 12:05 UTC (permalink / raw) To: Huacai Chen; +Cc: Huacai Chen, David Airlie, Daniel Vetter, dri-devel, stable On Wed, 26 Mar 2025, Huacai Chen <chenhuacai@kernel.org> wrote: > Hi, Dave, > > Gentle ping, can this patch be merged into 6.15? Pushed to drm-misc-next. BR, Jani. > > Huacai > > On Mon, Jan 13, 2025 at 10:13 PM Huacai Chen <chenhuacai@kernel.org> wrote: >> >> Hi, Dave, >> >> Gentle ping, can this patch be merged into 6.14? >> >> Huacai >> >> On Mon, Nov 25, 2024 at 2:00 PM Huacai Chen <chenhuacai@kernel.org> wrote: >> > >> > On Mon, Nov 11, 2024 at 10:41 PM Jani Nikula >> > <jani.nikula@linux.intel.com> wrote: >> > > >> > > On Mon, 11 Nov 2024, Huacai Chen <chenhuacai@loongson.cn> wrote: >> > > > Commit dbbfaf5f2641a ("drm: Remove bridge support from legacy helpers") >> > > > removes the drm_bridge_mode_fixup() call in drm_crtc_helper_set_mode(), >> > > > which makes the subsequent "encoder_funcs = encoder->helper_private" be >> > > > redundant, so remove it. >> > > > >> > > > Cc: stable@vger.kernel.org >> > > > Fixes: dbbfaf5f2641a ("drm: Remove bridge support from legacy helpers") >> > > >> > > IMO not necessary because nothing's broken, it's just redundant. >> > Maintainer is free to keep or remove the Cc and Fixes tag. :) >> > >> > Huacai >> > >> > > >> > > Reviewed-by: Jani Nikula <jani.nikula@intel.com> >> > > >> > > > Signed-off-by: Huacai Chen <chenhuacai@loongson.cn> >> > > > --- >> > > > drivers/gpu/drm/drm_crtc_helper.c | 1 - >> > > > 1 file changed, 1 deletion(-) >> > > > >> > > > diff --git a/drivers/gpu/drm/drm_crtc_helper.c b/drivers/gpu/drm/drm_crtc_helper.c >> > > > index 0955f1c385dd..39497493f74c 100644 >> > > > --- a/drivers/gpu/drm/drm_crtc_helper.c >> > > > +++ b/drivers/gpu/drm/drm_crtc_helper.c >> > > > @@ -334,7 +334,6 @@ bool drm_crtc_helper_set_mode(struct drm_crtc *crtc, >> > > > if (!encoder_funcs) >> > > > continue; >> > > > >> > > > - encoder_funcs = encoder->helper_private; >> > > > if (encoder_funcs->mode_fixup) { >> > > > if (!(ret = encoder_funcs->mode_fixup(encoder, mode, >> > > > adjusted_mode))) { >> > > >> > > -- >> > > Jani Nikula, Intel -- Jani Nikula, Intel ^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2025-03-27 12:05 UTC | newest] Thread overview: 6+ messages (download: mbox.gz follow: Atom feed -- links below jump to the message on this page -- 2024-11-11 13:21 [PATCH] drm: Remove redundant statement in drm_crtc_helper_set_mode() Huacai Chen 2024-11-11 14:41 ` Jani Nikula 2024-11-25 6:00 ` Huacai Chen 2025-01-13 14:13 ` Huacai Chen 2025-03-26 14:02 ` Huacai Chen 2025-03-27 12:05 ` Jani Nikula
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.