From: Gregory CLEMENT <gregory.clement@bootlin.com>
To: Krzysztof Kozlowski <krzk@kernel.org>,
Robert Marko <robert.marko@sartura.hr>,
Andrew Lunn <andrew@lunn.ch>,
Sebastian Hesselbarth <sebastian.hesselbarth@gmail.com>,
Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Conor Dooley <conor+dt@kernel.org>,
linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org
Cc: Krzysztof Kozlowski <krzk@kernel.org>
Subject: Re: [PATCH 1/3] arm64: dts: marvell: eDPU: drop redundant address/size-cells
Date: Sun, 05 May 2024 18:06:12 +0200 [thread overview]
Message-ID: <871q6gp7kb.fsf@BLaptop.bootlin.com> (raw)
In-Reply-To: <20240402183240.49193-1-krzk@kernel.org>
Krzysztof Kozlowski <krzk@kernel.org> writes:
> The ethernet-switch node does not have children with unit addresses, so
> address/size-cells are not really correct, as reported by dtc W=1
> warning:
>
> armada-3720-eDPU.dts:26.19-60.4: Warning (avoid_unnecessary_addr_size): /soc/internal-regs@d0000000/mdio@32004/switch@0: unnecessary #address-cells/#size-cells without "ranges" or child "reg" property
>
> This probably also fixes dtbs_check warning, but I could not find it, so
> not sure about that.
>
> Signed-off-by: Krzysztof Kozlowski <krzk@kernel.org>
Applied on mvebu/dt64 as well as the 2 other pacthes.
Thanks,
Gregory
> ---
> arch/arm64/boot/dts/marvell/armada-3720-eDPU.dts | 2 --
> 1 file changed, 2 deletions(-)
>
> diff --git a/arch/arm64/boot/dts/marvell/armada-3720-eDPU.dts b/arch/arm64/boot/dts/marvell/armada-3720-eDPU.dts
> index d6d37a1f6f38..91c2f8b4edfa 100644
> --- a/arch/arm64/boot/dts/marvell/armada-3720-eDPU.dts
> +++ b/arch/arm64/boot/dts/marvell/armada-3720-eDPU.dts
> @@ -25,8 +25,6 @@ &mdio {
> /* Actual device is MV88E6361 */
> switch: switch@0 {
> compatible = "marvell,mv88e6190";
> - #address-cells = <1>;
> - #size-cells = <0>;
> reg = <0>;
> status = "disabled";
>
> --
> 2.34.1
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
WARNING: multiple messages have this Message-ID (diff)
From: Gregory CLEMENT <gregory.clement@bootlin.com>
To: Krzysztof Kozlowski <krzk@kernel.org>,
Robert Marko <robert.marko@sartura.hr>,
Andrew Lunn <andrew@lunn.ch>,
Sebastian Hesselbarth <sebastian.hesselbarth@gmail.com>,
Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Conor Dooley <conor+dt@kernel.org>,
linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org
Cc: Krzysztof Kozlowski <krzk@kernel.org>
Subject: Re: [PATCH 1/3] arm64: dts: marvell: eDPU: drop redundant address/size-cells
Date: Sun, 05 May 2024 18:06:12 +0200 [thread overview]
Message-ID: <871q6gp7kb.fsf@BLaptop.bootlin.com> (raw)
In-Reply-To: <20240402183240.49193-1-krzk@kernel.org>
Krzysztof Kozlowski <krzk@kernel.org> writes:
> The ethernet-switch node does not have children with unit addresses, so
> address/size-cells are not really correct, as reported by dtc W=1
> warning:
>
> armada-3720-eDPU.dts:26.19-60.4: Warning (avoid_unnecessary_addr_size): /soc/internal-regs@d0000000/mdio@32004/switch@0: unnecessary #address-cells/#size-cells without "ranges" or child "reg" property
>
> This probably also fixes dtbs_check warning, but I could not find it, so
> not sure about that.
>
> Signed-off-by: Krzysztof Kozlowski <krzk@kernel.org>
Applied on mvebu/dt64 as well as the 2 other pacthes.
Thanks,
Gregory
> ---
> arch/arm64/boot/dts/marvell/armada-3720-eDPU.dts | 2 --
> 1 file changed, 2 deletions(-)
>
> diff --git a/arch/arm64/boot/dts/marvell/armada-3720-eDPU.dts b/arch/arm64/boot/dts/marvell/armada-3720-eDPU.dts
> index d6d37a1f6f38..91c2f8b4edfa 100644
> --- a/arch/arm64/boot/dts/marvell/armada-3720-eDPU.dts
> +++ b/arch/arm64/boot/dts/marvell/armada-3720-eDPU.dts
> @@ -25,8 +25,6 @@ &mdio {
> /* Actual device is MV88E6361 */
> switch: switch@0 {
> compatible = "marvell,mv88e6190";
> - #address-cells = <1>;
> - #size-cells = <0>;
> reg = <0>;
> status = "disabled";
>
> --
> 2.34.1
next prev parent reply other threads:[~2024-05-05 16:06 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-04-02 18:32 [PATCH 1/3] arm64: dts: marvell: eDPU: drop redundant address/size-cells Krzysztof Kozlowski
2024-04-02 18:32 ` Krzysztof Kozlowski
2024-04-02 18:32 ` [PATCH 2/3] arm64: dts: marvell: turris-mox: drop unneeded flash address/size-cells Krzysztof Kozlowski
2024-04-02 18:32 ` Krzysztof Kozlowski
2024-04-02 19:10 ` Andrew Lunn
2024-04-02 19:10 ` Andrew Lunn
2024-04-02 19:28 ` Marek Behún
2024-04-02 19:28 ` Marek Behún
2024-04-02 18:32 ` [PATCH 3/3] arm64: dts: marvell: espressobin-ultra: fix Ethernet Switch unit address Krzysztof Kozlowski
2024-04-02 18:32 ` Krzysztof Kozlowski
2024-04-02 19:27 ` Andrew Lunn
2024-04-02 19:27 ` Andrew Lunn
2024-04-02 20:11 ` Krzysztof Kozlowski
2024-04-02 20:11 ` Krzysztof Kozlowski
2024-04-02 19:10 ` [PATCH 1/3] arm64: dts: marvell: eDPU: drop redundant address/size-cells Andrew Lunn
2024-04-02 19:10 ` Andrew Lunn
2024-05-05 16:06 ` Gregory CLEMENT [this message]
2024-05-05 16:06 ` Gregory CLEMENT
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=871q6gp7kb.fsf@BLaptop.bootlin.com \
--to=gregory.clement@bootlin.com \
--cc=andrew@lunn.ch \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=krzk@kernel.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=robert.marko@sartura.hr \
--cc=robh@kernel.org \
--cc=sebastian.hesselbarth@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.