From: Vinicius Costa Gomes <vinicius.gomes@intel.com>
To: "Song, Yoong Siang" <yoong.siang.song@intel.com>,
"Brandeburg, Jesse" <jesse.brandeburg@intel.com>,
"Nguyen, Anthony L" <anthony.l.nguyen@intel.com>,
"David S . Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
Richard Cochran <richardcochran@gmail.com>,
Alexei Starovoitov <ast@kernel.org>,
Daniel Borkmann <daniel@iogearbox.net>,
Jesper Dangaard Brouer <hawk@kernel.org>,
John Fastabend <john.fastabend@gmail.com>,
Stanislav Fomichev <sdf@google.com>,
"Bezdeka, Florian" <florian.bezdeka@siemens.com>,
Kurt Kanzenbach <kurt@linutronix.de>,
"Fijalkowski, Maciej" <maciej.fijalkowski@intel.com>
Cc: "intel-wired-lan@lists.osuosl.org"
<intel-wired-lan@lists.osuosl.org>,
"netdev@vger.kernel.org" <netdev@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"bpf@vger.kernel.org" <bpf@vger.kernel.org>,
"xdp-hints@xdp-project.net" <xdp-hints@xdp-project.net>
Subject: RE: [PATCH iwl-next,v4 1/1] igc: Add Tx hardware timestamp request for AF_XDP zero-copy packet
Date: Tue, 26 Mar 2024 11:30:27 -0700 [thread overview]
Message-ID: <871q7wq20s.fsf@intel.com> (raw)
In-Reply-To: <PH0PR11MB58308AF32C9678FA550F38BCD8352@PH0PR11MB5830.namprd11.prod.outlook.com>
"Song, Yoong Siang" <yoong.siang.song@intel.com> writes:
>>
>>More a question: you are potentially triggering an interrupt from
>>igc_ptp_clear_tx_tstamp() (igc_xsk_wakeup()) which can be called from
>>igc_down(). So, how does it work when there's a pending timestamp and
>>you remove the igc module? (example of a situation that it might be
>>problematic).
>
> Hi Vinicius,
>
> Thanks for reviewing the patch.
>
> There is test_bit(__IGC_DOWN, &adapter->state) checking in
> igc_sxk_wakeup(). Since igc_down() will set __IGC_DOWN before
> call into igc_ptp_suspend(), so I believe the checking in igc_sxk_wakeup()
> should be enough to prevent the situation that you mentioned.
>
Oh, I missed that one, sorry. Then:
Acked-by: Vinicius Costa Gomes <vinicius.gomes@intel.com>
Cheers,
--
Vinicius
WARNING: multiple messages have this Message-ID (diff)
From: Vinicius Costa Gomes <vinicius.gomes@intel.com>
To: "Song, Yoong Siang" <yoong.siang.song@intel.com>,
"Brandeburg, Jesse" <jesse.brandeburg@intel.com>,
"Nguyen, Anthony L" <anthony.l.nguyen@intel.com>,
"David S . Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
Richard Cochran <richardcochran@gmail.com>,
Alexei Starovoitov <ast@kernel.org>,
Daniel Borkmann <daniel@iogearbox.net>,
Jesper Dangaard Brouer <hawk@kernel.org>,
John Fastabend <john.fastabend@gmail.com>,
Stanislav Fomichev <sdf@google.com>,
"Bezdeka, Florian" <florian.bezdeka@siemens.com>,
Kurt Kanzenbach <kurt@linutronix.de>,
"Fijalkowski, Maciej" <maciej.fijalkowski@intel.com>
Cc: "netdev@vger.kernel.org" <netdev@vger.kernel.org>,
"bpf@vger.kernel.org" <bpf@vger.kernel.org>,
"xdp-hints@xdp-project.net" <xdp-hints@xdp-project.net>,
"intel-wired-lan@lists.osuosl.org"
<intel-wired-lan@lists.osuosl.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [Intel-wired-lan] [PATCH iwl-next, v4 1/1] igc: Add Tx hardware timestamp request for AF_XDP zero-copy packet
Date: Tue, 26 Mar 2024 11:30:27 -0700 [thread overview]
Message-ID: <871q7wq20s.fsf@intel.com> (raw)
In-Reply-To: <PH0PR11MB58308AF32C9678FA550F38BCD8352@PH0PR11MB5830.namprd11.prod.outlook.com>
"Song, Yoong Siang" <yoong.siang.song@intel.com> writes:
>>
>>More a question: you are potentially triggering an interrupt from
>>igc_ptp_clear_tx_tstamp() (igc_xsk_wakeup()) which can be called from
>>igc_down(). So, how does it work when there's a pending timestamp and
>>you remove the igc module? (example of a situation that it might be
>>problematic).
>
> Hi Vinicius,
>
> Thanks for reviewing the patch.
>
> There is test_bit(__IGC_DOWN, &adapter->state) checking in
> igc_sxk_wakeup(). Since igc_down() will set __IGC_DOWN before
> call into igc_ptp_suspend(), so I believe the checking in igc_sxk_wakeup()
> should be enough to prevent the situation that you mentioned.
>
Oh, I missed that one, sorry. Then:
Acked-by: Vinicius Costa Gomes <vinicius.gomes@intel.com>
Cheers,
--
Vinicius
next prev parent reply other threads:[~2024-03-26 18:30 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-03-25 2:09 [PATCH iwl-next,v4 1/1] igc: Add Tx hardware timestamp request for AF_XDP zero-copy packet Song Yoong Siang
2024-03-25 2:09 ` [Intel-wired-lan] [PATCH iwl-next, v4 " Song Yoong Siang
2024-03-26 2:29 ` [PATCH iwl-next,v4 " Vinicius Costa Gomes
2024-03-26 2:29 ` [Intel-wired-lan] [PATCH iwl-next, v4 " Vinicius Costa Gomes
2024-03-26 14:19 ` [PATCH iwl-next,v4 " Song, Yoong Siang
2024-03-26 14:19 ` [Intel-wired-lan] [PATCH iwl-next, v4 " Song, Yoong Siang
2024-03-26 18:30 ` Vinicius Costa Gomes [this message]
2024-03-26 18:30 ` Vinicius Costa Gomes
2024-03-26 8:56 ` [PATCH iwl-next,v4 " Florian Bezdeka
2024-03-26 8:56 ` [Intel-wired-lan] [PATCH iwl-next, v4 " Florian Bezdeka
2024-03-26 13:08 ` [PATCH iwl-next,v4 " Kurt Kanzenbach
2024-03-26 13:08 ` [Intel-wired-lan] [PATCH iwl-next, v4 " Kurt Kanzenbach
2024-03-26 14:55 ` [xdp-hints] Re: [PATCH iwl-next,v4 " Song, Yoong Siang
2024-03-26 14:55 ` [Intel-wired-lan] [xdp-hints] Re: [PATCH iwl-next, v4 " Song, Yoong Siang
2024-03-27 11:21 ` [xdp-hints] Re: [PATCH iwl-next,v4 " Florian Bezdeka
2024-03-27 11:21 ` [Intel-wired-lan] [xdp-hints] Re: [PATCH iwl-next, v4 " Florian Bezdeka
2024-03-27 14:54 ` [xdp-hints] Re: [PATCH iwl-next,v4 " Song, Yoong Siang
2024-03-27 14:54 ` [Intel-wired-lan] [xdp-hints] Re: [PATCH iwl-next, v4 " Song, Yoong Siang
2024-03-27 15:07 ` [xdp-hints] Re: [PATCH iwl-next,v4 " Florian Bezdeka
2024-03-27 15:07 ` [Intel-wired-lan] [xdp-hints] Re: [PATCH iwl-next, v4 " Florian Bezdeka
2024-04-08 11:31 ` [Intel-wired-lan] " naamax.meir
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=871q7wq20s.fsf@intel.com \
--to=vinicius.gomes@intel.com \
--cc=anthony.l.nguyen@intel.com \
--cc=ast@kernel.org \
--cc=bpf@vger.kernel.org \
--cc=daniel@iogearbox.net \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=florian.bezdeka@siemens.com \
--cc=hawk@kernel.org \
--cc=intel-wired-lan@lists.osuosl.org \
--cc=jesse.brandeburg@intel.com \
--cc=john.fastabend@gmail.com \
--cc=kuba@kernel.org \
--cc=kurt@linutronix.de \
--cc=linux-kernel@vger.kernel.org \
--cc=maciej.fijalkowski@intel.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=richardcochran@gmail.com \
--cc=sdf@google.com \
--cc=xdp-hints@xdp-project.net \
--cc=yoong.siang.song@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.