From: Jani Nikula <jani.nikula@linux.intel.com>
To: Thomas Zimmermann <tzimmermann@suse.de>,
javierm@redhat.com, chenhuacai@kernel.org
Cc: linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org,
Thorsten Leemhuis <regressions@leemhuis.info>,
Thomas Zimmermann <tzimmermann@suse.de>,
Jaak Ristioja <jaak@ristioja.ee>,
Huacai Chen <chenhuacai@loongson.cn>
Subject: Re: [PATCH] Revert "drivers/firmware: Move sysfb_init() from device_initcall to subsys_initcall_sync"
Date: Tue, 23 Jan 2024 21:17:13 +0200 [thread overview]
Message-ID: <871qa7n9l2.fsf@intel.com> (raw)
In-Reply-To: <874jf4nmgp.fsf@intel.com>
On Tue, 23 Jan 2024, Jani Nikula <jani.nikula@linux.intel.com> wrote:
> On Tue, 23 Jan 2024, Thomas Zimmermann <tzimmermann@suse.de> wrote:
>> This reverts commit 60aebc9559492cea6a9625f514a8041717e3a2e4.
>>
>> Commit 60aebc9559492cea ("drivers/firmware: Move sysfb_init() from
>> device_initcall to subsys_initcall_sync") messes up initialization order
>> of the graphics drivers and leads to blank displays on some systems. So
>> revert the commit.
>>
>> To make the display drivers fully independent from initialization
>> order requires to track framebuffer memory by device and independently
>> from the loaded drivers. The kernel currently lacks the infrastructure
>> to do so.
>>
>> Reported-by: Jaak Ristioja <jaak@ristioja.ee>
>> Closes: https://lore.kernel.org/dri-devel/ZUnNi3q3yB3zZfTl@P70.localdomain/T/#t
>> Reported-by: Huacai Chen <chenhuacai@loongson.cn>
>> Closes: https://lore.kernel.org/dri-devel/20231108024613.2898921-1-chenhuacai@loongson.cn/
>> Closes: https://gitlab.freedesktop.org/drm/intel/-/issues/10133
>
> FWIW,
>
> Acked-by: Jani Nikula <jani.nikula@intel.com>
>
> but would be great to get a Tested-by from Jaak or from the gitlab issue
> reporter.
The revert works for the gitlab issue reporter.
BR,
Jani.
--
Jani Nikula, Intel
prev parent reply other threads:[~2024-01-23 19:17 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-01-23 12:09 [PATCH] Revert "drivers/firmware: Move sysfb_init() from device_initcall to subsys_initcall_sync" Thomas Zimmermann
2024-01-23 12:09 ` Thomas Zimmermann
2024-01-23 13:12 ` Huacai Chen
2024-01-23 13:12 ` Huacai Chen
2024-01-23 13:15 ` Thomas Zimmermann
2024-01-23 13:38 ` Javier Martinez Canillas
2024-01-23 13:38 ` Javier Martinez Canillas
2024-01-23 14:39 ` Jani Nikula
2024-01-23 14:39 ` Jani Nikula
2024-01-23 19:17 ` Jani Nikula [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=871qa7n9l2.fsf@intel.com \
--to=jani.nikula@linux.intel.com \
--cc=chenhuacai@kernel.org \
--cc=chenhuacai@loongson.cn \
--cc=dri-devel@lists.freedesktop.org \
--cc=jaak@ristioja.ee \
--cc=javierm@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=regressions@leemhuis.info \
--cc=tzimmermann@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.