All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jonathan Corbet <corbet@lwn.net>
To: Jani Nikula <jani.nikula@intel.com>,
	Hunter Chasens <hunter.chasens18@ncf.edu>
Cc: Bagas Sanjaya <bagasdotme@gmail.com>,
	Luca Coelho <luciano.coelho@intel.com>,
	airlied@gmail.com, daniel@ffwll.ch,
	maarten.lankhorst@linux.intel.com, mripard@kernel.org,
	tzimmermann@suse.de, dri-devel@lists.freedesktop.org,
	Linux Documentation <linux-doc@vger.kernel.org>,
	Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v1] docs: gpu: rfc: i915_scheduler.rst remove unused directives for namespacing
Date: Mon, 06 Nov 2023 12:49:05 -0700	[thread overview]
Message-ID: <871qd24q8e.fsf@meer.lwn.net> (raw)
In-Reply-To: <87edh2zn2y.fsf@intel.com>

Jani Nikula <jani.nikula@intel.com> writes:

> Looks like this is because namespacing was introduced in Sphinx 3.1
> [1]. With earlier Sphinx, you get a warning about the namespace
> directives.
>
> However, with newer Sphinx, you get the warning mentioned in commit
> f6757dfcfde7 ("drm/doc: fix duplicate declaration warning") if you
> remove the namespace directives:
>
> linux/Documentation/gpu/driver-uapi.rst:2279: WARNING: Duplicate C declaration, also defined at rfc/i915_scheduler:3.
> Declaration is '.. c:struct:: i915_context_engines_parallel_submit'.
>
> It would be short-sighted to just remove the directives. Sooner or later
> we're gong to bump the (IMO extremely conservative) minimum version
> requirement.

I'd say let's just do that once the merge window is done.  A year ago
(in 31abfdda6527) I added a warning for <2.4.x, so raising the minimum
that far would appear to require no thought.  Going up to 3.1 is a step
beyond that, though, not sure if we want to go that far.

Something to ask at the LPC session next week.

Thanks,

jon

WARNING: multiple messages have this Message-ID (diff)
From: Jonathan Corbet <corbet@lwn.net>
To: Jani Nikula <jani.nikula@intel.com>,
	Hunter Chasens <hunter.chasens18@ncf.edu>
Cc: Bagas Sanjaya <bagasdotme@gmail.com>,
	Linux Documentation <linux-doc@vger.kernel.org>,
	tzimmermann@suse.de,
	Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
	mripard@kernel.org, Luca Coelho <luciano.coelho@intel.com>,
	dri-devel@lists.freedesktop.org
Subject: Re: [PATCH v1] docs: gpu: rfc: i915_scheduler.rst remove unused directives for namespacing
Date: Mon, 06 Nov 2023 12:49:05 -0700	[thread overview]
Message-ID: <871qd24q8e.fsf@meer.lwn.net> (raw)
In-Reply-To: <87edh2zn2y.fsf@intel.com>

Jani Nikula <jani.nikula@intel.com> writes:

> Looks like this is because namespacing was introduced in Sphinx 3.1
> [1]. With earlier Sphinx, you get a warning about the namespace
> directives.
>
> However, with newer Sphinx, you get the warning mentioned in commit
> f6757dfcfde7 ("drm/doc: fix duplicate declaration warning") if you
> remove the namespace directives:
>
> linux/Documentation/gpu/driver-uapi.rst:2279: WARNING: Duplicate C declaration, also defined at rfc/i915_scheduler:3.
> Declaration is '.. c:struct:: i915_context_engines_parallel_submit'.
>
> It would be short-sighted to just remove the directives. Sooner or later
> we're gong to bump the (IMO extremely conservative) minimum version
> requirement.

I'd say let's just do that once the merge window is done.  A year ago
(in 31abfdda6527) I added a warning for <2.4.x, so raising the minimum
that far would appear to require no thought.  Going up to 3.1 is a step
beyond that, though, not sure if we want to go that far.

Something to ask at the LPC session next week.

Thanks,

jon

  reply	other threads:[~2023-11-06 19:49 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-11-04 13:47 [PATCH v1] docs: gpu: rfc: i915_scheduler.rst remove unused directives for namespacing Hunter Chasens
2023-11-04 13:47 ` Hunter Chasens
2023-11-06  4:46 ` Bagas Sanjaya
2023-11-06  4:46   ` Bagas Sanjaya
2023-11-06 10:31   ` Jani Nikula
2023-11-06 10:31     ` Jani Nikula
2023-11-06 18:32     ` Hunter Chasens
2023-11-06 18:32       ` Hunter Chasens
2023-11-06 19:41       ` Jani Nikula
2023-11-06 19:41         ` Jani Nikula
2023-11-06 19:49         ` Jonathan Corbet [this message]
2023-11-06 19:49           ` Jonathan Corbet
2023-11-07  0:11         ` Bagas Sanjaya
2023-11-07  0:11           ` Bagas Sanjaya
2023-11-07  0:10     ` Bagas Sanjaya
2023-11-07  0:10       ` Bagas Sanjaya

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=871qd24q8e.fsf@meer.lwn.net \
    --to=corbet@lwn.net \
    --cc=airlied@gmail.com \
    --cc=bagasdotme@gmail.com \
    --cc=daniel@ffwll.ch \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=hunter.chasens18@ncf.edu \
    --cc=jani.nikula@intel.com \
    --cc=linux-doc@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=luciano.coelho@intel.com \
    --cc=maarten.lankhorst@linux.intel.com \
    --cc=mripard@kernel.org \
    --cc=tzimmermann@suse.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.