From: Andreas Schwab <schwab@linux-m68k.org>
To: Charlie Jenkins <charlie@rivosinc.com>
Cc: linux-riscv@lists.infradead.org, linux-mm@kvack.org,
linux-kernel@vger.kernel.org,
Eric Biederman <ebiederm@xmission.com>,
Kees Cook <keescook@chromium.org>,
Paul Walmsley <paul.walmsley@sifive.com>,
Palmer Dabbelt <palmer@dabbelt.com>,
Albert Ou <aou@eecs.berkeley.edu>
Subject: Re: [PATCH v4 1/2] riscv: Add remaining module relocations
Date: Wed, 18 Oct 2023 20:47:58 +0200 [thread overview]
Message-ID: <871qdr938h.fsf@igel.home> (raw)
In-Reply-To: <20231017-module_relocations-v4-1-937f5ef316f0@rivosinc.com> (Charlie Jenkins's message of "Tue, 17 Oct 2023 22:34:16 -0700")
On Okt 17 2023, Charlie Jenkins wrote:
> +static int apply_r_riscv_sub6_rela(struct module *me, u32 *location, Elf_Addr v)
> +{
> + *(u8 *)location = (*location - ((u8)v & 0x3F)) & 0x3F;
I think that should use *(u8*) on both sides.
--
Andreas Schwab, schwab@linux-m68k.org
GPG Key fingerprint = 7578 EB47 D4E5 4D69 2510 2552 DF73 E780 A9DA AEC1
"And now for something completely different."
_______________________________________________
linux-riscv mailing list
linux-riscv@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-riscv
WARNING: multiple messages have this Message-ID (diff)
From: Andreas Schwab <schwab@linux-m68k.org>
To: Charlie Jenkins <charlie@rivosinc.com>
Cc: linux-riscv@lists.infradead.org, linux-mm@kvack.org,
linux-kernel@vger.kernel.org,
Eric Biederman <ebiederm@xmission.com>,
Kees Cook <keescook@chromium.org>,
Paul Walmsley <paul.walmsley@sifive.com>,
Palmer Dabbelt <palmer@dabbelt.com>,
Albert Ou <aou@eecs.berkeley.edu>
Subject: Re: [PATCH v4 1/2] riscv: Add remaining module relocations
Date: Wed, 18 Oct 2023 20:47:58 +0200 [thread overview]
Message-ID: <871qdr938h.fsf@igel.home> (raw)
In-Reply-To: <20231017-module_relocations-v4-1-937f5ef316f0@rivosinc.com> (Charlie Jenkins's message of "Tue, 17 Oct 2023 22:34:16 -0700")
On Okt 17 2023, Charlie Jenkins wrote:
> +static int apply_r_riscv_sub6_rela(struct module *me, u32 *location, Elf_Addr v)
> +{
> + *(u8 *)location = (*location - ((u8)v & 0x3F)) & 0x3F;
I think that should use *(u8*) on both sides.
--
Andreas Schwab, schwab@linux-m68k.org
GPG Key fingerprint = 7578 EB47 D4E5 4D69 2510 2552 DF73 E780 A9DA AEC1
"And now for something completely different."
next prev parent reply other threads:[~2023-10-18 18:48 UTC|newest]
Thread overview: 32+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-10-18 5:34 [PATCH v4 0/2] riscv: Add remaining module relocations and tests Charlie Jenkins
2023-10-18 5:34 ` Charlie Jenkins
2023-10-18 5:34 ` [PATCH v4 1/2] riscv: Add remaining module relocations Charlie Jenkins
2023-10-18 5:34 ` Charlie Jenkins
2023-10-18 12:17 ` Emil Renner Berthing
2023-10-18 12:17 ` Emil Renner Berthing
2023-10-18 18:31 ` Charlie Jenkins
2023-10-18 18:31 ` Charlie Jenkins
2023-10-18 18:38 ` Emil Renner Berthing
2023-10-18 18:38 ` Emil Renner Berthing
2023-10-18 20:19 ` Charlie Jenkins
2023-10-18 20:19 ` Charlie Jenkins
2023-10-18 20:28 ` Emil Renner Berthing
2023-10-18 20:28 ` Emil Renner Berthing
2023-10-18 18:28 ` Samuel Holland
2023-10-18 18:28 ` Samuel Holland
2023-10-18 22:19 ` Charlie Jenkins
2023-10-18 22:19 ` Charlie Jenkins
2023-10-18 18:47 ` Andreas Schwab [this message]
2023-10-18 18:47 ` Andreas Schwab
2023-10-18 22:19 ` Charlie Jenkins
2023-10-18 22:19 ` Charlie Jenkins
2023-10-18 5:34 ` [PATCH v4 2/2] riscv: Add tests for riscv module loading Charlie Jenkins
2023-10-18 5:34 ` Charlie Jenkins
2023-10-18 11:35 ` [PATCH v4 0/2] riscv: Add remaining module relocations and tests Conor Dooley
2023-10-18 11:35 ` Conor Dooley
2023-10-18 17:31 ` Charlie Jenkins
2023-10-18 17:31 ` Charlie Jenkins
2023-10-18 17:41 ` Conor Dooley
2023-10-18 17:41 ` Conor Dooley
2023-10-19 5:56 ` Björn Töpel
2023-10-19 5:56 ` Björn Töpel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=871qdr938h.fsf@igel.home \
--to=schwab@linux-m68k.org \
--cc=aou@eecs.berkeley.edu \
--cc=charlie@rivosinc.com \
--cc=ebiederm@xmission.com \
--cc=keescook@chromium.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=linux-riscv@lists.infradead.org \
--cc=palmer@dabbelt.com \
--cc=paul.walmsley@sifive.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.