* [Intel-gfx] [PATCH 1/2] drm/i915: fix display probe for IVB Q and IVB D GT2 server
@ 2023-08-04 8:45 Jani Nikula
2023-08-04 8:46 ` [Intel-gfx] [PATCH 2/2] drm/i915: debug log when GMD ID indicates there's no display Jani Nikula
` (7 more replies)
0 siblings, 8 replies; 14+ messages in thread
From: Jani Nikula @ 2023-08-04 8:45 UTC (permalink / raw)
To: intel-gfx; +Cc: jani.nikula, Matt Roper, Andrzej Hajda
The current display probe is unable to differentiate between IVB Q and
IVB D GT2 server, as they both have the same device id, but different
subvendor and subdevice. This leads to the latter being misidentified as
the former, and should just end up not having a display. However, the no
display case returns a NULL as the display device info, and promptly
oopses.
As the IVB Q case is rare, and we're anyway moving towards GMD ID,
handle the identification requiring subvendor and subdevice as a special
case first, instead of unnecessarily growing the intel_display_ids[]
array with subvendor and subdevice.
[ 5.425298] BUG: kernel NULL pointer dereference, address: 0000000000000000
[ 5.426059] #PF: supervisor read access in kernel mode
[ 5.426810] #PF: error_code(0x0000) - not-present page
[ 5.427570] PGD 0 P4D 0
[ 5.428285] Oops: 0000 [#1] PREEMPT SMP PTI
[ 5.429035] CPU: 0 PID: 137 Comm: (udev-worker) Not tainted 6.4.0-1-amd64 #1 Debian 6.4.4-1
[ 5.429759] Hardware name: HP HP Z220 SFF Workstation/HP Z220 SFF Workstation, BIOS 4.19-218-gb184e6e0a1 02/02/2023
[ 5.430485] RIP: 0010:intel_device_info_driver_create+0xf1/0x120 [i915]
[ 5.431338] Code: 48 8b 97 80 1b 00 00 89 8f c0 1b 00 00 48 89 b7 b0 1b 00 00 48 89 97 b8 1b 00 00 0f b7 fd e8 76 e8 14 00 48 89 83 50 1b 00 00 <48> 8b 08 48 89 8b c4 1b 00 00 48 8b 48 08 48 89 8b cc 1b 00 00 8b
[ 5.432920] RSP: 0018:ffffb8254044fb98 EFLAGS: 00010206
[ 5.433707] RAX: 0000000000000000 RBX: ffff923076e80000 RCX: 0000000000000000
[ 5.434494] RDX: 0000000000000260 RSI: 0000000100001000 RDI: 000000000000016a
[ 5.435277] RBP: 000000000000016a R08: ffffb8254044fb00 R09: 0000000000000000
[ 5.436055] R10: ffff922d02761de8 R11: 00657361656c6572 R12: ffffffffc0e5d140
[ 5.436867] R13: ffff922d00b720d0 R14: 0000000076e80000 R15: ffff923078c0cae8
[ 5.437646] FS: 00007febd19a18c0(0000) GS:ffff92307c000000(0000) knlGS:0000000000000000
[ 5.438434] CS: 0010 DS: 0000 ES: 0000 CR0: 0000000080050033
[ 5.439218] CR2: 0000000000000000 CR3: 000000010256e002 CR4: 00000000001706f0
[ 5.440009] Call Trace:
[ 5.440824] <TASK>
[ 5.441611] ? __die+0x23/0x70
[ 5.442394] ? page_fault_oops+0x17d/0x4c0
[ 5.443173] ? exc_page_fault+0x7f/0x180
[ 5.443949] ? asm_exc_page_fault+0x26/0x30
[ 5.444756] ? intel_device_info_driver_create+0xf1/0x120 [i915]
[ 5.445652] ? intel_device_info_driver_create+0xea/0x120 [i915]
[ 5.446545] i915_driver_probe+0x7f/0xb60 [i915]
[ 5.447431] ? drm_privacy_screen_get+0x15c/0x1a0 [drm]
[ 5.448240] local_pci_probe+0x45/0xa0
[ 5.449013] pci_device_probe+0xc7/0x240
[ 5.449748] really_probe+0x19e/0x3e0
[ 5.450464] ? __pfx___driver_attach+0x10/0x10
[ 5.451172] __driver_probe_device+0x78/0x160
[ 5.451870] driver_probe_device+0x1f/0x90
[ 5.452601] __driver_attach+0xd2/0x1c0
[ 5.453293] bus_for_each_dev+0x88/0xd0
[ 5.453989] bus_add_driver+0x116/0x220
[ 5.454672] driver_register+0x59/0x100
[ 5.455336] i915_init+0x25/0xc0 [i915]
[ 5.456104] ? __pfx_i915_init+0x10/0x10 [i915]
[ 5.456882] do_one_initcall+0x5d/0x240
[ 5.457511] do_init_module+0x60/0x250
[ 5.458126] __do_sys_finit_module+0xac/0x120
[ 5.458721] do_syscall_64+0x60/0xc0
[ 5.459314] ? syscall_exit_to_user_mode+0x1b/0x40
[ 5.459897] ? do_syscall_64+0x6c/0xc0
[ 5.460510] entry_SYSCALL_64_after_hwframe+0x72/0xdc
[ 5.461082] RIP: 0033:0x7febd20b0eb9
[ 5.461648] Code: 08 89 e8 5b 5d c3 66 2e 0f 1f 84 00 00 00 00 00 90 48 89 f8 48 89 f7 48 89 d6 48 89 ca 4d 89 c2 4d 89 c8 4c 8b 4c 24 08 0f 05 <48> 3d 01 f0 ff ff 73 01 c3 48 8b 0d 2f 1f 0d 00 f7 d8 64 89 01 48
[ 5.462905] RSP: 002b:00007fffabb1ba78 EFLAGS: 00000246 ORIG_RAX: 0000000000000139
[ 5.463554] RAX: ffffffffffffffda RBX: 0000561e6304f410 RCX: 00007febd20b0eb9
[ 5.464201] RDX: 0000000000000000 RSI: 00007febd2244f0d RDI: 0000000000000015
[ 5.464869] RBP: 00007febd2244f0d R08: 0000000000000000 R09: 000000000000000a
[ 5.465512] R10: 0000000000000015 R11: 0000000000000246 R12: 0000000000020000
[ 5.466124] R13: 0000000000000000 R14: 0000561e63032b60 R15: 000000000000000a
[ 5.466700] </TASK>
[ 5.467271] Modules linked in: i915(+) drm_buddy video crc32_pclmul sr_mod hid_generic wmi crc32c_intel i2c_algo_bit sd_mod cdrom drm_display_helper cec usbhid rc_core ghash_clmulni_intel hid sha512_ssse3 ttm sha512_generic xhci_pci ehci_pci xhci_hcd ehci_hcd nvme ahci drm_kms_helper nvme_core libahci t10_pi libata psmouse aesni_intel scsi_mod crypto_simd i2c_i801 scsi_common crc64_rocksoft_generic cryptd i2c_smbus drm lpc_ich crc64_rocksoft crc_t10dif e1000e usbcore crct10dif_generic usb_common crct10dif_pclmul crc64 crct10dif_common button
[ 5.469750] CR2: 0000000000000000
[ 5.470364] ---[ end trace 0000000000000000 ]---
[ 5.470971] RIP: 0010:intel_device_info_driver_create+0xf1/0x120 [i915]
[ 5.471699] Code: 48 8b 97 80 1b 00 00 89 8f c0 1b 00 00 48 89 b7 b0 1b 00 00 48 89 97 b8 1b 00 00 0f b7 fd e8 76 e8 14 00 48 89 83 50 1b 00 00 <48> 8b 08 48 89 8b c4 1b 00 00 48 8b 48 08 48 89 8b cc 1b 00 00 8b
[ 5.473034] RSP: 0018:ffffb8254044fb98 EFLAGS: 00010206
[ 5.473698] RAX: 0000000000000000 RBX: ffff923076e80000 RCX: 0000000000000000
[ 5.474371] RDX: 0000000000000260 RSI: 0000000100001000 RDI: 000000000000016a
[ 5.475045] RBP: 000000000000016a R08: ffffb8254044fb00 R09: 0000000000000000
[ 5.475725] R10: ffff922d02761de8 R11: 00657361656c6572 R12: ffffffffc0e5d140
[ 5.476405] R13: ffff922d00b720d0 R14: 0000000076e80000 R15: ffff923078c0cae8
[ 5.477124] FS: 00007febd19a18c0(0000) GS:ffff92307c000000(0000) knlGS:0000000000000000
[ 5.477811] CS: 0010 DS: 0000 ES: 0000 CR0: 0000000080050033
[ 5.478499] CR2: 0000000000000000 CR3: 000000010256e002 CR4: 00000000001706f0
Fixes: 69d439818fe5 ("drm/i915/display: Make display responsible for probing its own IP")
Closes: https://gitlab.freedesktop.org/drm/intel/-/issues/8991
Cc: Matt Roper <matthew.d.roper@intel.com>
Cc: Andrzej Hajda <andrzej.hajda@intel.com>
Signed-off-by: Jani Nikula <jani.nikula@intel.com>
---
.../drm/i915/display/intel_display_device.c | 24 ++++++++++++++++---
1 file changed, 21 insertions(+), 3 deletions(-)
diff --git a/drivers/gpu/drm/i915/display/intel_display_device.c b/drivers/gpu/drm/i915/display/intel_display_device.c
index 8286e79522d1..3d6a262e037f 100644
--- a/drivers/gpu/drm/i915/display/intel_display_device.c
+++ b/drivers/gpu/drm/i915/display/intel_display_device.c
@@ -724,10 +724,24 @@ static const struct intel_display_device_info xe_lpdp_display = {
BIT(PORT_TC1) | BIT(PORT_TC2) | BIT(PORT_TC3) | BIT(PORT_TC4),
};
+/*
+ * Separate detection for no display cases to keep the display id array simple.
+ *
+ * IVB Q requires subvendor and subdevice matching to differentiate from IVB D
+ * GT2 server.
+ */
+static bool has_no_display(struct pci_dev *pdev)
+{
+ static const struct pci_device_id ids[] = {
+ INTEL_IVB_Q_IDS(0),
+ {}
+ };
+
+ return pci_match_id(ids, pdev);
+}
+
#undef INTEL_VGA_DEVICE
-#undef INTEL_QUANTA_VGA_DEVICE
#define INTEL_VGA_DEVICE(id, info) { id, info }
-#define INTEL_QUANTA_VGA_DEVICE(info) { 0x16a, info }
static const struct {
u32 devid;
@@ -752,7 +766,6 @@ static const struct {
INTEL_IRONLAKE_M_IDS(&ilk_m_display),
INTEL_SNB_D_IDS(&snb_display),
INTEL_SNB_M_IDS(&snb_display),
- INTEL_IVB_Q_IDS(NULL), /* must be first IVB in list */
INTEL_IVB_M_IDS(&ivb_display),
INTEL_IVB_D_IDS(&ivb_display),
INTEL_HSW_IDS(&hsw_display),
@@ -837,6 +850,11 @@ intel_display_device_probe(struct drm_i915_private *i915, bool has_gmdid,
if (has_gmdid)
return probe_gmdid_display(i915, gmdid_ver, gmdid_rel, gmdid_step);
+ if (has_no_display(pdev)) {
+ drm_dbg_kms(&i915->drm, "Device doesn't have display\n");
+ return &no_display;
+ }
+
for (i = 0; i < ARRAY_SIZE(intel_display_ids); i++) {
if (intel_display_ids[i].devid == pdev->device)
return intel_display_ids[i].info;
--
2.39.2
^ permalink raw reply related [flat|nested] 14+ messages in thread
* [Intel-gfx] [PATCH 2/2] drm/i915: debug log when GMD ID indicates there's no display
2023-08-04 8:45 [Intel-gfx] [PATCH 1/2] drm/i915: fix display probe for IVB Q and IVB D GT2 server Jani Nikula
@ 2023-08-04 8:46 ` Jani Nikula
2023-08-09 16:27 ` Luca Coelho
2023-08-04 17:03 ` [Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for series starting with [1/2] drm/i915: fix display probe for IVB Q and IVB D GT2 server Patchwork
` (6 subsequent siblings)
7 siblings, 1 reply; 14+ messages in thread
From: Jani Nikula @ 2023-08-04 8:46 UTC (permalink / raw)
To: intel-gfx; +Cc: jani.nikula
Debug log similar to the device id based identification of no display.
Signed-off-by: Jani Nikula <jani.nikula@intel.com>
---
drivers/gpu/drm/i915/display/intel_display_device.c | 5 +++--
1 file changed, 3 insertions(+), 2 deletions(-)
diff --git a/drivers/gpu/drm/i915/display/intel_display_device.c b/drivers/gpu/drm/i915/display/intel_display_device.c
index 3d6a262e037f..e4837f6fc01f 100644
--- a/drivers/gpu/drm/i915/display/intel_display_device.c
+++ b/drivers/gpu/drm/i915/display/intel_display_device.c
@@ -822,9 +822,10 @@ probe_gmdid_display(struct drm_i915_private *i915, u16 *ver, u16 *rel, u16 *step
val = ioread32(addr);
pci_iounmap(pdev, addr);
- if (val == 0)
- /* Platform doesn't have display */
+ if (val == 0) {
+ drm_dbg_kms(&i915->drm, "Device doesn't have display\n");
return &no_display;
+ }
*ver = REG_FIELD_GET(GMD_ID_ARCH_MASK, val);
*rel = REG_FIELD_GET(GMD_ID_RELEASE_MASK, val);
--
2.39.2
^ permalink raw reply related [flat|nested] 14+ messages in thread
* [Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for series starting with [1/2] drm/i915: fix display probe for IVB Q and IVB D GT2 server
2023-08-04 8:45 [Intel-gfx] [PATCH 1/2] drm/i915: fix display probe for IVB Q and IVB D GT2 server Jani Nikula
2023-08-04 8:46 ` [Intel-gfx] [PATCH 2/2] drm/i915: debug log when GMD ID indicates there's no display Jani Nikula
@ 2023-08-04 17:03 ` Patchwork
2023-08-04 17:04 ` [Intel-gfx] ✗ Fi.CI.SPARSE: " Patchwork
` (5 subsequent siblings)
7 siblings, 0 replies; 14+ messages in thread
From: Patchwork @ 2023-08-04 17:03 UTC (permalink / raw)
To: Jani Nikula; +Cc: intel-gfx
== Series Details ==
Series: series starting with [1/2] drm/i915: fix display probe for IVB Q and IVB D GT2 server
URL : https://patchwork.freedesktop.org/series/122015/
State : warning
== Summary ==
Error: dim checkpatch failed
/home/kbuild/linux/maintainer-tools/dim: line 50: /home/kbuild/.dimrc: No such file or directory
^ permalink raw reply [flat|nested] 14+ messages in thread
* [Intel-gfx] ✗ Fi.CI.SPARSE: warning for series starting with [1/2] drm/i915: fix display probe for IVB Q and IVB D GT2 server
2023-08-04 8:45 [Intel-gfx] [PATCH 1/2] drm/i915: fix display probe for IVB Q and IVB D GT2 server Jani Nikula
2023-08-04 8:46 ` [Intel-gfx] [PATCH 2/2] drm/i915: debug log when GMD ID indicates there's no display Jani Nikula
2023-08-04 17:03 ` [Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for series starting with [1/2] drm/i915: fix display probe for IVB Q and IVB D GT2 server Patchwork
@ 2023-08-04 17:04 ` Patchwork
2023-08-04 17:23 ` [Intel-gfx] ✓ Fi.CI.BAT: success " Patchwork
` (4 subsequent siblings)
7 siblings, 0 replies; 14+ messages in thread
From: Patchwork @ 2023-08-04 17:04 UTC (permalink / raw)
To: Jani Nikula; +Cc: intel-gfx
== Series Details ==
Series: series starting with [1/2] drm/i915: fix display probe for IVB Q and IVB D GT2 server
URL : https://patchwork.freedesktop.org/series/122015/
State : warning
== Summary ==
Error: dim sparse failed
/home/kbuild2/linux/maintainer-tools/dim: line 50: /home/kbuild2/.dimrc: No such file or directory
^ permalink raw reply [flat|nested] 14+ messages in thread
* [Intel-gfx] ✓ Fi.CI.BAT: success for series starting with [1/2] drm/i915: fix display probe for IVB Q and IVB D GT2 server
2023-08-04 8:45 [Intel-gfx] [PATCH 1/2] drm/i915: fix display probe for IVB Q and IVB D GT2 server Jani Nikula
` (2 preceding siblings ...)
2023-08-04 17:04 ` [Intel-gfx] ✗ Fi.CI.SPARSE: " Patchwork
@ 2023-08-04 17:23 ` Patchwork
2023-08-05 0:21 ` [Intel-gfx] ✓ Fi.CI.IGT: " Patchwork
` (3 subsequent siblings)
7 siblings, 0 replies; 14+ messages in thread
From: Patchwork @ 2023-08-04 17:23 UTC (permalink / raw)
To: Jani Nikula; +Cc: intel-gfx
[-- Attachment #1: Type: text/plain, Size: 9325 bytes --]
== Series Details ==
Series: series starting with [1/2] drm/i915: fix display probe for IVB Q and IVB D GT2 server
URL : https://patchwork.freedesktop.org/series/122015/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_13477 -> Patchwork_122015v1
====================================================
Summary
-------
**SUCCESS**
No regressions found.
External URL: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_122015v1/index.html
Participating hosts (43 -> 42)
------------------------------
Missing (1): fi-snb-2520m
Known issues
------------
Here are the changes found in Patchwork_122015v1 that come from known issues:
### IGT changes ###
#### Issues hit ####
* igt@i915_pm_rpm@basic-rte:
- fi-cfl-8109u: [PASS][1] -> [FAIL][2] ([i915#7940]) +1 similar issue
[1]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13477/fi-cfl-8109u/igt@i915_pm_rpm@basic-rte.html
[2]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_122015v1/fi-cfl-8109u/igt@i915_pm_rpm@basic-rte.html
* igt@i915_selftest@live@gt_heartbeat:
- fi-cfl-8109u: [PASS][3] -> [DMESG-FAIL][4] ([i915#5334])
[3]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13477/fi-cfl-8109u/igt@i915_selftest@live@gt_heartbeat.html
[4]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_122015v1/fi-cfl-8109u/igt@i915_selftest@live@gt_heartbeat.html
- fi-apl-guc: [PASS][5] -> [DMESG-FAIL][6] ([i915#5334])
[5]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13477/fi-apl-guc/igt@i915_selftest@live@gt_heartbeat.html
[6]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_122015v1/fi-apl-guc/igt@i915_selftest@live@gt_heartbeat.html
* igt@i915_selftest@live@gt_mocs:
- bat-mtlp-6: [PASS][7] -> [DMESG-FAIL][8] ([i915#7059])
[7]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13477/bat-mtlp-6/igt@i915_selftest@live@gt_mocs.html
[8]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_122015v1/bat-mtlp-6/igt@i915_selftest@live@gt_mocs.html
* igt@i915_selftest@live@requests:
- bat-mtlp-6: [PASS][9] -> [DMESG-FAIL][10] ([i915#8497])
[9]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13477/bat-mtlp-6/igt@i915_selftest@live@requests.html
[10]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_122015v1/bat-mtlp-6/igt@i915_selftest@live@requests.html
* igt@i915_selftest@live@slpc:
- bat-mtlp-8: NOTRUN -> [DMESG-WARN][11] ([i915#6367])
[11]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_122015v1/bat-mtlp-8/igt@i915_selftest@live@slpc.html
- bat-rpls-1: NOTRUN -> [DMESG-WARN][12] ([i915#6367])
[12]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_122015v1/bat-rpls-1/igt@i915_selftest@live@slpc.html
* igt@i915_suspend@basic-s3-without-i915:
- bat-mtlp-8: NOTRUN -> [SKIP][13] ([i915#6645])
[13]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_122015v1/bat-mtlp-8/igt@i915_suspend@basic-s3-without-i915.html
- bat-rpls-1: NOTRUN -> [ABORT][14] ([i915#6687] / [i915#7978] / [i915#8668])
[14]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_122015v1/bat-rpls-1/igt@i915_suspend@basic-s3-without-i915.html
* igt@kms_chamelium_hpd@common-hpd-after-suspend:
- bat-mtlp-8: NOTRUN -> [SKIP][15] ([i915#7828])
[15]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_122015v1/bat-mtlp-8/igt@kms_chamelium_hpd@common-hpd-after-suspend.html
* igt@kms_pipe_crc_basic@nonblocking-crc-frame-sequence:
- bat-dg2-11: NOTRUN -> [SKIP][16] ([i915#1845] / [i915#5354]) +3 similar issues
[16]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_122015v1/bat-dg2-11/igt@kms_pipe_crc_basic@nonblocking-crc-frame-sequence.html
* igt@kms_psr@cursor_plane_move:
- bat-rplp-1: NOTRUN -> [SKIP][17] ([i915#1072])
[17]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_122015v1/bat-rplp-1/igt@kms_psr@cursor_plane_move.html
* igt@kms_psr@sprite_plane_onoff:
- bat-rplp-1: NOTRUN -> [ABORT][18] ([i915#8712])
[18]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_122015v1/bat-rplp-1/igt@kms_psr@sprite_plane_onoff.html
#### Possible fixes ####
* igt@i915_pm_rpm@basic-rte:
- fi-cfl-guc: [FAIL][19] ([i915#7940]) -> [PASS][20]
[19]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13477/fi-cfl-guc/igt@i915_pm_rpm@basic-rte.html
[20]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_122015v1/fi-cfl-guc/igt@i915_pm_rpm@basic-rte.html
* igt@i915_pm_rpm@module-reload:
- fi-skl-guc: [FAIL][21] ([i915#7940]) -> [PASS][22]
[21]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13477/fi-skl-guc/igt@i915_pm_rpm@module-reload.html
[22]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_122015v1/fi-skl-guc/igt@i915_pm_rpm@module-reload.html
* igt@i915_selftest@live@gt_heartbeat:
- fi-kbl-soraka: [DMESG-FAIL][23] ([i915#5334] / [i915#7872]) -> [PASS][24]
[23]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13477/fi-kbl-soraka/igt@i915_selftest@live@gt_heartbeat.html
[24]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_122015v1/fi-kbl-soraka/igt@i915_selftest@live@gt_heartbeat.html
* igt@i915_selftest@live@reset:
- bat-rpls-1: [ABORT][25] ([i915#4983] / [i915#7461] / [i915#8347] / [i915#8384]) -> [PASS][26]
[25]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13477/bat-rpls-1/igt@i915_selftest@live@reset.html
[26]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_122015v1/bat-rpls-1/igt@i915_selftest@live@reset.html
#### Warnings ####
* igt@i915_module_load@load:
- bat-adlp-11: [DMESG-WARN][27] ([i915#4423]) -> [ABORT][28] ([i915#4423])
[27]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13477/bat-adlp-11/igt@i915_module_load@load.html
[28]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_122015v1/bat-adlp-11/igt@i915_module_load@load.html
* igt@i915_pm_rpm@basic-pci-d3-state:
- fi-kbl-guc: [FAIL][29] ([i915#7940]) -> [SKIP][30] ([fdo#109271])
[29]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13477/fi-kbl-guc/igt@i915_pm_rpm@basic-pci-d3-state.html
[30]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_122015v1/fi-kbl-guc/igt@i915_pm_rpm@basic-pci-d3-state.html
* igt@i915_selftest@live@requests:
- bat-mtlp-8: [ABORT][31] ([i915#7982]) -> [DMESG-FAIL][32] ([i915#8497])
[31]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13477/bat-mtlp-8/igt@i915_selftest@live@requests.html
[32]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_122015v1/bat-mtlp-8/igt@i915_selftest@live@requests.html
* igt@kms_psr@primary_page_flip:
- bat-rplp-1: [ABORT][33] ([i915#8442] / [i915#8668] / [i915#8860]) -> [SKIP][34] ([i915#1072])
[33]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13477/bat-rplp-1/igt@kms_psr@primary_page_flip.html
[34]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_122015v1/bat-rplp-1/igt@kms_psr@primary_page_flip.html
[fdo#109271]: https://bugs.freedesktop.org/show_bug.cgi?id=109271
[i915#1072]: https://gitlab.freedesktop.org/drm/intel/issues/1072
[i915#1845]: https://gitlab.freedesktop.org/drm/intel/issues/1845
[i915#4423]: https://gitlab.freedesktop.org/drm/intel/issues/4423
[i915#4983]: https://gitlab.freedesktop.org/drm/intel/issues/4983
[i915#5334]: https://gitlab.freedesktop.org/drm/intel/issues/5334
[i915#5354]: https://gitlab.freedesktop.org/drm/intel/issues/5354
[i915#6367]: https://gitlab.freedesktop.org/drm/intel/issues/6367
[i915#6645]: https://gitlab.freedesktop.org/drm/intel/issues/6645
[i915#6687]: https://gitlab.freedesktop.org/drm/intel/issues/6687
[i915#7059]: https://gitlab.freedesktop.org/drm/intel/issues/7059
[i915#7461]: https://gitlab.freedesktop.org/drm/intel/issues/7461
[i915#7828]: https://gitlab.freedesktop.org/drm/intel/issues/7828
[i915#7872]: https://gitlab.freedesktop.org/drm/intel/issues/7872
[i915#7940]: https://gitlab.freedesktop.org/drm/intel/issues/7940
[i915#7978]: https://gitlab.freedesktop.org/drm/intel/issues/7978
[i915#7982]: https://gitlab.freedesktop.org/drm/intel/issues/7982
[i915#8347]: https://gitlab.freedesktop.org/drm/intel/issues/8347
[i915#8384]: https://gitlab.freedesktop.org/drm/intel/issues/8384
[i915#8442]: https://gitlab.freedesktop.org/drm/intel/issues/8442
[i915#8497]: https://gitlab.freedesktop.org/drm/intel/issues/8497
[i915#8668]: https://gitlab.freedesktop.org/drm/intel/issues/8668
[i915#8712]: https://gitlab.freedesktop.org/drm/intel/issues/8712
[i915#8860]: https://gitlab.freedesktop.org/drm/intel/issues/8860
Build changes
-------------
* Linux: CI_DRM_13477 -> Patchwork_122015v1
CI-20190529: 20190529
CI_DRM_13477: 4a370c634541048c782ab36aee81ec52066b9c78 @ git://anongit.freedesktop.org/gfx-ci/linux
IGT_7415: 8764d812da7df2b3e880111482c8a5c13dd7bf87 @ https://gitlab.freedesktop.org/drm/igt-gpu-tools.git
Patchwork_122015v1: 4a370c634541048c782ab36aee81ec52066b9c78 @ git://anongit.freedesktop.org/gfx-ci/linux
### Linux commits
3e2152314d8f drm/i915: debug log when GMD ID indicates there's no display
b8fd4af3ffda drm/i915: fix display probe for IVB Q and IVB D GT2 server
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_122015v1/index.html
[-- Attachment #2: Type: text/html, Size: 11091 bytes --]
^ permalink raw reply [flat|nested] 14+ messages in thread
* [Intel-gfx] ✓ Fi.CI.IGT: success for series starting with [1/2] drm/i915: fix display probe for IVB Q and IVB D GT2 server
2023-08-04 8:45 [Intel-gfx] [PATCH 1/2] drm/i915: fix display probe for IVB Q and IVB D GT2 server Jani Nikula
` (3 preceding siblings ...)
2023-08-04 17:23 ` [Intel-gfx] ✓ Fi.CI.BAT: success " Patchwork
@ 2023-08-05 0:21 ` Patchwork
2023-08-09 16:26 ` [Intel-gfx] [PATCH 1/2] " Luca Coelho
` (2 subsequent siblings)
7 siblings, 0 replies; 14+ messages in thread
From: Patchwork @ 2023-08-05 0:21 UTC (permalink / raw)
To: Jani Nikula; +Cc: intel-gfx
[-- Attachment #1: Type: text/plain, Size: 32317 bytes --]
== Series Details ==
Series: series starting with [1/2] drm/i915: fix display probe for IVB Q and IVB D GT2 server
URL : https://patchwork.freedesktop.org/series/122015/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_13477_full -> Patchwork_122015v1_full
====================================================
Summary
-------
**SUCCESS**
No regressions found.
Participating hosts (10 -> 10)
------------------------------
No changes in participating hosts
Known issues
------------
Here are the changes found in Patchwork_122015v1_full that come from known issues:
### IGT changes ###
#### Issues hit ####
* igt@drm_fdinfo@virtual-busy-all:
- shard-dg2: NOTRUN -> [SKIP][1] ([i915#8414])
[1]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_122015v1/shard-dg2-1/igt@drm_fdinfo@virtual-busy-all.html
* igt@drm_mm@drm_mm_test:
- shard-snb: NOTRUN -> [SKIP][2] ([fdo#109271] / [i915#8661]) +1 similar issue
[2]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_122015v1/shard-snb7/igt@drm_mm@drm_mm_test.html
* igt@gem_ctx_exec@basic-nohangcheck:
- shard-rkl: [PASS][3] -> [FAIL][4] ([i915#6268])
[3]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13477/shard-rkl-7/igt@gem_ctx_exec@basic-nohangcheck.html
[4]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_122015v1/shard-rkl-1/igt@gem_ctx_exec@basic-nohangcheck.html
* igt@gem_ctx_persistence@smoketest:
- shard-snb: NOTRUN -> [SKIP][5] ([fdo#109271] / [i915#1099]) +3 similar issues
[5]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_122015v1/shard-snb1/igt@gem_ctx_persistence@smoketest.html
* igt@gem_eio@in-flight-contexts-10ms:
- shard-mtlp: [PASS][6] -> [ABORT][7] ([i915#7941])
[6]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13477/shard-mtlp-3/igt@gem_eio@in-flight-contexts-10ms.html
[7]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_122015v1/shard-mtlp-3/igt@gem_eio@in-flight-contexts-10ms.html
* igt@gem_eio@reset-stress:
- shard-dg1: [PASS][8] -> [FAIL][9] ([i915#5784])
[8]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13477/shard-dg1-16/igt@gem_eio@reset-stress.html
[9]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_122015v1/shard-dg1-13/igt@gem_eio@reset-stress.html
* igt@gem_eio@unwedge-stress:
- shard-snb: NOTRUN -> [FAIL][10] ([i915#8898])
[10]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_122015v1/shard-snb1/igt@gem_eio@unwedge-stress.html
* igt@gem_exec_await@wide-contexts:
- shard-dg2: [PASS][11] -> [FAIL][12] ([i915#5892])
[11]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13477/shard-dg2-10/igt@gem_exec_await@wide-contexts.html
[12]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_122015v1/shard-dg2-11/igt@gem_exec_await@wide-contexts.html
* igt@gem_exec_fair@basic-none-vip@rcs0:
- shard-glk: NOTRUN -> [FAIL][13] ([i915#2842])
[13]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_122015v1/shard-glk2/igt@gem_exec_fair@basic-none-vip@rcs0.html
* igt@gem_exec_fair@basic-pace-solo@rcs0:
- shard-rkl: [PASS][14] -> [FAIL][15] ([i915#2842]) +1 similar issue
[14]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13477/shard-rkl-4/igt@gem_exec_fair@basic-pace-solo@rcs0.html
[15]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_122015v1/shard-rkl-1/igt@gem_exec_fair@basic-pace-solo@rcs0.html
- shard-apl: [PASS][16] -> [FAIL][17] ([i915#2842])
[16]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13477/shard-apl1/igt@gem_exec_fair@basic-pace-solo@rcs0.html
[17]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_122015v1/shard-apl2/igt@gem_exec_fair@basic-pace-solo@rcs0.html
* igt@gem_exec_suspend@basic-s4-devices@lmem0:
- shard-dg2: [PASS][18] -> [ABORT][19] ([i915#7975] / [i915#8213])
[18]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13477/shard-dg2-11/igt@gem_exec_suspend@basic-s4-devices@lmem0.html
[19]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_122015v1/shard-dg2-8/igt@gem_exec_suspend@basic-s4-devices@lmem0.html
- shard-dg1: [PASS][20] -> [ABORT][21] ([i915#7975] / [i915#8213])
[20]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13477/shard-dg1-19/igt@gem_exec_suspend@basic-s4-devices@lmem0.html
[21]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_122015v1/shard-dg1-14/igt@gem_exec_suspend@basic-s4-devices@lmem0.html
* igt@gem_huc_copy@huc-copy:
- shard-glk: NOTRUN -> [SKIP][22] ([fdo#109271] / [i915#2190])
[22]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_122015v1/shard-glk2/igt@gem_huc_copy@huc-copy.html
* igt@gem_lmem_swapping@random-engines:
- shard-glk: NOTRUN -> [SKIP][23] ([fdo#109271] / [i915#4613]) +6 similar issues
[23]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_122015v1/shard-glk8/igt@gem_lmem_swapping@random-engines.html
* igt@gem_lmem_swapping@smem-oom@lmem0:
- shard-dg1: [PASS][24] -> [TIMEOUT][25] ([i915#5493])
[24]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13477/shard-dg1-17/igt@gem_lmem_swapping@smem-oom@lmem0.html
[25]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_122015v1/shard-dg1-15/igt@gem_lmem_swapping@smem-oom@lmem0.html
* igt@gem_mmap@bad-size:
- shard-dg2: NOTRUN -> [SKIP][26] ([i915#4083])
[26]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_122015v1/shard-dg2-1/igt@gem_mmap@bad-size.html
* igt@gem_render_copy@y-tiled-ccs-to-y-tiled-mc-ccs:
- shard-glk: NOTRUN -> [SKIP][27] ([fdo#109271]) +328 similar issues
[27]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_122015v1/shard-glk9/igt@gem_render_copy@y-tiled-ccs-to-y-tiled-mc-ccs.html
* igt@gem_userptr_blits@dmabuf-sync:
- shard-glk: NOTRUN -> [SKIP][28] ([fdo#109271] / [i915#3323])
[28]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_122015v1/shard-glk2/igt@gem_userptr_blits@dmabuf-sync.html
* igt@gem_userptr_blits@vma-merge:
- shard-glk: NOTRUN -> [FAIL][29] ([i915#3318])
[29]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_122015v1/shard-glk8/igt@gem_userptr_blits@vma-merge.html
* igt@i915_pipe_stress@stress-xrgb8888-untiled:
- shard-mtlp: [PASS][30] -> [FAIL][31] ([i915#8691])
[30]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13477/shard-mtlp-4/igt@i915_pipe_stress@stress-xrgb8888-untiled.html
[31]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_122015v1/shard-mtlp-1/igt@i915_pipe_stress@stress-xrgb8888-untiled.html
* igt@i915_pm_rc6_residency@rc6-idle@rcs0:
- shard-dg1: [PASS][32] -> [FAIL][33] ([i915#3591])
[32]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13477/shard-dg1-13/igt@i915_pm_rc6_residency@rc6-idle@rcs0.html
[33]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_122015v1/shard-dg1-16/igt@i915_pm_rc6_residency@rc6-idle@rcs0.html
* igt@i915_pm_rpm@dpms-mode-unset-non-lpsp:
- shard-dg2: [PASS][34] -> [SKIP][35] ([i915#1397]) +1 similar issue
[34]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13477/shard-dg2-11/igt@i915_pm_rpm@dpms-mode-unset-non-lpsp.html
[35]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_122015v1/shard-dg2-10/igt@i915_pm_rpm@dpms-mode-unset-non-lpsp.html
- shard-rkl: [PASS][36] -> [SKIP][37] ([i915#1397]) +1 similar issue
[36]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13477/shard-rkl-1/igt@i915_pm_rpm@dpms-mode-unset-non-lpsp.html
[37]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_122015v1/shard-rkl-7/igt@i915_pm_rpm@dpms-mode-unset-non-lpsp.html
* igt@i915_pm_rpm@modeset-non-lpsp-stress:
- shard-dg1: [PASS][38] -> [SKIP][39] ([i915#1397]) +1 similar issue
[38]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13477/shard-dg1-14/igt@i915_pm_rpm@modeset-non-lpsp-stress.html
[39]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_122015v1/shard-dg1-19/igt@i915_pm_rpm@modeset-non-lpsp-stress.html
* igt@i915_pm_rps@engine-order:
- shard-apl: [PASS][40] -> [FAIL][41] ([i915#6537])
[40]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13477/shard-apl7/igt@i915_pm_rps@engine-order.html
[41]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_122015v1/shard-apl4/igt@i915_pm_rps@engine-order.html
* igt@i915_selftest@live@gt_mocs:
- shard-mtlp: [PASS][42] -> [DMESG-FAIL][43] ([i915#7059])
[42]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13477/shard-mtlp-7/igt@i915_selftest@live@gt_mocs.html
[43]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_122015v1/shard-mtlp-4/igt@i915_selftest@live@gt_mocs.html
* igt@i915_selftest@live@workarounds:
- shard-mtlp: [PASS][44] -> [DMESG-FAIL][45] ([i915#6763])
[44]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13477/shard-mtlp-7/igt@i915_selftest@live@workarounds.html
[45]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_122015v1/shard-mtlp-4/igt@i915_selftest@live@workarounds.html
* igt@i915_suspend@forcewake:
- shard-dg2: [PASS][46] -> [FAIL][47] ([fdo#103375]) +3 similar issues
[46]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13477/shard-dg2-1/igt@i915_suspend@forcewake.html
[47]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_122015v1/shard-dg2-5/igt@i915_suspend@forcewake.html
* igt@kms_async_flips@crc@pipe-a-hdmi-a-3:
- shard-dg2: NOTRUN -> [FAIL][48] ([i915#8247]) +3 similar issues
[48]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_122015v1/shard-dg2-1/igt@kms_async_flips@crc@pipe-a-hdmi-a-3.html
* igt@kms_async_flips@crc@pipe-b-vga-1:
- shard-snb: NOTRUN -> [FAIL][49] ([i915#8247]) +1 similar issue
[49]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_122015v1/shard-snb2/igt@kms_async_flips@crc@pipe-b-vga-1.html
* igt@kms_async_flips@crc@pipe-d-hdmi-a-4:
- shard-dg1: NOTRUN -> [FAIL][50] ([i915#8247]) +3 similar issues
[50]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_122015v1/shard-dg1-18/igt@kms_async_flips@crc@pipe-d-hdmi-a-4.html
* igt@kms_big_fb@x-tiled-64bpp-rotate-90:
- shard-mtlp: NOTRUN -> [SKIP][51] ([fdo#111614])
[51]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_122015v1/shard-mtlp-1/igt@kms_big_fb@x-tiled-64bpp-rotate-90.html
* igt@kms_big_fb@x-tiled-max-hw-stride-64bpp-rotate-180-async-flip:
- shard-mtlp: [PASS][52] -> [FAIL][53] ([i915#3743])
[52]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13477/shard-mtlp-5/igt@kms_big_fb@x-tiled-max-hw-stride-64bpp-rotate-180-async-flip.html
[53]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_122015v1/shard-mtlp-5/igt@kms_big_fb@x-tiled-max-hw-stride-64bpp-rotate-180-async-flip.html
* igt@kms_ccs@pipe-a-missing-ccs-buffer-y_tiled_gen12_mc_ccs:
- shard-glk: NOTRUN -> [SKIP][54] ([fdo#109271] / [i915#3886]) +15 similar issues
[54]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_122015v1/shard-glk4/igt@kms_ccs@pipe-a-missing-ccs-buffer-y_tiled_gen12_mc_ccs.html
* igt@kms_ccs@pipe-b-crc-primary-rotation-180-yf_tiled_ccs:
- shard-dg2: NOTRUN -> [SKIP][55] ([i915#3689] / [i915#5354]) +1 similar issue
[55]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_122015v1/shard-dg2-1/igt@kms_ccs@pipe-b-crc-primary-rotation-180-yf_tiled_ccs.html
* igt@kms_ccs@pipe-c-bad-aux-stride-y_tiled_gen12_mc_ccs:
- shard-dg2: NOTRUN -> [SKIP][56] ([i915#3689] / [i915#3886] / [i915#5354])
[56]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_122015v1/shard-dg2-1/igt@kms_ccs@pipe-c-bad-aux-stride-y_tiled_gen12_mc_ccs.html
* igt@kms_ccs@pipe-c-crc-primary-rotation-180-yf_tiled_ccs:
- shard-mtlp: NOTRUN -> [SKIP][57] ([i915#6095])
[57]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_122015v1/shard-mtlp-1/igt@kms_ccs@pipe-c-crc-primary-rotation-180-yf_tiled_ccs.html
* igt@kms_cdclk@plane-scaling@pipe-b-dp-4:
- shard-dg2: NOTRUN -> [SKIP][58] ([i915#4087]) +3 similar issues
[58]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_122015v1/shard-dg2-11/igt@kms_cdclk@plane-scaling@pipe-b-dp-4.html
* igt@kms_cursor_crc@cursor-sliding-max-size:
- shard-dg2: NOTRUN -> [SKIP][59] ([i915#3555])
[59]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_122015v1/shard-dg2-1/igt@kms_cursor_crc@cursor-sliding-max-size.html
* igt@kms_cursor_legacy@flip-vs-cursor-atomic-transitions-varying-size:
- shard-glk: NOTRUN -> [FAIL][60] ([i915#2346])
[60]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_122015v1/shard-glk9/igt@kms_cursor_legacy@flip-vs-cursor-atomic-transitions-varying-size.html
* igt@kms_dither@fb-8bpc-vs-panel-6bpc@pipe-a-hdmi-a-1:
- shard-rkl: NOTRUN -> [SKIP][61] ([i915#3804])
[61]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_122015v1/shard-rkl-7/igt@kms_dither@fb-8bpc-vs-panel-6bpc@pipe-a-hdmi-a-1.html
* igt@kms_flip@2x-dpms-vs-vblank-race-interruptible:
- shard-dg2: NOTRUN -> [SKIP][62] ([fdo#109274])
[62]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_122015v1/shard-dg2-1/igt@kms_flip@2x-dpms-vs-vblank-race-interruptible.html
* igt@kms_flip@2x-nonexisting-fb:
- shard-snb: NOTRUN -> [SKIP][63] ([fdo#109271]) +179 similar issues
[63]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_122015v1/shard-snb2/igt@kms_flip@2x-nonexisting-fb.html
* igt@kms_flip@flip-vs-suspend-interruptible@b-vga1:
- shard-snb: NOTRUN -> [DMESG-WARN][64] ([i915#8841]) +3 similar issues
[64]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_122015v1/shard-snb2/igt@kms_flip@flip-vs-suspend-interruptible@b-vga1.html
* igt@kms_frontbuffer_tracking@fbc-tiling-linear:
- shard-dg2: [PASS][65] -> [FAIL][66] ([i915#6880]) +1 similar issue
[65]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13477/shard-dg2-8/igt@kms_frontbuffer_tracking@fbc-tiling-linear.html
[66]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_122015v1/shard-dg2-6/igt@kms_frontbuffer_tracking@fbc-tiling-linear.html
* igt@kms_hdr@bpc-switch-suspend:
- shard-dg2: NOTRUN -> [SKIP][67] ([i915#3555] / [i915#8228])
[67]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_122015v1/shard-dg2-1/igt@kms_hdr@bpc-switch-suspend.html
* igt@kms_plane_alpha_blend@alpha-basic@pipe-a-hdmi-a-1:
- shard-glk: NOTRUN -> [FAIL][68] ([i915#7862]) +1 similar issue
[68]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_122015v1/shard-glk4/igt@kms_plane_alpha_blend@alpha-basic@pipe-a-hdmi-a-1.html
* igt@kms_plane_scaling@intel-max-src-size@pipe-a-hdmi-a-4:
- shard-dg1: NOTRUN -> [FAIL][69] ([i915#8292])
[69]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_122015v1/shard-dg1-18/igt@kms_plane_scaling@intel-max-src-size@pipe-a-hdmi-a-4.html
* igt@kms_plane_scaling@plane-downscale-with-modifiers-factor-0-25@pipe-b-hdmi-a-1:
- shard-dg2: NOTRUN -> [SKIP][70] ([i915#5176]) +11 similar issues
[70]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_122015v1/shard-dg2-10/igt@kms_plane_scaling@plane-downscale-with-modifiers-factor-0-25@pipe-b-hdmi-a-1.html
* igt@kms_plane_scaling@plane-downscale-with-rotation-factor-0-25@pipe-b-hdmi-a-1:
- shard-rkl: NOTRUN -> [SKIP][71] ([i915#5176]) +11 similar issues
[71]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_122015v1/shard-rkl-7/igt@kms_plane_scaling@plane-downscale-with-rotation-factor-0-25@pipe-b-hdmi-a-1.html
* igt@kms_plane_scaling@plane-scaler-with-rotation-unity-scaling@pipe-d-hdmi-a-3:
- shard-dg1: NOTRUN -> [SKIP][72] ([i915#5176]) +7 similar issues
[72]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_122015v1/shard-dg1-13/igt@kms_plane_scaling@plane-scaler-with-rotation-unity-scaling@pipe-d-hdmi-a-3.html
* igt@kms_plane_scaling@planes-downscale-factor-0-25-upscale-20x20@pipe-a-hdmi-a-3:
- shard-dg1: NOTRUN -> [SKIP][73] ([i915#5235]) +15 similar issues
[73]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_122015v1/shard-dg1-12/igt@kms_plane_scaling@planes-downscale-factor-0-25-upscale-20x20@pipe-a-hdmi-a-3.html
* igt@kms_plane_scaling@planes-downscale-factor-0-25-upscale-20x20@pipe-b-hdmi-a-2:
- shard-rkl: NOTRUN -> [SKIP][74] ([i915#5235]) +5 similar issues
[74]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_122015v1/shard-rkl-2/igt@kms_plane_scaling@planes-downscale-factor-0-25-upscale-20x20@pipe-b-hdmi-a-2.html
* igt@kms_plane_scaling@planes-unity-scaling-downscale-factor-0-25@pipe-b-dp-4:
- shard-dg2: NOTRUN -> [SKIP][75] ([i915#5235]) +15 similar issues
[75]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_122015v1/shard-dg2-11/igt@kms_plane_scaling@planes-unity-scaling-downscale-factor-0-25@pipe-b-dp-4.html
* igt@kms_psr2_sf@cursor-plane-move-continuous-exceed-sf:
- shard-glk: NOTRUN -> [SKIP][76] ([fdo#109271] / [i915#658]) +3 similar issues
[76]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_122015v1/shard-glk9/igt@kms_psr2_sf@cursor-plane-move-continuous-exceed-sf.html
* igt@kms_psr@psr2_cursor_mmap_gtt:
- shard-dg2: NOTRUN -> [SKIP][77] ([i915#1072])
[77]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_122015v1/shard-dg2-1/igt@kms_psr@psr2_cursor_mmap_gtt.html
* igt@kms_selftest@drm_format:
- shard-glk: NOTRUN -> [SKIP][78] ([fdo#109271] / [i915#8661])
[78]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_122015v1/shard-glk9/igt@kms_selftest@drm_format.html
* igt@perf@non-zero-reason@0-rcs0:
- shard-dg2: [PASS][79] -> [FAIL][80] ([i915#7484])
[79]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13477/shard-dg2-10/igt@perf@non-zero-reason@0-rcs0.html
[80]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_122015v1/shard-dg2-11/igt@perf@non-zero-reason@0-rcs0.html
* igt@vc4/vc4_purgeable_bo@mark-willneed:
- shard-mtlp: NOTRUN -> [SKIP][81] ([i915#7711])
[81]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_122015v1/shard-mtlp-8/igt@vc4/vc4_purgeable_bo@mark-willneed.html
#### Possible fixes ####
* igt@gem_ctx_exec@basic-nohangcheck:
- shard-tglu: [FAIL][82] ([i915#6268]) -> [PASS][83]
[82]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13477/shard-tglu-2/igt@gem_ctx_exec@basic-nohangcheck.html
[83]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_122015v1/shard-tglu-2/igt@gem_ctx_exec@basic-nohangcheck.html
* igt@gem_exec_fair@basic-pace-share@rcs0:
- shard-glk: [FAIL][84] ([i915#2842]) -> [PASS][85]
[84]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13477/shard-glk4/igt@gem_exec_fair@basic-pace-share@rcs0.html
[85]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_122015v1/shard-glk3/igt@gem_exec_fair@basic-pace-share@rcs0.html
- shard-rkl: [FAIL][86] ([i915#2842]) -> [PASS][87] +2 similar issues
[86]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13477/shard-rkl-2/igt@gem_exec_fair@basic-pace-share@rcs0.html
[87]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_122015v1/shard-rkl-1/igt@gem_exec_fair@basic-pace-share@rcs0.html
* igt@gem_ppgtt@blt-vs-render-ctx0:
- shard-snb: [DMESG-FAIL][88] ([i915#8295]) -> [PASS][89]
[88]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13477/shard-snb1/igt@gem_ppgtt@blt-vs-render-ctx0.html
[89]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_122015v1/shard-snb2/igt@gem_ppgtt@blt-vs-render-ctx0.html
* igt@i915_pm_rc6_residency@rc6-idle@vecs0:
- shard-dg1: [FAIL][90] ([i915#3591]) -> [PASS][91] +1 similar issue
[90]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13477/shard-dg1-13/igt@i915_pm_rc6_residency@rc6-idle@vecs0.html
[91]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_122015v1/shard-dg1-16/igt@i915_pm_rc6_residency@rc6-idle@vecs0.html
* igt@i915_pm_rpm@cursor-dpms:
- shard-tglu: [FAIL][92] ([i915#7940]) -> [PASS][93] +1 similar issue
[92]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13477/shard-tglu-8/igt@i915_pm_rpm@cursor-dpms.html
[93]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_122015v1/shard-tglu-10/igt@i915_pm_rpm@cursor-dpms.html
* igt@i915_pm_rpm@dpms-mode-unset-non-lpsp:
- shard-dg1: [SKIP][94] ([i915#1397]) -> [PASS][95] +1 similar issue
[94]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13477/shard-dg1-19/igt@i915_pm_rpm@dpms-mode-unset-non-lpsp.html
[95]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_122015v1/shard-dg1-17/igt@i915_pm_rpm@dpms-mode-unset-non-lpsp.html
* igt@i915_pm_rpm@modeset-lpsp:
- shard-dg2: [SKIP][96] ([i915#1397]) -> [PASS][97]
[96]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13477/shard-dg2-8/igt@i915_pm_rpm@modeset-lpsp.html
[97]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_122015v1/shard-dg2-10/igt@i915_pm_rpm@modeset-lpsp.html
- shard-rkl: [SKIP][98] ([i915#1397]) -> [PASS][99]
[98]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13477/shard-rkl-1/igt@i915_pm_rpm@modeset-lpsp.html
[99]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_122015v1/shard-rkl-7/igt@i915_pm_rpm@modeset-lpsp.html
* igt@i915_suspend@basic-s2idle-without-i915:
- shard-apl: [DMESG-WARN][100] ([i915#1982]) -> [PASS][101]
[100]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13477/shard-apl4/igt@i915_suspend@basic-s2idle-without-i915.html
[101]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_122015v1/shard-apl6/igt@i915_suspend@basic-s2idle-without-i915.html
* igt@i915_suspend@basic-s3-without-i915:
- shard-rkl: [FAIL][102] ([fdo#103375]) -> [PASS][103]
[102]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13477/shard-rkl-4/igt@i915_suspend@basic-s3-without-i915.html
[103]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_122015v1/shard-rkl-2/igt@i915_suspend@basic-s3-without-i915.html
* igt@i915_suspend@debugfs-reader:
- shard-dg2: [FAIL][104] ([fdo#103375]) -> [PASS][105] +1 similar issue
[104]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13477/shard-dg2-5/igt@i915_suspend@debugfs-reader.html
[105]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_122015v1/shard-dg2-11/igt@i915_suspend@debugfs-reader.html
* igt@kms_big_fb@4-tiled-max-hw-stride-64bpp-rotate-0-hflip:
- shard-mtlp: [FAIL][106] ([i915#5138]) -> [PASS][107]
[106]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13477/shard-mtlp-4/igt@kms_big_fb@4-tiled-max-hw-stride-64bpp-rotate-0-hflip.html
[107]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_122015v1/shard-mtlp-1/igt@kms_big_fb@4-tiled-max-hw-stride-64bpp-rotate-0-hflip.html
* igt@kms_cursor_legacy@flip-vs-cursor-atomic-transitions-varying-size:
- shard-apl: [FAIL][108] ([i915#2346]) -> [PASS][109] +1 similar issue
[108]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13477/shard-apl7/igt@kms_cursor_legacy@flip-vs-cursor-atomic-transitions-varying-size.html
[109]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_122015v1/shard-apl4/igt@kms_cursor_legacy@flip-vs-cursor-atomic-transitions-varying-size.html
* igt@kms_plane@pixel-format-source-clamping@pipe-b-planes:
- shard-mtlp: [FAIL][110] ([i915#1623]) -> [PASS][111]
[110]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13477/shard-mtlp-7/igt@kms_plane@pixel-format-source-clamping@pipe-b-planes.html
[111]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_122015v1/shard-mtlp-7/igt@kms_plane@pixel-format-source-clamping@pipe-b-planes.html
* igt@perf_pmu@busy-double-start@vecs1:
- shard-dg2: [FAIL][112] ([i915#4349]) -> [PASS][113] +3 similar issues
[112]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13477/shard-dg2-5/igt@perf_pmu@busy-double-start@vecs1.html
[113]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_122015v1/shard-dg2-11/igt@perf_pmu@busy-double-start@vecs1.html
* igt@sysfs_heartbeat_interval@nopreempt@ccs0:
- shard-mtlp: [FAIL][114] ([i915#6015]) -> [PASS][115] +1 similar issue
[114]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13477/shard-mtlp-4/igt@sysfs_heartbeat_interval@nopreempt@ccs0.html
[115]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_122015v1/shard-mtlp-1/igt@sysfs_heartbeat_interval@nopreempt@ccs0.html
* igt@sysfs_timeslice_duration@timeout@ccs2:
- shard-dg2: [ABORT][116] -> [PASS][117]
[116]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13477/shard-dg2-11/igt@sysfs_timeslice_duration@timeout@ccs2.html
[117]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_122015v1/shard-dg2-1/igt@sysfs_timeslice_duration@timeout@ccs2.html
#### Warnings ####
* igt@i915_selftest@live@requests:
- shard-mtlp: [DMESG-FAIL][118] ([i915#8497]) -> [DMESG-FAIL][119] ([i915#7269])
[118]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13477/shard-mtlp-7/igt@i915_selftest@live@requests.html
[119]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_122015v1/shard-mtlp-4/igt@i915_selftest@live@requests.html
* igt@kms_content_protection@mei_interface:
- shard-dg2: [SKIP][120] ([i915#7118]) -> [SKIP][121] ([i915#7118] / [i915#7162]) +1 similar issue
[120]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13477/shard-dg2-10/igt@kms_content_protection@mei_interface.html
[121]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_122015v1/shard-dg2-11/igt@kms_content_protection@mei_interface.html
* igt@kms_content_protection@type1:
- shard-dg2: [SKIP][122] ([i915#7118] / [i915#7162]) -> [SKIP][123] ([i915#7118])
[122]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13477/shard-dg2-11/igt@kms_content_protection@type1.html
[123]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_122015v1/shard-dg2-10/igt@kms_content_protection@type1.html
* igt@kms_fbcon_fbt@psr:
- shard-rkl: [SKIP][124] ([fdo#110189] / [i915#3955]) -> [SKIP][125] ([i915#3955])
[124]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13477/shard-rkl-1/igt@kms_fbcon_fbt@psr.html
[125]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_122015v1/shard-rkl-6/igt@kms_fbcon_fbt@psr.html
* igt@kms_fbcon_fbt@psr-suspend:
- shard-rkl: [SKIP][126] ([i915#3955]) -> [SKIP][127] ([fdo#110189] / [i915#3955])
[126]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13477/shard-rkl-7/igt@kms_fbcon_fbt@psr-suspend.html
[127]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_122015v1/shard-rkl-2/igt@kms_fbcon_fbt@psr-suspend.html
* igt@kms_psr@cursor_plane_move:
- shard-dg1: [SKIP][128] ([i915#1072]) -> [SKIP][129] ([i915#1072] / [i915#4078])
[128]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13477/shard-dg1-15/igt@kms_psr@cursor_plane_move.html
[129]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_122015v1/shard-dg1-12/igt@kms_psr@cursor_plane_move.html
* igt@kms_psr@primary_page_flip:
- shard-dg1: [SKIP][130] ([i915#1072] / [i915#4078]) -> [SKIP][131] ([i915#1072]) +1 similar issue
[130]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13477/shard-dg1-18/igt@kms_psr@primary_page_flip.html
[131]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_122015v1/shard-dg1-17/igt@kms_psr@primary_page_flip.html
[fdo#103375]: https://bugs.freedesktop.org/show_bug.cgi?id=103375
[fdo#109271]: https://bugs.freedesktop.org/show_bug.cgi?id=109271
[fdo#109274]: https://bugs.freedesktop.org/show_bug.cgi?id=109274
[fdo#110189]: https://bugs.freedesktop.org/show_bug.cgi?id=110189
[fdo#111614]: https://bugs.freedesktop.org/show_bug.cgi?id=111614
[i915#1072]: https://gitlab.freedesktop.org/drm/intel/issues/1072
[i915#1099]: https://gitlab.freedesktop.org/drm/intel/issues/1099
[i915#1397]: https://gitlab.freedesktop.org/drm/intel/issues/1397
[i915#1623]: https://gitlab.freedesktop.org/drm/intel/issues/1623
[i915#1982]: https://gitlab.freedesktop.org/drm/intel/issues/1982
[i915#2190]: https://gitlab.freedesktop.org/drm/intel/issues/2190
[i915#2346]: https://gitlab.freedesktop.org/drm/intel/issues/2346
[i915#2842]: https://gitlab.freedesktop.org/drm/intel/issues/2842
[i915#3318]: https://gitlab.freedesktop.org/drm/intel/issues/3318
[i915#3323]: https://gitlab.freedesktop.org/drm/intel/issues/3323
[i915#3555]: https://gitlab.freedesktop.org/drm/intel/issues/3555
[i915#3591]: https://gitlab.freedesktop.org/drm/intel/issues/3591
[i915#3689]: https://gitlab.freedesktop.org/drm/intel/issues/3689
[i915#3743]: https://gitlab.freedesktop.org/drm/intel/issues/3743
[i915#3804]: https://gitlab.freedesktop.org/drm/intel/issues/3804
[i915#3886]: https://gitlab.freedesktop.org/drm/intel/issues/3886
[i915#3955]: https://gitlab.freedesktop.org/drm/intel/issues/3955
[i915#4078]: https://gitlab.freedesktop.org/drm/intel/issues/4078
[i915#4083]: https://gitlab.freedesktop.org/drm/intel/issues/4083
[i915#4087]: https://gitlab.freedesktop.org/drm/intel/issues/4087
[i915#4349]: https://gitlab.freedesktop.org/drm/intel/issues/4349
[i915#4613]: https://gitlab.freedesktop.org/drm/intel/issues/4613
[i915#5138]: https://gitlab.freedesktop.org/drm/intel/issues/5138
[i915#5176]: https://gitlab.freedesktop.org/drm/intel/issues/5176
[i915#5235]: https://gitlab.freedesktop.org/drm/intel/issues/5235
[i915#5354]: https://gitlab.freedesktop.org/drm/intel/issues/5354
[i915#5493]: https://gitlab.freedesktop.org/drm/intel/issues/5493
[i915#5784]: https://gitlab.freedesktop.org/drm/intel/issues/5784
[i915#5892]: https://gitlab.freedesktop.org/drm/intel/issues/5892
[i915#6015]: https://gitlab.freedesktop.org/drm/intel/issues/6015
[i915#6095]: https://gitlab.freedesktop.org/drm/intel/issues/6095
[i915#6268]: https://gitlab.freedesktop.org/drm/intel/issues/6268
[i915#6537]: https://gitlab.freedesktop.org/drm/intel/issues/6537
[i915#658]: https://gitlab.freedesktop.org/drm/intel/issues/658
[i915#6763]: https://gitlab.freedesktop.org/drm/intel/issues/6763
[i915#6880]: https://gitlab.freedesktop.org/drm/intel/issues/6880
[i915#7059]: https://gitlab.freedesktop.org/drm/intel/issues/7059
[i915#7118]: https://gitlab.freedesktop.org/drm/intel/issues/7118
[i915#7162]: https://gitlab.freedesktop.org/drm/intel/issues/7162
[i915#7269]: https://gitlab.freedesktop.org/drm/intel/issues/7269
[i915#7484]: https://gitlab.freedesktop.org/drm/intel/issues/7484
[i915#7711]: https://gitlab.freedesktop.org/drm/intel/issues/7711
[i915#7862]: https://gitlab.freedesktop.org/drm/intel/issues/7862
[i915#7940]: https://gitlab.freedesktop.org/drm/intel/issues/7940
[i915#7941]: https://gitlab.freedesktop.org/drm/intel/issues/7941
[i915#7975]: https://gitlab.freedesktop.org/drm/intel/issues/7975
[i915#8213]: https://gitlab.freedesktop.org/drm/intel/issues/8213
[i915#8228]: https://gitlab.freedesktop.org/drm/intel/issues/8228
[i915#8247]: https://gitlab.freedesktop.org/drm/intel/issues/8247
[i915#8292]: https://gitlab.freedesktop.org/drm/intel/issues/8292
[i915#8295]: https://gitlab.freedesktop.org/drm/intel/issues/8295
[i915#8414]: https://gitlab.freedesktop.org/drm/intel/issues/8414
[i915#8497]: https://gitlab.freedesktop.org/drm/intel/issues/8497
[i915#8661]: https://gitlab.freedesktop.org/drm/intel/issues/8661
[i915#8691]: https://gitlab.freedesktop.org/drm/intel/issues/8691
[i915#8841]: https://gitlab.freedesktop.org/drm/intel/issues/8841
[i915#8898]: https://gitlab.freedesktop.org/drm/intel/issues/8898
Build changes
-------------
* Linux: CI_DRM_13477 -> Patchwork_122015v1
CI-20190529: 20190529
CI_DRM_13477: 4a370c634541048c782ab36aee81ec52066b9c78 @ git://anongit.freedesktop.org/gfx-ci/linux
IGT_7415: 8764d812da7df2b3e880111482c8a5c13dd7bf87 @ https://gitlab.freedesktop.org/drm/igt-gpu-tools.git
Patchwork_122015v1: 4a370c634541048c782ab36aee81ec52066b9c78 @ git://anongit.freedesktop.org/gfx-ci/linux
piglit_4509: fdc5a4ca11124ab8413c7988896eec4c97336694 @ git://anongit.freedesktop.org/piglit
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_122015v1/index.html
[-- Attachment #2: Type: text/html, Size: 38219 bytes --]
^ permalink raw reply [flat|nested] 14+ messages in thread
* Re: [Intel-gfx] [PATCH 1/2] drm/i915: fix display probe for IVB Q and IVB D GT2 server
2023-08-04 8:45 [Intel-gfx] [PATCH 1/2] drm/i915: fix display probe for IVB Q and IVB D GT2 server Jani Nikula
` (4 preceding siblings ...)
2023-08-05 0:21 ` [Intel-gfx] ✓ Fi.CI.IGT: " Patchwork
@ 2023-08-09 16:26 ` Luca Coelho
2023-08-10 9:21 ` Jani Nikula
2023-08-09 22:27 ` Matt Roper
2023-08-10 9:29 ` Jani Nikula
7 siblings, 1 reply; 14+ messages in thread
From: Luca Coelho @ 2023-08-09 16:26 UTC (permalink / raw)
To: Jani Nikula, intel-gfx; +Cc: Matt Roper, Andrzej Hajda
On Fri, 2023-08-04 at 11:45 +0300, Jani Nikula wrote:
> The current display probe is unable to differentiate between IVB Q and
> IVB D GT2 server, as they both have the same device id, but different
> subvendor and subdevice. This leads to the latter being misidentified as
> the former, and should just end up not having a display. However, the no
> display case returns a NULL as the display device info, and promptly
> oopses.
>
> As the IVB Q case is rare, and we're anyway moving towards GMD ID,
> handle the identification requiring subvendor and subdevice as a special
> case first, instead of unnecessarily growing the intel_display_ids[]
> array with subvendor and subdevice.
>
> [ 5.425298] BUG: kernel NULL pointer dereference, address: 0000000000000000
> [ 5.426059] #PF: supervisor read access in kernel mode
> [ 5.426810] #PF: error_code(0x0000) - not-present page
> [ 5.427570] PGD 0 P4D 0
> [ 5.428285] Oops: 0000 [#1] PREEMPT SMP PTI
> [ 5.429035] CPU: 0 PID: 137 Comm: (udev-worker) Not tainted 6.4.0-1-amd64 #1 Debian 6.4.4-1
> [ 5.429759] Hardware name: HP HP Z220 SFF Workstation/HP Z220 SFF Workstation, BIOS 4.19-218-gb184e6e0a1 02/02/2023
> [ 5.430485] RIP: 0010:intel_device_info_driver_create+0xf1/0x120 [i915]
> [ 5.431338] Code: 48 8b 97 80 1b 00 00 89 8f c0 1b 00 00 48 89 b7 b0 1b 00 00 48 89 97 b8 1b 00 00 0f b7 fd e8 76 e8 14 00 48 89 83 50 1b 00 00 <48> 8b 08 48 89 8b c4 1b 00 00 48 8b 48 08 48 89 8b cc 1b 00 00 8b
> [ 5.432920] RSP: 0018:ffffb8254044fb98 EFLAGS: 00010206
> [ 5.433707] RAX: 0000000000000000 RBX: ffff923076e80000 RCX: 0000000000000000
> [ 5.434494] RDX: 0000000000000260 RSI: 0000000100001000 RDI: 000000000000016a
> [ 5.435277] RBP: 000000000000016a R08: ffffb8254044fb00 R09: 0000000000000000
> [ 5.436055] R10: ffff922d02761de8 R11: 00657361656c6572 R12: ffffffffc0e5d140
> [ 5.436867] R13: ffff922d00b720d0 R14: 0000000076e80000 R15: ffff923078c0cae8
> [ 5.437646] FS: 00007febd19a18c0(0000) GS:ffff92307c000000(0000) knlGS:0000000000000000
> [ 5.438434] CS: 0010 DS: 0000 ES: 0000 CR0: 0000000080050033
> [ 5.439218] CR2: 0000000000000000 CR3: 000000010256e002 CR4: 00000000001706f0
> [ 5.440009] Call Trace:
> [ 5.440824] <TASK>
> [ 5.441611] ? __die+0x23/0x70
> [ 5.442394] ? page_fault_oops+0x17d/0x4c0
> [ 5.443173] ? exc_page_fault+0x7f/0x180
> [ 5.443949] ? asm_exc_page_fault+0x26/0x30
> [ 5.444756] ? intel_device_info_driver_create+0xf1/0x120 [i915]
> [ 5.445652] ? intel_device_info_driver_create+0xea/0x120 [i915]
> [ 5.446545] i915_driver_probe+0x7f/0xb60 [i915]
> [ 5.447431] ? drm_privacy_screen_get+0x15c/0x1a0 [drm]
> [ 5.448240] local_pci_probe+0x45/0xa0
> [ 5.449013] pci_device_probe+0xc7/0x240
> [ 5.449748] really_probe+0x19e/0x3e0
> [ 5.450464] ? __pfx___driver_attach+0x10/0x10
> [ 5.451172] __driver_probe_device+0x78/0x160
> [ 5.451870] driver_probe_device+0x1f/0x90
> [ 5.452601] __driver_attach+0xd2/0x1c0
> [ 5.453293] bus_for_each_dev+0x88/0xd0
> [ 5.453989] bus_add_driver+0x116/0x220
> [ 5.454672] driver_register+0x59/0x100
> [ 5.455336] i915_init+0x25/0xc0 [i915]
> [ 5.456104] ? __pfx_i915_init+0x10/0x10 [i915]
> [ 5.456882] do_one_initcall+0x5d/0x240
> [ 5.457511] do_init_module+0x60/0x250
> [ 5.458126] __do_sys_finit_module+0xac/0x120
> [ 5.458721] do_syscall_64+0x60/0xc0
> [ 5.459314] ? syscall_exit_to_user_mode+0x1b/0x40
> [ 5.459897] ? do_syscall_64+0x6c/0xc0
> [ 5.460510] entry_SYSCALL_64_after_hwframe+0x72/0xdc
> [ 5.461082] RIP: 0033:0x7febd20b0eb9
> [ 5.461648] Code: 08 89 e8 5b 5d c3 66 2e 0f 1f 84 00 00 00 00 00 90 48 89 f8 48 89 f7 48 89 d6 48 89 ca 4d 89 c2 4d 89 c8 4c 8b 4c 24 08 0f 05 <48> 3d 01 f0 ff ff 73 01 c3 48 8b 0d 2f 1f 0d 00 f7 d8 64 89 01 48
> [ 5.462905] RSP: 002b:00007fffabb1ba78 EFLAGS: 00000246 ORIG_RAX: 0000000000000139
> [ 5.463554] RAX: ffffffffffffffda RBX: 0000561e6304f410 RCX: 00007febd20b0eb9
> [ 5.464201] RDX: 0000000000000000 RSI: 00007febd2244f0d RDI: 0000000000000015
> [ 5.464869] RBP: 00007febd2244f0d R08: 0000000000000000 R09: 000000000000000a
> [ 5.465512] R10: 0000000000000015 R11: 0000000000000246 R12: 0000000000020000
> [ 5.466124] R13: 0000000000000000 R14: 0000561e63032b60 R15: 000000000000000a
> [ 5.466700] </TASK>
> [ 5.467271] Modules linked in: i915(+) drm_buddy video crc32_pclmul sr_mod hid_generic wmi crc32c_intel i2c_algo_bit sd_mod cdrom drm_display_helper cec usbhid rc_core ghash_clmulni_intel hid sha512_ssse3 ttm sha512_generic xhci_pci ehci_pci xhci_hcd ehci_hcd nvme ahci drm_kms_helper nvme_core libahci t10_pi libata psmouse aesni_intel scsi_mod crypto_simd i2c_i801 scsi_common crc64_rocksoft_generic cryptd i2c_smbus drm lpc_ich crc64_rocksoft crc_t10dif e1000e usbcore crct10dif_generic usb_common crct10dif_pclmul crc64 crct10dif_common button
> [ 5.469750] CR2: 0000000000000000
> [ 5.470364] ---[ end trace 0000000000000000 ]---
> [ 5.470971] RIP: 0010:intel_device_info_driver_create+0xf1/0x120 [i915]
> [ 5.471699] Code: 48 8b 97 80 1b 00 00 89 8f c0 1b 00 00 48 89 b7 b0 1b 00 00 48 89 97 b8 1b 00 00 0f b7 fd e8 76 e8 14 00 48 89 83 50 1b 00 00 <48> 8b 08 48 89 8b c4 1b 00 00 48 8b 48 08 48 89 8b cc 1b 00 00 8b
> [ 5.473034] RSP: 0018:ffffb8254044fb98 EFLAGS: 00010206
> [ 5.473698] RAX: 0000000000000000 RBX: ffff923076e80000 RCX: 0000000000000000
> [ 5.474371] RDX: 0000000000000260 RSI: 0000000100001000 RDI: 000000000000016a
> [ 5.475045] RBP: 000000000000016a R08: ffffb8254044fb00 R09: 0000000000000000
> [ 5.475725] R10: ffff922d02761de8 R11: 00657361656c6572 R12: ffffffffc0e5d140
> [ 5.476405] R13: ffff922d00b720d0 R14: 0000000076e80000 R15: ffff923078c0cae8
> [ 5.477124] FS: 00007febd19a18c0(0000) GS:ffff92307c000000(0000) knlGS:0000000000000000
> [ 5.477811] CS: 0010 DS: 0000 ES: 0000 CR0: 0000000080050033
> [ 5.478499] CR2: 0000000000000000 CR3: 000000010256e002 CR4: 00000000001706f0
>
> Fixes: 69d439818fe5 ("drm/i915/display: Make display responsible for probing its own IP")
> Closes: https://gitlab.freedesktop.org/drm/intel/-/issues/8991
> Cc: Matt Roper <matthew.d.roper@intel.com>
> Cc: Andrzej Hajda <andrzej.hajda@intel.com>
> Signed-off-by: Jani Nikula <jani.nikula@intel.com>
> ---
> .../drm/i915/display/intel_display_device.c | 24 ++++++++++++++++---
> 1 file changed, 21 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/gpu/drm/i915/display/intel_display_device.c b/drivers/gpu/drm/i915/display/intel_display_device.c
> index 8286e79522d1..3d6a262e037f 100644
> --- a/drivers/gpu/drm/i915/display/intel_display_device.c
> +++ b/drivers/gpu/drm/i915/display/intel_display_device.c
> @@ -724,10 +724,24 @@ static const struct intel_display_device_info xe_lpdp_display = {
> BIT(PORT_TC1) | BIT(PORT_TC2) | BIT(PORT_TC3) | BIT(PORT_TC4),
> };
>
> +/*
> + * Separate detection for no display cases to keep the display id array simple.
> + *
> + * IVB Q requires subvendor and subdevice matching to differentiate from IVB D
> + * GT2 server.
> + */
> +static bool has_no_display(struct pci_dev *pdev)
> +{
> + static const struct pci_device_id ids[] = {
> + INTEL_IVB_Q_IDS(0),
> + {}
> + };
> +
> + return pci_match_id(ids, pdev);
> +}
> +
> #undef INTEL_VGA_DEVICE
> -#undef INTEL_QUANTA_VGA_DEVICE
> #define INTEL_VGA_DEVICE(id, info) { id, info }
> -#define INTEL_QUANTA_VGA_DEVICE(info) { 0x16a, info }
>
> static const struct {
> u32 devid;
> @@ -752,7 +766,6 @@ static const struct {
> INTEL_IRONLAKE_M_IDS(&ilk_m_display),
> INTEL_SNB_D_IDS(&snb_display),
> INTEL_SNB_M_IDS(&snb_display),
> - INTEL_IVB_Q_IDS(NULL), /* must be first IVB in list */
> INTEL_IVB_M_IDS(&ivb_display),
> INTEL_IVB_D_IDS(&ivb_display),
> INTEL_HSW_IDS(&hsw_display),
> @@ -837,6 +850,11 @@ intel_display_device_probe(struct drm_i915_private *i915, bool has_gmdid,
> if (has_gmdid)
> return probe_gmdid_display(i915, gmdid_ver, gmdid_rel, gmdid_step);
>
> + if (has_no_display(pdev)) {
> + drm_dbg_kms(&i915->drm, "Device doesn't have display\n");
> + return &no_display;
> + }
> +
> for (i = 0; i < ARRAY_SIZE(intel_display_ids); i++) {
> if (intel_display_ids[i].devid == pdev->device)
> return intel_display_ids[i].info;
Looks good to me.
Reviewed-by: Luca Coelho <luciano.coelho@intel.com>
--
Cheers,
Luca.
^ permalink raw reply [flat|nested] 14+ messages in thread
* Re: [Intel-gfx] [PATCH 2/2] drm/i915: debug log when GMD ID indicates there's no display
2023-08-04 8:46 ` [Intel-gfx] [PATCH 2/2] drm/i915: debug log when GMD ID indicates there's no display Jani Nikula
@ 2023-08-09 16:27 ` Luca Coelho
0 siblings, 0 replies; 14+ messages in thread
From: Luca Coelho @ 2023-08-09 16:27 UTC (permalink / raw)
To: Jani Nikula, intel-gfx
On Fri, 2023-08-04 at 11:46 +0300, Jani Nikula wrote:
> Debug log similar to the device id based identification of no display.
>
> Signed-off-by: Jani Nikula <jani.nikula@intel.com>
> ---
> drivers/gpu/drm/i915/display/intel_display_device.c | 5 +++--
> 1 file changed, 3 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/gpu/drm/i915/display/intel_display_device.c b/drivers/gpu/drm/i915/display/intel_display_device.c
> index 3d6a262e037f..e4837f6fc01f 100644
> --- a/drivers/gpu/drm/i915/display/intel_display_device.c
> +++ b/drivers/gpu/drm/i915/display/intel_display_device.c
> @@ -822,9 +822,10 @@ probe_gmdid_display(struct drm_i915_private *i915, u16 *ver, u16 *rel, u16 *step
> val = ioread32(addr);
> pci_iounmap(pdev, addr);
>
> - if (val == 0)
> - /* Platform doesn't have display */
> + if (val == 0) {
> + drm_dbg_kms(&i915->drm, "Device doesn't have display\n");
> return &no_display;
> + }
>
> *ver = REG_FIELD_GET(GMD_ID_ARCH_MASK, val);
> *rel = REG_FIELD_GET(GMD_ID_RELEASE_MASK, val);
Reviewed-by: Luca Coelho <luciano.coelho@intel.com>
--
Cheers,
Luca.
^ permalink raw reply [flat|nested] 14+ messages in thread
* Re: [Intel-gfx] [PATCH 1/2] drm/i915: fix display probe for IVB Q and IVB D GT2 server
2023-08-04 8:45 [Intel-gfx] [PATCH 1/2] drm/i915: fix display probe for IVB Q and IVB D GT2 server Jani Nikula
` (5 preceding siblings ...)
2023-08-09 16:26 ` [Intel-gfx] [PATCH 1/2] " Luca Coelho
@ 2023-08-09 22:27 ` Matt Roper
2023-08-10 9:29 ` Jani Nikula
7 siblings, 0 replies; 14+ messages in thread
From: Matt Roper @ 2023-08-09 22:27 UTC (permalink / raw)
To: Jani Nikula; +Cc: intel-gfx, Andrzej Hajda
On Fri, Aug 04, 2023 at 11:45:59AM +0300, Jani Nikula wrote:
> The current display probe is unable to differentiate between IVB Q and
> IVB D GT2 server, as they both have the same device id, but different
> subvendor and subdevice. This leads to the latter being misidentified as
> the former, and should just end up not having a display. However, the no
> display case returns a NULL as the display device info, and promptly
> oopses.
>
> As the IVB Q case is rare, and we're anyway moving towards GMD ID,
> handle the identification requiring subvendor and subdevice as a special
> case first, instead of unnecessarily growing the intel_display_ids[]
> array with subvendor and subdevice.
>
> [ 5.425298] BUG: kernel NULL pointer dereference, address: 0000000000000000
> [ 5.426059] #PF: supervisor read access in kernel mode
> [ 5.426810] #PF: error_code(0x0000) - not-present page
> [ 5.427570] PGD 0 P4D 0
> [ 5.428285] Oops: 0000 [#1] PREEMPT SMP PTI
> [ 5.429035] CPU: 0 PID: 137 Comm: (udev-worker) Not tainted 6.4.0-1-amd64 #1 Debian 6.4.4-1
> [ 5.429759] Hardware name: HP HP Z220 SFF Workstation/HP Z220 SFF Workstation, BIOS 4.19-218-gb184e6e0a1 02/02/2023
> [ 5.430485] RIP: 0010:intel_device_info_driver_create+0xf1/0x120 [i915]
> [ 5.431338] Code: 48 8b 97 80 1b 00 00 89 8f c0 1b 00 00 48 89 b7 b0 1b 00 00 48 89 97 b8 1b 00 00 0f b7 fd e8 76 e8 14 00 48 89 83 50 1b 00 00 <48> 8b 08 48 89 8b c4 1b 00 00 48 8b 48 08 48 89 8b cc 1b 00 00 8b
> [ 5.432920] RSP: 0018:ffffb8254044fb98 EFLAGS: 00010206
> [ 5.433707] RAX: 0000000000000000 RBX: ffff923076e80000 RCX: 0000000000000000
> [ 5.434494] RDX: 0000000000000260 RSI: 0000000100001000 RDI: 000000000000016a
> [ 5.435277] RBP: 000000000000016a R08: ffffb8254044fb00 R09: 0000000000000000
> [ 5.436055] R10: ffff922d02761de8 R11: 00657361656c6572 R12: ffffffffc0e5d140
> [ 5.436867] R13: ffff922d00b720d0 R14: 0000000076e80000 R15: ffff923078c0cae8
> [ 5.437646] FS: 00007febd19a18c0(0000) GS:ffff92307c000000(0000) knlGS:0000000000000000
> [ 5.438434] CS: 0010 DS: 0000 ES: 0000 CR0: 0000000080050033
> [ 5.439218] CR2: 0000000000000000 CR3: 000000010256e002 CR4: 00000000001706f0
> [ 5.440009] Call Trace:
> [ 5.440824] <TASK>
> [ 5.441611] ? __die+0x23/0x70
> [ 5.442394] ? page_fault_oops+0x17d/0x4c0
> [ 5.443173] ? exc_page_fault+0x7f/0x180
> [ 5.443949] ? asm_exc_page_fault+0x26/0x30
> [ 5.444756] ? intel_device_info_driver_create+0xf1/0x120 [i915]
> [ 5.445652] ? intel_device_info_driver_create+0xea/0x120 [i915]
> [ 5.446545] i915_driver_probe+0x7f/0xb60 [i915]
> [ 5.447431] ? drm_privacy_screen_get+0x15c/0x1a0 [drm]
> [ 5.448240] local_pci_probe+0x45/0xa0
> [ 5.449013] pci_device_probe+0xc7/0x240
> [ 5.449748] really_probe+0x19e/0x3e0
> [ 5.450464] ? __pfx___driver_attach+0x10/0x10
> [ 5.451172] __driver_probe_device+0x78/0x160
> [ 5.451870] driver_probe_device+0x1f/0x90
> [ 5.452601] __driver_attach+0xd2/0x1c0
> [ 5.453293] bus_for_each_dev+0x88/0xd0
> [ 5.453989] bus_add_driver+0x116/0x220
> [ 5.454672] driver_register+0x59/0x100
> [ 5.455336] i915_init+0x25/0xc0 [i915]
> [ 5.456104] ? __pfx_i915_init+0x10/0x10 [i915]
> [ 5.456882] do_one_initcall+0x5d/0x240
> [ 5.457511] do_init_module+0x60/0x250
> [ 5.458126] __do_sys_finit_module+0xac/0x120
> [ 5.458721] do_syscall_64+0x60/0xc0
> [ 5.459314] ? syscall_exit_to_user_mode+0x1b/0x40
> [ 5.459897] ? do_syscall_64+0x6c/0xc0
> [ 5.460510] entry_SYSCALL_64_after_hwframe+0x72/0xdc
> [ 5.461082] RIP: 0033:0x7febd20b0eb9
> [ 5.461648] Code: 08 89 e8 5b 5d c3 66 2e 0f 1f 84 00 00 00 00 00 90 48 89 f8 48 89 f7 48 89 d6 48 89 ca 4d 89 c2 4d 89 c8 4c 8b 4c 24 08 0f 05 <48> 3d 01 f0 ff ff 73 01 c3 48 8b 0d 2f 1f 0d 00 f7 d8 64 89 01 48
> [ 5.462905] RSP: 002b:00007fffabb1ba78 EFLAGS: 00000246 ORIG_RAX: 0000000000000139
> [ 5.463554] RAX: ffffffffffffffda RBX: 0000561e6304f410 RCX: 00007febd20b0eb9
> [ 5.464201] RDX: 0000000000000000 RSI: 00007febd2244f0d RDI: 0000000000000015
> [ 5.464869] RBP: 00007febd2244f0d R08: 0000000000000000 R09: 000000000000000a
> [ 5.465512] R10: 0000000000000015 R11: 0000000000000246 R12: 0000000000020000
> [ 5.466124] R13: 0000000000000000 R14: 0000561e63032b60 R15: 000000000000000a
> [ 5.466700] </TASK>
> [ 5.467271] Modules linked in: i915(+) drm_buddy video crc32_pclmul sr_mod hid_generic wmi crc32c_intel i2c_algo_bit sd_mod cdrom drm_display_helper cec usbhid rc_core ghash_clmulni_intel hid sha512_ssse3 ttm sha512_generic xhci_pci ehci_pci xhci_hcd ehci_hcd nvme ahci drm_kms_helper nvme_core libahci t10_pi libata psmouse aesni_intel scsi_mod crypto_simd i2c_i801 scsi_common crc64_rocksoft_generic cryptd i2c_smbus drm lpc_ich crc64_rocksoft crc_t10dif e1000e usbcore crct10dif_generic usb_common crct10dif_pclmul crc64 crct10dif_common button
> [ 5.469750] CR2: 0000000000000000
> [ 5.470364] ---[ end trace 0000000000000000 ]---
> [ 5.470971] RIP: 0010:intel_device_info_driver_create+0xf1/0x120 [i915]
> [ 5.471699] Code: 48 8b 97 80 1b 00 00 89 8f c0 1b 00 00 48 89 b7 b0 1b 00 00 48 89 97 b8 1b 00 00 0f b7 fd e8 76 e8 14 00 48 89 83 50 1b 00 00 <48> 8b 08 48 89 8b c4 1b 00 00 48 8b 48 08 48 89 8b cc 1b 00 00 8b
> [ 5.473034] RSP: 0018:ffffb8254044fb98 EFLAGS: 00010206
> [ 5.473698] RAX: 0000000000000000 RBX: ffff923076e80000 RCX: 0000000000000000
> [ 5.474371] RDX: 0000000000000260 RSI: 0000000100001000 RDI: 000000000000016a
> [ 5.475045] RBP: 000000000000016a R08: ffffb8254044fb00 R09: 0000000000000000
> [ 5.475725] R10: ffff922d02761de8 R11: 00657361656c6572 R12: ffffffffc0e5d140
> [ 5.476405] R13: ffff922d00b720d0 R14: 0000000076e80000 R15: ffff923078c0cae8
> [ 5.477124] FS: 00007febd19a18c0(0000) GS:ffff92307c000000(0000) knlGS:0000000000000000
> [ 5.477811] CS: 0010 DS: 0000 ES: 0000 CR0: 0000000080050033
> [ 5.478499] CR2: 0000000000000000 CR3: 000000010256e002 CR4: 00000000001706f0
>
> Fixes: 69d439818fe5 ("drm/i915/display: Make display responsible for probing its own IP")
> Closes: https://gitlab.freedesktop.org/drm/intel/-/issues/8991
> Cc: Matt Roper <matthew.d.roper@intel.com>
> Cc: Andrzej Hajda <andrzej.hajda@intel.com>
> Signed-off-by: Jani Nikula <jani.nikula@intel.com>
Reviewed-by: Matt Roper <matthew.d.roper@intel.com>
> ---
> .../drm/i915/display/intel_display_device.c | 24 ++++++++++++++++---
> 1 file changed, 21 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/gpu/drm/i915/display/intel_display_device.c b/drivers/gpu/drm/i915/display/intel_display_device.c
> index 8286e79522d1..3d6a262e037f 100644
> --- a/drivers/gpu/drm/i915/display/intel_display_device.c
> +++ b/drivers/gpu/drm/i915/display/intel_display_device.c
> @@ -724,10 +724,24 @@ static const struct intel_display_device_info xe_lpdp_display = {
> BIT(PORT_TC1) | BIT(PORT_TC2) | BIT(PORT_TC3) | BIT(PORT_TC4),
> };
>
> +/*
> + * Separate detection for no display cases to keep the display id array simple.
> + *
> + * IVB Q requires subvendor and subdevice matching to differentiate from IVB D
> + * GT2 server.
> + */
> +static bool has_no_display(struct pci_dev *pdev)
> +{
> + static const struct pci_device_id ids[] = {
> + INTEL_IVB_Q_IDS(0),
> + {}
> + };
> +
> + return pci_match_id(ids, pdev);
> +}
> +
> #undef INTEL_VGA_DEVICE
> -#undef INTEL_QUANTA_VGA_DEVICE
> #define INTEL_VGA_DEVICE(id, info) { id, info }
> -#define INTEL_QUANTA_VGA_DEVICE(info) { 0x16a, info }
>
> static const struct {
> u32 devid;
> @@ -752,7 +766,6 @@ static const struct {
> INTEL_IRONLAKE_M_IDS(&ilk_m_display),
> INTEL_SNB_D_IDS(&snb_display),
> INTEL_SNB_M_IDS(&snb_display),
> - INTEL_IVB_Q_IDS(NULL), /* must be first IVB in list */
> INTEL_IVB_M_IDS(&ivb_display),
> INTEL_IVB_D_IDS(&ivb_display),
> INTEL_HSW_IDS(&hsw_display),
> @@ -837,6 +850,11 @@ intel_display_device_probe(struct drm_i915_private *i915, bool has_gmdid,
> if (has_gmdid)
> return probe_gmdid_display(i915, gmdid_ver, gmdid_rel, gmdid_step);
>
> + if (has_no_display(pdev)) {
> + drm_dbg_kms(&i915->drm, "Device doesn't have display\n");
> + return &no_display;
> + }
> +
> for (i = 0; i < ARRAY_SIZE(intel_display_ids); i++) {
> if (intel_display_ids[i].devid == pdev->device)
> return intel_display_ids[i].info;
> --
> 2.39.2
>
--
Matt Roper
Graphics Software Engineer
Linux GPU Platform Enablement
Intel Corporation
^ permalink raw reply [flat|nested] 14+ messages in thread
* Re: [Intel-gfx] [PATCH 1/2] drm/i915: fix display probe for IVB Q and IVB D GT2 server
2023-08-09 16:26 ` [Intel-gfx] [PATCH 1/2] " Luca Coelho
@ 2023-08-10 9:21 ` Jani Nikula
0 siblings, 0 replies; 14+ messages in thread
From: Jani Nikula @ 2023-08-10 9:21 UTC (permalink / raw)
To: Luca Coelho, intel-gfx; +Cc: Matt Roper, Andrzej Hajda
On Wed, 09 Aug 2023, Luca Coelho <luca@coelho.fi> wrote:
> Looks good to me.
>
> Reviewed-by: Luca Coelho <luciano.coelho@intel.com>
Thanks for the reviews, pushed to drm-intel-next.
BR,
Jani.
>
> --
> Cheers,
> Luca.
--
Jani Nikula, Intel Open Source Graphics Center
^ permalink raw reply [flat|nested] 14+ messages in thread
* Re: [Intel-gfx] [PATCH 1/2] drm/i915: fix display probe for IVB Q and IVB D GT2 server
2023-08-04 8:45 [Intel-gfx] [PATCH 1/2] drm/i915: fix display probe for IVB Q and IVB D GT2 server Jani Nikula
@ 2023-08-10 9:29 ` Jani Nikula
2023-08-04 17:03 ` [Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for series starting with [1/2] drm/i915: fix display probe for IVB Q and IVB D GT2 server Patchwork
` (6 subsequent siblings)
7 siblings, 0 replies; 14+ messages in thread
From: Jani Nikula @ 2023-08-10 9:29 UTC (permalink / raw)
To: intel-gfx, Sasha Levin; +Cc: Matt Roper, stable, Andrzej Hajda
On Fri, 04 Aug 2023, Jani Nikula <jani.nikula@intel.com> wrote:
> The current display probe is unable to differentiate between IVB Q and
> IVB D GT2 server, as they both have the same device id, but different
> subvendor and subdevice. This leads to the latter being misidentified as
> the former, and should just end up not having a display. However, the no
> display case returns a NULL as the display device info, and promptly
> oopses.
>
> As the IVB Q case is rare, and we're anyway moving towards GMD ID,
> handle the identification requiring subvendor and subdevice as a special
> case first, instead of unnecessarily growing the intel_display_ids[]
> array with subvendor and subdevice.
>
> [ 5.425298] BUG: kernel NULL pointer dereference, address: 0000000000000000
> [ 5.426059] #PF: supervisor read access in kernel mode
> [ 5.426810] #PF: error_code(0x0000) - not-present page
> [ 5.427570] PGD 0 P4D 0
> [ 5.428285] Oops: 0000 [#1] PREEMPT SMP PTI
> [ 5.429035] CPU: 0 PID: 137 Comm: (udev-worker) Not tainted 6.4.0-1-amd64 #1 Debian 6.4.4-1
> [ 5.429759] Hardware name: HP HP Z220 SFF Workstation/HP Z220 SFF Workstation, BIOS 4.19-218-gb184e6e0a1 02/02/2023
> [ 5.430485] RIP: 0010:intel_device_info_driver_create+0xf1/0x120 [i915]
> [ 5.431338] Code: 48 8b 97 80 1b 00 00 89 8f c0 1b 00 00 48 89 b7 b0 1b 00 00 48 89 97 b8 1b 00 00 0f b7 fd e8 76 e8 14 00 48 89 83 50 1b 00 00 <48> 8b 08 48 89 8b c4 1b 00 00 48 8b 48 08 48 89 8b cc 1b 00 00 8b
> [ 5.432920] RSP: 0018:ffffb8254044fb98 EFLAGS: 00010206
> [ 5.433707] RAX: 0000000000000000 RBX: ffff923076e80000 RCX: 0000000000000000
> [ 5.434494] RDX: 0000000000000260 RSI: 0000000100001000 RDI: 000000000000016a
> [ 5.435277] RBP: 000000000000016a R08: ffffb8254044fb00 R09: 0000000000000000
> [ 5.436055] R10: ffff922d02761de8 R11: 00657361656c6572 R12: ffffffffc0e5d140
> [ 5.436867] R13: ffff922d00b720d0 R14: 0000000076e80000 R15: ffff923078c0cae8
> [ 5.437646] FS: 00007febd19a18c0(0000) GS:ffff92307c000000(0000) knlGS:0000000000000000
> [ 5.438434] CS: 0010 DS: 0000 ES: 0000 CR0: 0000000080050033
> [ 5.439218] CR2: 0000000000000000 CR3: 000000010256e002 CR4: 00000000001706f0
> [ 5.440009] Call Trace:
> [ 5.440824] <TASK>
> [ 5.441611] ? __die+0x23/0x70
> [ 5.442394] ? page_fault_oops+0x17d/0x4c0
> [ 5.443173] ? exc_page_fault+0x7f/0x180
> [ 5.443949] ? asm_exc_page_fault+0x26/0x30
> [ 5.444756] ? intel_device_info_driver_create+0xf1/0x120 [i915]
> [ 5.445652] ? intel_device_info_driver_create+0xea/0x120 [i915]
> [ 5.446545] i915_driver_probe+0x7f/0xb60 [i915]
> [ 5.447431] ? drm_privacy_screen_get+0x15c/0x1a0 [drm]
> [ 5.448240] local_pci_probe+0x45/0xa0
> [ 5.449013] pci_device_probe+0xc7/0x240
> [ 5.449748] really_probe+0x19e/0x3e0
> [ 5.450464] ? __pfx___driver_attach+0x10/0x10
> [ 5.451172] __driver_probe_device+0x78/0x160
> [ 5.451870] driver_probe_device+0x1f/0x90
> [ 5.452601] __driver_attach+0xd2/0x1c0
> [ 5.453293] bus_for_each_dev+0x88/0xd0
> [ 5.453989] bus_add_driver+0x116/0x220
> [ 5.454672] driver_register+0x59/0x100
> [ 5.455336] i915_init+0x25/0xc0 [i915]
> [ 5.456104] ? __pfx_i915_init+0x10/0x10 [i915]
> [ 5.456882] do_one_initcall+0x5d/0x240
> [ 5.457511] do_init_module+0x60/0x250
> [ 5.458126] __do_sys_finit_module+0xac/0x120
> [ 5.458721] do_syscall_64+0x60/0xc0
> [ 5.459314] ? syscall_exit_to_user_mode+0x1b/0x40
> [ 5.459897] ? do_syscall_64+0x6c/0xc0
> [ 5.460510] entry_SYSCALL_64_after_hwframe+0x72/0xdc
> [ 5.461082] RIP: 0033:0x7febd20b0eb9
> [ 5.461648] Code: 08 89 e8 5b 5d c3 66 2e 0f 1f 84 00 00 00 00 00 90 48 89 f8 48 89 f7 48 89 d6 48 89 ca 4d 89 c2 4d 89 c8 4c 8b 4c 24 08 0f 05 <48> 3d 01 f0 ff ff 73 01 c3 48 8b 0d 2f 1f 0d 00 f7 d8 64 89 01 48
> [ 5.462905] RSP: 002b:00007fffabb1ba78 EFLAGS: 00000246 ORIG_RAX: 0000000000000139
> [ 5.463554] RAX: ffffffffffffffda RBX: 0000561e6304f410 RCX: 00007febd20b0eb9
> [ 5.464201] RDX: 0000000000000000 RSI: 00007febd2244f0d RDI: 0000000000000015
> [ 5.464869] RBP: 00007febd2244f0d R08: 0000000000000000 R09: 000000000000000a
> [ 5.465512] R10: 0000000000000015 R11: 0000000000000246 R12: 0000000000020000
> [ 5.466124] R13: 0000000000000000 R14: 0000561e63032b60 R15: 000000000000000a
> [ 5.466700] </TASK>
> [ 5.467271] Modules linked in: i915(+) drm_buddy video crc32_pclmul sr_mod hid_generic wmi crc32c_intel i2c_algo_bit sd_mod cdrom drm_display_helper cec usbhid rc_core ghash_clmulni_intel hid sha512_ssse3 ttm sha512_generic xhci_pci ehci_pci xhci_hcd ehci_hcd nvme ahci drm_kms_helper nvme_core libahci t10_pi libata psmouse aesni_intel scsi_mod crypto_simd i2c_i801 scsi_common crc64_rocksoft_generic cryptd i2c_smbus drm lpc_ich crc64_rocksoft crc_t10dif e1000e usbcore crct10dif_generic usb_common crct10dif_pclmul crc64 crct10dif_common button
> [ 5.469750] CR2: 0000000000000000
> [ 5.470364] ---[ end trace 0000000000000000 ]---
> [ 5.470971] RIP: 0010:intel_device_info_driver_create+0xf1/0x120 [i915]
> [ 5.471699] Code: 48 8b 97 80 1b 00 00 89 8f c0 1b 00 00 48 89 b7 b0 1b 00 00 48 89 97 b8 1b 00 00 0f b7 fd e8 76 e8 14 00 48 89 83 50 1b 00 00 <48> 8b 08 48 89 8b c4 1b 00 00 48 8b 48 08 48 89 8b cc 1b 00 00 8b
> [ 5.473034] RSP: 0018:ffffb8254044fb98 EFLAGS: 00010206
> [ 5.473698] RAX: 0000000000000000 RBX: ffff923076e80000 RCX: 0000000000000000
> [ 5.474371] RDX: 0000000000000260 RSI: 0000000100001000 RDI: 000000000000016a
> [ 5.475045] RBP: 000000000000016a R08: ffffb8254044fb00 R09: 0000000000000000
> [ 5.475725] R10: ffff922d02761de8 R11: 00657361656c6572 R12: ffffffffc0e5d140
> [ 5.476405] R13: ffff922d00b720d0 R14: 0000000076e80000 R15: ffff923078c0cae8
> [ 5.477124] FS: 00007febd19a18c0(0000) GS:ffff92307c000000(0000) knlGS:0000000000000000
> [ 5.477811] CS: 0010 DS: 0000 ES: 0000 CR0: 0000000080050033
> [ 5.478499] CR2: 0000000000000000 CR3: 000000010256e002 CR4: 00000000001706f0
>
> Fixes: 69d439818fe5 ("drm/i915/display: Make display responsible for probing its own IP")
Sasha, after pushing this fix, I realized the bug report was against
6.4.4, but the above commit hit upstream in v6.5-rc1.
Turns out it was automatically backported as a dependency:
commit be2caaed96c55bb1fcd55a25e60d7b309ff49f2d
Author: Matt Roper <matthew.d.roper@intel.com>
Date: Tue May 23 12:56:07 2023 -0700
drm/i915/display: Make display responsible for probing its own IP
[ Upstream commit 69d439818fe501e8c9e50d963a53cb596e36f9f7 ]
Rather than selecting the display IP and feature flags at the same time
the general PCI probing happens, move this step into the display code
itself so that it can be more easily re-used outside of i915 (i.e., by
the Xe driver).
v2:
- Make intel_display_device_probe() always return a non-NULL pointer
and simplify copying of runtime_defaults. (Andrzej)
v3:
- Redefine INTEL_VGA_DEVICE/INTEL_QUANTA_DEVICE to eliminate a cast and
an include of linux/mod_devicetable.h. (Jani)
- Keep explicit memcpy for runtime defaults. (Jani)
Cc: Andrzej Hajda <andrzej.hajda@intel.com>
Signed-off-by: Matt Roper <matthew.d.roper@intel.com>
Reviewed-by: Andrzej Hajda <andrzej.hajda@intel.com>
Acked-by: Jani Nikula <jani.nikula@intel.com>
Link: https://patchwork.freedesktop.org/patch/msgid/20230523195609.73627-5-matthew.d.roper@intel.com
Stable-dep-of: 19db2062094c ("drm/i915: No 10bit gamma on desktop gen3 parts")
Signed-off-by: Sasha Levin <sashal@kernel.org>
I'm a bit surprised and scared this kind of refactoring commit got
backported to stable.
Do you have automation in place to backport the fixes to backported
commits too? I didn't think to add Cc: stable in the commit.
BR,
Jani.
> Closes: https://gitlab.freedesktop.org/drm/intel/-/issues/8991
> Cc: Matt Roper <matthew.d.roper@intel.com>
> Cc: Andrzej Hajda <andrzej.hajda@intel.com>
> Signed-off-by: Jani Nikula <jani.nikula@intel.com>
> ---
> .../drm/i915/display/intel_display_device.c | 24 ++++++++++++++++---
> 1 file changed, 21 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/gpu/drm/i915/display/intel_display_device.c b/drivers/gpu/drm/i915/display/intel_display_device.c
> index 8286e79522d1..3d6a262e037f 100644
> --- a/drivers/gpu/drm/i915/display/intel_display_device.c
> +++ b/drivers/gpu/drm/i915/display/intel_display_device.c
> @@ -724,10 +724,24 @@ static const struct intel_display_device_info xe_lpdp_display = {
> BIT(PORT_TC1) | BIT(PORT_TC2) | BIT(PORT_TC3) | BIT(PORT_TC4),
> };
>
> +/*
> + * Separate detection for no display cases to keep the display id array simple.
> + *
> + * IVB Q requires subvendor and subdevice matching to differentiate from IVB D
> + * GT2 server.
> + */
> +static bool has_no_display(struct pci_dev *pdev)
> +{
> + static const struct pci_device_id ids[] = {
> + INTEL_IVB_Q_IDS(0),
> + {}
> + };
> +
> + return pci_match_id(ids, pdev);
> +}
> +
> #undef INTEL_VGA_DEVICE
> -#undef INTEL_QUANTA_VGA_DEVICE
> #define INTEL_VGA_DEVICE(id, info) { id, info }
> -#define INTEL_QUANTA_VGA_DEVICE(info) { 0x16a, info }
>
> static const struct {
> u32 devid;
> @@ -752,7 +766,6 @@ static const struct {
> INTEL_IRONLAKE_M_IDS(&ilk_m_display),
> INTEL_SNB_D_IDS(&snb_display),
> INTEL_SNB_M_IDS(&snb_display),
> - INTEL_IVB_Q_IDS(NULL), /* must be first IVB in list */
> INTEL_IVB_M_IDS(&ivb_display),
> INTEL_IVB_D_IDS(&ivb_display),
> INTEL_HSW_IDS(&hsw_display),
> @@ -837,6 +850,11 @@ intel_display_device_probe(struct drm_i915_private *i915, bool has_gmdid,
> if (has_gmdid)
> return probe_gmdid_display(i915, gmdid_ver, gmdid_rel, gmdid_step);
>
> + if (has_no_display(pdev)) {
> + drm_dbg_kms(&i915->drm, "Device doesn't have display\n");
> + return &no_display;
> + }
> +
> for (i = 0; i < ARRAY_SIZE(intel_display_ids); i++) {
> if (intel_display_ids[i].devid == pdev->device)
> return intel_display_ids[i].info;
--
Jani Nikula, Intel Open Source Graphics Center
^ permalink raw reply [flat|nested] 14+ messages in thread
* Re: [PATCH 1/2] drm/i915: fix display probe for IVB Q and IVB D GT2 server
@ 2023-08-10 9:29 ` Jani Nikula
0 siblings, 0 replies; 14+ messages in thread
From: Jani Nikula @ 2023-08-10 9:29 UTC (permalink / raw)
To: intel-gfx, Sasha Levin; +Cc: Matt Roper, Andrzej Hajda, stable
On Fri, 04 Aug 2023, Jani Nikula <jani.nikula@intel.com> wrote:
> The current display probe is unable to differentiate between IVB Q and
> IVB D GT2 server, as they both have the same device id, but different
> subvendor and subdevice. This leads to the latter being misidentified as
> the former, and should just end up not having a display. However, the no
> display case returns a NULL as the display device info, and promptly
> oopses.
>
> As the IVB Q case is rare, and we're anyway moving towards GMD ID,
> handle the identification requiring subvendor and subdevice as a special
> case first, instead of unnecessarily growing the intel_display_ids[]
> array with subvendor and subdevice.
>
> [ 5.425298] BUG: kernel NULL pointer dereference, address: 0000000000000000
> [ 5.426059] #PF: supervisor read access in kernel mode
> [ 5.426810] #PF: error_code(0x0000) - not-present page
> [ 5.427570] PGD 0 P4D 0
> [ 5.428285] Oops: 0000 [#1] PREEMPT SMP PTI
> [ 5.429035] CPU: 0 PID: 137 Comm: (udev-worker) Not tainted 6.4.0-1-amd64 #1 Debian 6.4.4-1
> [ 5.429759] Hardware name: HP HP Z220 SFF Workstation/HP Z220 SFF Workstation, BIOS 4.19-218-gb184e6e0a1 02/02/2023
> [ 5.430485] RIP: 0010:intel_device_info_driver_create+0xf1/0x120 [i915]
> [ 5.431338] Code: 48 8b 97 80 1b 00 00 89 8f c0 1b 00 00 48 89 b7 b0 1b 00 00 48 89 97 b8 1b 00 00 0f b7 fd e8 76 e8 14 00 48 89 83 50 1b 00 00 <48> 8b 08 48 89 8b c4 1b 00 00 48 8b 48 08 48 89 8b cc 1b 00 00 8b
> [ 5.432920] RSP: 0018:ffffb8254044fb98 EFLAGS: 00010206
> [ 5.433707] RAX: 0000000000000000 RBX: ffff923076e80000 RCX: 0000000000000000
> [ 5.434494] RDX: 0000000000000260 RSI: 0000000100001000 RDI: 000000000000016a
> [ 5.435277] RBP: 000000000000016a R08: ffffb8254044fb00 R09: 0000000000000000
> [ 5.436055] R10: ffff922d02761de8 R11: 00657361656c6572 R12: ffffffffc0e5d140
> [ 5.436867] R13: ffff922d00b720d0 R14: 0000000076e80000 R15: ffff923078c0cae8
> [ 5.437646] FS: 00007febd19a18c0(0000) GS:ffff92307c000000(0000) knlGS:0000000000000000
> [ 5.438434] CS: 0010 DS: 0000 ES: 0000 CR0: 0000000080050033
> [ 5.439218] CR2: 0000000000000000 CR3: 000000010256e002 CR4: 00000000001706f0
> [ 5.440009] Call Trace:
> [ 5.440824] <TASK>
> [ 5.441611] ? __die+0x23/0x70
> [ 5.442394] ? page_fault_oops+0x17d/0x4c0
> [ 5.443173] ? exc_page_fault+0x7f/0x180
> [ 5.443949] ? asm_exc_page_fault+0x26/0x30
> [ 5.444756] ? intel_device_info_driver_create+0xf1/0x120 [i915]
> [ 5.445652] ? intel_device_info_driver_create+0xea/0x120 [i915]
> [ 5.446545] i915_driver_probe+0x7f/0xb60 [i915]
> [ 5.447431] ? drm_privacy_screen_get+0x15c/0x1a0 [drm]
> [ 5.448240] local_pci_probe+0x45/0xa0
> [ 5.449013] pci_device_probe+0xc7/0x240
> [ 5.449748] really_probe+0x19e/0x3e0
> [ 5.450464] ? __pfx___driver_attach+0x10/0x10
> [ 5.451172] __driver_probe_device+0x78/0x160
> [ 5.451870] driver_probe_device+0x1f/0x90
> [ 5.452601] __driver_attach+0xd2/0x1c0
> [ 5.453293] bus_for_each_dev+0x88/0xd0
> [ 5.453989] bus_add_driver+0x116/0x220
> [ 5.454672] driver_register+0x59/0x100
> [ 5.455336] i915_init+0x25/0xc0 [i915]
> [ 5.456104] ? __pfx_i915_init+0x10/0x10 [i915]
> [ 5.456882] do_one_initcall+0x5d/0x240
> [ 5.457511] do_init_module+0x60/0x250
> [ 5.458126] __do_sys_finit_module+0xac/0x120
> [ 5.458721] do_syscall_64+0x60/0xc0
> [ 5.459314] ? syscall_exit_to_user_mode+0x1b/0x40
> [ 5.459897] ? do_syscall_64+0x6c/0xc0
> [ 5.460510] entry_SYSCALL_64_after_hwframe+0x72/0xdc
> [ 5.461082] RIP: 0033:0x7febd20b0eb9
> [ 5.461648] Code: 08 89 e8 5b 5d c3 66 2e 0f 1f 84 00 00 00 00 00 90 48 89 f8 48 89 f7 48 89 d6 48 89 ca 4d 89 c2 4d 89 c8 4c 8b 4c 24 08 0f 05 <48> 3d 01 f0 ff ff 73 01 c3 48 8b 0d 2f 1f 0d 00 f7 d8 64 89 01 48
> [ 5.462905] RSP: 002b:00007fffabb1ba78 EFLAGS: 00000246 ORIG_RAX: 0000000000000139
> [ 5.463554] RAX: ffffffffffffffda RBX: 0000561e6304f410 RCX: 00007febd20b0eb9
> [ 5.464201] RDX: 0000000000000000 RSI: 00007febd2244f0d RDI: 0000000000000015
> [ 5.464869] RBP: 00007febd2244f0d R08: 0000000000000000 R09: 000000000000000a
> [ 5.465512] R10: 0000000000000015 R11: 0000000000000246 R12: 0000000000020000
> [ 5.466124] R13: 0000000000000000 R14: 0000561e63032b60 R15: 000000000000000a
> [ 5.466700] </TASK>
> [ 5.467271] Modules linked in: i915(+) drm_buddy video crc32_pclmul sr_mod hid_generic wmi crc32c_intel i2c_algo_bit sd_mod cdrom drm_display_helper cec usbhid rc_core ghash_clmulni_intel hid sha512_ssse3 ttm sha512_generic xhci_pci ehci_pci xhci_hcd ehci_hcd nvme ahci drm_kms_helper nvme_core libahci t10_pi libata psmouse aesni_intel scsi_mod crypto_simd i2c_i801 scsi_common crc64_rocksoft_generic cryptd i2c_smbus drm lpc_ich crc64_rocksoft crc_t10dif e1000e usbcore crct10dif_generic usb_common crct10dif_pclmul crc64 crct10dif_common button
> [ 5.469750] CR2: 0000000000000000
> [ 5.470364] ---[ end trace 0000000000000000 ]---
> [ 5.470971] RIP: 0010:intel_device_info_driver_create+0xf1/0x120 [i915]
> [ 5.471699] Code: 48 8b 97 80 1b 00 00 89 8f c0 1b 00 00 48 89 b7 b0 1b 00 00 48 89 97 b8 1b 00 00 0f b7 fd e8 76 e8 14 00 48 89 83 50 1b 00 00 <48> 8b 08 48 89 8b c4 1b 00 00 48 8b 48 08 48 89 8b cc 1b 00 00 8b
> [ 5.473034] RSP: 0018:ffffb8254044fb98 EFLAGS: 00010206
> [ 5.473698] RAX: 0000000000000000 RBX: ffff923076e80000 RCX: 0000000000000000
> [ 5.474371] RDX: 0000000000000260 RSI: 0000000100001000 RDI: 000000000000016a
> [ 5.475045] RBP: 000000000000016a R08: ffffb8254044fb00 R09: 0000000000000000
> [ 5.475725] R10: ffff922d02761de8 R11: 00657361656c6572 R12: ffffffffc0e5d140
> [ 5.476405] R13: ffff922d00b720d0 R14: 0000000076e80000 R15: ffff923078c0cae8
> [ 5.477124] FS: 00007febd19a18c0(0000) GS:ffff92307c000000(0000) knlGS:0000000000000000
> [ 5.477811] CS: 0010 DS: 0000 ES: 0000 CR0: 0000000080050033
> [ 5.478499] CR2: 0000000000000000 CR3: 000000010256e002 CR4: 00000000001706f0
>
> Fixes: 69d439818fe5 ("drm/i915/display: Make display responsible for probing its own IP")
Sasha, after pushing this fix, I realized the bug report was against
6.4.4, but the above commit hit upstream in v6.5-rc1.
Turns out it was automatically backported as a dependency:
commit be2caaed96c55bb1fcd55a25e60d7b309ff49f2d
Author: Matt Roper <matthew.d.roper@intel.com>
Date: Tue May 23 12:56:07 2023 -0700
drm/i915/display: Make display responsible for probing its own IP
[ Upstream commit 69d439818fe501e8c9e50d963a53cb596e36f9f7 ]
Rather than selecting the display IP and feature flags at the same time
the general PCI probing happens, move this step into the display code
itself so that it can be more easily re-used outside of i915 (i.e., by
the Xe driver).
v2:
- Make intel_display_device_probe() always return a non-NULL pointer
and simplify copying of runtime_defaults. (Andrzej)
v3:
- Redefine INTEL_VGA_DEVICE/INTEL_QUANTA_DEVICE to eliminate a cast and
an include of linux/mod_devicetable.h. (Jani)
- Keep explicit memcpy for runtime defaults. (Jani)
Cc: Andrzej Hajda <andrzej.hajda@intel.com>
Signed-off-by: Matt Roper <matthew.d.roper@intel.com>
Reviewed-by: Andrzej Hajda <andrzej.hajda@intel.com>
Acked-by: Jani Nikula <jani.nikula@intel.com>
Link: https://patchwork.freedesktop.org/patch/msgid/20230523195609.73627-5-matthew.d.roper@intel.com
Stable-dep-of: 19db2062094c ("drm/i915: No 10bit gamma on desktop gen3 parts")
Signed-off-by: Sasha Levin <sashal@kernel.org>
I'm a bit surprised and scared this kind of refactoring commit got
backported to stable.
Do you have automation in place to backport the fixes to backported
commits too? I didn't think to add Cc: stable in the commit.
BR,
Jani.
> Closes: https://gitlab.freedesktop.org/drm/intel/-/issues/8991
> Cc: Matt Roper <matthew.d.roper@intel.com>
> Cc: Andrzej Hajda <andrzej.hajda@intel.com>
> Signed-off-by: Jani Nikula <jani.nikula@intel.com>
> ---
> .../drm/i915/display/intel_display_device.c | 24 ++++++++++++++++---
> 1 file changed, 21 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/gpu/drm/i915/display/intel_display_device.c b/drivers/gpu/drm/i915/display/intel_display_device.c
> index 8286e79522d1..3d6a262e037f 100644
> --- a/drivers/gpu/drm/i915/display/intel_display_device.c
> +++ b/drivers/gpu/drm/i915/display/intel_display_device.c
> @@ -724,10 +724,24 @@ static const struct intel_display_device_info xe_lpdp_display = {
> BIT(PORT_TC1) | BIT(PORT_TC2) | BIT(PORT_TC3) | BIT(PORT_TC4),
> };
>
> +/*
> + * Separate detection for no display cases to keep the display id array simple.
> + *
> + * IVB Q requires subvendor and subdevice matching to differentiate from IVB D
> + * GT2 server.
> + */
> +static bool has_no_display(struct pci_dev *pdev)
> +{
> + static const struct pci_device_id ids[] = {
> + INTEL_IVB_Q_IDS(0),
> + {}
> + };
> +
> + return pci_match_id(ids, pdev);
> +}
> +
> #undef INTEL_VGA_DEVICE
> -#undef INTEL_QUANTA_VGA_DEVICE
> #define INTEL_VGA_DEVICE(id, info) { id, info }
> -#define INTEL_QUANTA_VGA_DEVICE(info) { 0x16a, info }
>
> static const struct {
> u32 devid;
> @@ -752,7 +766,6 @@ static const struct {
> INTEL_IRONLAKE_M_IDS(&ilk_m_display),
> INTEL_SNB_D_IDS(&snb_display),
> INTEL_SNB_M_IDS(&snb_display),
> - INTEL_IVB_Q_IDS(NULL), /* must be first IVB in list */
> INTEL_IVB_M_IDS(&ivb_display),
> INTEL_IVB_D_IDS(&ivb_display),
> INTEL_HSW_IDS(&hsw_display),
> @@ -837,6 +850,11 @@ intel_display_device_probe(struct drm_i915_private *i915, bool has_gmdid,
> if (has_gmdid)
> return probe_gmdid_display(i915, gmdid_ver, gmdid_rel, gmdid_step);
>
> + if (has_no_display(pdev)) {
> + drm_dbg_kms(&i915->drm, "Device doesn't have display\n");
> + return &no_display;
> + }
> +
> for (i = 0; i < ARRAY_SIZE(intel_display_ids); i++) {
> if (intel_display_ids[i].devid == pdev->device)
> return intel_display_ids[i].info;
--
Jani Nikula, Intel Open Source Graphics Center
^ permalink raw reply [flat|nested] 14+ messages in thread
* Re: [Intel-gfx] [PATCH 1/2] drm/i915: fix display probe for IVB Q and IVB D GT2 server
2023-08-10 9:29 ` Jani Nikula
@ 2023-08-10 15:51 ` Greg KH
-1 siblings, 0 replies; 14+ messages in thread
From: Greg KH @ 2023-08-10 15:51 UTC (permalink / raw)
To: Jani Nikula; +Cc: Sasha Levin, intel-gfx, Matt Roper, stable, Andrzej Hajda
On Thu, Aug 10, 2023 at 12:29:48PM +0300, Jani Nikula wrote:
> On Fri, 04 Aug 2023, Jani Nikula <jani.nikula@intel.com> wrote:
> > The current display probe is unable to differentiate between IVB Q and
> > IVB D GT2 server, as they both have the same device id, but different
> > subvendor and subdevice. This leads to the latter being misidentified as
> > the former, and should just end up not having a display. However, the no
> > display case returns a NULL as the display device info, and promptly
> > oopses.
> >
> > As the IVB Q case is rare, and we're anyway moving towards GMD ID,
> > handle the identification requiring subvendor and subdevice as a special
> > case first, instead of unnecessarily growing the intel_display_ids[]
> > array with subvendor and subdevice.
> >
> > [ 5.425298] BUG: kernel NULL pointer dereference, address: 0000000000000000
> > [ 5.426059] #PF: supervisor read access in kernel mode
> > [ 5.426810] #PF: error_code(0x0000) - not-present page
> > [ 5.427570] PGD 0 P4D 0
> > [ 5.428285] Oops: 0000 [#1] PREEMPT SMP PTI
> > [ 5.429035] CPU: 0 PID: 137 Comm: (udev-worker) Not tainted 6.4.0-1-amd64 #1 Debian 6.4.4-1
> > [ 5.429759] Hardware name: HP HP Z220 SFF Workstation/HP Z220 SFF Workstation, BIOS 4.19-218-gb184e6e0a1 02/02/2023
> > [ 5.430485] RIP: 0010:intel_device_info_driver_create+0xf1/0x120 [i915]
> > [ 5.431338] Code: 48 8b 97 80 1b 00 00 89 8f c0 1b 00 00 48 89 b7 b0 1b 00 00 48 89 97 b8 1b 00 00 0f b7 fd e8 76 e8 14 00 48 89 83 50 1b 00 00 <48> 8b 08 48 89 8b c4 1b 00 00 48 8b 48 08 48 89 8b cc 1b 00 00 8b
> > [ 5.432920] RSP: 0018:ffffb8254044fb98 EFLAGS: 00010206
> > [ 5.433707] RAX: 0000000000000000 RBX: ffff923076e80000 RCX: 0000000000000000
> > [ 5.434494] RDX: 0000000000000260 RSI: 0000000100001000 RDI: 000000000000016a
> > [ 5.435277] RBP: 000000000000016a R08: ffffb8254044fb00 R09: 0000000000000000
> > [ 5.436055] R10: ffff922d02761de8 R11: 00657361656c6572 R12: ffffffffc0e5d140
> > [ 5.436867] R13: ffff922d00b720d0 R14: 0000000076e80000 R15: ffff923078c0cae8
> > [ 5.437646] FS: 00007febd19a18c0(0000) GS:ffff92307c000000(0000) knlGS:0000000000000000
> > [ 5.438434] CS: 0010 DS: 0000 ES: 0000 CR0: 0000000080050033
> > [ 5.439218] CR2: 0000000000000000 CR3: 000000010256e002 CR4: 00000000001706f0
> > [ 5.440009] Call Trace:
> > [ 5.440824] <TASK>
> > [ 5.441611] ? __die+0x23/0x70
> > [ 5.442394] ? page_fault_oops+0x17d/0x4c0
> > [ 5.443173] ? exc_page_fault+0x7f/0x180
> > [ 5.443949] ? asm_exc_page_fault+0x26/0x30
> > [ 5.444756] ? intel_device_info_driver_create+0xf1/0x120 [i915]
> > [ 5.445652] ? intel_device_info_driver_create+0xea/0x120 [i915]
> > [ 5.446545] i915_driver_probe+0x7f/0xb60 [i915]
> > [ 5.447431] ? drm_privacy_screen_get+0x15c/0x1a0 [drm]
> > [ 5.448240] local_pci_probe+0x45/0xa0
> > [ 5.449013] pci_device_probe+0xc7/0x240
> > [ 5.449748] really_probe+0x19e/0x3e0
> > [ 5.450464] ? __pfx___driver_attach+0x10/0x10
> > [ 5.451172] __driver_probe_device+0x78/0x160
> > [ 5.451870] driver_probe_device+0x1f/0x90
> > [ 5.452601] __driver_attach+0xd2/0x1c0
> > [ 5.453293] bus_for_each_dev+0x88/0xd0
> > [ 5.453989] bus_add_driver+0x116/0x220
> > [ 5.454672] driver_register+0x59/0x100
> > [ 5.455336] i915_init+0x25/0xc0 [i915]
> > [ 5.456104] ? __pfx_i915_init+0x10/0x10 [i915]
> > [ 5.456882] do_one_initcall+0x5d/0x240
> > [ 5.457511] do_init_module+0x60/0x250
> > [ 5.458126] __do_sys_finit_module+0xac/0x120
> > [ 5.458721] do_syscall_64+0x60/0xc0
> > [ 5.459314] ? syscall_exit_to_user_mode+0x1b/0x40
> > [ 5.459897] ? do_syscall_64+0x6c/0xc0
> > [ 5.460510] entry_SYSCALL_64_after_hwframe+0x72/0xdc
> > [ 5.461082] RIP: 0033:0x7febd20b0eb9
> > [ 5.461648] Code: 08 89 e8 5b 5d c3 66 2e 0f 1f 84 00 00 00 00 00 90 48 89 f8 48 89 f7 48 89 d6 48 89 ca 4d 89 c2 4d 89 c8 4c 8b 4c 24 08 0f 05 <48> 3d 01 f0 ff ff 73 01 c3 48 8b 0d 2f 1f 0d 00 f7 d8 64 89 01 48
> > [ 5.462905] RSP: 002b:00007fffabb1ba78 EFLAGS: 00000246 ORIG_RAX: 0000000000000139
> > [ 5.463554] RAX: ffffffffffffffda RBX: 0000561e6304f410 RCX: 00007febd20b0eb9
> > [ 5.464201] RDX: 0000000000000000 RSI: 00007febd2244f0d RDI: 0000000000000015
> > [ 5.464869] RBP: 00007febd2244f0d R08: 0000000000000000 R09: 000000000000000a
> > [ 5.465512] R10: 0000000000000015 R11: 0000000000000246 R12: 0000000000020000
> > [ 5.466124] R13: 0000000000000000 R14: 0000561e63032b60 R15: 000000000000000a
> > [ 5.466700] </TASK>
> > [ 5.467271] Modules linked in: i915(+) drm_buddy video crc32_pclmul sr_mod hid_generic wmi crc32c_intel i2c_algo_bit sd_mod cdrom drm_display_helper cec usbhid rc_core ghash_clmulni_intel hid sha512_ssse3 ttm sha512_generic xhci_pci ehci_pci xhci_hcd ehci_hcd nvme ahci drm_kms_helper nvme_core libahci t10_pi libata psmouse aesni_intel scsi_mod crypto_simd i2c_i801 scsi_common crc64_rocksoft_generic cryptd i2c_smbus drm lpc_ich crc64_rocksoft crc_t10dif e1000e usbcore crct10dif_generic usb_common crct10dif_pclmul crc64 crct10dif_common button
> > [ 5.469750] CR2: 0000000000000000
> > [ 5.470364] ---[ end trace 0000000000000000 ]---
> > [ 5.470971] RIP: 0010:intel_device_info_driver_create+0xf1/0x120 [i915]
> > [ 5.471699] Code: 48 8b 97 80 1b 00 00 89 8f c0 1b 00 00 48 89 b7 b0 1b 00 00 48 89 97 b8 1b 00 00 0f b7 fd e8 76 e8 14 00 48 89 83 50 1b 00 00 <48> 8b 08 48 89 8b c4 1b 00 00 48 8b 48 08 48 89 8b cc 1b 00 00 8b
> > [ 5.473034] RSP: 0018:ffffb8254044fb98 EFLAGS: 00010206
> > [ 5.473698] RAX: 0000000000000000 RBX: ffff923076e80000 RCX: 0000000000000000
> > [ 5.474371] RDX: 0000000000000260 RSI: 0000000100001000 RDI: 000000000000016a
> > [ 5.475045] RBP: 000000000000016a R08: ffffb8254044fb00 R09: 0000000000000000
> > [ 5.475725] R10: ffff922d02761de8 R11: 00657361656c6572 R12: ffffffffc0e5d140
> > [ 5.476405] R13: ffff922d00b720d0 R14: 0000000076e80000 R15: ffff923078c0cae8
> > [ 5.477124] FS: 00007febd19a18c0(0000) GS:ffff92307c000000(0000) knlGS:0000000000000000
> > [ 5.477811] CS: 0010 DS: 0000 ES: 0000 CR0: 0000000080050033
> > [ 5.478499] CR2: 0000000000000000 CR3: 000000010256e002 CR4: 00000000001706f0
> >
> > Fixes: 69d439818fe5 ("drm/i915/display: Make display responsible for probing its own IP")
>
> Sasha, after pushing this fix, I realized the bug report was against
> 6.4.4, but the above commit hit upstream in v6.5-rc1.
>
> Turns out it was automatically backported as a dependency:
>
> commit be2caaed96c55bb1fcd55a25e60d7b309ff49f2d
> Author: Matt Roper <matthew.d.roper@intel.com>
> Date: Tue May 23 12:56:07 2023 -0700
>
> drm/i915/display: Make display responsible for probing its own IP
>
> [ Upstream commit 69d439818fe501e8c9e50d963a53cb596e36f9f7 ]
>
> Rather than selecting the display IP and feature flags at the same time
> the general PCI probing happens, move this step into the display code
> itself so that it can be more easily re-used outside of i915 (i.e., by
> the Xe driver).
>
> v2:
> - Make intel_display_device_probe() always return a non-NULL pointer
> and simplify copying of runtime_defaults. (Andrzej)
> v3:
> - Redefine INTEL_VGA_DEVICE/INTEL_QUANTA_DEVICE to eliminate a cast and
> an include of linux/mod_devicetable.h. (Jani)
> - Keep explicit memcpy for runtime defaults. (Jani)
>
> Cc: Andrzej Hajda <andrzej.hajda@intel.com>
> Signed-off-by: Matt Roper <matthew.d.roper@intel.com>
> Reviewed-by: Andrzej Hajda <andrzej.hajda@intel.com>
> Acked-by: Jani Nikula <jani.nikula@intel.com>
> Link: https://patchwork.freedesktop.org/patch/msgid/20230523195609.73627-5-matthew.d.roper@intel.com
> Stable-dep-of: 19db2062094c ("drm/i915: No 10bit gamma on desktop gen3 parts")
> Signed-off-by: Sasha Levin <sashal@kernel.org>
>
> I'm a bit surprised and scared this kind of refactoring commit got
> backported to stable.
It was needed by a different change, as the "Stable-dep-of:" line shows.
> Do you have automation in place to backport the fixes to backported
> commits too? I didn't think to add Cc: stable in the commit.
Yes, we do have it, but it can lag a release or two.
thanks
greg k-h
^ permalink raw reply [flat|nested] 14+ messages in thread
* Re: [PATCH 1/2] drm/i915: fix display probe for IVB Q and IVB D GT2 server
@ 2023-08-10 15:51 ` Greg KH
0 siblings, 0 replies; 14+ messages in thread
From: Greg KH @ 2023-08-10 15:51 UTC (permalink / raw)
To: Jani Nikula; +Cc: intel-gfx, Sasha Levin, Matt Roper, Andrzej Hajda, stable
On Thu, Aug 10, 2023 at 12:29:48PM +0300, Jani Nikula wrote:
> On Fri, 04 Aug 2023, Jani Nikula <jani.nikula@intel.com> wrote:
> > The current display probe is unable to differentiate between IVB Q and
> > IVB D GT2 server, as they both have the same device id, but different
> > subvendor and subdevice. This leads to the latter being misidentified as
> > the former, and should just end up not having a display. However, the no
> > display case returns a NULL as the display device info, and promptly
> > oopses.
> >
> > As the IVB Q case is rare, and we're anyway moving towards GMD ID,
> > handle the identification requiring subvendor and subdevice as a special
> > case first, instead of unnecessarily growing the intel_display_ids[]
> > array with subvendor and subdevice.
> >
> > [ 5.425298] BUG: kernel NULL pointer dereference, address: 0000000000000000
> > [ 5.426059] #PF: supervisor read access in kernel mode
> > [ 5.426810] #PF: error_code(0x0000) - not-present page
> > [ 5.427570] PGD 0 P4D 0
> > [ 5.428285] Oops: 0000 [#1] PREEMPT SMP PTI
> > [ 5.429035] CPU: 0 PID: 137 Comm: (udev-worker) Not tainted 6.4.0-1-amd64 #1 Debian 6.4.4-1
> > [ 5.429759] Hardware name: HP HP Z220 SFF Workstation/HP Z220 SFF Workstation, BIOS 4.19-218-gb184e6e0a1 02/02/2023
> > [ 5.430485] RIP: 0010:intel_device_info_driver_create+0xf1/0x120 [i915]
> > [ 5.431338] Code: 48 8b 97 80 1b 00 00 89 8f c0 1b 00 00 48 89 b7 b0 1b 00 00 48 89 97 b8 1b 00 00 0f b7 fd e8 76 e8 14 00 48 89 83 50 1b 00 00 <48> 8b 08 48 89 8b c4 1b 00 00 48 8b 48 08 48 89 8b cc 1b 00 00 8b
> > [ 5.432920] RSP: 0018:ffffb8254044fb98 EFLAGS: 00010206
> > [ 5.433707] RAX: 0000000000000000 RBX: ffff923076e80000 RCX: 0000000000000000
> > [ 5.434494] RDX: 0000000000000260 RSI: 0000000100001000 RDI: 000000000000016a
> > [ 5.435277] RBP: 000000000000016a R08: ffffb8254044fb00 R09: 0000000000000000
> > [ 5.436055] R10: ffff922d02761de8 R11: 00657361656c6572 R12: ffffffffc0e5d140
> > [ 5.436867] R13: ffff922d00b720d0 R14: 0000000076e80000 R15: ffff923078c0cae8
> > [ 5.437646] FS: 00007febd19a18c0(0000) GS:ffff92307c000000(0000) knlGS:0000000000000000
> > [ 5.438434] CS: 0010 DS: 0000 ES: 0000 CR0: 0000000080050033
> > [ 5.439218] CR2: 0000000000000000 CR3: 000000010256e002 CR4: 00000000001706f0
> > [ 5.440009] Call Trace:
> > [ 5.440824] <TASK>
> > [ 5.441611] ? __die+0x23/0x70
> > [ 5.442394] ? page_fault_oops+0x17d/0x4c0
> > [ 5.443173] ? exc_page_fault+0x7f/0x180
> > [ 5.443949] ? asm_exc_page_fault+0x26/0x30
> > [ 5.444756] ? intel_device_info_driver_create+0xf1/0x120 [i915]
> > [ 5.445652] ? intel_device_info_driver_create+0xea/0x120 [i915]
> > [ 5.446545] i915_driver_probe+0x7f/0xb60 [i915]
> > [ 5.447431] ? drm_privacy_screen_get+0x15c/0x1a0 [drm]
> > [ 5.448240] local_pci_probe+0x45/0xa0
> > [ 5.449013] pci_device_probe+0xc7/0x240
> > [ 5.449748] really_probe+0x19e/0x3e0
> > [ 5.450464] ? __pfx___driver_attach+0x10/0x10
> > [ 5.451172] __driver_probe_device+0x78/0x160
> > [ 5.451870] driver_probe_device+0x1f/0x90
> > [ 5.452601] __driver_attach+0xd2/0x1c0
> > [ 5.453293] bus_for_each_dev+0x88/0xd0
> > [ 5.453989] bus_add_driver+0x116/0x220
> > [ 5.454672] driver_register+0x59/0x100
> > [ 5.455336] i915_init+0x25/0xc0 [i915]
> > [ 5.456104] ? __pfx_i915_init+0x10/0x10 [i915]
> > [ 5.456882] do_one_initcall+0x5d/0x240
> > [ 5.457511] do_init_module+0x60/0x250
> > [ 5.458126] __do_sys_finit_module+0xac/0x120
> > [ 5.458721] do_syscall_64+0x60/0xc0
> > [ 5.459314] ? syscall_exit_to_user_mode+0x1b/0x40
> > [ 5.459897] ? do_syscall_64+0x6c/0xc0
> > [ 5.460510] entry_SYSCALL_64_after_hwframe+0x72/0xdc
> > [ 5.461082] RIP: 0033:0x7febd20b0eb9
> > [ 5.461648] Code: 08 89 e8 5b 5d c3 66 2e 0f 1f 84 00 00 00 00 00 90 48 89 f8 48 89 f7 48 89 d6 48 89 ca 4d 89 c2 4d 89 c8 4c 8b 4c 24 08 0f 05 <48> 3d 01 f0 ff ff 73 01 c3 48 8b 0d 2f 1f 0d 00 f7 d8 64 89 01 48
> > [ 5.462905] RSP: 002b:00007fffabb1ba78 EFLAGS: 00000246 ORIG_RAX: 0000000000000139
> > [ 5.463554] RAX: ffffffffffffffda RBX: 0000561e6304f410 RCX: 00007febd20b0eb9
> > [ 5.464201] RDX: 0000000000000000 RSI: 00007febd2244f0d RDI: 0000000000000015
> > [ 5.464869] RBP: 00007febd2244f0d R08: 0000000000000000 R09: 000000000000000a
> > [ 5.465512] R10: 0000000000000015 R11: 0000000000000246 R12: 0000000000020000
> > [ 5.466124] R13: 0000000000000000 R14: 0000561e63032b60 R15: 000000000000000a
> > [ 5.466700] </TASK>
> > [ 5.467271] Modules linked in: i915(+) drm_buddy video crc32_pclmul sr_mod hid_generic wmi crc32c_intel i2c_algo_bit sd_mod cdrom drm_display_helper cec usbhid rc_core ghash_clmulni_intel hid sha512_ssse3 ttm sha512_generic xhci_pci ehci_pci xhci_hcd ehci_hcd nvme ahci drm_kms_helper nvme_core libahci t10_pi libata psmouse aesni_intel scsi_mod crypto_simd i2c_i801 scsi_common crc64_rocksoft_generic cryptd i2c_smbus drm lpc_ich crc64_rocksoft crc_t10dif e1000e usbcore crct10dif_generic usb_common crct10dif_pclmul crc64 crct10dif_common button
> > [ 5.469750] CR2: 0000000000000000
> > [ 5.470364] ---[ end trace 0000000000000000 ]---
> > [ 5.470971] RIP: 0010:intel_device_info_driver_create+0xf1/0x120 [i915]
> > [ 5.471699] Code: 48 8b 97 80 1b 00 00 89 8f c0 1b 00 00 48 89 b7 b0 1b 00 00 48 89 97 b8 1b 00 00 0f b7 fd e8 76 e8 14 00 48 89 83 50 1b 00 00 <48> 8b 08 48 89 8b c4 1b 00 00 48 8b 48 08 48 89 8b cc 1b 00 00 8b
> > [ 5.473034] RSP: 0018:ffffb8254044fb98 EFLAGS: 00010206
> > [ 5.473698] RAX: 0000000000000000 RBX: ffff923076e80000 RCX: 0000000000000000
> > [ 5.474371] RDX: 0000000000000260 RSI: 0000000100001000 RDI: 000000000000016a
> > [ 5.475045] RBP: 000000000000016a R08: ffffb8254044fb00 R09: 0000000000000000
> > [ 5.475725] R10: ffff922d02761de8 R11: 00657361656c6572 R12: ffffffffc0e5d140
> > [ 5.476405] R13: ffff922d00b720d0 R14: 0000000076e80000 R15: ffff923078c0cae8
> > [ 5.477124] FS: 00007febd19a18c0(0000) GS:ffff92307c000000(0000) knlGS:0000000000000000
> > [ 5.477811] CS: 0010 DS: 0000 ES: 0000 CR0: 0000000080050033
> > [ 5.478499] CR2: 0000000000000000 CR3: 000000010256e002 CR4: 00000000001706f0
> >
> > Fixes: 69d439818fe5 ("drm/i915/display: Make display responsible for probing its own IP")
>
> Sasha, after pushing this fix, I realized the bug report was against
> 6.4.4, but the above commit hit upstream in v6.5-rc1.
>
> Turns out it was automatically backported as a dependency:
>
> commit be2caaed96c55bb1fcd55a25e60d7b309ff49f2d
> Author: Matt Roper <matthew.d.roper@intel.com>
> Date: Tue May 23 12:56:07 2023 -0700
>
> drm/i915/display: Make display responsible for probing its own IP
>
> [ Upstream commit 69d439818fe501e8c9e50d963a53cb596e36f9f7 ]
>
> Rather than selecting the display IP and feature flags at the same time
> the general PCI probing happens, move this step into the display code
> itself so that it can be more easily re-used outside of i915 (i.e., by
> the Xe driver).
>
> v2:
> - Make intel_display_device_probe() always return a non-NULL pointer
> and simplify copying of runtime_defaults. (Andrzej)
> v3:
> - Redefine INTEL_VGA_DEVICE/INTEL_QUANTA_DEVICE to eliminate a cast and
> an include of linux/mod_devicetable.h. (Jani)
> - Keep explicit memcpy for runtime defaults. (Jani)
>
> Cc: Andrzej Hajda <andrzej.hajda@intel.com>
> Signed-off-by: Matt Roper <matthew.d.roper@intel.com>
> Reviewed-by: Andrzej Hajda <andrzej.hajda@intel.com>
> Acked-by: Jani Nikula <jani.nikula@intel.com>
> Link: https://patchwork.freedesktop.org/patch/msgid/20230523195609.73627-5-matthew.d.roper@intel.com
> Stable-dep-of: 19db2062094c ("drm/i915: No 10bit gamma on desktop gen3 parts")
> Signed-off-by: Sasha Levin <sashal@kernel.org>
>
> I'm a bit surprised and scared this kind of refactoring commit got
> backported to stable.
It was needed by a different change, as the "Stable-dep-of:" line shows.
> Do you have automation in place to backport the fixes to backported
> commits too? I didn't think to add Cc: stable in the commit.
Yes, we do have it, but it can lag a release or two.
thanks
greg k-h
^ permalink raw reply [flat|nested] 14+ messages in thread
end of thread, other threads:[~2023-08-10 15:51 UTC | newest]
Thread overview: 14+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2023-08-04 8:45 [Intel-gfx] [PATCH 1/2] drm/i915: fix display probe for IVB Q and IVB D GT2 server Jani Nikula
2023-08-04 8:46 ` [Intel-gfx] [PATCH 2/2] drm/i915: debug log when GMD ID indicates there's no display Jani Nikula
2023-08-09 16:27 ` Luca Coelho
2023-08-04 17:03 ` [Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for series starting with [1/2] drm/i915: fix display probe for IVB Q and IVB D GT2 server Patchwork
2023-08-04 17:04 ` [Intel-gfx] ✗ Fi.CI.SPARSE: " Patchwork
2023-08-04 17:23 ` [Intel-gfx] ✓ Fi.CI.BAT: success " Patchwork
2023-08-05 0:21 ` [Intel-gfx] ✓ Fi.CI.IGT: " Patchwork
2023-08-09 16:26 ` [Intel-gfx] [PATCH 1/2] " Luca Coelho
2023-08-10 9:21 ` Jani Nikula
2023-08-09 22:27 ` Matt Roper
2023-08-10 9:29 ` Jani Nikula
2023-08-10 9:29 ` Jani Nikula
2023-08-10 15:51 ` [Intel-gfx] " Greg KH
2023-08-10 15:51 ` Greg KH
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.