From: "Dixit, Ashutosh" <ashutosh.dixit@intel.com>
To: Guenter Roeck <linux@roeck-us.net>
Cc: linux-hwmon@vger.kernel.org, intel-xe@lists.freedesktop.org
Subject: Re: [Intel-xe] [PATCH v2 0/6] Add HWMON support for DGFX
Date: Sun, 02 Jul 2023 18:48:20 -0700 [thread overview]
Message-ID: <871qhpepej.wl-ashutosh.dixit@intel.com> (raw)
In-Reply-To: <4b71ba43-4cbb-0840-a46a-3fe4518254d0@roeck-us.net>
On Sun, 02 Jul 2023 13:51:40 -0700, Guenter Roeck wrote:
>
> On 7/2/23 13:29, Dixit, Ashutosh wrote:
>
> > Of course people might have been abusing the deprecated API's (or NULL chip
> > parameter) but to me it seems there is also some legitimate use for them.
> >
>
> You still neglect to explain what you think that legitimate use would be.
To me "drivers/gpu/drm/amd/pm/amdgpu_pm.c" is a legitimate use case which
doesn't use chip_info (both standard and custom hwmon attributes are
defined without using chip_info). "drivers/gpu/drm/i915/i915_hwmon.c" has
all this extra code related to chip_info/channel_info which is not
needed. i915 could well move to the amdgpu model and that would reduce i915
code. That is what I was originally proposing for this new patch series.
Ashutosh
WARNING: multiple messages have this Message-ID (diff)
From: "Dixit, Ashutosh" <ashutosh.dixit@intel.com>
To: Guenter Roeck <linux@roeck-us.net>
Cc: Badal Nilawar <badal.nilawar@intel.com>,
intel-xe@lists.freedesktop.org, linux-hwmon@vger.kernel.org,
anshuman.gupta@intel.com, andi.shyti@linux.intel.com,
riana.tauro@intel.com, matthew.brost@intel.com
Subject: Re: [PATCH v2 0/6] Add HWMON support for DGFX
Date: Sun, 02 Jul 2023 18:48:20 -0700 [thread overview]
Message-ID: <871qhpepej.wl-ashutosh.dixit@intel.com> (raw)
In-Reply-To: <4b71ba43-4cbb-0840-a46a-3fe4518254d0@roeck-us.net>
On Sun, 02 Jul 2023 13:51:40 -0700, Guenter Roeck wrote:
>
> On 7/2/23 13:29, Dixit, Ashutosh wrote:
>
> > Of course people might have been abusing the deprecated API's (or NULL chip
> > parameter) but to me it seems there is also some legitimate use for them.
> >
>
> You still neglect to explain what you think that legitimate use would be.
To me "drivers/gpu/drm/amd/pm/amdgpu_pm.c" is a legitimate use case which
doesn't use chip_info (both standard and custom hwmon attributes are
defined without using chip_info). "drivers/gpu/drm/i915/i915_hwmon.c" has
all this extra code related to chip_info/channel_info which is not
needed. i915 could well move to the amdgpu model and that would reduce i915
code. That is what I was originally proposing for this new patch series.
Ashutosh
next prev parent reply other threads:[~2023-07-03 1:48 UTC|newest]
Thread overview: 72+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-06-27 18:30 [Intel-xe] [PATCH v2 0/6] Add HWMON support for DGFX Badal Nilawar
2023-06-27 18:30 ` Badal Nilawar
2023-06-27 18:27 ` [Intel-xe] ✓ CI.Patch_applied: success for Add HWMON support for DGFX (rev2) Patchwork
2023-06-27 18:27 ` [Intel-xe] ✗ CI.checkpatch: warning " Patchwork
2023-06-27 18:29 ` [Intel-xe] ✓ CI.KUnit: success " Patchwork
2023-06-27 18:30 ` [Intel-xe] [PATCH v2 1/6] drm/xe/hwmon: Add HWMON infrastructure Badal Nilawar
2023-06-27 18:30 ` Badal Nilawar
2023-06-28 22:50 ` [Intel-xe] " Matthew Brost
2023-06-28 22:50 ` Matthew Brost
2023-07-05 18:30 ` [Intel-xe] " Nilawar, Badal
2023-07-05 18:30 ` Nilawar, Badal
2023-06-29 13:49 ` [Intel-xe] " Andi Shyti
2023-06-29 13:49 ` Andi Shyti
2023-07-07 14:23 ` [Intel-xe] " Nilawar, Badal
2023-07-07 14:23 ` Nilawar, Badal
2023-06-27 18:30 ` [Intel-xe] [PATCH v2 2/6] drm/xe/hwmon: Expose power attributes Badal Nilawar
2023-06-27 18:30 ` Badal Nilawar
2023-06-29 0:18 ` [Intel-xe] " Matthew Brost
2023-06-29 0:18 ` Matthew Brost
2023-06-29 14:09 ` [Intel-xe] " Andi Shyti
2023-06-29 14:09 ` Andi Shyti
2023-08-15 23:20 ` [Intel-xe] " Dixit, Ashutosh
2023-08-15 23:20 ` Dixit, Ashutosh
2023-08-18 4:03 ` [Intel-xe] " Nilawar, Badal
2023-08-18 4:03 ` Nilawar, Badal
2023-08-18 13:55 ` [Intel-xe] " Andi Shyti
2023-08-18 13:55 ` Andi Shyti
2023-07-06 10:36 ` [Intel-xe] " Nilawar, Badal
2023-07-06 10:36 ` Nilawar, Badal
2023-06-27 18:30 ` [Intel-xe] [PATCH v2 3/6] drm/xe/hwmon: Expose card reactive critical power Badal Nilawar
2023-06-27 18:30 ` Badal Nilawar
2023-06-28 15:52 ` [Intel-xe] " Nilawar, Badal
2023-06-29 14:40 ` Andi Shyti
2023-06-29 14:40 ` Andi Shyti
2023-07-06 19:05 ` [Intel-xe] " Dixit, Ashutosh
2023-07-06 19:05 ` Dixit, Ashutosh
2023-06-27 18:30 ` [Intel-xe] [PATCH v2 4/6] drm/xe/hwmon: Expose input voltage attribute Badal Nilawar
2023-06-27 18:30 ` Badal Nilawar
2023-06-29 14:58 ` [Intel-xe] " Andi Shyti
2023-06-29 14:58 ` Andi Shyti
2023-06-27 18:30 ` [Intel-xe] [PATCH v2 5/6] drm/xe/hwmon: Expose hwmon energy attribute Badal Nilawar
2023-06-27 18:30 ` Badal Nilawar
2023-06-29 15:09 ` [Intel-xe] " Andi Shyti
2023-06-29 15:09 ` Andi Shyti
2023-06-27 18:30 ` [Intel-xe] [PATCH v2 6/6] drm/xe/hwmon: Expose power1_max_interval Badal Nilawar
2023-06-27 18:30 ` Badal Nilawar
2023-06-27 18:32 ` [Intel-xe] ✓ CI.Build: success for Add HWMON support for DGFX (rev2) Patchwork
2023-06-27 18:33 ` [Intel-xe] ✗ CI.Hooks: failure " Patchwork
2023-07-02 1:31 ` [Intel-xe] [PATCH v2 0/6] Add HWMON support for DGFX Dixit, Ashutosh
2023-07-02 1:31 ` Dixit, Ashutosh
2023-07-02 3:02 ` [Intel-xe] " Guenter Roeck
2023-07-02 3:02 ` Guenter Roeck
2023-07-02 15:57 ` [Intel-xe] " Dixit, Ashutosh
2023-07-02 15:57 ` Dixit, Ashutosh
2023-07-02 17:01 ` [Intel-xe] " Guenter Roeck
2023-07-02 17:01 ` Guenter Roeck
2023-07-02 20:29 ` [Intel-xe] " Dixit, Ashutosh
2023-07-02 20:29 ` Dixit, Ashutosh
2023-07-02 20:51 ` [Intel-xe] " Guenter Roeck
2023-07-02 20:51 ` Guenter Roeck
2023-07-03 1:48 ` Dixit, Ashutosh [this message]
2023-07-03 1:48 ` Dixit, Ashutosh
2023-07-03 2:37 ` [Intel-xe] " Guenter Roeck
2023-07-03 2:37 ` Guenter Roeck
2023-07-14 20:21 ` [Intel-xe] " Rodrigo Vivi
2023-07-14 20:21 ` Rodrigo Vivi
2023-07-14 22:26 ` Guenter Roeck
2023-07-14 22:26 ` Guenter Roeck
2023-07-19 17:01 ` Rodrigo Vivi
2023-07-19 17:01 ` Rodrigo Vivi
2023-07-03 8:55 ` Andi Shyti
2023-07-03 8:55 ` Andi Shyti
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=871qhpepej.wl-ashutosh.dixit@intel.com \
--to=ashutosh.dixit@intel.com \
--cc=intel-xe@lists.freedesktop.org \
--cc=linux-hwmon@vger.kernel.org \
--cc=linux@roeck-us.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.