* [PATCH] Run docker probe only if docker or podman are available
@ 2022-10-30 8:35 Stefan Weil via
2022-11-02 20:28 ` Stefan Weil via
2022-11-02 23:30 ` Alex Bennée
0 siblings, 2 replies; 4+ messages in thread
From: Stefan Weil via @ 2022-10-30 8:35 UTC (permalink / raw)
To: qemu-devel; +Cc: Paolo Bonzini, Alex Bennée, Stefan Weil
The docker probe uses "sudo -n" which can cause an e-mail with a security warning
each time when configure is run. Therefore run docker probe only if either docker
or podman are available.
That avoids the problematic "sudo -n" on build environments which have neither
docker nor podman installed.
Fixes: c4575b59155e2e00 ("configure: store container engine in config-host.mak")
Signed-off-by: Stefan Weil <sw@weilnetz.de>
---
configure | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/configure b/configure
index 81561be7c1..3af99282b7 100755
--- a/configure
+++ b/configure
@@ -1779,7 +1779,7 @@ fi
# functions to probe cross compilers
container="no"
-if test $use_containers = "yes"; then
+if test $use_containers = "yes" && (has "docker" || has "podman"); then
case $($python "$source_path"/tests/docker/docker.py probe) in
*docker) container=docker ;;
podman) container=podman ;;
--
2.30.2
^ permalink raw reply related [flat|nested] 4+ messages in thread* Re: [PATCH] Run docker probe only if docker or podman are available
2022-10-30 8:35 [PATCH] Run docker probe only if docker or podman are available Stefan Weil via
@ 2022-11-02 20:28 ` Stefan Weil via
2022-11-02 23:30 ` Alex Bennée
1 sibling, 0 replies; 4+ messages in thread
From: Stefan Weil @ 2022-11-02 20:28 UTC (permalink / raw)
To: qemu-devel, QEMU Trivial; +Cc: Paolo Bonzini, Alex Bennée
Am 30.10.22 um 09:35 schrieb Stefan Weil:
> The docker probe uses "sudo -n" which can cause an e-mail with a security warning
> each time when configure is run. Therefore run docker probe only if either docker
> or podman are available.
>
> That avoids the problematic "sudo -n" on build environments which have neither
> docker nor podman installed.
>
> Fixes: c4575b59155e2e00 ("configure: store container engine in config-host.mak")
> Signed-off-by: Stefan Weil <sw@weilnetz.de>
> ---
> configure | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/configure b/configure
> index 81561be7c1..3af99282b7 100755
> --- a/configure
> +++ b/configure
> @@ -1779,7 +1779,7 @@ fi
> # functions to probe cross compilers
>
> container="no"
> -if test $use_containers = "yes"; then
> +if test $use_containers = "yes" && (has "docker" || has "podman"); then
> case $($python "$source_path"/tests/docker/docker.py probe) in
> *docker) container=docker ;;
> podman) container=podman ;;
Can this patch be applied by qemu-trivial? For me those security e-mails
are a bug and should be at least avoided as far as possible in the new
QEMU release.
Thanks, Stefan
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH] Run docker probe only if docker or podman are available
@ 2022-11-02 20:28 ` Stefan Weil via
0 siblings, 0 replies; 4+ messages in thread
From: Stefan Weil via @ 2022-11-02 20:28 UTC (permalink / raw)
To: qemu-devel, QEMU Trivial; +Cc: Paolo Bonzini, Alex Bennée
Am 30.10.22 um 09:35 schrieb Stefan Weil:
> The docker probe uses "sudo -n" which can cause an e-mail with a security warning
> each time when configure is run. Therefore run docker probe only if either docker
> or podman are available.
>
> That avoids the problematic "sudo -n" on build environments which have neither
> docker nor podman installed.
>
> Fixes: c4575b59155e2e00 ("configure: store container engine in config-host.mak")
> Signed-off-by: Stefan Weil <sw@weilnetz.de>
> ---
> configure | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/configure b/configure
> index 81561be7c1..3af99282b7 100755
> --- a/configure
> +++ b/configure
> @@ -1779,7 +1779,7 @@ fi
> # functions to probe cross compilers
>
> container="no"
> -if test $use_containers = "yes"; then
> +if test $use_containers = "yes" && (has "docker" || has "podman"); then
> case $($python "$source_path"/tests/docker/docker.py probe) in
> *docker) container=docker ;;
> podman) container=podman ;;
Can this patch be applied by qemu-trivial? For me those security e-mails
are a bug and should be at least avoided as far as possible in the new
QEMU release.
Thanks, Stefan
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] Run docker probe only if docker or podman are available
2022-10-30 8:35 [PATCH] Run docker probe only if docker or podman are available Stefan Weil via
2022-11-02 20:28 ` Stefan Weil via
@ 2022-11-02 23:30 ` Alex Bennée
1 sibling, 0 replies; 4+ messages in thread
From: Alex Bennée @ 2022-11-02 23:30 UTC (permalink / raw)
To: Stefan Weil; +Cc: qemu-devel, Paolo Bonzini
Stefan Weil <sw@weilnetz.de> writes:
> The docker probe uses "sudo -n" which can cause an e-mail with a security warning
> each time when configure is run. Therefore run docker probe only if either docker
> or podman are available.
>
> That avoids the problematic "sudo -n" on build environments which have neither
> docker nor podman installed.
Queued to for-7.2/misc-fixes, thanks.
--
Alex Bennée
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2022-11-02 23:31 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2022-10-30 8:35 [PATCH] Run docker probe only if docker or podman are available Stefan Weil via
2022-11-02 20:28 ` Stefan Weil
2022-11-02 20:28 ` Stefan Weil via
2022-11-02 23:30 ` Alex Bennée
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.