All of lore.kernel.org
 help / color / mirror / Atom feed
From: Takashi Iwai <tiwai@suse.de>
To: Ren Zhijie <renzhijie2@huawei.com>
Cc: alsa-devel@alsa-project.org, sbinding@opensource.cirrus.com,
	arnd@arndb.de, tanureal@opensource.cirrus.com,
	vitalyr@opensource.cirrus.com, patches@opensource.cirrus.com,
	tiwai@suse.com, rf@opensource.cirrus.com,
	james.schulman@cirrus.com, david.rhodes@cirrus.com,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH -next] ALSA: hda: cs35l41: Fix build error unused-function
Date: Mon, 25 Jul 2022 08:32:55 +0200	[thread overview]
Message-ID: <871qu9em7c.wl-tiwai@suse.de> (raw)
In-Reply-To: <20220725023611.57055-1-renzhijie2@huawei.com>

On Mon, 25 Jul 2022 04:36:11 +0200,
Ren Zhijie wrote:
> 
> If CONFIG_PM_SLEEP is not set,
> make ARCH=x86_64 CROSS_COMPILE=x86_64-linux-gnu-, will be failed, like this:
> 
> sound/pci/hda/cs35l41_hda.c:583:12: error: ‘cs35l41_runtime_resume’ defined but not used [-Werror=unused-function]
>  static int cs35l41_runtime_resume(struct device *dev)
>             ^~~~~~~~~~~~~~~~~~~~~~
> sound/pci/hda/cs35l41_hda.c:565:12: error: ‘cs35l41_runtime_suspend’ defined but not used [-Werror=unused-function]
>  static int cs35l41_runtime_suspend(struct device *dev)
>             ^~~~~~~~~~~~~~~~~~~~~~~
> cc1: all warnings being treated as errors
> make[3]: *** [sound/pci/hda/cs35l41_hda.o] Error 1
> 
> commit 1a3c7bb08826 ("PM: core: Add new *_PM_OPS macros,
> deprecate old ones"), add new marco RUNTIME_PM_OPS to fix this unused-function problem.
> 
> Fixes: 1873ebd30cc8 ("ALSA: hda: cs35l41: Support Hibernation during Suspend")
> Signed-off-by: Ren Zhijie <renzhijie2@huawei.com>

Thanks, applied.


Takashi

WARNING: multiple messages have this Message-ID (diff)
From: Takashi Iwai <tiwai@suse.de>
To: Ren Zhijie <renzhijie2@huawei.com>
Cc: <james.schulman@cirrus.com>, <david.rhodes@cirrus.com>,
	<tanureal@opensource.cirrus.com>, <rf@opensource.cirrus.com>,
	<perex@perex.cz>, <tiwai@suse.com>,
	<sbinding@opensource.cirrus.com>, <vitalyr@opensource.cirrus.com>,
	patches@opensource.cirrus.com, alsa-devel@alsa-project.org,
	linux-kernel@vger.kernel.org, arnd@arndb.de
Subject: Re: [PATCH -next] ALSA: hda: cs35l41: Fix build error unused-function
Date: Mon, 25 Jul 2022 08:32:55 +0200	[thread overview]
Message-ID: <871qu9em7c.wl-tiwai@suse.de> (raw)
In-Reply-To: <20220725023611.57055-1-renzhijie2@huawei.com>

On Mon, 25 Jul 2022 04:36:11 +0200,
Ren Zhijie wrote:
> 
> If CONFIG_PM_SLEEP is not set,
> make ARCH=x86_64 CROSS_COMPILE=x86_64-linux-gnu-, will be failed, like this:
> 
> sound/pci/hda/cs35l41_hda.c:583:12: error: ‘cs35l41_runtime_resume’ defined but not used [-Werror=unused-function]
>  static int cs35l41_runtime_resume(struct device *dev)
>             ^~~~~~~~~~~~~~~~~~~~~~
> sound/pci/hda/cs35l41_hda.c:565:12: error: ‘cs35l41_runtime_suspend’ defined but not used [-Werror=unused-function]
>  static int cs35l41_runtime_suspend(struct device *dev)
>             ^~~~~~~~~~~~~~~~~~~~~~~
> cc1: all warnings being treated as errors
> make[3]: *** [sound/pci/hda/cs35l41_hda.o] Error 1
> 
> commit 1a3c7bb08826 ("PM: core: Add new *_PM_OPS macros,
> deprecate old ones"), add new marco RUNTIME_PM_OPS to fix this unused-function problem.
> 
> Fixes: 1873ebd30cc8 ("ALSA: hda: cs35l41: Support Hibernation during Suspend")
> Signed-off-by: Ren Zhijie <renzhijie2@huawei.com>

Thanks, applied.


Takashi

  reply	other threads:[~2022-07-25  6:33 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-07-25  2:36 [PATCH -next] ALSA: hda: cs35l41: Fix build error unused-function Ren Zhijie
2022-07-25  2:36 ` Ren Zhijie
2022-07-25  6:32 ` Takashi Iwai [this message]
2022-07-25  6:32   ` Takashi Iwai

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=871qu9em7c.wl-tiwai@suse.de \
    --to=tiwai@suse.de \
    --cc=alsa-devel@alsa-project.org \
    --cc=arnd@arndb.de \
    --cc=david.rhodes@cirrus.com \
    --cc=james.schulman@cirrus.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=patches@opensource.cirrus.com \
    --cc=renzhijie2@huawei.com \
    --cc=rf@opensource.cirrus.com \
    --cc=sbinding@opensource.cirrus.com \
    --cc=tanureal@opensource.cirrus.com \
    --cc=tiwai@suse.com \
    --cc=vitalyr@opensource.cirrus.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.