All of lore.kernel.org
 help / color / mirror / Atom feed
From: Kalle Valo <kvalo@kernel.org>
To: Maxime Bizon <mbizon@freebox.fr>
Cc: Manikanta Pubbisetty <quic_mpubbise@quicinc.com>,
	 ath11k@lists.infradead.org,  linux-wireless@vger.kernel.org,
	 devicetree@vger.kernel.org,  robh@kernel.org,  mka@chromium.org
Subject: Re: [PATCH v7 4/9] ath11k: Add register access logic for WCN6750
Date: Mon, 30 May 2022 19:17:29 +0300	[thread overview]
Message-ID: <871qwbouzq.fsf@kernel.org> (raw)
In-Reply-To: <c1c3472427080716c69ad99ebe5d1954db44f03f.camel@freebox.fr> (Maxime Bizon's message of "Mon, 30 May 2022 16:19:06 +0200")

Maxime Bizon <mbizon@freebox.fr> writes:

> On Thu, 2022-05-26 at 09:12 +0530, Manikanta Pubbisetty wrote:
>
>> 
>> Thanks for letting me know about this, IIRC I don't remember 
>> encountering this problem in my testing. Just for my understanding,
>> have you reverted this change and confirmed that these errors go away
>> ?
>
> I first confirmed the register location was indeed incorrect, then I
> fixed it like this:

Looks good to me. Can you submit that as a proper patch?

-- 
https://patchwork.kernel.org/project/linux-wireless/list/

https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches

-- 
ath11k mailing list
ath11k@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/ath11k

WARNING: multiple messages have this Message-ID (diff)
From: Kalle Valo <kvalo@kernel.org>
To: Maxime Bizon <mbizon@freebox.fr>
Cc: Manikanta Pubbisetty <quic_mpubbise@quicinc.com>,
	ath11k@lists.infradead.org, linux-wireless@vger.kernel.org,
	devicetree@vger.kernel.org, robh@kernel.org, mka@chromium.org
Subject: Re: [PATCH v7 4/9] ath11k: Add register access logic for WCN6750
Date: Mon, 30 May 2022 19:17:29 +0300	[thread overview]
Message-ID: <871qwbouzq.fsf@kernel.org> (raw)
In-Reply-To: <c1c3472427080716c69ad99ebe5d1954db44f03f.camel@freebox.fr> (Maxime Bizon's message of "Mon, 30 May 2022 16:19:06 +0200")

Maxime Bizon <mbizon@freebox.fr> writes:

> On Thu, 2022-05-26 at 09:12 +0530, Manikanta Pubbisetty wrote:
>
>> 
>> Thanks for letting me know about this, IIRC I don't remember 
>> encountering this problem in my testing. Just for my understanding,
>> have you reverted this change and confirmed that these errors go away
>> ?
>
> I first confirmed the register location was indeed incorrect, then I
> fixed it like this:

Looks good to me. Can you submit that as a proper patch?

-- 
https://patchwork.kernel.org/project/linux-wireless/list/

https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches

  reply	other threads:[~2022-05-30 16:17 UTC|newest]

Thread overview: 36+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-04-29 17:04 [PATCH v7 0/9] add support for WCN6750 Manikanta Pubbisetty
2022-04-29 17:04 ` Manikanta Pubbisetty
2022-04-29 17:04 ` [PATCH v7 1/9] dt: bindings: net: add bindings of WCN6750 for ath11k Manikanta Pubbisetty
2022-04-29 17:04   ` Manikanta Pubbisetty
2022-05-02 13:59   ` Kalle Valo
2022-05-02 13:59     ` Kalle Valo
2022-04-29 17:04 ` [PATCH v7 2/9] ath11k: Move parameters in bus_params to hw_params Manikanta Pubbisetty
2022-04-29 17:04   ` Manikanta Pubbisetty
2022-04-29 17:04 ` [PATCH v7 3/9] ath11k: Add HW params for WCN6750 Manikanta Pubbisetty
2022-04-29 17:04   ` Manikanta Pubbisetty
2022-04-29 17:04 ` [PATCH v7 4/9] ath11k: Add register access logic " Manikanta Pubbisetty
2022-04-29 17:04   ` Manikanta Pubbisetty
2022-05-02  9:12   ` Kalle Valo
2022-05-02  9:12     ` Kalle Valo
2022-05-25 18:46   ` Maxime Bizon
2022-05-25 18:46     ` Maxime Bizon
2022-05-26  3:42     ` Manikanta Pubbisetty
2022-05-26  3:42       ` Manikanta Pubbisetty
2022-05-30 14:19       ` Maxime Bizon
2022-05-30 14:19         ` Maxime Bizon
2022-05-30 16:17         ` Kalle Valo [this message]
2022-05-30 16:17           ` Kalle Valo
2022-05-30 16:22           ` Maxime Bizon
2022-05-30 16:22             ` Maxime Bizon
2022-04-29 17:04 ` [PATCH v7 5/9] ath11k: Fetch device information via QMI " Manikanta Pubbisetty
2022-04-29 17:04   ` Manikanta Pubbisetty
2022-05-02  9:29   ` Kalle Valo
2022-05-02  9:29     ` Kalle Valo
2022-04-29 17:04 ` [PATCH v7 6/9] ath11k: Add QMI changes " Manikanta Pubbisetty
2022-04-29 17:04   ` Manikanta Pubbisetty
2022-04-29 17:05 ` [PATCH v7 7/9] ath11k: HAL changes to support WCN6750 Manikanta Pubbisetty
2022-04-29 17:05   ` Manikanta Pubbisetty
2022-04-29 17:05 ` [PATCH v7 8/9] ath11k: Datapath " Manikanta Pubbisetty
2022-04-29 17:05   ` Manikanta Pubbisetty
2022-04-29 17:05 ` [PATCH v7 9/9] ath11k: Add support for WCN6750 device Manikanta Pubbisetty
2022-04-29 17:05   ` Manikanta Pubbisetty

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=871qwbouzq.fsf@kernel.org \
    --to=kvalo@kernel.org \
    --cc=ath11k@lists.infradead.org \
    --cc=devicetree@vger.kernel.org \
    --cc=linux-wireless@vger.kernel.org \
    --cc=mbizon@freebox.fr \
    --cc=mka@chromium.org \
    --cc=quic_mpubbise@quicinc.com \
    --cc=robh@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.