From: Baruch Siach via buildroot <buildroot@buildroot.org>
To: Charlie Leger <c.leger@borea-dental.com>
Cc: buildroot@buildroot.org
Subject: Re: [Buildroot] [PATCH 1/1] linux:linux.mk: Add "firmware-imx" dependency if needed
Date: Wed, 04 May 2022 13:06:08 +0300 [thread overview]
Message-ID: <871qx9y5gg.fsf@tarshish> (raw)
In-Reply-To: <b6b1cd4e-29d9-7a70-3c5c-cba4f272420f@borea-dental.com>
Hi Charlie,
On Wed, May 04 2022, Charlie Leger wrote:
> Thank you for your review
>
> Le 04/05/2022 à 11:43, Baruch Siach a écrit :
> On Wed, May 04 2022, Leger Charlie wrote:
>
> Since SDMA firmwares for imx[6,7,8] are now provided only by firmware-imx package and not linux-firmware
> package [1].
> Linux build can failed if depending on firmware imx, so add firmware-imx dependency on linux if package is checked.
>
>
> What build failure do you see when firmware-imx does not install before
> kernel build? As far as I can see firmware files are only used at
> run-time.
>
> Failure will happens only for specific kernel configuration which used "CONFIG_EXTRA_FIRMWARE" option [1], which allow to built-in firmware.
> If firmware needed belongs to "firmware-imx" package, linux build will failed.
Thanks for the clarification. The commit log should mention that
firmware-imx is needed at build time for CONFIG_EXTRA_FIRMWARE.
baruch
> Charlie,
>
> https://cateee.net/lkddb/web-lkddb/EXTRA_FIRMWARE.html
>
> baruch
>
> [1] http://lists.busybox.net/pipermail/buildroot/2021-January/603807.html
>
> Signed-off-by: Leger Charlie <c.leger@borea-dental.com>
> ---
> linux/linux.mk | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/linux/linux.mk b/linux/linux.mk
> index 7ff7b05042..e40672ceca 100644
> --- a/linux/linux.mk
> +++ b/linux/linux.mk
> @@ -73,6 +73,7 @@ LINUX_INSTALL_IMAGES = YES
> LINUX_DEPENDENCIES = host-kmod \
> $(if $(BR2_PACKAGE_INTEL_MICROCODE),intel-microcode) \
> $(if $(BR2_PACKAGE_LINUX_FIRMWARE),linux-firmware) \
> + $(if $(BR2_PACKAGE_FREESCALE_IMX),firmware-imx) \
> $(if $(BR2_PACKAGE_WIRELESS_REGDB),wireless-regdb)
>
> # Starting with 4.16, the generated kconfig paser code is no longer
--
~. .~ Tk Open Systems
=}------------------------------------------------ooO--U--Ooo------------{=
- baruch@tkos.co.il - tel: +972.52.368.4656, http://www.tkos.co.il -
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot
next prev parent reply other threads:[~2022-05-04 10:09 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-05-04 9:40 [Buildroot] [PATCH 1/1] linux:linux.mk: Add "firmware-imx" dependency if needed Leger Charlie
2022-05-04 9:43 ` Baruch Siach via buildroot
2022-05-04 10:00 ` Charlie Leger
2022-05-04 10:06 ` Baruch Siach via buildroot [this message]
2022-05-04 11:38 ` Charlie Leger
2022-05-04 11:42 ` Baruch Siach via buildroot
2022-05-05 21:30 ` Arnout Vandecappelle
2022-05-28 9:09 ` Peter Korsgaard
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=871qx9y5gg.fsf@tarshish \
--to=buildroot@buildroot.org \
--cc=baruch@tkos.co.il \
--cc=c.leger@borea-dental.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.