Re: [Buildroot] [PATCH 1/1] linux:linux.mk: Add "firmware-imx" dependency if needed

[Baruch Siach via buildroot <buildroot@buildroot.org>]

Hi Charlie,

On Wed, May 04 2022, Charlie Leger wrote:
> Le 04/05/2022 à 12:06, Baruch Siach a écrit :
> On Wed, May 04 2022, Charlie Leger wrote:
>
>  Thank you for your review
>
> Le 04/05/2022 à 11:43, Baruch Siach a écrit :
> On Wed, May 04 2022, Leger Charlie wrote:
>
>  Since SDMA firmwares for imx[6,7,8] are now provided only by firmware-imx package and not linux-firmware
>  package [1].
> Linux build can failed if depending on firmware imx, so add firmware-imx dependency on linux if package is checked.
>
>
> What build failure do you see when firmware-imx does not install before
> kernel build? As far as I can see firmware files are only used at
> run-time.
>
> Failure will happens only for specific kernel configuration which used "CONFIG_EXTRA_FIRMWARE" option [1], which allow to built-in firmware.
> If firmware needed belongs to "firmware-imx" package, linux build will failed.
>
> Thanks for the clarification. The commit log should mention that
> firmware-imx is needed at build time for CONFIG_EXTRA_FIRMWARE.
>
> I'm sorry for the dummy question... do I need to provide a v2 patch for it ?

I think that a v2 patch would be nice in this case. You might want to
wait a day or two before sending v2 to let others add their comment on
v1.

When sending v2 make sure that commit log lines length is 72 characters
or less.

Thanks,
baruch

-- 
                                                     ~. .~   Tk Open Systems
=}------------------------------------------------ooO--U--Ooo------------{=
   - baruch@tkos.co.il - tel: +972.52.368.4656, http://www.tkos.co.il -
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot