From: Marc Zyngier <maz@kernel.org>
To: Peter Maydell <peter.maydell@linaro.org>
Cc: kvm@vger.kernel.org,
Richard Henderson <richard.henderson@linaro.org>,
qemu-devel@nongnu.org, kernel-team@android.com,
kvmarm@lists.cs.columbia.edu
Subject: Re: [PATCH v3] hw/arm/virt: KVM: Enable PAuth when supported by the host
Date: Tue, 11 Jan 2022 14:18:42 +0000 [thread overview]
Message-ID: <871r1etkxp.wl-maz@kernel.org> (raw)
In-Reply-To: <CAFEAcA8L5pH41cQ6srk9-JbMKNjdhCD7YpWcw4P06t83Jp11vw@mail.gmail.com>
On Tue, 11 Jan 2022 13:58:49 +0000,
Peter Maydell <peter.maydell@linaro.org> wrote:
>
> On Sat, 8 Jan 2022 at 13:42, Marc Zyngier <maz@kernel.org> wrote:
> >
> > On 2022-01-07 20:23, Richard Henderson wrote:
> > > On 1/7/22 7:01 AM, Marc Zyngier wrote:
> > >> @@ -1380,17 +1380,10 @@ void arm_cpu_finalize_features(ARMCPU *cpu,
> > >> Error **errp)
> > >> return;
> > >> }
> > >> - /*
> > >> - * KVM does not support modifications to this feature.
> > >> - * We have not registered the cpu properties when KVM
> > >> - * is in use, so the user will not be able to set them.
> > >> - */
> > >> - if (!kvm_enabled()) {
> > >> - arm_cpu_pauth_finalize(cpu, &local_err);
> > >> - if (local_err != NULL) {
> > >> + arm_cpu_pauth_finalize(cpu, &local_err);
> > >> + if (local_err != NULL) {
> > >> error_propagate(errp, local_err);
> > >> return;
> > >> - }
> > >> }
> > >
> > > Indentation is still off -- error + return should be out-dented one
> > > level.
> > >
> >
> > Duh. Clearly, my brain can't spot these. Apologies for the extra noise.
> >
> > > Otherwise,
> > > Reviewed-by: Richard Henderson <richard.henderson@linaro.org>
> >
> > Thanks. I'll repost a version shortly, unless someone shouts.
>
> Don't worry about it -- I've applied this to target-arm.next and
> fixed the indent there.
Awesome, thanks Peter.
M.
--
Without deviation from the norm, progress is not possible.
_______________________________________________
kvmarm mailing list
kvmarm@lists.cs.columbia.edu
https://lists.cs.columbia.edu/mailman/listinfo/kvmarm
WARNING: multiple messages have this Message-ID (diff)
From: Marc Zyngier <maz@kernel.org>
To: Peter Maydell <peter.maydell@linaro.org>
Cc: Richard Henderson <richard.henderson@linaro.org>,
qemu-devel@nongnu.org, kvmarm@lists.cs.columbia.edu,
kvm@vger.kernel.org, kernel-team@android.com,
Eric Auger <eric.auger@redhat.com>,
Andrew Jones <drjones@redhat.com>
Subject: Re: [PATCH v3] hw/arm/virt: KVM: Enable PAuth when supported by the host
Date: Tue, 11 Jan 2022 14:18:42 +0000 [thread overview]
Message-ID: <871r1etkxp.wl-maz@kernel.org> (raw)
In-Reply-To: <CAFEAcA8L5pH41cQ6srk9-JbMKNjdhCD7YpWcw4P06t83Jp11vw@mail.gmail.com>
On Tue, 11 Jan 2022 13:58:49 +0000,
Peter Maydell <peter.maydell@linaro.org> wrote:
>
> On Sat, 8 Jan 2022 at 13:42, Marc Zyngier <maz@kernel.org> wrote:
> >
> > On 2022-01-07 20:23, Richard Henderson wrote:
> > > On 1/7/22 7:01 AM, Marc Zyngier wrote:
> > >> @@ -1380,17 +1380,10 @@ void arm_cpu_finalize_features(ARMCPU *cpu,
> > >> Error **errp)
> > >> return;
> > >> }
> > >> - /*
> > >> - * KVM does not support modifications to this feature.
> > >> - * We have not registered the cpu properties when KVM
> > >> - * is in use, so the user will not be able to set them.
> > >> - */
> > >> - if (!kvm_enabled()) {
> > >> - arm_cpu_pauth_finalize(cpu, &local_err);
> > >> - if (local_err != NULL) {
> > >> + arm_cpu_pauth_finalize(cpu, &local_err);
> > >> + if (local_err != NULL) {
> > >> error_propagate(errp, local_err);
> > >> return;
> > >> - }
> > >> }
> > >
> > > Indentation is still off -- error + return should be out-dented one
> > > level.
> > >
> >
> > Duh. Clearly, my brain can't spot these. Apologies for the extra noise.
> >
> > > Otherwise,
> > > Reviewed-by: Richard Henderson <richard.henderson@linaro.org>
> >
> > Thanks. I'll repost a version shortly, unless someone shouts.
>
> Don't worry about it -- I've applied this to target-arm.next and
> fixed the indent there.
Awesome, thanks Peter.
M.
--
Without deviation from the norm, progress is not possible.
WARNING: multiple messages have this Message-ID (diff)
From: Marc Zyngier <maz@kernel.org>
To: Peter Maydell <peter.maydell@linaro.org>
Cc: Andrew Jones <drjones@redhat.com>,
kvm@vger.kernel.org,
Richard Henderson <richard.henderson@linaro.org>,
qemu-devel@nongnu.org, Eric Auger <eric.auger@redhat.com>,
kernel-team@android.com, kvmarm@lists.cs.columbia.edu
Subject: Re: [PATCH v3] hw/arm/virt: KVM: Enable PAuth when supported by the host
Date: Tue, 11 Jan 2022 14:18:42 +0000 [thread overview]
Message-ID: <871r1etkxp.wl-maz@kernel.org> (raw)
In-Reply-To: <CAFEAcA8L5pH41cQ6srk9-JbMKNjdhCD7YpWcw4P06t83Jp11vw@mail.gmail.com>
On Tue, 11 Jan 2022 13:58:49 +0000,
Peter Maydell <peter.maydell@linaro.org> wrote:
>
> On Sat, 8 Jan 2022 at 13:42, Marc Zyngier <maz@kernel.org> wrote:
> >
> > On 2022-01-07 20:23, Richard Henderson wrote:
> > > On 1/7/22 7:01 AM, Marc Zyngier wrote:
> > >> @@ -1380,17 +1380,10 @@ void arm_cpu_finalize_features(ARMCPU *cpu,
> > >> Error **errp)
> > >> return;
> > >> }
> > >> - /*
> > >> - * KVM does not support modifications to this feature.
> > >> - * We have not registered the cpu properties when KVM
> > >> - * is in use, so the user will not be able to set them.
> > >> - */
> > >> - if (!kvm_enabled()) {
> > >> - arm_cpu_pauth_finalize(cpu, &local_err);
> > >> - if (local_err != NULL) {
> > >> + arm_cpu_pauth_finalize(cpu, &local_err);
> > >> + if (local_err != NULL) {
> > >> error_propagate(errp, local_err);
> > >> return;
> > >> - }
> > >> }
> > >
> > > Indentation is still off -- error + return should be out-dented one
> > > level.
> > >
> >
> > Duh. Clearly, my brain can't spot these. Apologies for the extra noise.
> >
> > > Otherwise,
> > > Reviewed-by: Richard Henderson <richard.henderson@linaro.org>
> >
> > Thanks. I'll repost a version shortly, unless someone shouts.
>
> Don't worry about it -- I've applied this to target-arm.next and
> fixed the indent there.
Awesome, thanks Peter.
M.
--
Without deviation from the norm, progress is not possible.
next prev parent reply other threads:[~2022-01-11 14:18 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-01-07 15:01 [PATCH v3] hw/arm/virt: KVM: Enable PAuth when supported by the host Marc Zyngier
2022-01-07 15:01 ` Marc Zyngier
2022-01-07 15:01 ` Marc Zyngier
2022-01-07 20:23 ` Richard Henderson
2022-01-07 20:23 ` Richard Henderson
2022-01-07 20:23 ` Richard Henderson
2022-01-08 13:42 ` Marc Zyngier
2022-01-08 13:42 ` Marc Zyngier
2022-01-08 13:42 ` Marc Zyngier
2022-01-11 13:58 ` Peter Maydell
2022-01-11 13:58 ` Peter Maydell
2022-01-11 13:58 ` Peter Maydell
2022-01-11 14:18 ` Marc Zyngier [this message]
2022-01-11 14:18 ` Marc Zyngier
2022-01-11 14:18 ` Marc Zyngier
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=871r1etkxp.wl-maz@kernel.org \
--to=maz@kernel.org \
--cc=kernel-team@android.com \
--cc=kvm@vger.kernel.org \
--cc=kvmarm@lists.cs.columbia.edu \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
--cc=richard.henderson@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.