From: Michael Ellerman <mpe@ellerman.id.au>
To: Christophe Leroy <christophe.leroy@csgroup.eu>,
Benjamin Herrenschmidt <benh@kernel.crashing.org>,
Paul Mackerras <paulus@samba.org>
Cc: linuxppc-dev@lists.ozlabs.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] powerpc/32s: Allocate one 256k IBAT instead of two consecutives 128k IBATs
Date: Fri, 03 Dec 2021 14:55:09 +1100 [thread overview]
Message-ID: <871r2upcki.fsf@mpe.ellerman.id.au> (raw)
In-Reply-To: <ab58b296832b0ec650e2203200e060adbcb2677d.1637930421.git.christophe.leroy@csgroup.eu>
Christophe Leroy <christophe.leroy@csgroup.eu> writes:
> Today we have the following IBATs allocated:
>
> ---[ Instruction Block Address Translation ]---
> 0: 0xc0000000-0xc03fffff 0x00000000 4M Kernel x m
> 1: 0xc0400000-0xc05fffff 0x00400000 2M Kernel x m
> 2: 0xc0600000-0xc06fffff 0x00600000 1M Kernel x m
> 3: 0xc0700000-0xc077ffff 0x00700000 512K Kernel x m
> 4: 0xc0780000-0xc079ffff 0x00780000 128K Kernel x m
> 5: 0xc07a0000-0xc07bffff 0x007a0000 128K Kernel x m
> 6: -
> 7: -
>
> The two 128K should be a single 256K instead.
>
> When _etext is not aligned to 128Kbytes, the system will allocate
> all necessary BATs to the lower 128Kbytes boundary, then allocate
> an additional 128Kbytes BAT for the remaining block.
>
> Instead, align the top to 128Kbytes so that the function directly
> allocates a 256Mbytes last block:
^
I think that's meant to be 256Kbytes, I changed it when committing.
> ---[ Instruction Block Address Translation ]---
> 0: 0xc0000000-0xc03fffff 0x00000000 4M Kernel x m
> 1: 0xc0400000-0xc05fffff 0x00400000 2M Kernel x m
> 2: 0xc0600000-0xc06fffff 0x00600000 1M Kernel x m
> 3: 0xc0700000-0xc077ffff 0x00700000 512K Kernel x m
> 4: 0xc0780000-0xc07bffff 0x00780000 256K Kernel x m
> 5: -
> 6: -
> 7: -
>
> Signed-off-by: Christophe Leroy <christophe.leroy@csgroup.eu>
cheers
WARNING: multiple messages have this Message-ID (diff)
From: Michael Ellerman <mpe@ellerman.id.au>
To: Christophe Leroy <christophe.leroy@csgroup.eu>,
Benjamin Herrenschmidt <benh@kernel.crashing.org>,
Paul Mackerras <paulus@samba.org>
Cc: Christophe Leroy <christophe.leroy@csgroup.eu>,
linux-kernel@vger.kernel.org, linuxppc-dev@lists.ozlabs.org
Subject: Re: [PATCH] powerpc/32s: Allocate one 256k IBAT instead of two consecutives 128k IBATs
Date: Fri, 03 Dec 2021 14:55:09 +1100 [thread overview]
Message-ID: <871r2upcki.fsf@mpe.ellerman.id.au> (raw)
In-Reply-To: <ab58b296832b0ec650e2203200e060adbcb2677d.1637930421.git.christophe.leroy@csgroup.eu>
Christophe Leroy <christophe.leroy@csgroup.eu> writes:
> Today we have the following IBATs allocated:
>
> ---[ Instruction Block Address Translation ]---
> 0: 0xc0000000-0xc03fffff 0x00000000 4M Kernel x m
> 1: 0xc0400000-0xc05fffff 0x00400000 2M Kernel x m
> 2: 0xc0600000-0xc06fffff 0x00600000 1M Kernel x m
> 3: 0xc0700000-0xc077ffff 0x00700000 512K Kernel x m
> 4: 0xc0780000-0xc079ffff 0x00780000 128K Kernel x m
> 5: 0xc07a0000-0xc07bffff 0x007a0000 128K Kernel x m
> 6: -
> 7: -
>
> The two 128K should be a single 256K instead.
>
> When _etext is not aligned to 128Kbytes, the system will allocate
> all necessary BATs to the lower 128Kbytes boundary, then allocate
> an additional 128Kbytes BAT for the remaining block.
>
> Instead, align the top to 128Kbytes so that the function directly
> allocates a 256Mbytes last block:
^
I think that's meant to be 256Kbytes, I changed it when committing.
> ---[ Instruction Block Address Translation ]---
> 0: 0xc0000000-0xc03fffff 0x00000000 4M Kernel x m
> 1: 0xc0400000-0xc05fffff 0x00400000 2M Kernel x m
> 2: 0xc0600000-0xc06fffff 0x00600000 1M Kernel x m
> 3: 0xc0700000-0xc077ffff 0x00700000 512K Kernel x m
> 4: 0xc0780000-0xc07bffff 0x00780000 256K Kernel x m
> 5: -
> 6: -
> 7: -
>
> Signed-off-by: Christophe Leroy <christophe.leroy@csgroup.eu>
cheers
next prev parent reply other threads:[~2021-12-03 3:55 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-11-26 12:40 [PATCH] powerpc/32s: Allocate one 256k IBAT instead of two consecutives 128k IBATs Christophe Leroy
2021-11-26 12:40 ` Christophe Leroy
2021-12-03 3:55 ` Michael Ellerman [this message]
2021-12-03 3:55 ` Michael Ellerman
2021-12-15 0:24 ` Michael Ellerman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=871r2upcki.fsf@mpe.ellerman.id.au \
--to=mpe@ellerman.id.au \
--cc=benh@kernel.crashing.org \
--cc=christophe.leroy@csgroup.eu \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=paulus@samba.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.