Re: [PATCH v2] ath11k: add read variant from SMBIOS for download board data

From: Kalle Valo <kvalo@codeaurora.org>
To: Mark Herbert <mark.herbert42@gmail.com>
Cc: Wen Gong <quic_wgong@quicinc.com>,
	ath11k@lists.infradead.org, linux-wireless@vger.kernel.org
Subject: Re: [PATCH v2] ath11k: add read variant from SMBIOS for download board data
Date: Mon, 22 Nov 2021 20:06:22 +0200	[thread overview]
Message-ID: <871r3883q9.fsf@codeaurora.org> (raw)
In-Reply-To: <f237c04d-6574-ec9a-ebca-65d2d9ff9edd@gmail.com> (Mark Herbert's message of "Mon, 22 Nov 2021 20:58:56 +0300")

Mark Herbert <mark.herbert42@gmail.com> writes:

> Tried this on Dell XPS 13 9310
>
> Maybe this patch is good for 6855, but 6390 in Dell seems to be killed
> completely with it. Reverting it makes things work again.
>
> [    5.537034] ath11k_pci 0000:72:00.0: chip_id 0x0 chip_family 0xb
> board_id 0xff soc_id 0xffffffff
> [    5.537038] ath11k_pci 0000:72:00.0: fw_version 0x101c06cc
> fw_build_timestamp 2020-06-24 19:50 fw_build_id
> [    5.537236] ath11k_pci 0000:72:00.0: failed to fetch board data for
> bus=pci,qmi-chip-id=0,qmi-board-id=255,variant=DE_1901 from
> ath11k/QCA6390/hw2.0/board-2.bin
> [    5.537255] ath11k_pci 0000:72:00.0: failed to fetch board-2.bin or
> board.bin from QCA6390/hw2.0
> [    5.537257] ath11k_pci 0000:72:00.0: qmi failed to fetch board file: -2
> [    5.537258] ath11k_pci 0000:72:00.0: failed to load board data file: -2

Doh, I didn't realise that. I only tested this on my NUC testbox, I
should have tested this on my XPS 13 9310 as well. Thanks for the
report!

I think I need to revert this and rethink how to handle the backwards
compatibility.

-- 
https://patchwork.kernel.org/project/linux-wireless/list/

https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches

-- 
ath11k mailing list
ath11k@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/ath11k