All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jani Nikula <jani.nikula@linux.intel.com>
To: He Ying <heying24@huawei.com>,
	mripard@kernel.org, wens@csie.org, airlied@linux.ie,
	daniel@ffwll.ch, jernej.skrabec@gmail.com
Cc: linux-kernel@vger.kernel.org,
	linux-arm-kernel@lists.infradead.org,
	dri-devel@lists.freedesktop.org, linux-sunxi@lists.linux.dev
Subject: Re: [PATCH] drm: Grab reference of connector before return connector from sun4i_tcon_get_connector
Date: Tue, 02 Nov 2021 10:37:14 +0200	[thread overview]
Message-ID: <871r3zdkcl.fsf@intel.com> (raw)
In-Reply-To: <33e01d45-c9f9-0e8c-6871-868ecd198368@huawei.com>

On Tue, 02 Nov 2021, He Ying <heying24@huawei.com> wrote:
> 在 2021/11/1 21:02, Jani Nikula 写道:
>> On Mon, 01 Nov 2021, He Ying <heying24@huawei.com> wrote:
>>>  From the comments of drm_for_each_connector_iter(), we know
>>> that "connector is only valid within the list body, if you
>>> want to use connector after calling drm_connector_list_iter_end()
>>> then you need to grab your own reference first using
>>> drm_connector_get()". So fix the wrong use of connector
>>> according to the comments and then call drm_connector_put()
>>> after using connector finishes.
>>>
>>> Signed-off-by: He Ying <heying24@huawei.com>
>> Please use "drm/sun4i:" subject prefix for sun4i patches.
>
> OK. I'll send a V2 later. By the way, may I have your suggestions about
> this patch's content.

Sorry, I only looked here because of the subject prefix, and would have
skipped it completely with a drm/sun4i prefix. ;)

BR,
Jani.


-- 
Jani Nikula, Intel Open Source Graphics Center

WARNING: multiple messages have this Message-ID (diff)
From: Jani Nikula <jani.nikula@linux.intel.com>
To: He Ying <heying24@huawei.com>,
	mripard@kernel.org, wens@csie.org, airlied@linux.ie,
	daniel@ffwll.ch, jernej.skrabec@gmail.com
Cc: linux-kernel@vger.kernel.org,
	linux-arm-kernel@lists.infradead.org,
	dri-devel@lists.freedesktop.org, linux-sunxi@lists.linux.dev
Subject: Re: [PATCH] drm: Grab reference of connector before return connector from sun4i_tcon_get_connector
Date: Tue, 02 Nov 2021 10:37:14 +0200	[thread overview]
Message-ID: <871r3zdkcl.fsf@intel.com> (raw)
In-Reply-To: <33e01d45-c9f9-0e8c-6871-868ecd198368@huawei.com>

On Tue, 02 Nov 2021, He Ying <heying24@huawei.com> wrote:
> 在 2021/11/1 21:02, Jani Nikula 写道:
>> On Mon, 01 Nov 2021, He Ying <heying24@huawei.com> wrote:
>>>  From the comments of drm_for_each_connector_iter(), we know
>>> that "connector is only valid within the list body, if you
>>> want to use connector after calling drm_connector_list_iter_end()
>>> then you need to grab your own reference first using
>>> drm_connector_get()". So fix the wrong use of connector
>>> according to the comments and then call drm_connector_put()
>>> after using connector finishes.
>>>
>>> Signed-off-by: He Ying <heying24@huawei.com>
>> Please use "drm/sun4i:" subject prefix for sun4i patches.
>
> OK. I'll send a V2 later. By the way, may I have your suggestions about
> this patch's content.

Sorry, I only looked here because of the subject prefix, and would have
skipped it completely with a drm/sun4i prefix. ;)

BR,
Jani.


-- 
Jani Nikula, Intel Open Source Graphics Center

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

WARNING: multiple messages have this Message-ID (diff)
From: Jani Nikula <jani.nikula@linux.intel.com>
To: He Ying <heying24@huawei.com>,
	mripard@kernel.org, wens@csie.org, airlied@linux.ie,
	daniel@ffwll.ch, jernej.skrabec@gmail.com
Cc: dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org,
	linux-arm-kernel@lists.infradead.org,
	linux-sunxi@lists.linux.dev
Subject: Re: [PATCH] drm: Grab reference of connector before return connector from sun4i_tcon_get_connector
Date: Tue, 02 Nov 2021 10:37:14 +0200	[thread overview]
Message-ID: <871r3zdkcl.fsf@intel.com> (raw)
In-Reply-To: <33e01d45-c9f9-0e8c-6871-868ecd198368@huawei.com>

On Tue, 02 Nov 2021, He Ying <heying24@huawei.com> wrote:
> 在 2021/11/1 21:02, Jani Nikula 写道:
>> On Mon, 01 Nov 2021, He Ying <heying24@huawei.com> wrote:
>>>  From the comments of drm_for_each_connector_iter(), we know
>>> that "connector is only valid within the list body, if you
>>> want to use connector after calling drm_connector_list_iter_end()
>>> then you need to grab your own reference first using
>>> drm_connector_get()". So fix the wrong use of connector
>>> according to the comments and then call drm_connector_put()
>>> after using connector finishes.
>>>
>>> Signed-off-by: He Ying <heying24@huawei.com>
>> Please use "drm/sun4i:" subject prefix for sun4i patches.
>
> OK. I'll send a V2 later. By the way, may I have your suggestions about
> this patch's content.

Sorry, I only looked here because of the subject prefix, and would have
skipped it completely with a drm/sun4i prefix. ;)

BR,
Jani.


-- 
Jani Nikula, Intel Open Source Graphics Center

  reply	other threads:[~2021-11-02  8:37 UTC|newest]

Thread overview: 21+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-11-01  6:29 [PATCH] drm: Grab reference of connector before return connector from sun4i_tcon_get_connector He Ying
2021-11-01  6:29 ` He Ying
2021-11-01  6:29 ` He Ying
2021-11-01 13:02 ` Jani Nikula
2021-11-01 13:02   ` Jani Nikula
2021-11-01 13:02   ` Jani Nikula
2021-11-02  2:48   ` He Ying
2021-11-02  2:48     ` He Ying
2021-11-02  2:48     ` He Ying
2021-11-02  8:37     ` Jani Nikula [this message]
2021-11-02  8:37       ` Jani Nikula
2021-11-02  8:37       ` Jani Nikula
2021-11-02  8:46     ` [PATCH -V2] drm/sun4i: " He Ying
2021-11-02  8:46       ` He Ying
2021-11-02  8:46       ` He Ying
2021-11-02 15:03       ` Maxime Ripard
2021-11-02 15:03         ` Maxime Ripard
2021-11-02 15:03         ` Maxime Ripard
2021-11-03  2:26         ` He Ying
2021-11-03  2:26           ` He Ying
2021-11-03  2:26           ` He Ying

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=871r3zdkcl.fsf@intel.com \
    --to=jani.nikula@linux.intel.com \
    --cc=airlied@linux.ie \
    --cc=daniel@ffwll.ch \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=heying24@huawei.com \
    --cc=jernej.skrabec@gmail.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-sunxi@lists.linux.dev \
    --cc=mripard@kernel.org \
    --cc=wens@csie.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.