From: Marc Zyngier <maz@kernel.org>
To: Arnd Bergmann <arnd@kernel.org>
Cc: linux-arm-kernel@lists.infradead.org,
Arnd Bergmann <arnd@arndb.de>,
Catalin Marinas <catalin.marinas@arm.com>,
linux-kernel@vger.kernel.org,
Sean Christopherson <seanjc@google.com>,
Paolo Bonzini <pbonzini@redhat.com>,
Will Deacon <will@kernel.org>,
kvmarm@lists.cs.columbia.edu
Subject: Re: [PATCH] KVM: arm64: remove incorrect __init annotation
Date: Sun, 03 Jan 2021 16:43:55 +0000 [thread overview]
Message-ID: <871rf2km2c.wl-maz@kernel.org> (raw)
In-Reply-To: <20210103140104.3853922-1-arnd@kernel.org>
On Sun, 03 Jan 2021 14:00:50 +0000,
Arnd Bergmann <arnd@kernel.org> wrote:
>
> From: Arnd Bergmann <arnd@arndb.de>
>
> When hyp_cpu_pm_exit() is not inlined, it causes a link time warning:
>
> WARNING: modpost: vmlinux.o(.text+0x39974): Section mismatch in reference from the function kvm_arch_init() to the function .init.text:hyp_cpu_pm_exit()
> The function kvm_arch_init() references
> the function __init hyp_cpu_pm_exit().
> This is often because kvm_arch_init lacks a __init
> annotation or the annotation of hyp_cpu_pm_exit is wrong.
>
> This is not only called at boot time, so remove the annotation
> to prevent undefined behavior in case it gets called after being
> freed.
It *is* only called at boot time (despite these functions being called
from module_init(), KVM cannot be built as a module on arm64).
The annotations are wrong nonetheless.
>
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
Posted here [1], and queued for the next batch of fixes.
M.
[1] https://lore.kernel.org/linux-arm-kernel/20201223120854.255347-1-maz@kernel.org
--
Without deviation from the norm, progress is not possible.
_______________________________________________
kvmarm mailing list
kvmarm@lists.cs.columbia.edu
https://lists.cs.columbia.edu/mailman/listinfo/kvmarm
WARNING: multiple messages have this Message-ID (diff)
From: Marc Zyngier <maz@kernel.org>
To: Arnd Bergmann <arnd@kernel.org>
Cc: linux-arm-kernel@lists.infradead.org,
Arnd Bergmann <arnd@arndb.de>,
Suzuki K Poulose <suzuki.poulose@arm.com>,
Catalin Marinas <catalin.marinas@arm.com>,
linux-kernel@vger.kernel.org, James Morse <james.morse@arm.com>,
Andrew Scull <ascull@google.com>,
Sean Christopherson <seanjc@google.com>,
Paolo Bonzini <pbonzini@redhat.com>,
David Brazdil <dbrazdil@google.com>,
Will Deacon <will@kernel.org>,
kvmarm@lists.cs.columbia.edu,
Julien Thierry <julien.thierry.kdev@gmail.com>
Subject: Re: [PATCH] KVM: arm64: remove incorrect __init annotation
Date: Sun, 03 Jan 2021 16:43:55 +0000 [thread overview]
Message-ID: <871rf2km2c.wl-maz@kernel.org> (raw)
In-Reply-To: <20210103140104.3853922-1-arnd@kernel.org>
On Sun, 03 Jan 2021 14:00:50 +0000,
Arnd Bergmann <arnd@kernel.org> wrote:
>
> From: Arnd Bergmann <arnd@arndb.de>
>
> When hyp_cpu_pm_exit() is not inlined, it causes a link time warning:
>
> WARNING: modpost: vmlinux.o(.text+0x39974): Section mismatch in reference from the function kvm_arch_init() to the function .init.text:hyp_cpu_pm_exit()
> The function kvm_arch_init() references
> the function __init hyp_cpu_pm_exit().
> This is often because kvm_arch_init lacks a __init
> annotation or the annotation of hyp_cpu_pm_exit is wrong.
>
> This is not only called at boot time, so remove the annotation
> to prevent undefined behavior in case it gets called after being
> freed.
It *is* only called at boot time (despite these functions being called
from module_init(), KVM cannot be built as a module on arm64).
The annotations are wrong nonetheless.
>
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
Posted here [1], and queued for the next batch of fixes.
M.
[1] https://lore.kernel.org/linux-arm-kernel/20201223120854.255347-1-maz@kernel.org
--
Without deviation from the norm, progress is not possible.
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
WARNING: multiple messages have this Message-ID (diff)
From: Marc Zyngier <maz@kernel.org>
To: Arnd Bergmann <arnd@kernel.org>
Cc: Catalin Marinas <catalin.marinas@arm.com>,
Will Deacon <will@kernel.org>, Arnd Bergmann <arnd@arndb.de>,
James Morse <james.morse@arm.com>,
Julien Thierry <julien.thierry.kdev@gmail.com>,
Suzuki K Poulose <suzuki.poulose@arm.com>,
David Brazdil <dbrazdil@google.com>,
Paolo Bonzini <pbonzini@redhat.com>,
Sean Christopherson <seanjc@google.com>,
Andrew Scull <ascull@google.com>,
linux-arm-kernel@lists.infradead.org,
kvmarm@lists.cs.columbia.edu, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] KVM: arm64: remove incorrect __init annotation
Date: Sun, 03 Jan 2021 16:43:55 +0000 [thread overview]
Message-ID: <871rf2km2c.wl-maz@kernel.org> (raw)
In-Reply-To: <20210103140104.3853922-1-arnd@kernel.org>
On Sun, 03 Jan 2021 14:00:50 +0000,
Arnd Bergmann <arnd@kernel.org> wrote:
>
> From: Arnd Bergmann <arnd@arndb.de>
>
> When hyp_cpu_pm_exit() is not inlined, it causes a link time warning:
>
> WARNING: modpost: vmlinux.o(.text+0x39974): Section mismatch in reference from the function kvm_arch_init() to the function .init.text:hyp_cpu_pm_exit()
> The function kvm_arch_init() references
> the function __init hyp_cpu_pm_exit().
> This is often because kvm_arch_init lacks a __init
> annotation or the annotation of hyp_cpu_pm_exit is wrong.
>
> This is not only called at boot time, so remove the annotation
> to prevent undefined behavior in case it gets called after being
> freed.
It *is* only called at boot time (despite these functions being called
from module_init(), KVM cannot be built as a module on arm64).
The annotations are wrong nonetheless.
>
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
Posted here [1], and queued for the next batch of fixes.
M.
[1] https://lore.kernel.org/linux-arm-kernel/20201223120854.255347-1-maz@kernel.org
--
Without deviation from the norm, progress is not possible.
next prev parent reply other threads:[~2021-01-03 16:44 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-01-03 14:00 [PATCH] KVM: arm64: remove incorrect __init annotation Arnd Bergmann
2021-01-03 14:00 ` Arnd Bergmann
2021-01-03 14:00 ` Arnd Bergmann
2021-01-03 16:43 ` Marc Zyngier [this message]
2021-01-03 16:43 ` Marc Zyngier
2021-01-03 16:43 ` Marc Zyngier
2021-01-03 18:38 ` Arnd Bergmann
2021-01-03 18:38 ` Arnd Bergmann
2021-01-03 18:38 ` Arnd Bergmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=871rf2km2c.wl-maz@kernel.org \
--to=maz@kernel.org \
--cc=arnd@arndb.de \
--cc=arnd@kernel.org \
--cc=catalin.marinas@arm.com \
--cc=kvmarm@lists.cs.columbia.edu \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=pbonzini@redhat.com \
--cc=seanjc@google.com \
--cc=will@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.