From: "Aurélien Aptel" <aaptel@suse.com>
To: Dan Carpenter <dan.carpenter@oracle.com>,
Steve French <sfrench@samba.org>,
Shyam Prasad N <sprasad@microsoft.com>
Cc: linux-cifs@vger.kernel.org, kernel-janitors@vger.kernel.org,
samba-technical@lists.samba.org
Subject: Re: [PATCH] cifs: Fix uninitialized variable in set_chmod_dacl()
Date: Mon, 14 Dec 2020 12:16:26 +0000 [thread overview]
Message-ID: <871rfsd1lx.fsf@suse.com> (raw)
In-Reply-To: <X9dS1EllbQhuX7/C@mwanda>
Hi Dan,
Dan Carpenter via samba-technical <samba-technical@lists.samba.org>
writes:
> Initialize the "nmode" variable earlier to prevent an uninitialized
> variable bug when we do "size += setup_special_mode_ACE(pntace, nmode);"
>
> Fixes: 253374f7557e ("cifs: Fix unix perm bits to cifsacl conversion for "other" bits.")
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
The current version of Steve's for-next already sets nmode earlier in
commit 0f22053e811ca ("cifs: Fix unix perm bits to cifsacl conversion
for "other" bits."). I believe this patch can be ignored.
Cheers,
--
Aurélien Aptel / SUSE Labs Samba Team
GPG: 1839 CB5F 9F5B FB9B AA97 8C99 03C8 A49B 521B D5D3
SUSE Software Solutions Germany GmbH, Maxfeldstr. 5, 90409 Nürnberg, DE
GF: Felix Imendörffer, Mary Higgins, Sri Rasiah HRB 247165 (AG München)
WARNING: multiple messages have this Message-ID (diff)
From: "Aurélien Aptel" <aaptel@suse.com>
To: Dan Carpenter <dan.carpenter@oracle.com>,
Steve French <sfrench@samba.org>,
Shyam Prasad N <sprasad@microsoft.com>
Cc: linux-cifs@vger.kernel.org, kernel-janitors@vger.kernel.org,
samba-technical@lists.samba.org
Subject: Re: [PATCH] cifs: Fix uninitialized variable in set_chmod_dacl()
Date: Mon, 14 Dec 2020 13:16:26 +0100 [thread overview]
Message-ID: <871rfsd1lx.fsf@suse.com> (raw)
In-Reply-To: <X9dS1EllbQhuX7/C@mwanda>
Hi Dan,
Dan Carpenter via samba-technical <samba-technical@lists.samba.org>
writes:
> Initialize the "nmode" variable earlier to prevent an uninitialized
> variable bug when we do "size += setup_special_mode_ACE(pntace, nmode);"
>
> Fixes: 253374f7557e ("cifs: Fix unix perm bits to cifsacl conversion for "other" bits.")
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
The current version of Steve's for-next already sets nmode earlier in
commit 0f22053e811ca ("cifs: Fix unix perm bits to cifsacl conversion
for "other" bits."). I believe this patch can be ignored.
Cheers,
--
Aurélien Aptel / SUSE Labs Samba Team
GPG: 1839 CB5F 9F5B FB9B AA97 8C99 03C8 A49B 521B D5D3
SUSE Software Solutions Germany GmbH, Maxfeldstr. 5, 90409 Nürnberg, DE
GF: Felix Imendörffer, Mary Higgins, Sri Rasiah HRB 247165 (AG München)
next prev parent reply other threads:[~2020-12-14 12:16 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-12-14 11:56 [PATCH] cifs: Fix uninitialized variable in set_chmod_dacl() Dan Carpenter
2020-12-14 11:56 ` Dan Carpenter
2020-12-14 12:06 ` [EXTERNAL] " Shyam Prasad
2020-12-14 12:16 ` Aurélien Aptel [this message]
2020-12-14 12:16 ` Aurélien Aptel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=871rfsd1lx.fsf@suse.com \
--to=aaptel@suse.com \
--cc=dan.carpenter@oracle.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-cifs@vger.kernel.org \
--cc=samba-technical@lists.samba.org \
--cc=sfrench@samba.org \
--cc=sprasad@microsoft.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.