All of lore.kernel.org
 help / color / mirror / Atom feed
From: Andreas Schwab <schwab@linux-m68k.org>
To: Souptick Joarder <jrdr.linux@gmail.com>
Cc: guoren@linux.alibaba.com, linux-kernel@vger.kernel.org,
	aou@eecs.berkeley.edu, palmer@dabbelt.com,
	paul.walmsley@sifive.com, linux-riscv@lists.infradead.org
Subject: Re: [PATCH] riscv: Fixed kernel test robot warning
Date: Tue, 08 Dec 2020 21:22:46 +0100	[thread overview]
Message-ID: <871rg0cajt.fsf@igel.home> (raw)
In-Reply-To: <CAFqt6zbp56nOfnLvuieMMtpEi7TXuB67bGS_Y=offyiROc=etg@mail.gmail.com> (Souptick Joarder's message of "Wed, 9 Dec 2020 01:28:44 +0530")

On Dez 09 2020, Souptick Joarder wrote:

> On Wed, Dec 9, 2020 at 1:21 AM Andreas Schwab <schwab@linux-m68k.org> wrote:
>>
>> On Dez 09 2020, Souptick Joarder wrote:
>>
>> > Kernel test robot throws below warning -
>> >
>> >    arch/riscv/kernel/asm-offsets.c:14:6: warning: no previous prototype
>> > for 'asm_offsets' [-Wmissing-prototypes]
>> >       14 | void asm_offsets(void)
>> >          |      ^~~~~~~~~~~
>> >
>> > This patch should fixed it.
>>
>> Or rename it to main, like most other asm-offsets files.
>
> Few asm-offsets files named it as foo(). Does a rename to main() will
> work straight forward ?

Calling it main will suppress the warning, but other than that it is
completely irrelevant how you call it.

Andreas.

-- 
Andreas Schwab, schwab@linux-m68k.org
GPG Key fingerprint = 7578 EB47 D4E5 4D69 2510  2552 DF73 E780 A9DA AEC1
"And now for something completely different."

_______________________________________________
linux-riscv mailing list
linux-riscv@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-riscv

WARNING: multiple messages have this Message-ID (diff)
From: Andreas Schwab <schwab@linux-m68k.org>
To: Souptick Joarder <jrdr.linux@gmail.com>
Cc: paul.walmsley@sifive.com, palmer@dabbelt.com,
	aou@eecs.berkeley.edu, guoren@linux.alibaba.com,
	linux-riscv@lists.infradead.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] riscv: Fixed kernel test robot warning
Date: Tue, 08 Dec 2020 21:22:46 +0100	[thread overview]
Message-ID: <871rg0cajt.fsf@igel.home> (raw)
In-Reply-To: <CAFqt6zbp56nOfnLvuieMMtpEi7TXuB67bGS_Y=offyiROc=etg@mail.gmail.com> (Souptick Joarder's message of "Wed, 9 Dec 2020 01:28:44 +0530")

On Dez 09 2020, Souptick Joarder wrote:

> On Wed, Dec 9, 2020 at 1:21 AM Andreas Schwab <schwab@linux-m68k.org> wrote:
>>
>> On Dez 09 2020, Souptick Joarder wrote:
>>
>> > Kernel test robot throws below warning -
>> >
>> >    arch/riscv/kernel/asm-offsets.c:14:6: warning: no previous prototype
>> > for 'asm_offsets' [-Wmissing-prototypes]
>> >       14 | void asm_offsets(void)
>> >          |      ^~~~~~~~~~~
>> >
>> > This patch should fixed it.
>>
>> Or rename it to main, like most other asm-offsets files.
>
> Few asm-offsets files named it as foo(). Does a rename to main() will
> work straight forward ?

Calling it main will suppress the warning, but other than that it is
completely irrelevant how you call it.

Andreas.

-- 
Andreas Schwab, schwab@linux-m68k.org
GPG Key fingerprint = 7578 EB47 D4E5 4D69 2510  2552 DF73 E780 A9DA AEC1
"And now for something completely different."

  reply	other threads:[~2020-12-08 20:23 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-12-08 19:27 [PATCH] riscv: Fixed kernel test robot warning Souptick Joarder
2020-12-08 19:27 ` Souptick Joarder
2020-12-08 19:51 ` Andreas Schwab
2020-12-08 19:51   ` Andreas Schwab
2020-12-08 19:58   ` Souptick Joarder
2020-12-08 19:58     ` Souptick Joarder
2020-12-08 20:22     ` Andreas Schwab [this message]
2020-12-08 20:22       ` Andreas Schwab
2020-12-11  1:47       ` Palmer Dabbelt
2020-12-11  1:47         ` Palmer Dabbelt

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=871rg0cajt.fsf@igel.home \
    --to=schwab@linux-m68k.org \
    --cc=aou@eecs.berkeley.edu \
    --cc=guoren@linux.alibaba.com \
    --cc=jrdr.linux@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-riscv@lists.infradead.org \
    --cc=palmer@dabbelt.com \
    --cc=paul.walmsley@sifive.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.