* [Intel-gfx] [PATCH] drm/i915/gt: Plug IPS into intel_rps_set
@ 2020-11-19 22:36 Chris Wilson
2020-11-19 22:58 ` Chris Wilson
` (2 more replies)
0 siblings, 3 replies; 5+ messages in thread
From: Chris Wilson @ 2020-11-19 22:36 UTC (permalink / raw)
To: intel-gfx; +Cc: Chris Wilson
The old IPS interface did not match the RPS interface that we tried to
plug it into (bool vs int return). Once repaired, our minimal
selftesting is finally happy!
Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
---
drivers/gpu/drm/i915/gt/intel_rps.c | 18 ++++++++++--------
1 file changed, 10 insertions(+), 8 deletions(-)
diff --git a/drivers/gpu/drm/i915/gt/intel_rps.c b/drivers/gpu/drm/i915/gt/intel_rps.c
index 0d88f17799ff..9785fdc088ce 100644
--- a/drivers/gpu/drm/i915/gt/intel_rps.c
+++ b/drivers/gpu/drm/i915/gt/intel_rps.c
@@ -400,7 +400,7 @@ static unsigned int gen5_invert_freq(struct intel_rps *rps,
return val;
}
-static bool gen5_rps_set(struct intel_rps *rps, u8 val)
+static int gen5_rps_set(struct intel_rps *rps, u8 val)
{
struct intel_uncore *uncore = rps_to_uncore(rps);
u16 rgvswctl;
@@ -410,7 +410,7 @@ static bool gen5_rps_set(struct intel_rps *rps, u8 val)
rgvswctl = intel_uncore_read16(uncore, MEMSWCTL);
if (rgvswctl & MEMCTL_CMD_STS) {
DRM_DEBUG("gpu busy, RCS change rejected\n");
- return false; /* still busy with another command */
+ return -EBUSY; /* still busy with another command */
}
/* Invert the frequency bin into an ips delay */
@@ -426,7 +426,7 @@ static bool gen5_rps_set(struct intel_rps *rps, u8 val)
rgvswctl |= MEMCTL_CMD_STS;
intel_uncore_write16(uncore, MEMSWCTL, rgvswctl);
- return true;
+ return 0;
}
static unsigned long intel_pxfreq(u32 vidfreq)
@@ -797,7 +797,7 @@ static int rps_set(struct intel_rps *rps, u8 val, bool update)
struct drm_i915_private *i915 = rps_to_i915(rps);
int err;
- if (INTEL_GEN(i915) < 6)
+ if (INTEL_GEN(i915) < 5)
return 0;
if (val == rps->last_freq)
@@ -805,12 +805,14 @@ static int rps_set(struct intel_rps *rps, u8 val, bool update)
if (IS_VALLEYVIEW(i915) || IS_CHERRYVIEW(i915))
err = vlv_rps_set(rps, val);
- else
+ else if (INTEL_GEN(i915) >= 6)
err = gen6_rps_set(rps, val);
+ else
+ err = gen5_rps_set(rps, val);
if (err)
return err;
- if (update)
+ if (update && INTEL_GEN(i915) >= 6)
gen6_rps_set_thresholds(rps, val);
rps->last_freq = val;
@@ -1794,7 +1796,7 @@ void gen5_rps_irq_handler(struct intel_rps *rps)
rps->min_freq_softlimit,
rps->max_freq_softlimit);
- if (new_freq != rps->cur_freq && gen5_rps_set(rps, new_freq))
+ if (new_freq != rps->cur_freq && !gen5_rps_set(rps, new_freq))
rps->cur_freq = new_freq;
spin_unlock(&mchdev_lock);
@@ -2105,7 +2107,7 @@ bool i915_gpu_turbo_disable(void)
spin_lock_irq(&mchdev_lock);
rps->max_freq_softlimit = rps->min_freq;
- ret = gen5_rps_set(&i915->gt.rps, rps->min_freq);
+ ret = !gen5_rps_set(&i915->gt.rps, rps->min_freq);
spin_unlock_irq(&mchdev_lock);
drm_dev_put(&i915->drm);
--
2.20.1
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply related [flat|nested] 5+ messages in thread* [Intel-gfx] [PATCH] drm/i915/gt: Plug IPS into intel_rps_set 2020-11-19 22:36 [Intel-gfx] [PATCH] drm/i915/gt: Plug IPS into intel_rps_set Chris Wilson @ 2020-11-19 22:58 ` Chris Wilson 2020-11-20 11:52 ` Mika Kuoppala 2020-11-20 0:21 ` [Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915/gt: Plug IPS into intel_rps_set (rev2) Patchwork 2020-11-20 6:21 ` [Intel-gfx] ✓ Fi.CI.IGT: " Patchwork 2 siblings, 1 reply; 5+ messages in thread From: Chris Wilson @ 2020-11-19 22:58 UTC (permalink / raw) To: intel-gfx; +Cc: Chris Wilson The old IPS interface did not match the RPS interface that we tried to plug it into (bool vs int return). Once repaired, our minimal selftesting is finally happy! Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk> --- drivers/gpu/drm/i915/gt/intel_rps.c | 34 +++++++++++++++++++---------- 1 file changed, 22 insertions(+), 12 deletions(-) diff --git a/drivers/gpu/drm/i915/gt/intel_rps.c b/drivers/gpu/drm/i915/gt/intel_rps.c index 0d88f17799ff..b13e7845d483 100644 --- a/drivers/gpu/drm/i915/gt/intel_rps.c +++ b/drivers/gpu/drm/i915/gt/intel_rps.c @@ -400,7 +400,7 @@ static unsigned int gen5_invert_freq(struct intel_rps *rps, return val; } -static bool gen5_rps_set(struct intel_rps *rps, u8 val) +static int __gen5_rps_set(struct intel_rps *rps, u8 val) { struct intel_uncore *uncore = rps_to_uncore(rps); u16 rgvswctl; @@ -410,7 +410,7 @@ static bool gen5_rps_set(struct intel_rps *rps, u8 val) rgvswctl = intel_uncore_read16(uncore, MEMSWCTL); if (rgvswctl & MEMCTL_CMD_STS) { DRM_DEBUG("gpu busy, RCS change rejected\n"); - return false; /* still busy with another command */ + return -EBUSY; /* still busy with another command */ } /* Invert the frequency bin into an ips delay */ @@ -426,7 +426,18 @@ static bool gen5_rps_set(struct intel_rps *rps, u8 val) rgvswctl |= MEMCTL_CMD_STS; intel_uncore_write16(uncore, MEMSWCTL, rgvswctl); - return true; + return 0; +} + +static int gen5_rps_set(struct intel_rps *rps, u8 val) +{ + int err; + + spin_lock_irq(&mchdev_lock); + err = __gen5_rps_set(rps, val); + spin_unlock_irq(&mchdev_lock); + + return err; } static unsigned long intel_pxfreq(u32 vidfreq) @@ -557,7 +568,7 @@ static bool gen5_rps_enable(struct intel_rps *rps) "stuck trying to change perf mode\n"); mdelay(1); - gen5_rps_set(rps, rps->cur_freq); + __gen5_rps_set(rps, rps->cur_freq); rps->ips.last_count1 = intel_uncore_read(uncore, DMIEC); rps->ips.last_count1 += intel_uncore_read(uncore, DDREC); @@ -599,7 +610,7 @@ static void gen5_rps_disable(struct intel_rps *rps) intel_uncore_write(uncore, MEMINTRSTS, MEMINT_EVAL_CHG); /* Go back to the starting frequency */ - gen5_rps_set(rps, rps->idle_freq); + __gen5_rps_set(rps, rps->idle_freq); mdelay(1); rgvswctl |= MEMCTL_CMD_STS; intel_uncore_write(uncore, MEMSWCTL, rgvswctl); @@ -797,20 +808,19 @@ static int rps_set(struct intel_rps *rps, u8 val, bool update) struct drm_i915_private *i915 = rps_to_i915(rps); int err; - if (INTEL_GEN(i915) < 6) - return 0; - if (val == rps->last_freq) return 0; if (IS_VALLEYVIEW(i915) || IS_CHERRYVIEW(i915)) err = vlv_rps_set(rps, val); - else + else if (INTEL_GEN(i915) >= 6) err = gen6_rps_set(rps, val); + else + err = gen5_rps_set(rps, val); if (err) return err; - if (update) + if (update && INTEL_GEN(i915) >= 6) gen6_rps_set_thresholds(rps, val); rps->last_freq = val; @@ -1794,7 +1804,7 @@ void gen5_rps_irq_handler(struct intel_rps *rps) rps->min_freq_softlimit, rps->max_freq_softlimit); - if (new_freq != rps->cur_freq && gen5_rps_set(rps, new_freq)) + if (new_freq != rps->cur_freq && !__gen5_rps_set(rps, new_freq)) rps->cur_freq = new_freq; spin_unlock(&mchdev_lock); @@ -2105,7 +2115,7 @@ bool i915_gpu_turbo_disable(void) spin_lock_irq(&mchdev_lock); rps->max_freq_softlimit = rps->min_freq; - ret = gen5_rps_set(&i915->gt.rps, rps->min_freq); + ret = !__gen5_rps_set(&i915->gt.rps, rps->min_freq); spin_unlock_irq(&mchdev_lock); drm_dev_put(&i915->drm); -- 2.20.1 _______________________________________________ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/intel-gfx ^ permalink raw reply related [flat|nested] 5+ messages in thread
* Re: [Intel-gfx] [PATCH] drm/i915/gt: Plug IPS into intel_rps_set 2020-11-19 22:58 ` Chris Wilson @ 2020-11-20 11:52 ` Mika Kuoppala 0 siblings, 0 replies; 5+ messages in thread From: Mika Kuoppala @ 2020-11-20 11:52 UTC (permalink / raw) To: Chris Wilson, intel-gfx; +Cc: Chris Wilson Chris Wilson <chris@chris-wilson.co.uk> writes: > The old IPS interface did not match the RPS interface that we tried to > plug it into (bool vs int return). Once repaired, our minimal > selftesting is finally happy! > > Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk> Reviewed-by: Mika Kuoppala <mika.kuoppala@linux.intel.com> > --- > drivers/gpu/drm/i915/gt/intel_rps.c | 34 +++++++++++++++++++---------- > 1 file changed, 22 insertions(+), 12 deletions(-) > > diff --git a/drivers/gpu/drm/i915/gt/intel_rps.c b/drivers/gpu/drm/i915/gt/intel_rps.c > index 0d88f17799ff..b13e7845d483 100644 > --- a/drivers/gpu/drm/i915/gt/intel_rps.c > +++ b/drivers/gpu/drm/i915/gt/intel_rps.c > @@ -400,7 +400,7 @@ static unsigned int gen5_invert_freq(struct intel_rps *rps, > return val; > } > > -static bool gen5_rps_set(struct intel_rps *rps, u8 val) > +static int __gen5_rps_set(struct intel_rps *rps, u8 val) > { > struct intel_uncore *uncore = rps_to_uncore(rps); > u16 rgvswctl; > @@ -410,7 +410,7 @@ static bool gen5_rps_set(struct intel_rps *rps, u8 val) > rgvswctl = intel_uncore_read16(uncore, MEMSWCTL); > if (rgvswctl & MEMCTL_CMD_STS) { > DRM_DEBUG("gpu busy, RCS change rejected\n"); > - return false; /* still busy with another command */ > + return -EBUSY; /* still busy with another command */ > } > > /* Invert the frequency bin into an ips delay */ > @@ -426,7 +426,18 @@ static bool gen5_rps_set(struct intel_rps *rps, u8 val) > rgvswctl |= MEMCTL_CMD_STS; > intel_uncore_write16(uncore, MEMSWCTL, rgvswctl); > > - return true; > + return 0; > +} > + > +static int gen5_rps_set(struct intel_rps *rps, u8 val) > +{ > + int err; > + > + spin_lock_irq(&mchdev_lock); > + err = __gen5_rps_set(rps, val); > + spin_unlock_irq(&mchdev_lock); > + > + return err; > } > > static unsigned long intel_pxfreq(u32 vidfreq) > @@ -557,7 +568,7 @@ static bool gen5_rps_enable(struct intel_rps *rps) > "stuck trying to change perf mode\n"); > mdelay(1); > > - gen5_rps_set(rps, rps->cur_freq); > + __gen5_rps_set(rps, rps->cur_freq); > > rps->ips.last_count1 = intel_uncore_read(uncore, DMIEC); > rps->ips.last_count1 += intel_uncore_read(uncore, DDREC); > @@ -599,7 +610,7 @@ static void gen5_rps_disable(struct intel_rps *rps) > intel_uncore_write(uncore, MEMINTRSTS, MEMINT_EVAL_CHG); > > /* Go back to the starting frequency */ > - gen5_rps_set(rps, rps->idle_freq); > + __gen5_rps_set(rps, rps->idle_freq); > mdelay(1); > rgvswctl |= MEMCTL_CMD_STS; > intel_uncore_write(uncore, MEMSWCTL, rgvswctl); > @@ -797,20 +808,19 @@ static int rps_set(struct intel_rps *rps, u8 val, bool update) > struct drm_i915_private *i915 = rps_to_i915(rps); > int err; > > - if (INTEL_GEN(i915) < 6) > - return 0; > - > if (val == rps->last_freq) > return 0; > > if (IS_VALLEYVIEW(i915) || IS_CHERRYVIEW(i915)) > err = vlv_rps_set(rps, val); > - else > + else if (INTEL_GEN(i915) >= 6) > err = gen6_rps_set(rps, val); > + else > + err = gen5_rps_set(rps, val); > if (err) > return err; > > - if (update) > + if (update && INTEL_GEN(i915) >= 6) > gen6_rps_set_thresholds(rps, val); > rps->last_freq = val; > > @@ -1794,7 +1804,7 @@ void gen5_rps_irq_handler(struct intel_rps *rps) > rps->min_freq_softlimit, > rps->max_freq_softlimit); > > - if (new_freq != rps->cur_freq && gen5_rps_set(rps, new_freq)) > + if (new_freq != rps->cur_freq && !__gen5_rps_set(rps, new_freq)) > rps->cur_freq = new_freq; > > spin_unlock(&mchdev_lock); > @@ -2105,7 +2115,7 @@ bool i915_gpu_turbo_disable(void) > > spin_lock_irq(&mchdev_lock); > rps->max_freq_softlimit = rps->min_freq; > - ret = gen5_rps_set(&i915->gt.rps, rps->min_freq); > + ret = !__gen5_rps_set(&i915->gt.rps, rps->min_freq); > spin_unlock_irq(&mchdev_lock); > > drm_dev_put(&i915->drm); > -- > 2.20.1 > > _______________________________________________ > Intel-gfx mailing list > Intel-gfx@lists.freedesktop.org > https://lists.freedesktop.org/mailman/listinfo/intel-gfx _______________________________________________ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/intel-gfx ^ permalink raw reply [flat|nested] 5+ messages in thread
* [Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915/gt: Plug IPS into intel_rps_set (rev2) 2020-11-19 22:36 [Intel-gfx] [PATCH] drm/i915/gt: Plug IPS into intel_rps_set Chris Wilson 2020-11-19 22:58 ` Chris Wilson @ 2020-11-20 0:21 ` Patchwork 2020-11-20 6:21 ` [Intel-gfx] ✓ Fi.CI.IGT: " Patchwork 2 siblings, 0 replies; 5+ messages in thread From: Patchwork @ 2020-11-20 0:21 UTC (permalink / raw) To: Chris Wilson; +Cc: intel-gfx [-- Attachment #1.1: Type: text/plain, Size: 5595 bytes --] == Series Details == Series: drm/i915/gt: Plug IPS into intel_rps_set (rev2) URL : https://patchwork.freedesktop.org/series/84081/ State : success == Summary == CI Bug Log - changes from CI_DRM_9364 -> Patchwork_18946 ==================================================== Summary ------- **SUCCESS** No regressions found. External URL: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18946/index.html New tests --------- New tests have been introduced between CI_DRM_9364 and Patchwork_18946: ### New CI tests (1) ### * boot: - Statuses : 1 fail(s) 39 pass(s) - Exec time: [0.0] s Known issues ------------ Here are the changes found in Patchwork_18946 that come from known issues: ### IGT changes ### #### Issues hit #### * igt@i915_selftest@live@gt_heartbeat: - fi-bsw-nick: [PASS][1] -> [DMESG-FAIL][2] ([i915#2675] / [i915#541]) [1]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9364/fi-bsw-nick/igt@i915_selftest@live@gt_heartbeat.html [2]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18946/fi-bsw-nick/igt@i915_selftest@live@gt_heartbeat.html * igt@i915_selftest@live@gt_timelines: - fi-apl-guc: [PASS][3] -> [INCOMPLETE][4] ([i915#1635]) [3]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9364/fi-apl-guc/igt@i915_selftest@live@gt_timelines.html [4]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18946/fi-apl-guc/igt@i915_selftest@live@gt_timelines.html * igt@prime_vgem@basic-read: - fi-tgl-y: [PASS][5] -> [DMESG-WARN][6] ([i915#402]) [5]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9364/fi-tgl-y/igt@prime_vgem@basic-read.html [6]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18946/fi-tgl-y/igt@prime_vgem@basic-read.html #### Possible fixes #### * igt@debugfs_test@read_all_entries: - fi-tgl-y: [DMESG-WARN][7] ([i915#402]) -> [PASS][8] +1 similar issue [7]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9364/fi-tgl-y/igt@debugfs_test@read_all_entries.html [8]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18946/fi-tgl-y/igt@debugfs_test@read_all_entries.html * igt@i915_module_load@reload: - fi-icl-y: [DMESG-WARN][9] ([i915#1982]) -> [PASS][10] [9]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9364/fi-icl-y/igt@i915_module_load@reload.html [10]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18946/fi-icl-y/igt@i915_module_load@reload.html * igt@i915_pm_rpm@basic-pci-d3-state: - fi-bsw-kefka: [DMESG-WARN][11] ([i915#1982]) -> [PASS][12] [11]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9364/fi-bsw-kefka/igt@i915_pm_rpm@basic-pci-d3-state.html [12]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18946/fi-bsw-kefka/igt@i915_pm_rpm@basic-pci-d3-state.html * igt@kms_psr@cursor_plane_move: - fi-tgl-y: [DMESG-WARN][13] ([i915#1982]) -> [PASS][14] [13]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9364/fi-tgl-y/igt@kms_psr@cursor_plane_move.html [14]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18946/fi-tgl-y/igt@kms_psr@cursor_plane_move.html #### Warnings #### * igt@gem_exec_suspend@basic-s3: - fi-tgl-y: [DMESG-WARN][15] ([i915#2411]) -> [DMESG-WARN][16] ([i915#2411] / [i915#402]) [15]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9364/fi-tgl-y/igt@gem_exec_suspend@basic-s3.html [16]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18946/fi-tgl-y/igt@gem_exec_suspend@basic-s3.html * igt@runner@aborted: - fi-kbl-8809g: [FAIL][17] ([i915#1186] / [i915#1784] / [i915#2426] / [i915#2439]) -> [FAIL][18] ([i915#1186] / [i915#2426]) [17]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9364/fi-kbl-8809g/igt@runner@aborted.html [18]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18946/fi-kbl-8809g/igt@runner@aborted.html {name}: This element is suppressed. This means it is ignored when computing the status of the difference (SUCCESS, WARNING, or FAILURE). [i915#1186]: https://gitlab.freedesktop.org/drm/intel/issues/1186 [i915#1635]: https://gitlab.freedesktop.org/drm/intel/issues/1635 [i915#1784]: https://gitlab.freedesktop.org/drm/intel/issues/1784 [i915#1982]: https://gitlab.freedesktop.org/drm/intel/issues/1982 [i915#2292]: https://gitlab.freedesktop.org/drm/intel/issues/2292 [i915#2411]: https://gitlab.freedesktop.org/drm/intel/issues/2411 [i915#2426]: https://gitlab.freedesktop.org/drm/intel/issues/2426 [i915#2439]: https://gitlab.freedesktop.org/drm/intel/issues/2439 [i915#2675]: https://gitlab.freedesktop.org/drm/intel/issues/2675 [i915#402]: https://gitlab.freedesktop.org/drm/intel/issues/402 [i915#541]: https://gitlab.freedesktop.org/drm/intel/issues/541 [k.org#204565]: https://bugzilla.kernel.org/show_bug.cgi?id=204565 Participating hosts (43 -> 40) ------------------------------ Additional (1): fi-bxt-dsi Missing (4): fi-ilk-m540 fi-bsw-cyan fi-bdw-samus fi-hsw-4200u Build changes ------------- * Linux: CI_DRM_9364 -> Patchwork_18946 CI-20190529: 20190529 CI_DRM_9364: c7321011fe308f5bc466293213b01e5a86d6ff52 @ git://anongit.freedesktop.org/gfx-ci/linux IGT_5861: 71f45998b2819b2d473277d91fc3c63eef5c4a99 @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools Patchwork_18946: 634b6faa0d2dc516a6197d31e8b6b626520ffa49 @ git://anongit.freedesktop.org/gfx-ci/linux == Linux commits == 634b6faa0d2d drm/i915/gt: Plug IPS into intel_rps_set == Logs == For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18946/index.html [-- Attachment #1.2: Type: text/html, Size: 6783 bytes --] [-- Attachment #2: Type: text/plain, Size: 160 bytes --] _______________________________________________ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/intel-gfx ^ permalink raw reply [flat|nested] 5+ messages in thread
* [Intel-gfx] ✓ Fi.CI.IGT: success for drm/i915/gt: Plug IPS into intel_rps_set (rev2) 2020-11-19 22:36 [Intel-gfx] [PATCH] drm/i915/gt: Plug IPS into intel_rps_set Chris Wilson 2020-11-19 22:58 ` Chris Wilson 2020-11-20 0:21 ` [Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915/gt: Plug IPS into intel_rps_set (rev2) Patchwork @ 2020-11-20 6:21 ` Patchwork 2 siblings, 0 replies; 5+ messages in thread From: Patchwork @ 2020-11-20 6:21 UTC (permalink / raw) To: Chris Wilson; +Cc: intel-gfx [-- Attachment #1.1: Type: text/plain, Size: 16814 bytes --] == Series Details == Series: drm/i915/gt: Plug IPS into intel_rps_set (rev2) URL : https://patchwork.freedesktop.org/series/84081/ State : success == Summary == CI Bug Log - changes from CI_DRM_9364_full -> Patchwork_18946_full ==================================================== Summary ------- **SUCCESS** No regressions found. New tests --------- New tests have been introduced between CI_DRM_9364_full and Patchwork_18946_full: ### New CI tests (1) ### * boot: - Statuses : 175 pass(s) - Exec time: [0.0] s Known issues ------------ Here are the changes found in Patchwork_18946_full that come from known issues: ### IGT changes ### #### Issues hit #### * igt@gem_exec_reloc@basic-many-active@rcs0: - shard-apl: [PASS][1] -> [FAIL][2] ([i915#1635] / [i915#2389]) [1]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9364/shard-apl1/igt@gem_exec_reloc@basic-many-active@rcs0.html [2]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18946/shard-apl7/igt@gem_exec_reloc@basic-many-active@rcs0.html * igt@gem_workarounds@suspend-resume: - shard-skl: [PASS][3] -> [INCOMPLETE][4] ([i915#198]) [3]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9364/shard-skl2/igt@gem_workarounds@suspend-resume.html [4]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18946/shard-skl1/igt@gem_workarounds@suspend-resume.html * igt@kms_cursor_crc@pipe-a-cursor-128x128-onscreen: - shard-skl: [PASS][5] -> [FAIL][6] ([i915#54]) [5]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9364/shard-skl3/igt@kms_cursor_crc@pipe-a-cursor-128x128-onscreen.html [6]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18946/shard-skl5/igt@kms_cursor_crc@pipe-a-cursor-128x128-onscreen.html * igt@kms_cursor_edge_walk@pipe-b-64x64-right-edge: - shard-skl: [PASS][7] -> [DMESG-WARN][8] ([i915#1982]) +6 similar issues [7]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9364/shard-skl9/igt@kms_cursor_edge_walk@pipe-b-64x64-right-edge.html [8]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18946/shard-skl8/igt@kms_cursor_edge_walk@pipe-b-64x64-right-edge.html * igt@kms_draw_crc@draw-method-xrgb2101010-mmap-gtt-xtiled: - shard-apl: [PASS][9] -> [DMESG-WARN][10] ([i915#1635] / [i915#1982]) +1 similar issue [9]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9364/shard-apl2/igt@kms_draw_crc@draw-method-xrgb2101010-mmap-gtt-xtiled.html [10]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18946/shard-apl3/igt@kms_draw_crc@draw-method-xrgb2101010-mmap-gtt-xtiled.html * igt@kms_flip@basic-plain-flip@a-edp1: - shard-tglb: [PASS][11] -> [DMESG-WARN][12] ([i915#1982]) +3 similar issues [11]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9364/shard-tglb7/igt@kms_flip@basic-plain-flip@a-edp1.html [12]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18946/shard-tglb8/igt@kms_flip@basic-plain-flip@a-edp1.html * igt@kms_flip@flip-vs-absolute-wf_vblank@a-dp1: - shard-kbl: [PASS][13] -> [DMESG-WARN][14] ([i915#1982]) +1 similar issue [13]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9364/shard-kbl7/igt@kms_flip@flip-vs-absolute-wf_vblank@a-dp1.html [14]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18946/shard-kbl6/igt@kms_flip@flip-vs-absolute-wf_vblank@a-dp1.html * igt@kms_flip@flip-vs-expired-vblank@a-edp1: - shard-tglb: [PASS][15] -> [FAIL][16] ([i915#2598]) [15]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9364/shard-tglb8/igt@kms_flip@flip-vs-expired-vblank@a-edp1.html [16]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18946/shard-tglb1/igt@kms_flip@flip-vs-expired-vblank@a-edp1.html * igt@kms_flip@modeset-vs-vblank-race-interruptible@a-hdmi-a1: - shard-glk: [PASS][17] -> [FAIL][18] ([i915#407]) [17]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9364/shard-glk4/igt@kms_flip@modeset-vs-vblank-race-interruptible@a-hdmi-a1.html [18]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18946/shard-glk7/igt@kms_flip@modeset-vs-vblank-race-interruptible@a-hdmi-a1.html * igt@kms_flip@plain-flip-ts-check-interruptible@b-edp1: - shard-skl: [PASS][19] -> [FAIL][20] ([i915#2122]) [19]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9364/shard-skl9/igt@kms_flip@plain-flip-ts-check-interruptible@b-edp1.html [20]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18946/shard-skl9/igt@kms_flip@plain-flip-ts-check-interruptible@b-edp1.html * igt@kms_frontbuffer_tracking@psr-rgb101010-draw-render: - shard-skl: [PASS][21] -> [FAIL][22] ([i915#49]) [21]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9364/shard-skl1/igt@kms_frontbuffer_tracking@psr-rgb101010-draw-render.html [22]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18946/shard-skl7/igt@kms_frontbuffer_tracking@psr-rgb101010-draw-render.html * igt@kms_frontbuffer_tracking@psr-suspend: - shard-skl: [PASS][23] -> [INCOMPLETE][24] ([i915#123]) [23]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9364/shard-skl10/igt@kms_frontbuffer_tracking@psr-suspend.html [24]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18946/shard-skl6/igt@kms_frontbuffer_tracking@psr-suspend.html * igt@kms_hdr@bpc-switch-suspend: - shard-skl: [PASS][25] -> [FAIL][26] ([i915#1188]) [25]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9364/shard-skl8/igt@kms_hdr@bpc-switch-suspend.html [26]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18946/shard-skl4/igt@kms_hdr@bpc-switch-suspend.html * igt@kms_plane_alpha_blend@pipe-b-coverage-7efc: - shard-skl: [PASS][27] -> [FAIL][28] ([fdo#108145] / [i915#265]) +1 similar issue [27]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9364/shard-skl2/igt@kms_plane_alpha_blend@pipe-b-coverage-7efc.html [28]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18946/shard-skl7/igt@kms_plane_alpha_blend@pipe-b-coverage-7efc.html * igt@kms_psr@psr2_sprite_render: - shard-iclb: [PASS][29] -> [SKIP][30] ([fdo#109441]) +2 similar issues [29]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9364/shard-iclb2/igt@kms_psr@psr2_sprite_render.html [30]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18946/shard-iclb7/igt@kms_psr@psr2_sprite_render.html * igt@kms_universal_plane@universal-plane-gen9-features-pipe-a: - shard-iclb: [PASS][31] -> [DMESG-WARN][32] ([i915#1982]) +1 similar issue [31]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9364/shard-iclb1/igt@kms_universal_plane@universal-plane-gen9-features-pipe-a.html [32]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18946/shard-iclb6/igt@kms_universal_plane@universal-plane-gen9-features-pipe-a.html #### Possible fixes #### * igt@core_hotunplug@unbind-rebind: - shard-iclb: [DMESG-WARN][33] ([i915#1982]) -> [PASS][34] [33]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9364/shard-iclb8/igt@core_hotunplug@unbind-rebind.html [34]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18946/shard-iclb8/igt@core_hotunplug@unbind-rebind.html * igt@gem_blits@basic: - shard-skl: [TIMEOUT][35] ([i915#2502]) -> [PASS][36] [35]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9364/shard-skl8/igt@gem_blits@basic.html [36]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18946/shard-skl5/igt@gem_blits@basic.html * igt@kms_big_fb@y-tiled-32bpp-rotate-90: - shard-kbl: [DMESG-WARN][37] ([i915#1982]) -> [PASS][38] +1 similar issue [37]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9364/shard-kbl4/igt@kms_big_fb@y-tiled-32bpp-rotate-90.html [38]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18946/shard-kbl6/igt@kms_big_fb@y-tiled-32bpp-rotate-90.html * igt@kms_cursor_crc@pipe-a-cursor-128x42-sliding: - shard-skl: [FAIL][39] ([i915#54]) -> [PASS][40] +2 similar issues [39]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9364/shard-skl2/igt@kms_cursor_crc@pipe-a-cursor-128x42-sliding.html [40]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18946/shard-skl7/igt@kms_cursor_crc@pipe-a-cursor-128x42-sliding.html * igt@kms_cursor_legacy@flip-vs-cursor-legacy: - shard-tglb: [FAIL][41] ([i915#2346]) -> [PASS][42] [41]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9364/shard-tglb6/igt@kms_cursor_legacy@flip-vs-cursor-legacy.html [42]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18946/shard-tglb3/igt@kms_cursor_legacy@flip-vs-cursor-legacy.html * igt@kms_flip@2x-plain-flip-ts-check-interruptible@ab-hdmi-a1-hdmi-a2: - shard-glk: [FAIL][43] ([i915#2122]) -> [PASS][44] [43]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9364/shard-glk1/igt@kms_flip@2x-plain-flip-ts-check-interruptible@ab-hdmi-a1-hdmi-a2.html [44]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18946/shard-glk3/igt@kms_flip@2x-plain-flip-ts-check-interruptible@ab-hdmi-a1-hdmi-a2.html * igt@kms_frontbuffer_tracking@fbc-1p-offscren-pri-indfb-draw-blt: - shard-apl: [DMESG-WARN][45] ([i915#1635] / [i915#1982]) -> [PASS][46] +3 similar issues [45]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9364/shard-apl6/igt@kms_frontbuffer_tracking@fbc-1p-offscren-pri-indfb-draw-blt.html [46]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18946/shard-apl7/igt@kms_frontbuffer_tracking@fbc-1p-offscren-pri-indfb-draw-blt.html * igt@kms_frontbuffer_tracking@fbc-2p-primscrn-indfb-pgflip-blt: - shard-glk: [DMESG-WARN][47] ([i915#1982]) -> [PASS][48] +4 similar issues [47]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9364/shard-glk5/igt@kms_frontbuffer_tracking@fbc-2p-primscrn-indfb-pgflip-blt.html [48]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18946/shard-glk4/igt@kms_frontbuffer_tracking@fbc-2p-primscrn-indfb-pgflip-blt.html * igt@kms_hdr@bpc-switch-dpms: - shard-skl: [FAIL][49] ([i915#1188]) -> [PASS][50] [49]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9364/shard-skl4/igt@kms_hdr@bpc-switch-dpms.html [50]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18946/shard-skl5/igt@kms_hdr@bpc-switch-dpms.html * igt@kms_psr2_su@page_flip: - shard-iclb: [SKIP][51] ([fdo#109642] / [fdo#111068]) -> [PASS][52] [51]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9364/shard-iclb7/igt@kms_psr2_su@page_flip.html [52]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18946/shard-iclb2/igt@kms_psr2_su@page_flip.html * igt@kms_psr@psr2_dpms: - shard-iclb: [SKIP][53] ([fdo#109441]) -> [PASS][54] [53]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9364/shard-iclb7/igt@kms_psr@psr2_dpms.html [54]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18946/shard-iclb2/igt@kms_psr@psr2_dpms.html * igt@kms_universal_plane@universal-plane-gen9-features-pipe-a: - shard-skl: [DMESG-WARN][55] ([i915#1982]) -> [PASS][56] +2 similar issues [55]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9364/shard-skl7/igt@kms_universal_plane@universal-plane-gen9-features-pipe-a.html [56]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18946/shard-skl1/igt@kms_universal_plane@universal-plane-gen9-features-pipe-a.html #### Warnings #### * igt@gem_workarounds@suspend-resume-fd: - shard-apl: [DMESG-WARN][57] ([i915#1635] / [i915#2635]) -> [INCOMPLETE][58] ([i915#1635] / [i915#2405] / [i915#2635]) [57]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9364/shard-apl3/igt@gem_workarounds@suspend-resume-fd.html [58]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18946/shard-apl6/igt@gem_workarounds@suspend-resume-fd.html * igt@kms_flip@flip-vs-expired-vblank-interruptible@a-edp1: - shard-skl: [DMESG-WARN][59] ([i915#1982]) -> [DMESG-FAIL][60] ([i915#1982]) [59]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9364/shard-skl8/igt@kms_flip@flip-vs-expired-vblank-interruptible@a-edp1.html [60]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18946/shard-skl4/igt@kms_flip@flip-vs-expired-vblank-interruptible@a-edp1.html * igt@kms_flip@plain-flip-fb-recreate-interruptible@a-edp1: - shard-skl: [DMESG-FAIL][61] ([i915#1982]) -> [DMESG-WARN][62] ([i915#1982]) [61]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9364/shard-skl7/igt@kms_flip@plain-flip-fb-recreate-interruptible@a-edp1.html [62]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18946/shard-skl10/igt@kms_flip@plain-flip-fb-recreate-interruptible@a-edp1.html * igt@kms_plane_alpha_blend@pipe-c-alpha-basic: - shard-apl: [DMESG-FAIL][63] ([fdo#108145] / [i915#1635] / [i915#1982]) -> [FAIL][64] ([fdo#108145] / [i915#1635] / [i915#265]) [63]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9364/shard-apl1/igt@kms_plane_alpha_blend@pipe-c-alpha-basic.html [64]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18946/shard-apl6/igt@kms_plane_alpha_blend@pipe-c-alpha-basic.html * igt@runner@aborted: - shard-kbl: ([FAIL][65], [FAIL][66]) ([i915#2295]) -> ([FAIL][67], [FAIL][68]) ([i915#2295] / [i915#483]) [65]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9364/shard-kbl7/igt@runner@aborted.html [66]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9364/shard-kbl7/igt@runner@aborted.html [67]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18946/shard-kbl3/igt@runner@aborted.html [68]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18946/shard-kbl7/igt@runner@aborted.html - shard-iclb: ([FAIL][69], [FAIL][70]) ([i915#2295]) -> ([FAIL][71], [FAIL][72]) ([i915#2295] / [i915#483]) [69]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9364/shard-iclb2/igt@runner@aborted.html [70]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9364/shard-iclb4/igt@runner@aborted.html [71]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18946/shard-iclb7/igt@runner@aborted.html [72]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18946/shard-iclb5/igt@runner@aborted.html - shard-skl: [FAIL][73] ([i915#2295] / [i915#483]) -> [FAIL][74] ([i915#2295]) [73]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9364/shard-skl7/igt@runner@aborted.html [74]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18946/shard-skl10/igt@runner@aborted.html {name}: This element is suppressed. This means it is ignored when computing the status of the difference (SUCCESS, WARNING, or FAILURE). [fdo#108145]: https://bugs.freedesktop.org/show_bug.cgi?id=108145 [fdo#109441]: https://bugs.freedesktop.org/show_bug.cgi?id=109441 [fdo#109642]: https://bugs.freedesktop.org/show_bug.cgi?id=109642 [fdo#111068]: https://bugs.freedesktop.org/show_bug.cgi?id=111068 [i915#1188]: https://gitlab.freedesktop.org/drm/intel/issues/1188 [i915#123]: https://gitlab.freedesktop.org/drm/intel/issues/123 [i915#1635]: https://gitlab.freedesktop.org/drm/intel/issues/1635 [i915#198]: https://gitlab.freedesktop.org/drm/intel/issues/198 [i915#1982]: https://gitlab.freedesktop.org/drm/intel/issues/1982 [i915#2122]: https://gitlab.freedesktop.org/drm/intel/issues/2122 [i915#2295]: https://gitlab.freedesktop.org/drm/intel/issues/2295 [i915#2346]: https://gitlab.freedesktop.org/drm/intel/issues/2346 [i915#2389]: https://gitlab.freedesktop.org/drm/intel/issues/2389 [i915#2405]: https://gitlab.freedesktop.org/drm/intel/issues/2405 [i915#2502]: https://gitlab.freedesktop.org/drm/intel/issues/2502 [i915#2597]: https://gitlab.freedesktop.org/drm/intel/issues/2597 [i915#2598]: https://gitlab.freedesktop.org/drm/intel/issues/2598 [i915#2635]: https://gitlab.freedesktop.org/drm/intel/issues/2635 [i915#265]: https://gitlab.freedesktop.org/drm/intel/issues/265 [i915#407]: https://gitlab.freedesktop.org/drm/intel/issues/407 [i915#483]: https://gitlab.freedesktop.org/drm/intel/issues/483 [i915#49]: https://gitlab.freedesktop.org/drm/intel/issues/49 [i915#54]: https://gitlab.freedesktop.org/drm/intel/issues/54 Participating hosts (10 -> 10) ------------------------------ No changes in participating hosts Build changes ------------- * Linux: CI_DRM_9364 -> Patchwork_18946 CI-20190529: 20190529 CI_DRM_9364: c7321011fe308f5bc466293213b01e5a86d6ff52 @ git://anongit.freedesktop.org/gfx-ci/linux IGT_5861: 71f45998b2819b2d473277d91fc3c63eef5c4a99 @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools Patchwork_18946: 634b6faa0d2dc516a6197d31e8b6b626520ffa49 @ git://anongit.freedesktop.org/gfx-ci/linux piglit_4509: fdc5a4ca11124ab8413c7988896eec4c97336694 @ git://anongit.freedesktop.org/piglit == Logs == For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18946/index.html [-- Attachment #1.2: Type: text/html, Size: 20536 bytes --] [-- Attachment #2: Type: text/plain, Size: 160 bytes --] _______________________________________________ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/intel-gfx ^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2020-11-20 11:54 UTC | newest] Thread overview: 5+ messages (download: mbox.gz follow: Atom feed -- links below jump to the message on this page -- 2020-11-19 22:36 [Intel-gfx] [PATCH] drm/i915/gt: Plug IPS into intel_rps_set Chris Wilson 2020-11-19 22:58 ` Chris Wilson 2020-11-20 11:52 ` Mika Kuoppala 2020-11-20 0:21 ` [Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915/gt: Plug IPS into intel_rps_set (rev2) Patchwork 2020-11-20 6:21 ` [Intel-gfx] ✓ Fi.CI.IGT: " Patchwork
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.