From: Kalle Valo <kvalo@codeaurora.org>
To: Venkateswara Naralasetty <vnaralas@codeaurora.org>
Cc: Manikanta Pubbisetty <mpubbise@codeaurora.org>,
linux-wireless@vger.kernel.org, ath11k@lists.infradead.org
Subject: Re: [PATCHv2] ath11k: add raw mode and software crypto support
Date: Thu, 17 Sep 2020 18:18:22 +0300 [thread overview]
Message-ID: <871rj0h1oh.fsf@codeaurora.org> (raw)
In-Reply-To: <010101746c6a54fa-91406158-3f0a-4f10-8328-a7f560dd3feb-000000@us-west-2.amazonses.com> (Venkateswara Naralasetty's message of "Tue, 8 Sep 2020 06:32:22 +0000")
Venkateswara Naralasetty <vnaralas@codeaurora.org> writes:
> Adding raw mode tx/rx support. Also, adding support
> for software crypto which depends on raw mode.
>
> To enable raw mode tx/rx:
> insmod ath11k.ko frame_mode=0
>
> To enable software crypto:
> insmod ath11k.ko crypto_mode=1
>
> These modes could be helpful in debugging crypto related issues.
>
> Tested-on: IPQ8074 WLAN.HK.2.1.0.1-01228-QCAHKSWPL_SILICONZ-1
>
> Signed-off-by: Manikanta Pubbisetty <mpubbise@codeaurora.org>
> Signed-off-by: Venkateswara Naralasetty <vnaralas@codeaurora.org>
[...]
> --- a/drivers/net/wireless/ath/ath11k/wmi.c
> +++ b/drivers/net/wireless/ath/ath11k/wmi.c
> @@ -3366,6 +3366,10 @@ int ath11k_wmi_cmd_init(struct ath11k_base *ab)
> config.rx_timeout_pri[2] = TARGET_RX_TIMEOUT_LO_PRI;
> config.rx_timeout_pri[3] = TARGET_RX_TIMEOUT_HI_PRI;
> config.rx_decap_mode = TARGET_DECAP_MODE_NATIVE_WIFI;
> +
> + if (test_bit(ATH11K_FLAG_RAW_MODE, &ab->dev_flags))
> + config.rx_decap_mode = TARGET_DECAP_MODE_RAW;
Did you test this at all? Because to me it looks like in
ath11k_init_wmi_config_ipq8074() this is overwritten with:
config->rx_decap_mode = TARGET_DECAP_MODE_NATIVE_WIFI;
So I can't see how this would even work. I noticed this while I was
cleaning up ath11k_wmi_cmd_init(). I'll send a patch soon, please test
that and let me know if it works.
--
https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches
--
ath11k mailing list
ath11k@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/ath11k
WARNING: multiple messages have this Message-ID (diff)
From: Kalle Valo <kvalo@codeaurora.org>
To: Venkateswara Naralasetty <vnaralas@codeaurora.org>
Cc: ath11k@lists.infradead.org,
Manikanta Pubbisetty <mpubbise@codeaurora.org>,
linux-wireless@vger.kernel.org
Subject: Re: [PATCHv2] ath11k: add raw mode and software crypto support
Date: Thu, 17 Sep 2020 18:18:22 +0300 [thread overview]
Message-ID: <871rj0h1oh.fsf@codeaurora.org> (raw)
In-Reply-To: <010101746c6a54fa-91406158-3f0a-4f10-8328-a7f560dd3feb-000000@us-west-2.amazonses.com> (Venkateswara Naralasetty's message of "Tue, 8 Sep 2020 06:32:22 +0000")
Venkateswara Naralasetty <vnaralas@codeaurora.org> writes:
> Adding raw mode tx/rx support. Also, adding support
> for software crypto which depends on raw mode.
>
> To enable raw mode tx/rx:
> insmod ath11k.ko frame_mode=0
>
> To enable software crypto:
> insmod ath11k.ko crypto_mode=1
>
> These modes could be helpful in debugging crypto related issues.
>
> Tested-on: IPQ8074 WLAN.HK.2.1.0.1-01228-QCAHKSWPL_SILICONZ-1
>
> Signed-off-by: Manikanta Pubbisetty <mpubbise@codeaurora.org>
> Signed-off-by: Venkateswara Naralasetty <vnaralas@codeaurora.org>
[...]
> --- a/drivers/net/wireless/ath/ath11k/wmi.c
> +++ b/drivers/net/wireless/ath/ath11k/wmi.c
> @@ -3366,6 +3366,10 @@ int ath11k_wmi_cmd_init(struct ath11k_base *ab)
> config.rx_timeout_pri[2] = TARGET_RX_TIMEOUT_LO_PRI;
> config.rx_timeout_pri[3] = TARGET_RX_TIMEOUT_HI_PRI;
> config.rx_decap_mode = TARGET_DECAP_MODE_NATIVE_WIFI;
> +
> + if (test_bit(ATH11K_FLAG_RAW_MODE, &ab->dev_flags))
> + config.rx_decap_mode = TARGET_DECAP_MODE_RAW;
Did you test this at all? Because to me it looks like in
ath11k_init_wmi_config_ipq8074() this is overwritten with:
config->rx_decap_mode = TARGET_DECAP_MODE_NATIVE_WIFI;
So I can't see how this would even work. I noticed this while I was
cleaning up ath11k_wmi_cmd_init(). I'll send a patch soon, please test
that and let me know if it works.
--
https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches
next prev parent reply other threads:[~2020-09-17 15:18 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-08 6:32 [PATCHv2] ath11k: add raw mode and software crypto support Venkateswara Naralasetty
2020-09-17 15:18 ` Kalle Valo [this message]
2020-09-17 15:18 ` Kalle Valo
2020-09-18 5:34 ` vnaralas
2020-09-18 5:34 ` vnaralas
2020-09-18 7:15 ` Kalle Valo
2020-09-18 7:15 ` Kalle Valo
-- strict thread matches above, loose matches on Subject: below --
2020-09-08 6:32 Venkateswara Naralasetty
2020-09-11 9:57 ` Kalle Valo
2020-09-11 9:57 ` Kalle Valo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=871rj0h1oh.fsf@codeaurora.org \
--to=kvalo@codeaurora.org \
--cc=ath11k@lists.infradead.org \
--cc=linux-wireless@vger.kernel.org \
--cc=mpubbise@codeaurora.org \
--cc=vnaralas@codeaurora.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.