All of lore.kernel.org
 help / color / mirror / Atom feed
From: John Ogness <john.ogness@linutronix.de>
To: kernel test robot <lkp@intel.com>
Cc: Andrea Parri <parri.andrea@gmail.com>,
	Petr Mladek <pmladek@suse.com>,
	kbuild-all@lists.01.org,
	Sergey Senozhatsky <sergey.senozhatsky.work@gmail.com>,
	Paul McKenney <paulmck@kernel.org>,
	Peter Zijlstra <peterz@infradead.org>,
	Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
	kexec@lists.infradead.org, linux-kernel@vger.kernel.org,
	Steven Rostedt <rostedt@goodmis.org>,
	Thomas Gleixner <tglx@linutronix.de>
Subject: Re: [RFC PATCH] printk: _printk_rb_static_dict can be static
Date: Fri, 19 Jun 2020 08:49:21 +0200	[thread overview]
Message-ID: <871rmbim8e.fsf@vostro.fn.ogness.net> (raw)
In-Reply-To: <20200618182323.GA72993@4e49555bcca1> (kernel test robot's message of "Fri, 19 Jun 2020 02:23:23 +0800")

On 2020-06-18, kernel test robot <lkp@intel.com> wrote:
> Signed-off-by: kernel test robot <lkp@intel.com>
> ---
>  printk.c |    2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/kernel/printk/printk.c b/kernel/printk/printk.c
> index 7642ef634956f..d812ada06735f 100644
> --- a/kernel/printk/printk.c
> +++ b/kernel/printk/printk.c
> @@ -434,7 +434,7 @@ static u32 log_buf_len = __LOG_BUF_LEN;
>   */
>  #define PRB_AVGBITS 5	/* 32 character average length */
>  
> -_DECLARE_PRINTKRB(printk_rb_static, CONFIG_LOG_BUF_SHIFT - PRB_AVGBITS,
> +static _DECLARE_PRINTKRB(printk_rb_static, CONFIG_LOG_BUF_SHIFT - PRB_AVGBITS,
>  		  PRB_AVGBITS, PRB_AVGBITS, &__log_buf[0]);

_DECLARE_PRINTKRB declares multiple variables, so this patch will not
work as intended. I would like to declare the variables static but am
not sure how best to go about it.

In the Linux source I see examples of macros just desclaring the
variables static. And I see examples of the macros providing a parameter
where the "static" keyword can be specified.

Since the ringbuffer was created exclusively to serve printk, I would
prefer to just have _DECLARE_PRINTKRB (and DECLARE_PRINTKRB) declare all
the variables as static.

John Ogness

_______________________________________________
kexec mailing list
kexec@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/kexec

WARNING: multiple messages have this Message-ID (diff)
From: John Ogness <john.ogness@linutronix.de>
To: kbuild-all@lists.01.org
Subject: Re: [RFC PATCH] printk: _printk_rb_static_dict can be static
Date: Fri, 19 Jun 2020 08:49:21 +0200	[thread overview]
Message-ID: <871rmbim8e.fsf@vostro.fn.ogness.net> (raw)
In-Reply-To: <20200618182323.GA72993@4e49555bcca1>

[-- Attachment #1: Type: text/plain, Size: 1263 bytes --]

On 2020-06-18, kernel test robot <lkp@intel.com> wrote:
> Signed-off-by: kernel test robot <lkp@intel.com>
> ---
>  printk.c |    2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/kernel/printk/printk.c b/kernel/printk/printk.c
> index 7642ef634956f..d812ada06735f 100644
> --- a/kernel/printk/printk.c
> +++ b/kernel/printk/printk.c
> @@ -434,7 +434,7 @@ static u32 log_buf_len = __LOG_BUF_LEN;
>   */
>  #define PRB_AVGBITS 5	/* 32 character average length */
>  
> -_DECLARE_PRINTKRB(printk_rb_static, CONFIG_LOG_BUF_SHIFT - PRB_AVGBITS,
> +static _DECLARE_PRINTKRB(printk_rb_static, CONFIG_LOG_BUF_SHIFT - PRB_AVGBITS,
>  		  PRB_AVGBITS, PRB_AVGBITS, &__log_buf[0]);

_DECLARE_PRINTKRB declares multiple variables, so this patch will not
work as intended. I would like to declare the variables static but am
not sure how best to go about it.

In the Linux source I see examples of macros just desclaring the
variables static. And I see examples of the macros providing a parameter
where the "static" keyword can be specified.

Since the ringbuffer was created exclusively to serve printk, I would
prefer to just have _DECLARE_PRINTKRB (and DECLARE_PRINTKRB) declare all
the variables as static.

John Ogness

WARNING: multiple messages have this Message-ID (diff)
From: John Ogness <john.ogness@linutronix.de>
To: kernel test robot <lkp@intel.com>
Cc: Petr Mladek <pmladek@suse.com>,
	kbuild-all@lists.01.org, Peter Zijlstra <peterz@infradead.org>,
	Sergey Senozhatsky <sergey.senozhatsky.work@gmail.com>,
	Steven Rostedt <rostedt@goodmis.org>,
	Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
	Andrea Parri <parri.andrea@gmail.com>,
	Thomas Gleixner <tglx@linutronix.de>,
	Paul McKenney <paulmck@kernel.org>,
	kexec@lists.infradead.org, linux-kernel@vger.kernel.org
Subject: Re: [RFC PATCH] printk: _printk_rb_static_dict can be static
Date: Fri, 19 Jun 2020 08:49:21 +0200	[thread overview]
Message-ID: <871rmbim8e.fsf@vostro.fn.ogness.net> (raw)
In-Reply-To: <20200618182323.GA72993@4e49555bcca1> (kernel test robot's message of "Fri, 19 Jun 2020 02:23:23 +0800")

On 2020-06-18, kernel test robot <lkp@intel.com> wrote:
> Signed-off-by: kernel test robot <lkp@intel.com>
> ---
>  printk.c |    2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/kernel/printk/printk.c b/kernel/printk/printk.c
> index 7642ef634956f..d812ada06735f 100644
> --- a/kernel/printk/printk.c
> +++ b/kernel/printk/printk.c
> @@ -434,7 +434,7 @@ static u32 log_buf_len = __LOG_BUF_LEN;
>   */
>  #define PRB_AVGBITS 5	/* 32 character average length */
>  
> -_DECLARE_PRINTKRB(printk_rb_static, CONFIG_LOG_BUF_SHIFT - PRB_AVGBITS,
> +static _DECLARE_PRINTKRB(printk_rb_static, CONFIG_LOG_BUF_SHIFT - PRB_AVGBITS,
>  		  PRB_AVGBITS, PRB_AVGBITS, &__log_buf[0]);

_DECLARE_PRINTKRB declares multiple variables, so this patch will not
work as intended. I would like to declare the variables static but am
not sure how best to go about it.

In the Linux source I see examples of macros just desclaring the
variables static. And I see examples of the macros providing a parameter
where the "static" keyword can be specified.

Since the ringbuffer was created exclusively to serve printk, I would
prefer to just have _DECLARE_PRINTKRB (and DECLARE_PRINTKRB) declare all
the variables as static.

John Ogness

  reply	other threads:[~2020-06-19  6:49 UTC|newest]

Thread overview: 74+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-06-18 14:49 [PATCH v3 0/3] printk: replace ringbuffer John Ogness
2020-06-18 14:49 ` John Ogness
2020-06-18 14:49 ` [PATCH v3 1/3] crash: add VMCOREINFO macro to define offset in a struct declared by typedef John Ogness
2020-06-18 14:49   ` John Ogness
2020-06-24  8:49   ` Petr Mladek
2020-06-24  8:49     ` Petr Mladek
2020-07-04  9:30   ` Baoquan He
2020-07-04  9:30     ` Baoquan He
2020-06-18 14:49 ` [PATCH v3 2/3] printk: add lockless ringbuffer John Ogness
2020-06-18 14:49   ` John Ogness
2020-06-29 15:32   ` Paul E. McKenney
2020-06-29 15:32     ` Paul E. McKenney
2020-07-02  8:35   ` Petr Mladek
2020-07-02  8:35     ` Petr Mladek
2020-06-18 14:49 ` [PATCH v3 3/3] printk: use the " John Ogness
2020-06-18 14:49   ` John Ogness
2020-06-18 18:23   ` kernel test robot
2020-06-18 18:23     ` kernel test robot
2020-06-18 18:23     ` kernel test robot
2020-06-18 18:23   ` [RFC PATCH] printk: _printk_rb_static_dict can be static kernel test robot
2020-06-18 18:23     ` kernel test robot
2020-06-18 18:23     ` kernel test robot
2020-06-19  6:49     ` John Ogness [this message]
2020-06-19  6:49       ` John Ogness
2020-06-19  6:49       ` John Ogness
2020-06-19 12:29       ` Steven Rostedt
2020-06-19 12:29         ` Steven Rostedt
2020-06-19 12:29         ` Steven Rostedt
2020-06-25  8:16   ` truncate dict: was: Re: [PATCH v3 3/3] printk: use the lockless ringbuffer Petr Mladek
2020-06-25  8:16     ` Petr Mladek
2020-06-26 13:48     ` John Ogness
2020-06-26 13:48       ` John Ogness
2020-06-25  8:28   ` buffer allocation: was: " Petr Mladek
2020-06-25  8:28     ` Petr Mladek
2020-06-26 15:02     ` John Ogness
2020-06-26 15:02       ` John Ogness
2020-06-29 14:04       ` Petr Mladek
2020-06-29 14:04         ` Petr Mladek
2020-06-29 21:57         ` John Ogness
2020-06-29 21:57           ` John Ogness
2020-07-02 13:27           ` Petr Mladek
2020-07-02 13:27             ` Petr Mladek
2020-06-25 12:09   ` record_printk_text tricks: " Petr Mladek
2020-06-25 12:09     ` Petr Mladek
2020-06-25 15:25     ` Petr Mladek
2020-06-25 15:25       ` Petr Mladek
2020-06-26 23:25     ` John Ogness
2020-06-26 23:25       ` John Ogness
2020-06-25 15:17   ` pending output optimization: " Petr Mladek
2020-06-25 15:17     ` Petr Mladek
2020-07-01 19:58     ` John Ogness
2020-07-01 19:58       ` John Ogness
2020-06-25 15:20   ` syslog size unread: " Petr Mladek
2020-06-25 15:20     ` Petr Mladek
2020-06-29 21:51     ` John Ogness
2020-06-29 21:51       ` John Ogness
2020-07-02  8:25   ` lijiang
2020-07-02  8:25     ` lijiang
2020-07-02  9:02     ` John Ogness
2020-07-02  9:02       ` John Ogness
2020-07-02  9:43       ` lijiang
2020-07-02  9:43         ` lijiang
2020-07-02 13:31         ` Petr Mladek
2020-07-02 13:31           ` Petr Mladek
2020-07-04  1:12           ` lijiang
2020-07-04  1:12             ` lijiang
2020-07-03 11:54         ` John Ogness
2020-07-03 11:54           ` John Ogness
2020-07-08  5:50           ` lijiang
2020-07-08  5:50             ` lijiang
2020-06-25  7:19 ` [PATCH v3 0/3] printk: replace ringbuffer Dave Young
2020-06-25  7:19   ` Dave Young
2020-06-25 14:13   ` John Ogness
2020-06-25 14:13     ` John Ogness

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=871rmbim8e.fsf@vostro.fn.ogness.net \
    --to=john.ogness@linutronix.de \
    --cc=gregkh@linuxfoundation.org \
    --cc=kbuild-all@lists.01.org \
    --cc=kexec@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=lkp@intel.com \
    --cc=parri.andrea@gmail.com \
    --cc=paulmck@kernel.org \
    --cc=peterz@infradead.org \
    --cc=pmladek@suse.com \
    --cc=rostedt@goodmis.org \
    --cc=sergey.senozhatsky.work@gmail.com \
    --cc=tglx@linutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.