* [PATCH] drm/i915/dp: Add dpcd link_rate quirk for Apple 15" MBP 2017
@ 2020-02-29 5:41 ` Mario Kleiner
0 siblings, 0 replies; 9+ messages in thread
From: Mario Kleiner @ 2020-02-29 5:41 UTC (permalink / raw)
To: intel-gfx, dri-devel; +Cc: Jani Nikula
This fixes a problem found on the MacBookPro 2017 Retina panel.
The panel reports 10 bpc color depth in its EDID, and the
firmware chooses link settings at boot which support enough
bandwidth for 10 bpc (324000 kbit/sec = multiplier 0xc),
but the DP_MAX_LINK_RATE dpcd register only reports
2.7 Gbps (multiplier value 0xa) as possible, in direct
contradiction of what the firmware successfully set up.
This restricts the panel to 8 bpc, not providing the full
color depth of the panel.
This patch adds a quirk specific to the MBP 2017 15" Retina
panel to add the additiional 324000 kbps link rate during
edp setup.
Link to previous discussion of a different attempted fix
with Ville and Jani:
https://patchwork.kernel.org/patch/11325935/
Signed-off-by: Mario Kleiner <mario.kleiner.de@gmail.com>
Cc: Ville Syrjälä <ville.syrjala@linux.intel.com>
Cc: Jani Nikula <jani.nikula@intel.com>
---
drivers/gpu/drm/drm_dp_helper.c | 2 ++
drivers/gpu/drm/i915/display/intel_dp.c | 7 +++++++
include/drm/drm_dp_helper.h | 7 +++++++
3 files changed, 16 insertions(+)
diff --git a/drivers/gpu/drm/drm_dp_helper.c b/drivers/gpu/drm/drm_dp_helper.c
index 5a103e9b3c86..36a371c016cb 100644
--- a/drivers/gpu/drm/drm_dp_helper.c
+++ b/drivers/gpu/drm/drm_dp_helper.c
@@ -1179,6 +1179,8 @@ static const struct dpcd_quirk dpcd_quirk_list[] = {
{ OUI(0x00, 0x00, 0x00), DEVICE_ID('C', 'H', '7', '5', '1', '1'), false, BIT(DP_DPCD_QUIRK_NO_SINK_COUNT) },
/* Synaptics DP1.4 MST hubs can support DSC without virtual DPCD */
{ OUI(0x90, 0xCC, 0x24), DEVICE_ID_ANY, true, BIT(DP_DPCD_QUIRK_DSC_WITHOUT_VIRTUAL_DPCD) },
+ /* Apple MacBookPro 2017 15 inch eDP Retina panel reports too low DP_MAX_LINK_RATE */
+ { OUI(0x00, 0x10, 0xfa), DEVICE_ID(101, 68, 21, 101, 98, 97), false, BIT(DP_DPCD_QUIRK_CAN_DO_MAX_LINK_RATE_3_24_GBPS) },
};
#undef OUI
diff --git a/drivers/gpu/drm/i915/display/intel_dp.c b/drivers/gpu/drm/i915/display/intel_dp.c
index 4074d83b1a5f..1f6bd659ad41 100644
--- a/drivers/gpu/drm/i915/display/intel_dp.c
+++ b/drivers/gpu/drm/i915/display/intel_dp.c
@@ -178,6 +178,13 @@ static void intel_dp_set_sink_rates(struct intel_dp *intel_dp)
}
intel_dp->num_sink_rates = i;
+
+ if (drm_dp_has_quirk(&intel_dp->desc,
+ DP_DPCD_QUIRK_CAN_DO_MAX_LINK_RATE_3_24_GBPS)) {
+ /* Needed for Apple MBP 2017, 15 inch eDP Retina panel */
+ intel_dp->sink_rates[i] = 324000;
+ intel_dp->num_sink_rates++;
+ }
}
/* Get length of rates array potentially limited by max_rate. */
diff --git a/include/drm/drm_dp_helper.h b/include/drm/drm_dp_helper.h
index 262faf9e5e94..4b86a1f2a559 100644
--- a/include/drm/drm_dp_helper.h
+++ b/include/drm/drm_dp_helper.h
@@ -1532,6 +1532,13 @@ enum drm_dp_quirk {
* The DSC caps can be read from the physical aux instead.
*/
DP_DPCD_QUIRK_DSC_WITHOUT_VIRTUAL_DPCD,
+ /**
+ * @DP_DPCD_QUIRK_CAN_DO_MAX_LINK_RATE_3_24_GBPS:
+ *
+ * The device supports a link rate of 3.24 Gbps (multiplier 0xc) despite
+ * the DP_MAX_LINK_RATE register reporting a lower max multiplier.
+ */
+ DP_DPCD_QUIRK_CAN_DO_MAX_LINK_RATE_3_24_GBPS,
};
/**
--
2.20.1
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
^ permalink raw reply related [flat|nested] 9+ messages in thread
* [Intel-gfx] [PATCH] drm/i915/dp: Add dpcd link_rate quirk for Apple 15" MBP 2017
@ 2020-02-29 5:41 ` Mario Kleiner
0 siblings, 0 replies; 9+ messages in thread
From: Mario Kleiner @ 2020-02-29 5:41 UTC (permalink / raw)
To: intel-gfx, dri-devel; +Cc: Jani Nikula
This fixes a problem found on the MacBookPro 2017 Retina panel.
The panel reports 10 bpc color depth in its EDID, and the
firmware chooses link settings at boot which support enough
bandwidth for 10 bpc (324000 kbit/sec = multiplier 0xc),
but the DP_MAX_LINK_RATE dpcd register only reports
2.7 Gbps (multiplier value 0xa) as possible, in direct
contradiction of what the firmware successfully set up.
This restricts the panel to 8 bpc, not providing the full
color depth of the panel.
This patch adds a quirk specific to the MBP 2017 15" Retina
panel to add the additiional 324000 kbps link rate during
edp setup.
Link to previous discussion of a different attempted fix
with Ville and Jani:
https://patchwork.kernel.org/patch/11325935/
Signed-off-by: Mario Kleiner <mario.kleiner.de@gmail.com>
Cc: Ville Syrjälä <ville.syrjala@linux.intel.com>
Cc: Jani Nikula <jani.nikula@intel.com>
---
drivers/gpu/drm/drm_dp_helper.c | 2 ++
drivers/gpu/drm/i915/display/intel_dp.c | 7 +++++++
include/drm/drm_dp_helper.h | 7 +++++++
3 files changed, 16 insertions(+)
diff --git a/drivers/gpu/drm/drm_dp_helper.c b/drivers/gpu/drm/drm_dp_helper.c
index 5a103e9b3c86..36a371c016cb 100644
--- a/drivers/gpu/drm/drm_dp_helper.c
+++ b/drivers/gpu/drm/drm_dp_helper.c
@@ -1179,6 +1179,8 @@ static const struct dpcd_quirk dpcd_quirk_list[] = {
{ OUI(0x00, 0x00, 0x00), DEVICE_ID('C', 'H', '7', '5', '1', '1'), false, BIT(DP_DPCD_QUIRK_NO_SINK_COUNT) },
/* Synaptics DP1.4 MST hubs can support DSC without virtual DPCD */
{ OUI(0x90, 0xCC, 0x24), DEVICE_ID_ANY, true, BIT(DP_DPCD_QUIRK_DSC_WITHOUT_VIRTUAL_DPCD) },
+ /* Apple MacBookPro 2017 15 inch eDP Retina panel reports too low DP_MAX_LINK_RATE */
+ { OUI(0x00, 0x10, 0xfa), DEVICE_ID(101, 68, 21, 101, 98, 97), false, BIT(DP_DPCD_QUIRK_CAN_DO_MAX_LINK_RATE_3_24_GBPS) },
};
#undef OUI
diff --git a/drivers/gpu/drm/i915/display/intel_dp.c b/drivers/gpu/drm/i915/display/intel_dp.c
index 4074d83b1a5f..1f6bd659ad41 100644
--- a/drivers/gpu/drm/i915/display/intel_dp.c
+++ b/drivers/gpu/drm/i915/display/intel_dp.c
@@ -178,6 +178,13 @@ static void intel_dp_set_sink_rates(struct intel_dp *intel_dp)
}
intel_dp->num_sink_rates = i;
+
+ if (drm_dp_has_quirk(&intel_dp->desc,
+ DP_DPCD_QUIRK_CAN_DO_MAX_LINK_RATE_3_24_GBPS)) {
+ /* Needed for Apple MBP 2017, 15 inch eDP Retina panel */
+ intel_dp->sink_rates[i] = 324000;
+ intel_dp->num_sink_rates++;
+ }
}
/* Get length of rates array potentially limited by max_rate. */
diff --git a/include/drm/drm_dp_helper.h b/include/drm/drm_dp_helper.h
index 262faf9e5e94..4b86a1f2a559 100644
--- a/include/drm/drm_dp_helper.h
+++ b/include/drm/drm_dp_helper.h
@@ -1532,6 +1532,13 @@ enum drm_dp_quirk {
* The DSC caps can be read from the physical aux instead.
*/
DP_DPCD_QUIRK_DSC_WITHOUT_VIRTUAL_DPCD,
+ /**
+ * @DP_DPCD_QUIRK_CAN_DO_MAX_LINK_RATE_3_24_GBPS:
+ *
+ * The device supports a link rate of 3.24 Gbps (multiplier 0xc) despite
+ * the DP_MAX_LINK_RATE register reporting a lower max multiplier.
+ */
+ DP_DPCD_QUIRK_CAN_DO_MAX_LINK_RATE_3_24_GBPS,
};
/**
--
2.20.1
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply related [flat|nested] 9+ messages in thread
* [Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for drm/i915/dp: Add dpcd link_rate quirk for Apple 15" MBP 2017
2020-02-29 5:41 ` [Intel-gfx] " Mario Kleiner
(?)
@ 2020-02-29 5:49 ` Patchwork
-1 siblings, 0 replies; 9+ messages in thread
From: Patchwork @ 2020-02-29 5:49 UTC (permalink / raw)
To: Mario Kleiner; +Cc: intel-gfx
== Series Details ==
Series: drm/i915/dp: Add dpcd link_rate quirk for Apple 15" MBP 2017
URL : https://patchwork.freedesktop.org/series/74100/
State : warning
== Summary ==
$ dim checkpatch origin/drm-tip
983ed114d770 drm/i915/dp: Add dpcd link_rate quirk for Apple 15" MBP 2017
-:43: WARNING:LONG_LINE: line over 100 characters
#43: FILE: drivers/gpu/drm/drm_dp_helper.c:1242:
+ { OUI(0x00, 0x10, 0xfa), DEVICE_ID(101, 68, 21, 101, 98, 97), false, BIT(DP_DPCD_QUIRK_CAN_DO_MAX_LINK_RATE_3_24_GBPS) },
-:57: CHECK:PARENTHESIS_ALIGNMENT: Alignment should match open parenthesis
#57: FILE: drivers/gpu/drm/i915/display/intel_dp.c:178:
+ if (drm_dp_has_quirk(&intel_dp->desc,
+ DP_DPCD_QUIRK_CAN_DO_MAX_LINK_RATE_3_24_GBPS)) {
total: 0 errors, 1 warnings, 1 checks, 34 lines checked
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 9+ messages in thread
* [Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915/dp: Add dpcd link_rate quirk for Apple 15" MBP 2017
2020-02-29 5:41 ` [Intel-gfx] " Mario Kleiner
(?)
(?)
@ 2020-02-29 6:14 ` Patchwork
-1 siblings, 0 replies; 9+ messages in thread
From: Patchwork @ 2020-02-29 6:14 UTC (permalink / raw)
To: Mario Kleiner; +Cc: intel-gfx
== Series Details ==
Series: drm/i915/dp: Add dpcd link_rate quirk for Apple 15" MBP 2017
URL : https://patchwork.freedesktop.org/series/74100/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_8035 -> Patchwork_16772
====================================================
Summary
-------
**SUCCESS**
No regressions found.
External URL: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16772/index.html
Known issues
------------
Here are the changes found in Patchwork_16772 that come from known issues:
### IGT changes ###
#### Issues hit ####
* igt@gem_flink_basic@basic:
- fi-tgl-y: [PASS][1] -> [DMESG-WARN][2] ([CI#94] / [i915#402]) +1 similar issue
[1]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8035/fi-tgl-y/igt@gem_flink_basic@basic.html
[2]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16772/fi-tgl-y/igt@gem_flink_basic@basic.html
* igt@i915_selftest@live@gem_contexts:
- fi-cml-s: [PASS][3] -> [DMESG-FAIL][4] ([i915#877])
[3]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8035/fi-cml-s/igt@i915_selftest@live@gem_contexts.html
[4]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16772/fi-cml-s/igt@i915_selftest@live@gem_contexts.html
#### Possible fixes ####
* igt@gem_exec_suspend@basic-s4-devices:
- fi-tgl-y: [FAIL][5] ([CI#94]) -> [PASS][6]
[5]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8035/fi-tgl-y/igt@gem_exec_suspend@basic-s4-devices.html
[6]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16772/fi-tgl-y/igt@gem_exec_suspend@basic-s4-devices.html
* igt@gem_mmap_gtt@basic:
- fi-tgl-y: [DMESG-WARN][7] ([CI#94] / [i915#402]) -> [PASS][8] +1 similar issue
[7]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8035/fi-tgl-y/igt@gem_mmap_gtt@basic.html
[8]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16772/fi-tgl-y/igt@gem_mmap_gtt@basic.html
* igt@i915_selftest@live@gem_contexts:
- fi-cfl-8700k: [INCOMPLETE][9] ([i915#424]) -> [PASS][10]
[9]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8035/fi-cfl-8700k/igt@i915_selftest@live@gem_contexts.html
[10]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16772/fi-cfl-8700k/igt@i915_selftest@live@gem_contexts.html
* igt@i915_selftest@live@gt_heartbeat:
- fi-bxt-dsi: [DMESG-FAIL][11] ([i915#541]) -> [PASS][12]
[11]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8035/fi-bxt-dsi/igt@i915_selftest@live@gt_heartbeat.html
[12]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16772/fi-bxt-dsi/igt@i915_selftest@live@gt_heartbeat.html
#### Warnings ####
* igt@kms_chamelium@hdmi-hpd-fast:
- fi-kbl-7500u: [FAIL][13] ([fdo#111407]) -> [FAIL][14] ([fdo#111096] / [i915#323])
[13]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8035/fi-kbl-7500u/igt@kms_chamelium@hdmi-hpd-fast.html
[14]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16772/fi-kbl-7500u/igt@kms_chamelium@hdmi-hpd-fast.html
{name}: This element is suppressed. This means it is ignored when computing
the status of the difference (SUCCESS, WARNING, or FAILURE).
[CI#94]: https://gitlab.freedesktop.org/gfx-ci/i915-infra/issues/94
[fdo#111096]: https://bugs.freedesktop.org/show_bug.cgi?id=111096
[fdo#111407]: https://bugs.freedesktop.org/show_bug.cgi?id=111407
[i915#323]: https://gitlab.freedesktop.org/drm/intel/issues/323
[i915#402]: https://gitlab.freedesktop.org/drm/intel/issues/402
[i915#424]: https://gitlab.freedesktop.org/drm/intel/issues/424
[i915#541]: https://gitlab.freedesktop.org/drm/intel/issues/541
[i915#877]: https://gitlab.freedesktop.org/drm/intel/issues/877
[i915#998]: https://gitlab.freedesktop.org/drm/intel/issues/998
Participating hosts (48 -> 36)
------------------------------
Additional (3): fi-cfl-8109u fi-bwr-2160 fi-kbl-r
Missing (15): fi-tgl-dsi fi-bsw-n3050 fi-glk-dsi fi-byt-squawks fi-bsw-cyan fi-snb-2520m fi-ilk-650 fi-ctg-p8600 fi-gdg-551 fi-skl-lmem fi-bdw-samus fi-byt-clapper fi-bsw-nick fi-skl-6600u fi-snb-2600
Build changes
-------------
* CI: CI-20190529 -> None
* Linux: CI_DRM_8035 -> Patchwork_16772
CI-20190529: 20190529
CI_DRM_8035: cacad502dcd40516c6a9be38ca3ef0c1288f4cf4 @ git://anongit.freedesktop.org/gfx-ci/linux
IGT_5477: 3fe5828f45fc533ba4d9ee84dbb5aea320ce61bc @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools
Patchwork_16772: 983ed114d770b6d3f542ca959c02450ff64faf9d @ git://anongit.freedesktop.org/gfx-ci/linux
== Linux commits ==
983ed114d770 drm/i915/dp: Add dpcd link_rate quirk for Apple 15" MBP 2017
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16772/index.html
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 9+ messages in thread
* [Intel-gfx] ✗ Fi.CI.IGT: failure for drm/i915/dp: Add dpcd link_rate quirk for Apple 15" MBP 2017
2020-02-29 5:41 ` [Intel-gfx] " Mario Kleiner
` (2 preceding siblings ...)
(?)
@ 2020-03-02 1:45 ` Patchwork
-1 siblings, 0 replies; 9+ messages in thread
From: Patchwork @ 2020-03-02 1:45 UTC (permalink / raw)
To: Mario Kleiner; +Cc: intel-gfx
== Series Details ==
Series: drm/i915/dp: Add dpcd link_rate quirk for Apple 15" MBP 2017
URL : https://patchwork.freedesktop.org/series/74100/
State : failure
== Summary ==
CI Bug Log - changes from CI_DRM_8035_full -> Patchwork_16772_full
====================================================
Summary
-------
**FAILURE**
Serious unknown changes coming with Patchwork_16772_full absolutely need to be
verified manually.
If you think the reported changes have nothing to do with the changes
introduced in Patchwork_16772_full, please notify your bug team to allow them
to document this new failure mode, which will reduce false positives in CI.
Possible new issues
-------------------
Here are the unknown changes that may have been introduced in Patchwork_16772_full:
### IGT changes ###
#### Possible regressions ####
* igt@kms_cursor_legacy@cursor-vs-flip-atomic-transitions:
- shard-hsw: [PASS][1] -> [TIMEOUT][2] +1 similar issue
[1]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8035/shard-hsw5/igt@kms_cursor_legacy@cursor-vs-flip-atomic-transitions.html
[2]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16772/shard-hsw4/igt@kms_cursor_legacy@cursor-vs-flip-atomic-transitions.html
#### Warnings ####
* igt@kms_chamelium@dp-audio-edid:
- shard-hsw: [SKIP][3] ([fdo#109271] / [fdo#111827]) -> [TIMEOUT][4]
[3]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8035/shard-hsw5/igt@kms_chamelium@dp-audio-edid.html
[4]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16772/shard-hsw4/igt@kms_chamelium@dp-audio-edid.html
* igt@kms_psr@primary_blt:
- shard-hsw: [SKIP][5] ([fdo#109271]) -> [TIMEOUT][6]
[5]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8035/shard-hsw5/igt@kms_psr@primary_blt.html
[6]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16772/shard-hsw4/igt@kms_psr@primary_blt.html
#### Suppressed ####
The following results come from untrusted machines, tests, or statuses.
They do not affect the overall result.
* {igt@perf@stress-open-close}:
- shard-hsw: [PASS][7] -> [TIMEOUT][8]
[7]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8035/shard-hsw5/igt@perf@stress-open-close.html
[8]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16772/shard-hsw4/igt@perf@stress-open-close.html
- shard-skl: [PASS][9] -> [INCOMPLETE][10]
[9]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8035/shard-skl1/igt@perf@stress-open-close.html
[10]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16772/shard-skl3/igt@perf@stress-open-close.html
Known issues
------------
Here are the changes found in Patchwork_16772_full that come from known issues:
### IGT changes ###
#### Issues hit ####
* igt@gem_eio@wait-immediate:
- shard-hsw: [PASS][11] -> [TIMEOUT][12] ([i915#1084])
[11]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8035/shard-hsw5/igt@gem_eio@wait-immediate.html
[12]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16772/shard-hsw4/igt@gem_eio@wait-immediate.html
* igt@gem_exec_balancer@hang:
- shard-tglb: [PASS][13] -> [FAIL][14] ([i915#1277])
[13]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8035/shard-tglb5/igt@gem_exec_balancer@hang.html
[14]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16772/shard-tglb2/igt@gem_exec_balancer@hang.html
* igt@gem_exec_schedule@implicit-write-read-bsd1:
- shard-iclb: [PASS][15] -> [SKIP][16] ([fdo#109276] / [i915#677]) +1 similar issue
[15]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8035/shard-iclb4/igt@gem_exec_schedule@implicit-write-read-bsd1.html
[16]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16772/shard-iclb5/igt@gem_exec_schedule@implicit-write-read-bsd1.html
* igt@gem_exec_schedule@out-order-bsd2:
- shard-iclb: [PASS][17] -> [SKIP][18] ([fdo#109276]) +15 similar issues
[17]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8035/shard-iclb1/igt@gem_exec_schedule@out-order-bsd2.html
[18]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16772/shard-iclb5/igt@gem_exec_schedule@out-order-bsd2.html
* igt@gem_exec_schedule@pi-shared-iova-bsd:
- shard-iclb: [PASS][19] -> [SKIP][20] ([i915#677]) +1 similar issue
[19]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8035/shard-iclb7/igt@gem_exec_schedule@pi-shared-iova-bsd.html
[20]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16772/shard-iclb2/igt@gem_exec_schedule@pi-shared-iova-bsd.html
* igt@gem_exec_schedule@preempt-self-bsd:
- shard-iclb: [PASS][21] -> [SKIP][22] ([fdo#112146])
[21]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8035/shard-iclb5/igt@gem_exec_schedule@preempt-self-bsd.html
[22]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16772/shard-iclb1/igt@gem_exec_schedule@preempt-self-bsd.html
* igt@gem_exec_store@cachelines-vcs1:
- shard-iclb: [PASS][23] -> [SKIP][24] ([fdo#112080]) +7 similar issues
[23]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8035/shard-iclb1/igt@gem_exec_store@cachelines-vcs1.html
[24]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16772/shard-iclb8/igt@gem_exec_store@cachelines-vcs1.html
* igt@gem_ppgtt@flink-and-close-vma-leak:
- shard-glk: [PASS][25] -> [FAIL][26] ([i915#644])
[25]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8035/shard-glk9/igt@gem_ppgtt@flink-and-close-vma-leak.html
[26]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16772/shard-glk4/igt@gem_ppgtt@flink-and-close-vma-leak.html
- shard-tglb: [PASS][27] -> [FAIL][28] ([i915#644])
[27]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8035/shard-tglb1/igt@gem_ppgtt@flink-and-close-vma-leak.html
[28]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16772/shard-tglb5/igt@gem_ppgtt@flink-and-close-vma-leak.html
- shard-iclb: [PASS][29] -> [FAIL][30] ([i915#644])
[29]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8035/shard-iclb8/igt@gem_ppgtt@flink-and-close-vma-leak.html
[30]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16772/shard-iclb5/igt@gem_ppgtt@flink-and-close-vma-leak.html
* igt@i915_pm_rps@reset:
- shard-iclb: [PASS][31] -> [FAIL][32] ([i915#413])
[31]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8035/shard-iclb2/igt@i915_pm_rps@reset.html
[32]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16772/shard-iclb4/igt@i915_pm_rps@reset.html
* igt@kms_busy@extended-modeset-hang-newfb-with-reset-render-pipe-a:
- shard-kbl: [PASS][33] -> [DMESG-WARN][34] ([i915#56] / [i915#62] / [i915#92]) +10 similar issues
[33]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8035/shard-kbl3/igt@kms_busy@extended-modeset-hang-newfb-with-reset-render-pipe-a.html
[34]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16772/shard-kbl2/igt@kms_busy@extended-modeset-hang-newfb-with-reset-render-pipe-a.html
* igt@kms_cursor_crc@pipe-c-cursor-256x256-random:
- shard-kbl: [PASS][35] -> [DMESG-WARN][36] ([i915#62] / [i915#92]) +11 similar issues
[35]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8035/shard-kbl7/igt@kms_cursor_crc@pipe-c-cursor-256x256-random.html
[36]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16772/shard-kbl2/igt@kms_cursor_crc@pipe-c-cursor-256x256-random.html
* igt@kms_cursor_crc@pipe-c-cursor-256x85-onscreen:
- shard-skl: [PASS][37] -> [FAIL][38] ([i915#54])
[37]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8035/shard-skl10/igt@kms_cursor_crc@pipe-c-cursor-256x85-onscreen.html
[38]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16772/shard-skl3/igt@kms_cursor_crc@pipe-c-cursor-256x85-onscreen.html
* igt@kms_cursor_crc@pipe-c-cursor-64x21-sliding:
- shard-apl: [PASS][39] -> [FAIL][40] ([i915#54])
[39]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8035/shard-apl7/igt@kms_cursor_crc@pipe-c-cursor-64x21-sliding.html
[40]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16772/shard-apl8/igt@kms_cursor_crc@pipe-c-cursor-64x21-sliding.html
* igt@kms_fbcon_fbt@fbc-suspend:
- shard-kbl: [PASS][41] -> [DMESG-WARN][42] ([i915#62] / [i915#74] / [i915#92])
[41]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8035/shard-kbl7/igt@kms_fbcon_fbt@fbc-suspend.html
[42]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16772/shard-kbl2/igt@kms_fbcon_fbt@fbc-suspend.html
* igt@kms_flip@flip-vs-expired-vblank-interruptible:
- shard-skl: [PASS][43] -> [FAIL][44] ([i915#79])
[43]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8035/shard-skl5/igt@kms_flip@flip-vs-expired-vblank-interruptible.html
[44]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16772/shard-skl5/igt@kms_flip@flip-vs-expired-vblank-interruptible.html
* igt@kms_flip@flip-vs-suspend-interruptible:
- shard-apl: [PASS][45] -> [DMESG-WARN][46] ([i915#180])
[45]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8035/shard-apl8/igt@kms_flip@flip-vs-suspend-interruptible.html
[46]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16772/shard-apl4/igt@kms_flip@flip-vs-suspend-interruptible.html
- shard-hsw: [PASS][47] -> [INCOMPLETE][48] ([i915#61])
[47]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8035/shard-hsw6/igt@kms_flip@flip-vs-suspend-interruptible.html
[48]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16772/shard-hsw4/igt@kms_flip@flip-vs-suspend-interruptible.html
* igt@kms_frontbuffer_tracking@fbc-1p-rte:
- shard-kbl: [PASS][49] -> [DMESG-WARN][50] ([i915#56] / [i915#62])
[49]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8035/shard-kbl3/igt@kms_frontbuffer_tracking@fbc-1p-rte.html
[50]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16772/shard-kbl2/igt@kms_frontbuffer_tracking@fbc-1p-rte.html
* igt@kms_hdr@bpc-switch-dpms:
- shard-skl: [PASS][51] -> [FAIL][52] ([i915#1188]) +2 similar issues
[51]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8035/shard-skl8/igt@kms_hdr@bpc-switch-dpms.html
[52]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16772/shard-skl7/igt@kms_hdr@bpc-switch-dpms.html
* igt@kms_pipe_crc_basic@suspend-read-crc-pipe-a:
- shard-kbl: [PASS][53] -> [DMESG-WARN][54] ([i915#180]) +2 similar issues
[53]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8035/shard-kbl2/igt@kms_pipe_crc_basic@suspend-read-crc-pipe-a.html
[54]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16772/shard-kbl3/igt@kms_pipe_crc_basic@suspend-read-crc-pipe-a.html
* igt@kms_plane@pixel-format-pipe-b-planes-source-clamping:
- shard-hsw: [PASS][55] -> [DMESG-FAIL][56] ([IGT#6])
[55]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8035/shard-hsw7/igt@kms_plane@pixel-format-pipe-b-planes-source-clamping.html
[56]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16772/shard-hsw5/igt@kms_plane@pixel-format-pipe-b-planes-source-clamping.html
* igt@kms_plane_alpha_blend@pipe-c-constant-alpha-min:
- shard-skl: [PASS][57] -> [FAIL][58] ([fdo#108145])
[57]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8035/shard-skl10/igt@kms_plane_alpha_blend@pipe-c-constant-alpha-min.html
[58]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16772/shard-skl3/igt@kms_plane_alpha_blend@pipe-c-constant-alpha-min.html
* igt@kms_plane_alpha_blend@pipe-c-coverage-7efc:
- shard-skl: [PASS][59] -> [FAIL][60] ([fdo#108145] / [i915#265]) +1 similar issue
[59]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8035/shard-skl9/igt@kms_plane_alpha_blend@pipe-c-coverage-7efc.html
[60]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16772/shard-skl8/igt@kms_plane_alpha_blend@pipe-c-coverage-7efc.html
* igt@kms_plane_lowres@pipe-a-tiling-x:
- shard-glk: [PASS][61] -> [FAIL][62] ([i915#899])
[61]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8035/shard-glk6/igt@kms_plane_lowres@pipe-a-tiling-x.html
[62]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16772/shard-glk3/igt@kms_plane_lowres@pipe-a-tiling-x.html
* igt@kms_psr@psr2_cursor_render:
- shard-iclb: [PASS][63] -> [SKIP][64] ([fdo#109441]) +3 similar issues
[63]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8035/shard-iclb2/igt@kms_psr@psr2_cursor_render.html
[64]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16772/shard-iclb4/igt@kms_psr@psr2_cursor_render.html
#### Possible fixes ####
* igt@gem_busy@busy-vcs1:
- shard-iclb: [SKIP][65] ([fdo#112080]) -> [PASS][66] +12 similar issues
[65]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8035/shard-iclb5/igt@gem_busy@busy-vcs1.html
[66]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16772/shard-iclb1/igt@gem_busy@busy-vcs1.html
* igt@gem_ctx_persistence@legacy-engines-mixed-process@blt:
- shard-tglb: [FAIL][67] ([i915#679]) -> [PASS][68]
[67]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8035/shard-tglb8/igt@gem_ctx_persistence@legacy-engines-mixed-process@blt.html
[68]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16772/shard-tglb8/igt@gem_ctx_persistence@legacy-engines-mixed-process@blt.html
* igt@gem_ctx_persistence@legacy-engines-mixed-process@bsd:
- shard-skl: [FAIL][69] ([i915#679]) -> [PASS][70]
[69]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8035/shard-skl7/igt@gem_ctx_persistence@legacy-engines-mixed-process@bsd.html
[70]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16772/shard-skl1/igt@gem_ctx_persistence@legacy-engines-mixed-process@bsd.html
* igt@gem_ctx_persistence@legacy-engines-mixed-process@bsd1:
- shard-skl: [INCOMPLETE][71] ([i915#1239]) -> [PASS][72]
[71]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8035/shard-skl7/igt@gem_ctx_persistence@legacy-engines-mixed-process@bsd1.html
[72]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16772/shard-skl1/igt@gem_ctx_persistence@legacy-engines-mixed-process@bsd1.html
* igt@gem_ctx_persistence@legacy-engines-mixed-process@vebox:
- shard-tglb: [INCOMPLETE][73] ([i915#1239]) -> [PASS][74]
[73]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8035/shard-tglb8/igt@gem_ctx_persistence@legacy-engines-mixed-process@vebox.html
[74]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16772/shard-tglb8/igt@gem_ctx_persistence@legacy-engines-mixed-process@vebox.html
* igt@gem_ctx_shared@exec-single-timeline-bsd:
- shard-iclb: [SKIP][75] ([fdo#110841]) -> [PASS][76]
[75]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8035/shard-iclb1/igt@gem_ctx_shared@exec-single-timeline-bsd.html
[76]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16772/shard-iclb6/igt@gem_ctx_shared@exec-single-timeline-bsd.html
* igt@gem_exec_schedule@fifo-bsd1:
- shard-iclb: [SKIP][77] ([fdo#109276]) -> [PASS][78] +13 similar issues
[77]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8035/shard-iclb6/igt@gem_exec_schedule@fifo-bsd1.html
[78]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16772/shard-iclb2/igt@gem_exec_schedule@fifo-bsd1.html
* igt@gem_exec_schedule@implicit-both-bsd2:
- shard-iclb: [SKIP][79] ([fdo#109276] / [i915#677]) -> [PASS][80]
[79]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8035/shard-iclb5/igt@gem_exec_schedule@implicit-both-bsd2.html
[80]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16772/shard-iclb1/igt@gem_exec_schedule@implicit-both-bsd2.html
* igt@gem_exec_schedule@pi-userfault-bsd:
- shard-iclb: [SKIP][81] ([i915#677]) -> [PASS][82]
[81]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8035/shard-iclb1/igt@gem_exec_schedule@pi-userfault-bsd.html
[82]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16772/shard-iclb5/igt@gem_exec_schedule@pi-userfault-bsd.html
* igt@gem_exec_schedule@preempt-hang-bsd:
- shard-iclb: [SKIP][83] ([fdo#112146]) -> [PASS][84] +2 similar issues
[83]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8035/shard-iclb4/igt@gem_exec_schedule@preempt-hang-bsd.html
[84]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16772/shard-iclb5/igt@gem_exec_schedule@preempt-hang-bsd.html
* igt@gem_exec_whisper@basic-fds-forked:
- shard-iclb: [INCOMPLETE][85] -> [PASS][86]
[85]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8035/shard-iclb4/igt@gem_exec_whisper@basic-fds-forked.html
[86]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16772/shard-iclb2/igt@gem_exec_whisper@basic-fds-forked.html
* igt@gem_ppgtt@flink-and-close-vma-leak:
- shard-apl: [FAIL][87] ([i915#644]) -> [PASS][88]
[87]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8035/shard-apl2/igt@gem_ppgtt@flink-and-close-vma-leak.html
[88]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16772/shard-apl7/igt@gem_ppgtt@flink-and-close-vma-leak.html
* igt@gem_workarounds@suspend-resume-context:
- shard-apl: [DMESG-WARN][89] ([i915#180]) -> [PASS][90] +5 similar issues
[89]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8035/shard-apl1/igt@gem_workarounds@suspend-resume-context.html
[90]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16772/shard-apl1/igt@gem_workarounds@suspend-resume-context.html
* igt@i915_pm_rpm@modeset-stress-extra-wait:
- shard-glk: [DMESG-WARN][91] ([i915#118] / [i915#95]) -> [PASS][92]
[91]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8035/shard-glk8/igt@i915_pm_rpm@modeset-stress-extra-wait.html
[92]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16772/shard-glk5/igt@i915_pm_rpm@modeset-stress-extra-wait.html
* igt@kms_cursor_crc@pipe-a-cursor-suspend:
- shard-kbl: [DMESG-WARN][93] ([i915#180]) -> [PASS][94] +7 similar issues
[93]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8035/shard-kbl6/igt@kms_cursor_crc@pipe-a-cursor-suspend.html
[94]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16772/shard-kbl1/igt@kms_cursor_crc@pipe-a-cursor-suspend.html
* igt@kms_cursor_legacy@flip-vs-cursor-atomic-transitions:
- shard-skl: [FAIL][95] ([IGT#5]) -> [PASS][96]
[95]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8035/shard-skl1/igt@kms_cursor_legacy@flip-vs-cursor-atomic-transitions.html
[96]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16772/shard-skl3/igt@kms_cursor_legacy@flip-vs-cursor-atomic-transitions.html
* igt@kms_flip@flip-vs-suspend-interruptible:
- shard-skl: [INCOMPLETE][97] ([i915#221]) -> [PASS][98]
[97]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8035/shard-skl6/igt@kms_flip@flip-vs-suspend-interruptible.html
[98]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16772/shard-skl10/igt@kms_flip@flip-vs-suspend-interruptible.html
* igt@kms_flip@plain-flip-fb-recreate-interruptible:
- shard-glk: [FAIL][99] ([i915#34]) -> [PASS][100]
[99]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8035/shard-glk9/igt@kms_flip@plain-flip-fb-recreate-interruptible.html
[100]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16772/shard-glk4/igt@kms_flip@plain-flip-fb-recreate-interruptible.html
* igt@kms_frontbuffer_tracking@psr-1p-primscrn-spr-indfb-draw-blt:
- shard-tglb: [SKIP][101] ([i915#668]) -> [PASS][102] +4 similar issues
[101]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8035/shard-tglb3/igt@kms_frontbuffer_tracking@psr-1p-primscrn-spr-indfb-draw-blt.html
[102]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16772/shard-tglb3/igt@kms_frontbuffer_tracking@psr-1p-primscrn-spr-indfb-draw-blt.html
* igt@kms_plane_multiple@atomic-pipe-b-tiling-y:
- shard-skl: [DMESG-WARN][103] ([IGT#6]) -> [PASS][104]
[103]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8035/shard-skl6/igt@kms_plane_multiple@atomic-pipe-b-tiling-y.html
[104]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16772/shard-skl10/igt@kms_plane_multiple@atomic-pipe-b-tiling-y.html
* igt@kms_psr@psr2_sprite_mmap_cpu:
- shard-iclb: [SKIP][105] ([fdo#109441]) -> [PASS][106]
[105]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8035/shard-iclb7/igt@kms_psr@psr2_sprite_mmap_cpu.html
[106]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16772/shard-iclb2/igt@kms_psr@psr2_sprite_mmap_cpu.html
#### Warnings ####
* igt@gem_exec_schedule@pi-common-vebox:
- shard-hsw: [SKIP][107] ([fdo#109271]) -> [TIMEOUT][108] ([i915#1084])
[107]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8035/shard-hsw5/igt@gem_exec_schedule@pi-common-vebox.html
[108]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16772/shard-hsw4/igt@gem_exec_schedule@pi-common-vebox.html
* igt@i915_pm_rpm@debugfs-forcewake-user:
- shard-snb: [SKIP][109] ([fdo#109271]) -> [INCOMPLETE][110] ([i915#82])
[109]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8035/shard-snb6/igt@i915_pm_rpm@debugfs-forcewake-user.html
[110]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16772/shard-snb4/igt@i915_pm_rpm@debugfs-forcewake-user.html
* igt@kms_dp_dsc@basic-dsc-enable-edp:
- shard-iclb: [DMESG-WARN][111] ([i915#1226]) -> [SKIP][112] ([fdo#109349])
[111]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8035/shard-iclb2/igt@kms_dp_dsc@basic-dsc-enable-edp.html
[112]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16772/shard-iclb4/igt@kms_dp_dsc@basic-dsc-enable-edp.html
{name}: This element is suppressed. This means it is ignored when computing
the status of the difference (SUCCESS, WARNING, or FAILURE).
[IGT#5]: https://gitlab.freedesktop.org/drm/igt-gpu-tools/issues/5
[IGT#6]: https://gitlab.freedesktop.org/drm/igt-gpu-tools/issues/6
[fdo#108145]: https://bugs.freedesktop.org/show_bug.cgi?id=108145
[fdo#109271]: https://bugs.freedesktop.org/show_bug.cgi?id=109271
[fdo#109276]: https://bugs.freedesktop.org/show_bug.cgi?id=109276
[fdo#109349]: https://bugs.freedesktop.org/show_bug.cgi?id=109349
[fdo#109441]: https://bugs.freedesktop.org/show_bug.cgi?id=109441
[fdo#110841]: https://bugs.freedesktop.org/show_bug.cgi?id=110841
[fdo#111827]: https://bugs.freedesktop.org/show_bug.cgi?id=111827
[fdo#112080]: https://bugs.freedesktop.org/show_bug.cgi?id=112080
[fdo#112146]: https://bugs.freedesktop.org/show_bug.cgi?id=112146
[i915#1084]: https://gitlab.freedesktop.org/drm/intel/issues/1084
[i915#118]: https://gitlab.freedesktop.org/drm/intel/issues/118
[i915#1188]: https://gitlab.freedesktop.org/drm/intel/issues/1188
[i915#1226]: https://gitlab.freedesktop.org/drm/intel/issues/1226
[i915#1239]: https://gitlab.freedesktop.org/drm/intel/issues/1239
[i915#1277]: https://gitlab.freedesktop.org/drm/intel/issues/1277
[i915#180]: https://gitlab.freedesktop.org/drm/intel/issues/180
[i915#221]: https://gitlab.freedesktop.org/drm/intel/issues/221
[i915#265]: https://gitlab.freedesktop.org/drm/intel/issues/265
[i915#34]: https://gitlab.freedesktop.org/drm/intel/issues/34
[i915#413]: https://gitlab.freedesktop.org/drm/intel/issues/413
[i915#54]: https://gitlab.freedesktop.org/drm/intel/issues/54
[i915#56]: https://gitlab.freedesktop.org/drm/intel/issues/56
[i915#58]: https://gitlab.freedesktop.org/drm/intel/issues/58
[i915#61]: https://gitlab.freedesktop.org/drm/intel/issues/61
[i915#62]: https://gitlab.freedesktop.org/drm/intel/issues/62
[i915#644]: https://gitlab.freedesktop.org/drm/intel/issues/644
[i915#668]: https://gitlab.freedesktop.org/drm/intel/issues/668
[i915#677]: https://gitlab.freedesktop.org/drm/intel/issues/677
[i915#679]: https://gitlab.freedesktop.org/drm/intel/issues/679
[i915#74]: https://gitlab.freedesktop.org/drm/intel/issues/74
[i915#79]: https://gitlab.freedesktop.org/drm/intel/issues/79
[i915#82]: https://gitlab.freedesktop.org/drm/intel/issues/82
[i915#899]: https://gitlab.freedesktop.org/drm/intel/issues/899
[i915#92]: https://gitlab.freedesktop.org/drm/intel/issues/92
[i915#95]: https://gitlab.freedesktop.org/drm/intel/issues/95
[k.org#198133]: https://bugzilla.kernel.org/show_bug.cgi?id=198133
Participating hosts (10 -> 10)
------------------------------
No changes in participating hosts
Build changes
-------------
* CI: CI-20190529 -> None
* Linux: CI_DRM_8035 -> Patchwork_16772
CI-20190529: 20190529
CI_DRM_8035: cacad502dcd40516c6a9be38ca3ef0c1288f4cf4 @ git://anongit.freedesktop.org/gfx-ci/linux
IGT_5477: 3fe5828f45fc533ba4d9ee84dbb5aea320ce61bc @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools
Patchwork_16772: 983ed114d770b6d3f542ca959c02450ff64faf9d @ git://anongit.freedesktop.org/gfx-ci/linux
piglit_4509: fdc5a4ca11124ab8413c7988896eec4c97336694 @ git://anongit.freedesktop.org/piglit
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16772/index.html
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH] drm/i915/dp: Add dpcd link_rate quirk for Apple 15" MBP 2017
2020-02-29 5:41 ` [Intel-gfx] " Mario Kleiner
@ 2020-03-04 15:32 ` Jani Nikula
-1 siblings, 0 replies; 9+ messages in thread
From: Jani Nikula @ 2020-03-04 15:32 UTC (permalink / raw)
To: Mario Kleiner, intel-gfx, dri-devel
On Sat, 29 Feb 2020, Mario Kleiner <mario.kleiner.de@gmail.com> wrote:
> This fixes a problem found on the MacBookPro 2017 Retina panel.
>
> The panel reports 10 bpc color depth in its EDID, and the
> firmware chooses link settings at boot which support enough
> bandwidth for 10 bpc (324000 kbit/sec = multiplier 0xc),
> but the DP_MAX_LINK_RATE dpcd register only reports
> 2.7 Gbps (multiplier value 0xa) as possible, in direct
> contradiction of what the firmware successfully set up.
>
> This restricts the panel to 8 bpc, not providing the full
> color depth of the panel.
>
> This patch adds a quirk specific to the MBP 2017 15" Retina
> panel to add the additiional 324000 kbps link rate during
> edp setup.
>
> Link to previous discussion of a different attempted fix
> with Ville and Jani:
>
> https://patchwork.kernel.org/patch/11325935/
>
> Signed-off-by: Mario Kleiner <mario.kleiner.de@gmail.com>
> Cc: Ville Syrjälä <ville.syrjala@linux.intel.com>
> Cc: Jani Nikula <jani.nikula@intel.com>
> ---
> drivers/gpu/drm/drm_dp_helper.c | 2 ++
> drivers/gpu/drm/i915/display/intel_dp.c | 7 +++++++
> include/drm/drm_dp_helper.h | 7 +++++++
> 3 files changed, 16 insertions(+)
>
> diff --git a/drivers/gpu/drm/drm_dp_helper.c b/drivers/gpu/drm/drm_dp_helper.c
> index 5a103e9b3c86..36a371c016cb 100644
> --- a/drivers/gpu/drm/drm_dp_helper.c
> +++ b/drivers/gpu/drm/drm_dp_helper.c
> @@ -1179,6 +1179,8 @@ static const struct dpcd_quirk dpcd_quirk_list[] = {
> { OUI(0x00, 0x00, 0x00), DEVICE_ID('C', 'H', '7', '5', '1', '1'), false, BIT(DP_DPCD_QUIRK_NO_SINK_COUNT) },
> /* Synaptics DP1.4 MST hubs can support DSC without virtual DPCD */
> { OUI(0x90, 0xCC, 0x24), DEVICE_ID_ANY, true, BIT(DP_DPCD_QUIRK_DSC_WITHOUT_VIRTUAL_DPCD) },
> + /* Apple MacBookPro 2017 15 inch eDP Retina panel reports too low DP_MAX_LINK_RATE */
> + { OUI(0x00, 0x10, 0xfa), DEVICE_ID(101, 68, 21, 101, 98, 97), false, BIT(DP_DPCD_QUIRK_CAN_DO_MAX_LINK_RATE_3_24_GBPS) },
> };
>
> #undef OUI
> diff --git a/drivers/gpu/drm/i915/display/intel_dp.c b/drivers/gpu/drm/i915/display/intel_dp.c
> index 4074d83b1a5f..1f6bd659ad41 100644
> --- a/drivers/gpu/drm/i915/display/intel_dp.c
> +++ b/drivers/gpu/drm/i915/display/intel_dp.c
> @@ -178,6 +178,13 @@ static void intel_dp_set_sink_rates(struct intel_dp *intel_dp)
> }
>
> intel_dp->num_sink_rates = i;
> +
> + if (drm_dp_has_quirk(&intel_dp->desc,
> + DP_DPCD_QUIRK_CAN_DO_MAX_LINK_RATE_3_24_GBPS)) {
> + /* Needed for Apple MBP 2017, 15 inch eDP Retina panel */
> + intel_dp->sink_rates[i] = 324000;
> + intel_dp->num_sink_rates++;
> + }
If we can isolate the quirk to this one function, I'll be happy. \o/
However, even if this might work on said machine, I'd prefer it if we
didn't give the idea that you could just append a value in sink_rates
(it must be sorted). How about putting something like this in the
beginning of the function, to be a bit more explicit:
if (quirk) {
static const int quirk_rates[] = { 162000, 270000, 324000 };
memcpy(intel_dp->sink_rates, quirk_rates, sizeof(quirk_rates));
intel_dp->num_sink_rates = ARRAY_SIZE(quirk_rates);
return;
}
BR,
Jani.
> }
>
> /* Get length of rates array potentially limited by max_rate. */
> diff --git a/include/drm/drm_dp_helper.h b/include/drm/drm_dp_helper.h
> index 262faf9e5e94..4b86a1f2a559 100644
> --- a/include/drm/drm_dp_helper.h
> +++ b/include/drm/drm_dp_helper.h
> @@ -1532,6 +1532,13 @@ enum drm_dp_quirk {
> * The DSC caps can be read from the physical aux instead.
> */
> DP_DPCD_QUIRK_DSC_WITHOUT_VIRTUAL_DPCD,
> + /**
> + * @DP_DPCD_QUIRK_CAN_DO_MAX_LINK_RATE_3_24_GBPS:
> + *
> + * The device supports a link rate of 3.24 Gbps (multiplier 0xc) despite
> + * the DP_MAX_LINK_RATE register reporting a lower max multiplier.
> + */
> + DP_DPCD_QUIRK_CAN_DO_MAX_LINK_RATE_3_24_GBPS,
> };
>
> /**
--
Jani Nikula, Intel Open Source Graphics Center
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [Intel-gfx] [PATCH] drm/i915/dp: Add dpcd link_rate quirk for Apple 15" MBP 2017
@ 2020-03-04 15:32 ` Jani Nikula
0 siblings, 0 replies; 9+ messages in thread
From: Jani Nikula @ 2020-03-04 15:32 UTC (permalink / raw)
To: Mario Kleiner, intel-gfx, dri-devel
On Sat, 29 Feb 2020, Mario Kleiner <mario.kleiner.de@gmail.com> wrote:
> This fixes a problem found on the MacBookPro 2017 Retina panel.
>
> The panel reports 10 bpc color depth in its EDID, and the
> firmware chooses link settings at boot which support enough
> bandwidth for 10 bpc (324000 kbit/sec = multiplier 0xc),
> but the DP_MAX_LINK_RATE dpcd register only reports
> 2.7 Gbps (multiplier value 0xa) as possible, in direct
> contradiction of what the firmware successfully set up.
>
> This restricts the panel to 8 bpc, not providing the full
> color depth of the panel.
>
> This patch adds a quirk specific to the MBP 2017 15" Retina
> panel to add the additiional 324000 kbps link rate during
> edp setup.
>
> Link to previous discussion of a different attempted fix
> with Ville and Jani:
>
> https://patchwork.kernel.org/patch/11325935/
>
> Signed-off-by: Mario Kleiner <mario.kleiner.de@gmail.com>
> Cc: Ville Syrjälä <ville.syrjala@linux.intel.com>
> Cc: Jani Nikula <jani.nikula@intel.com>
> ---
> drivers/gpu/drm/drm_dp_helper.c | 2 ++
> drivers/gpu/drm/i915/display/intel_dp.c | 7 +++++++
> include/drm/drm_dp_helper.h | 7 +++++++
> 3 files changed, 16 insertions(+)
>
> diff --git a/drivers/gpu/drm/drm_dp_helper.c b/drivers/gpu/drm/drm_dp_helper.c
> index 5a103e9b3c86..36a371c016cb 100644
> --- a/drivers/gpu/drm/drm_dp_helper.c
> +++ b/drivers/gpu/drm/drm_dp_helper.c
> @@ -1179,6 +1179,8 @@ static const struct dpcd_quirk dpcd_quirk_list[] = {
> { OUI(0x00, 0x00, 0x00), DEVICE_ID('C', 'H', '7', '5', '1', '1'), false, BIT(DP_DPCD_QUIRK_NO_SINK_COUNT) },
> /* Synaptics DP1.4 MST hubs can support DSC without virtual DPCD */
> { OUI(0x90, 0xCC, 0x24), DEVICE_ID_ANY, true, BIT(DP_DPCD_QUIRK_DSC_WITHOUT_VIRTUAL_DPCD) },
> + /* Apple MacBookPro 2017 15 inch eDP Retina panel reports too low DP_MAX_LINK_RATE */
> + { OUI(0x00, 0x10, 0xfa), DEVICE_ID(101, 68, 21, 101, 98, 97), false, BIT(DP_DPCD_QUIRK_CAN_DO_MAX_LINK_RATE_3_24_GBPS) },
> };
>
> #undef OUI
> diff --git a/drivers/gpu/drm/i915/display/intel_dp.c b/drivers/gpu/drm/i915/display/intel_dp.c
> index 4074d83b1a5f..1f6bd659ad41 100644
> --- a/drivers/gpu/drm/i915/display/intel_dp.c
> +++ b/drivers/gpu/drm/i915/display/intel_dp.c
> @@ -178,6 +178,13 @@ static void intel_dp_set_sink_rates(struct intel_dp *intel_dp)
> }
>
> intel_dp->num_sink_rates = i;
> +
> + if (drm_dp_has_quirk(&intel_dp->desc,
> + DP_DPCD_QUIRK_CAN_DO_MAX_LINK_RATE_3_24_GBPS)) {
> + /* Needed for Apple MBP 2017, 15 inch eDP Retina panel */
> + intel_dp->sink_rates[i] = 324000;
> + intel_dp->num_sink_rates++;
> + }
If we can isolate the quirk to this one function, I'll be happy. \o/
However, even if this might work on said machine, I'd prefer it if we
didn't give the idea that you could just append a value in sink_rates
(it must be sorted). How about putting something like this in the
beginning of the function, to be a bit more explicit:
if (quirk) {
static const int quirk_rates[] = { 162000, 270000, 324000 };
memcpy(intel_dp->sink_rates, quirk_rates, sizeof(quirk_rates));
intel_dp->num_sink_rates = ARRAY_SIZE(quirk_rates);
return;
}
BR,
Jani.
> }
>
> /* Get length of rates array potentially limited by max_rate. */
> diff --git a/include/drm/drm_dp_helper.h b/include/drm/drm_dp_helper.h
> index 262faf9e5e94..4b86a1f2a559 100644
> --- a/include/drm/drm_dp_helper.h
> +++ b/include/drm/drm_dp_helper.h
> @@ -1532,6 +1532,13 @@ enum drm_dp_quirk {
> * The DSC caps can be read from the physical aux instead.
> */
> DP_DPCD_QUIRK_DSC_WITHOUT_VIRTUAL_DPCD,
> + /**
> + * @DP_DPCD_QUIRK_CAN_DO_MAX_LINK_RATE_3_24_GBPS:
> + *
> + * The device supports a link rate of 3.24 Gbps (multiplier 0xc) despite
> + * the DP_MAX_LINK_RATE register reporting a lower max multiplier.
> + */
> + DP_DPCD_QUIRK_CAN_DO_MAX_LINK_RATE_3_24_GBPS,
> };
>
> /**
--
Jani Nikula, Intel Open Source Graphics Center
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH] drm/i915/dp: Add dpcd link_rate quirk for Apple 15" MBP 2017
2020-03-04 15:32 ` [Intel-gfx] " Jani Nikula
@ 2020-03-05 8:18 ` Mario Kleiner
-1 siblings, 0 replies; 9+ messages in thread
From: Mario Kleiner @ 2020-03-05 8:18 UTC (permalink / raw)
To: Jani Nikula; +Cc: intel-gfx, dri-devel
On Wed, Mar 4, 2020 at 4:32 PM Jani Nikula <jani.nikula@intel.com> wrote:
>
> On Sat, 29 Feb 2020, Mario Kleiner <mario.kleiner.de@gmail.com> wrote:
> > This fixes a problem found on the MacBookPro 2017 Retina panel.
> >
> > The panel reports 10 bpc color depth in its EDID, and the
> > firmware chooses link settings at boot which support enough
> > bandwidth for 10 bpc (324000 kbit/sec = multiplier 0xc),
> > but the DP_MAX_LINK_RATE dpcd register only reports
> > 2.7 Gbps (multiplier value 0xa) as possible, in direct
> > contradiction of what the firmware successfully set up.
> >
> > This restricts the panel to 8 bpc, not providing the full
> > color depth of the panel.
> >
> > This patch adds a quirk specific to the MBP 2017 15" Retina
> > panel to add the additiional 324000 kbps link rate during
> > edp setup.
> >
> > Link to previous discussion of a different attempted fix
> > with Ville and Jani:
> >
> > https://patchwork.kernel.org/patch/11325935/
> >
> > Signed-off-by: Mario Kleiner <mario.kleiner.de@gmail.com>
> > Cc: Ville Syrjälä <ville.syrjala@linux.intel.com>
> > Cc: Jani Nikula <jani.nikula@intel.com>
> > ---
> > drivers/gpu/drm/drm_dp_helper.c | 2 ++
> > drivers/gpu/drm/i915/display/intel_dp.c | 7 +++++++
> > include/drm/drm_dp_helper.h | 7 +++++++
> > 3 files changed, 16 insertions(+)
> >
> > diff --git a/drivers/gpu/drm/drm_dp_helper.c b/drivers/gpu/drm/drm_dp_helper.c
> > index 5a103e9b3c86..36a371c016cb 100644
> > --- a/drivers/gpu/drm/drm_dp_helper.c
> > +++ b/drivers/gpu/drm/drm_dp_helper.c
> > @@ -1179,6 +1179,8 @@ static const struct dpcd_quirk dpcd_quirk_list[] = {
> > { OUI(0x00, 0x00, 0x00), DEVICE_ID('C', 'H', '7', '5', '1', '1'), false, BIT(DP_DPCD_QUIRK_NO_SINK_COUNT) },
> > /* Synaptics DP1.4 MST hubs can support DSC without virtual DPCD */
> > { OUI(0x90, 0xCC, 0x24), DEVICE_ID_ANY, true, BIT(DP_DPCD_QUIRK_DSC_WITHOUT_VIRTUAL_DPCD) },
> > + /* Apple MacBookPro 2017 15 inch eDP Retina panel reports too low DP_MAX_LINK_RATE */
> > + { OUI(0x00, 0x10, 0xfa), DEVICE_ID(101, 68, 21, 101, 98, 97), false, BIT(DP_DPCD_QUIRK_CAN_DO_MAX_LINK_RATE_3_24_GBPS) },
> > };
> >
> > #undef OUI
> > diff --git a/drivers/gpu/drm/i915/display/intel_dp.c b/drivers/gpu/drm/i915/display/intel_dp.c
> > index 4074d83b1a5f..1f6bd659ad41 100644
> > --- a/drivers/gpu/drm/i915/display/intel_dp.c
> > +++ b/drivers/gpu/drm/i915/display/intel_dp.c
> > @@ -178,6 +178,13 @@ static void intel_dp_set_sink_rates(struct intel_dp *intel_dp)
> > }
> >
> > intel_dp->num_sink_rates = i;
> > +
> > + if (drm_dp_has_quirk(&intel_dp->desc,
> > + DP_DPCD_QUIRK_CAN_DO_MAX_LINK_RATE_3_24_GBPS)) {
> > + /* Needed for Apple MBP 2017, 15 inch eDP Retina panel */
> > + intel_dp->sink_rates[i] = 324000;
> > + intel_dp->num_sink_rates++;
> > + }
>
> If we can isolate the quirk to this one function, I'll be happy. \o/
>
Me too \o/ - Patch v2 is out, following your proposal, retested on the
machine, works. cat ... i915_display_info reports a pipe depth of 30
bpp, instead of 24 bpp.
I didn't add a stable tag, but wonder if a cc stable tag could be
added by you, if you think it is minimal enough, to get it also into
the kernels for the spring distro updates. In any case, case closed.
Thanks for the review,
-mario
> However, even if this might work on said machine, I'd prefer it if we
> didn't give the idea that you could just append a value in sink_rates
> (it must be sorted). How about putting something like this in the
> beginning of the function, to be a bit more explicit:
>
> if (quirk) {
> static const int quirk_rates[] = { 162000, 270000, 324000 };
>
> memcpy(intel_dp->sink_rates, quirk_rates, sizeof(quirk_rates));
> intel_dp->num_sink_rates = ARRAY_SIZE(quirk_rates);
>
> return;
> }
>
> BR,
> Jani.
>
> > }
> >
> > /* Get length of rates array potentially limited by max_rate. */
> > diff --git a/include/drm/drm_dp_helper.h b/include/drm/drm_dp_helper.h
> > index 262faf9e5e94..4b86a1f2a559 100644
> > --- a/include/drm/drm_dp_helper.h
> > +++ b/include/drm/drm_dp_helper.h
> > @@ -1532,6 +1532,13 @@ enum drm_dp_quirk {
> > * The DSC caps can be read from the physical aux instead.
> > */
> > DP_DPCD_QUIRK_DSC_WITHOUT_VIRTUAL_DPCD,
> > + /**
> > + * @DP_DPCD_QUIRK_CAN_DO_MAX_LINK_RATE_3_24_GBPS:
> > + *
> > + * The device supports a link rate of 3.24 Gbps (multiplier 0xc) despite
> > + * the DP_MAX_LINK_RATE register reporting a lower max multiplier.
> > + */
> > + DP_DPCD_QUIRK_CAN_DO_MAX_LINK_RATE_3_24_GBPS,
> > };
> >
> > /**
>
> --
> Jani Nikula, Intel Open Source Graphics Center
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [Intel-gfx] [PATCH] drm/i915/dp: Add dpcd link_rate quirk for Apple 15" MBP 2017
@ 2020-03-05 8:18 ` Mario Kleiner
0 siblings, 0 replies; 9+ messages in thread
From: Mario Kleiner @ 2020-03-05 8:18 UTC (permalink / raw)
To: Jani Nikula; +Cc: intel-gfx, dri-devel
On Wed, Mar 4, 2020 at 4:32 PM Jani Nikula <jani.nikula@intel.com> wrote:
>
> On Sat, 29 Feb 2020, Mario Kleiner <mario.kleiner.de@gmail.com> wrote:
> > This fixes a problem found on the MacBookPro 2017 Retina panel.
> >
> > The panel reports 10 bpc color depth in its EDID, and the
> > firmware chooses link settings at boot which support enough
> > bandwidth for 10 bpc (324000 kbit/sec = multiplier 0xc),
> > but the DP_MAX_LINK_RATE dpcd register only reports
> > 2.7 Gbps (multiplier value 0xa) as possible, in direct
> > contradiction of what the firmware successfully set up.
> >
> > This restricts the panel to 8 bpc, not providing the full
> > color depth of the panel.
> >
> > This patch adds a quirk specific to the MBP 2017 15" Retina
> > panel to add the additiional 324000 kbps link rate during
> > edp setup.
> >
> > Link to previous discussion of a different attempted fix
> > with Ville and Jani:
> >
> > https://patchwork.kernel.org/patch/11325935/
> >
> > Signed-off-by: Mario Kleiner <mario.kleiner.de@gmail.com>
> > Cc: Ville Syrjälä <ville.syrjala@linux.intel.com>
> > Cc: Jani Nikula <jani.nikula@intel.com>
> > ---
> > drivers/gpu/drm/drm_dp_helper.c | 2 ++
> > drivers/gpu/drm/i915/display/intel_dp.c | 7 +++++++
> > include/drm/drm_dp_helper.h | 7 +++++++
> > 3 files changed, 16 insertions(+)
> >
> > diff --git a/drivers/gpu/drm/drm_dp_helper.c b/drivers/gpu/drm/drm_dp_helper.c
> > index 5a103e9b3c86..36a371c016cb 100644
> > --- a/drivers/gpu/drm/drm_dp_helper.c
> > +++ b/drivers/gpu/drm/drm_dp_helper.c
> > @@ -1179,6 +1179,8 @@ static const struct dpcd_quirk dpcd_quirk_list[] = {
> > { OUI(0x00, 0x00, 0x00), DEVICE_ID('C', 'H', '7', '5', '1', '1'), false, BIT(DP_DPCD_QUIRK_NO_SINK_COUNT) },
> > /* Synaptics DP1.4 MST hubs can support DSC without virtual DPCD */
> > { OUI(0x90, 0xCC, 0x24), DEVICE_ID_ANY, true, BIT(DP_DPCD_QUIRK_DSC_WITHOUT_VIRTUAL_DPCD) },
> > + /* Apple MacBookPro 2017 15 inch eDP Retina panel reports too low DP_MAX_LINK_RATE */
> > + { OUI(0x00, 0x10, 0xfa), DEVICE_ID(101, 68, 21, 101, 98, 97), false, BIT(DP_DPCD_QUIRK_CAN_DO_MAX_LINK_RATE_3_24_GBPS) },
> > };
> >
> > #undef OUI
> > diff --git a/drivers/gpu/drm/i915/display/intel_dp.c b/drivers/gpu/drm/i915/display/intel_dp.c
> > index 4074d83b1a5f..1f6bd659ad41 100644
> > --- a/drivers/gpu/drm/i915/display/intel_dp.c
> > +++ b/drivers/gpu/drm/i915/display/intel_dp.c
> > @@ -178,6 +178,13 @@ static void intel_dp_set_sink_rates(struct intel_dp *intel_dp)
> > }
> >
> > intel_dp->num_sink_rates = i;
> > +
> > + if (drm_dp_has_quirk(&intel_dp->desc,
> > + DP_DPCD_QUIRK_CAN_DO_MAX_LINK_RATE_3_24_GBPS)) {
> > + /* Needed for Apple MBP 2017, 15 inch eDP Retina panel */
> > + intel_dp->sink_rates[i] = 324000;
> > + intel_dp->num_sink_rates++;
> > + }
>
> If we can isolate the quirk to this one function, I'll be happy. \o/
>
Me too \o/ - Patch v2 is out, following your proposal, retested on the
machine, works. cat ... i915_display_info reports a pipe depth of 30
bpp, instead of 24 bpp.
I didn't add a stable tag, but wonder if a cc stable tag could be
added by you, if you think it is minimal enough, to get it also into
the kernels for the spring distro updates. In any case, case closed.
Thanks for the review,
-mario
> However, even if this might work on said machine, I'd prefer it if we
> didn't give the idea that you could just append a value in sink_rates
> (it must be sorted). How about putting something like this in the
> beginning of the function, to be a bit more explicit:
>
> if (quirk) {
> static const int quirk_rates[] = { 162000, 270000, 324000 };
>
> memcpy(intel_dp->sink_rates, quirk_rates, sizeof(quirk_rates));
> intel_dp->num_sink_rates = ARRAY_SIZE(quirk_rates);
>
> return;
> }
>
> BR,
> Jani.
>
> > }
> >
> > /* Get length of rates array potentially limited by max_rate. */
> > diff --git a/include/drm/drm_dp_helper.h b/include/drm/drm_dp_helper.h
> > index 262faf9e5e94..4b86a1f2a559 100644
> > --- a/include/drm/drm_dp_helper.h
> > +++ b/include/drm/drm_dp_helper.h
> > @@ -1532,6 +1532,13 @@ enum drm_dp_quirk {
> > * The DSC caps can be read from the physical aux instead.
> > */
> > DP_DPCD_QUIRK_DSC_WITHOUT_VIRTUAL_DPCD,
> > + /**
> > + * @DP_DPCD_QUIRK_CAN_DO_MAX_LINK_RATE_3_24_GBPS:
> > + *
> > + * The device supports a link rate of 3.24 Gbps (multiplier 0xc) despite
> > + * the DP_MAX_LINK_RATE register reporting a lower max multiplier.
> > + */
> > + DP_DPCD_QUIRK_CAN_DO_MAX_LINK_RATE_3_24_GBPS,
> > };
> >
> > /**
>
> --
> Jani Nikula, Intel Open Source Graphics Center
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 9+ messages in thread
end of thread, other threads:[~2020-03-05 8:18 UTC | newest]
Thread overview: 9+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2020-02-29 5:41 [PATCH] drm/i915/dp: Add dpcd link_rate quirk for Apple 15" MBP 2017 Mario Kleiner
2020-02-29 5:41 ` [Intel-gfx] " Mario Kleiner
2020-02-29 5:49 ` [Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for " Patchwork
2020-02-29 6:14 ` [Intel-gfx] ✓ Fi.CI.BAT: success " Patchwork
2020-03-02 1:45 ` [Intel-gfx] ✗ Fi.CI.IGT: failure " Patchwork
2020-03-04 15:32 ` [PATCH] " Jani Nikula
2020-03-04 15:32 ` [Intel-gfx] " Jani Nikula
2020-03-05 8:18 ` Mario Kleiner
2020-03-05 8:18 ` [Intel-gfx] " Mario Kleiner
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.