All of lore.kernel.org
 help / color / mirror / Atom feed
From: Kalle Valo <kvalo@codeaurora.org>
To: John Crispin <john@phrozen.org>
Cc: devicetree@vger.kernel.org, Rob Herring <robh+dt@kernel.org>,
	linux-wireless@vger.kernel.org, ath11k@lists.infradead.org
Subject: Re: [PATCH 1/2] dt: bindings: net: ath11k: add qcom, board_id definition
Date: Thu, 19 Dec 2019 15:49:39 +0200	[thread overview]
Message-ID: <871rt077d8.fsf@kamboji.qca.qualcomm.com> (raw)
In-Reply-To: <20191217164329.4151-1-john@phrozen.org> (John Crispin's message of "Tue, 17 Dec 2019 17:43:28 +0100")

John Crispin <john@phrozen.org> writes:

> We need to be able to define what id the board has allowing us to load the
> correct definition data. This patch adds the description of the required
> property.
>
> Signed-off-by: John Crispin <john@phrozen.org>
> ---
>  .../devicetree/bindings/net/wireless/qcom,ath11k.yaml        | 5 +++++
>  1 file changed, 5 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/net/wireless/qcom,ath11k.yaml b/Documentation/devicetree/bindings/net/wireless/qcom,ath11k.yaml
> index a1717db36dba..c68daf6ad424 100644
> --- a/Documentation/devicetree/bindings/net/wireless/qcom,ath11k.yaml
> +++ b/Documentation/devicetree/bindings/net/wireless/qcom,ath11k.yaml
> @@ -142,6 +142,11 @@ properties:
>          * reg
>          * reg-names
>  
> +  qcom,board_id:
> +      $ref: /schemas/types.yaml#/definitions/uint32
> +      description:
> +        The board id defining what board definition should be loaded

I think this needs more discussion. This is very tricky to get right, as
it needs to be extensible and what not. With ath10k we have learned that
a simple integer is not enough.

-- 
https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches

_______________________________________________
ath11k mailing list
ath11k@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/ath11k

WARNING: multiple messages have this Message-ID (diff)
From: Kalle Valo <kvalo@codeaurora.org>
To: John Crispin <john@phrozen.org>
Cc: Rob Herring <robh+dt@kernel.org>,
	devicetree@vger.kernel.org, linux-wireless@vger.kernel.org,
	ath11k@lists.infradead.org
Subject: Re: [PATCH 1/2] dt: bindings: net: ath11k: add qcom,board_id definition
Date: Thu, 19 Dec 2019 15:49:39 +0200	[thread overview]
Message-ID: <871rt077d8.fsf@kamboji.qca.qualcomm.com> (raw)
In-Reply-To: <20191217164329.4151-1-john@phrozen.org> (John Crispin's message of "Tue, 17 Dec 2019 17:43:28 +0100")

John Crispin <john@phrozen.org> writes:

> We need to be able to define what id the board has allowing us to load the
> correct definition data. This patch adds the description of the required
> property.
>
> Signed-off-by: John Crispin <john@phrozen.org>
> ---
>  .../devicetree/bindings/net/wireless/qcom,ath11k.yaml        | 5 +++++
>  1 file changed, 5 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/net/wireless/qcom,ath11k.yaml b/Documentation/devicetree/bindings/net/wireless/qcom,ath11k.yaml
> index a1717db36dba..c68daf6ad424 100644
> --- a/Documentation/devicetree/bindings/net/wireless/qcom,ath11k.yaml
> +++ b/Documentation/devicetree/bindings/net/wireless/qcom,ath11k.yaml
> @@ -142,6 +142,11 @@ properties:
>          * reg
>          * reg-names
>  
> +  qcom,board_id:
> +      $ref: /schemas/types.yaml#/definitions/uint32
> +      description:
> +        The board id defining what board definition should be loaded

I think this needs more discussion. This is very tricky to get right, as
it needs to be extensible and what not. With ath10k we have learned that
a simple integer is not enough.

-- 
https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches

  parent reply	other threads:[~2019-12-19 13:49 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-12-17 16:43 [PATCH 1/2] dt: bindings: net: ath11k: add qcom,board_id definition John Crispin
2019-12-17 16:43 ` John Crispin
2019-12-17 16:43 ` [PATCH 2/2] ath11k: load appropriate board data based on board id John Crispin
2019-12-17 16:43   ` John Crispin
2019-12-19 13:49 ` Kalle Valo [this message]
2019-12-19 13:49   ` [PATCH 1/2] dt: bindings: net: ath11k: add qcom,board_id definition Kalle Valo
2019-12-19 13:57   ` John Crispin
2019-12-19 13:57     ` John Crispin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=871rt077d8.fsf@kamboji.qca.qualcomm.com \
    --to=kvalo@codeaurora.org \
    --cc=ath11k@lists.infradead.org \
    --cc=devicetree@vger.kernel.org \
    --cc=john@phrozen.org \
    --cc=linux-wireless@vger.kernel.org \
    --cc=robh+dt@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.