All of lore.kernel.org
 help / color / mirror / Atom feed
From: Mika Kuoppala <mika.kuoppala@linux.intel.com>
To: Chris Wilson <chris@chris-wilson.co.uk>, intel-gfx@lists.freedesktop.org
Subject: Re: [PATCH 1/2] drm/i915/selftests: Initialise ret
Date: Mon, 28 Oct 2019 16:52:46 +0200	[thread overview]
Message-ID: <871ruw7wht.fsf@gaia.fi.intel.com> (raw)
In-Reply-To: <20191028142652.1987-1-chris@chris-wilson.co.uk>

Chris Wilson <chris@chris-wilson.co.uk> writes:

> Keep smatch quiet,
>
> drivers/gpu/drm/i915//gem/selftests/i915_gem_context.c:1268 __igt_ctx_sseu() error: uninitialized symbol 'ret'.
> drivers/gpu/drm/i915//gem/selftests/i915_gem_context.c:1280 __igt_ctx_sseu() error: uninitialized symbol 'ret'.
>
> Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>

Reviewed-by: Mika Kuoppala <mika.kuoppala@linux.intel.com>

> ---
>  drivers/gpu/drm/i915/gem/selftests/i915_gem_context.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/i915/gem/selftests/i915_gem_context.c b/drivers/gpu/drm/i915/gem/selftests/i915_gem_context.c
> index d1d873f23338..c6e61564bb5e 100644
> --- a/drivers/gpu/drm/i915/gem/selftests/i915_gem_context.c
> +++ b/drivers/gpu/drm/i915/gem/selftests/i915_gem_context.c
> @@ -1188,7 +1188,7 @@ __igt_ctx_sseu(struct drm_i915_private *i915,
>  {
>  	struct drm_i915_gem_object *obj;
>  	int inst = 0;
> -	int ret;
> +	int ret = 0;
>  
>  	if (INTEL_GEN(i915) < 9 || !RUNTIME_INFO(i915)->sseu.has_slice_pg)
>  		return 0;
> -- 
> 2.24.0.rc1
>
> _______________________________________________
> Intel-gfx mailing list
> Intel-gfx@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/intel-gfx
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

WARNING: multiple messages have this Message-ID (diff)
From: Mika Kuoppala <mika.kuoppala@linux.intel.com>
To: Chris Wilson <chris@chris-wilson.co.uk>, intel-gfx@lists.freedesktop.org
Subject: Re: [Intel-gfx] [PATCH 1/2] drm/i915/selftests: Initialise ret
Date: Mon, 28 Oct 2019 16:52:46 +0200	[thread overview]
Message-ID: <871ruw7wht.fsf@gaia.fi.intel.com> (raw)
Message-ID: <20191028145246.c5QzQR43-ylzhRyeYnOr6cE7DSM_DOC5IhE8qQxc3SU@z> (raw)
In-Reply-To: <20191028142652.1987-1-chris@chris-wilson.co.uk>

Chris Wilson <chris@chris-wilson.co.uk> writes:

> Keep smatch quiet,
>
> drivers/gpu/drm/i915//gem/selftests/i915_gem_context.c:1268 __igt_ctx_sseu() error: uninitialized symbol 'ret'.
> drivers/gpu/drm/i915//gem/selftests/i915_gem_context.c:1280 __igt_ctx_sseu() error: uninitialized symbol 'ret'.
>
> Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>

Reviewed-by: Mika Kuoppala <mika.kuoppala@linux.intel.com>

> ---
>  drivers/gpu/drm/i915/gem/selftests/i915_gem_context.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/i915/gem/selftests/i915_gem_context.c b/drivers/gpu/drm/i915/gem/selftests/i915_gem_context.c
> index d1d873f23338..c6e61564bb5e 100644
> --- a/drivers/gpu/drm/i915/gem/selftests/i915_gem_context.c
> +++ b/drivers/gpu/drm/i915/gem/selftests/i915_gem_context.c
> @@ -1188,7 +1188,7 @@ __igt_ctx_sseu(struct drm_i915_private *i915,
>  {
>  	struct drm_i915_gem_object *obj;
>  	int inst = 0;
> -	int ret;
> +	int ret = 0;
>  
>  	if (INTEL_GEN(i915) < 9 || !RUNTIME_INFO(i915)->sseu.has_slice_pg)
>  		return 0;
> -- 
> 2.24.0.rc1
>
> _______________________________________________
> Intel-gfx mailing list
> Intel-gfx@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/intel-gfx
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

  parent reply	other threads:[~2019-10-28 14:53 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-10-28 14:26 [PATCH 1/2] drm/i915/selftests: Initialise ret Chris Wilson
2019-10-28 14:26 ` [Intel-gfx] " Chris Wilson
2019-10-28 14:26 ` [PATCH 2/2] drm/i915/display: Mark conn as initialised by iterator Chris Wilson
2019-10-28 14:26   ` [Intel-gfx] " Chris Wilson
2019-10-28 14:55   ` Mika Kuoppala
2019-10-28 14:55     ` [Intel-gfx] " Mika Kuoppala
2019-10-28 14:52 ` Mika Kuoppala [this message]
2019-10-28 14:52   ` [Intel-gfx] [PATCH 1/2] drm/i915/selftests: Initialise ret Mika Kuoppala
2019-10-28 17:58 ` ✗ Fi.CI.CHECKPATCH: warning for series starting with [1/2] " Patchwork
2019-10-28 17:58   ` [Intel-gfx] " Patchwork
2019-10-28 18:20 ` ✓ Fi.CI.BAT: success " Patchwork
2019-10-28 18:20   ` [Intel-gfx] " Patchwork
2019-10-29 13:16 ` ✓ Fi.CI.IGT: " Patchwork
2019-10-29 13:16   ` [Intel-gfx] " Patchwork

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=871ruw7wht.fsf@gaia.fi.intel.com \
    --to=mika.kuoppala@linux.intel.com \
    --cc=chris@chris-wilson.co.uk \
    --cc=intel-gfx@lists.freedesktop.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.