From: Markus Armbruster <armbru@redhat.com>
To: Paolo Bonzini <pbonzini@redhat.com>
Cc: "Marc-André Lureau" <marcandre.lureau@redhat.com>,
"Richard Henderson" <rth@twiddle.net>,
qemu-devel@nongnu.org, "Eduardo Habkost" <ehabkost@redhat.com>
Subject: Re: [Qemu-devel] qapi/misc.json is too big, let's bite off a few chunks
Date: Fri, 07 Jun 2019 10:25:16 +0200 [thread overview]
Message-ID: <871s05g5ub.fsf@dusky.pond.sub.org> (raw)
In-Reply-To: <564efcce-64ac-0a39-8899-f6b6d6d7984e@redhat.com> (Paolo Bonzini's message of "Fri, 24 May 2019 20:31:17 +0200")
Paolo Bonzini <pbonzini@redhat.com> writes:
> On 23/05/19 18:14, Markus Armbruster wrote:
>> * Machine core (Eduardo, Marcel)
>>
>> query-machines, query-current-machine,
>>
>> ~60 lines. Hardly worthwhile from a "let's shrink misc.json" point of
>> view. Might be worthwhile from a "let's make get_maintainers.pl
>> work".
>>
>> * CPUs (Paolo, Richard)
>>
>> query-cpus, query-cpus-fast
>>
>> ~300 lines. The commands are implemented in cpus.c, which MAINTAINERS
>> covers both under "Main loop" and under "Guest CPU cores (TCG) /
>> Overall". Neither feels right to me for these QMP commands.
>>
>> * NUMA (Eduardo)
>>
>> query-memdev, set-numa-node
>>
>> ~200 lines.
>
> I would move all three of these and add a new entry to MAINTAINERS.
Double-checking: do you propose to move all three to a single new QAPI
module, with a new MAINTAINERS entry covering just the new QAPI module?
If yes, care to propose a QAPI module file name, a MAINTAINERS head
line, and maintainers?
Or do you propose to create three QAPI modules machine.json, cpus.json,
numa.json, with machine.json filed in MAINTAINERS under "Machine core",
numa.json under "NUMA", and cpus.json under a new entry?
next prev parent reply other threads:[~2019-06-07 8:26 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-05-23 16:14 [Qemu-devel] qapi/misc.json is too big, let's bite off a few chunks Markus Armbruster
2019-05-24 18:31 ` Paolo Bonzini
2019-06-07 8:25 ` Markus Armbruster [this message]
2019-06-07 11:35 ` Paolo Bonzini
2019-06-07 12:45 ` Markus Armbruster
2019-06-11 21:20 ` Eduardo Habkost
2019-05-24 18:53 ` Eduardo Habkost
2019-05-27 8:00 ` Markus Armbruster
2019-05-27 10:03 ` Paolo Bonzini
2019-05-28 19:37 ` Eduardo Habkost
2019-06-07 6:59 ` Markus Armbruster
2019-06-07 8:33 ` Philippe Mathieu-Daudé
2019-06-07 12:25 ` Markus Armbruster
2019-06-07 9:59 ` Daniel P. Berrangé
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=871s05g5ub.fsf@dusky.pond.sub.org \
--to=armbru@redhat.com \
--cc=ehabkost@redhat.com \
--cc=marcandre.lureau@redhat.com \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=rth@twiddle.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.