All of lore.kernel.org
 help / color / mirror / Atom feed
From: Markus Armbruster <armbru@redhat.com>
To: qemu-devel@nongnu.org
Cc: "Marc-André Lureau" <marcandre.lureau@redhat.com>,
	"Richard Henderson" <rth@twiddle.net>,
	"Eduardo Habkost" <ehabkost@redhat.com>,
	"Paolo Bonzini" <pbonzini@redhat.com>
Subject: [Qemu-devel] qapi/misc.json is too big, let's bite off a few chunks
Date: Thu, 23 May 2019 18:14:18 +0200	[thread overview]
Message-ID: <87woihi1wl.fsf@dusky.pond.sub.org> (raw)

It's nice when QAPI schema modules clearly belong to a single subsystem
in addition to "QAPI Schema".  misc.json doesn't, and it's grown fat:
3000+ lines.  Let's move out some stuff.  Here are a few candidates:

* Dump (Marc-André)

  dump-guest-memory, query-dump, DUMP_COMPLETED,
  query-dump-guest-memory-capability

  ~200 lines.

* Machine core (Eduardo, Marcel)

  query-machines, query-current-machine, 

  ~60 lines.  Hardly worthwhile from a "let's shrink misc.json" point of
  view.  Might be worthwhile from a "let's make get_maintainers.pl
  work".

* CPUs (Paolo, Richard)

  query-cpus, query-cpus-fast

  ~300 lines.  The commands are implemented in cpus.c, which MAINTAINERS
  covers both under "Main loop" and under "Guest CPU cores (TCG) /
  Overall".  Neither feels right to me for these QMP commands.

* NUMA (Eduardo)

  query-memdev, set-numa-node

  ~200 lines.

Opinions?

Additional candidates?


             reply	other threads:[~2019-05-23 16:21 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-05-23 16:14 Markus Armbruster [this message]
2019-05-24 18:31 ` [Qemu-devel] qapi/misc.json is too big, let's bite off a few chunks Paolo Bonzini
2019-06-07  8:25   ` Markus Armbruster
2019-06-07 11:35     ` Paolo Bonzini
2019-06-07 12:45       ` Markus Armbruster
2019-06-11 21:20         ` Eduardo Habkost
2019-05-24 18:53 ` Eduardo Habkost
2019-05-27  8:00   ` Markus Armbruster
2019-05-27 10:03     ` Paolo Bonzini
2019-05-28 19:37       ` Eduardo Habkost
2019-06-07  6:59       ` Markus Armbruster
2019-06-07  8:33         ` Philippe Mathieu-Daudé
2019-06-07 12:25           ` Markus Armbruster
2019-06-07  9:59         ` Daniel P. Berrangé

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87woihi1wl.fsf@dusky.pond.sub.org \
    --to=armbru@redhat.com \
    --cc=ehabkost@redhat.com \
    --cc=marcandre.lureau@redhat.com \
    --cc=pbonzini@redhat.com \
    --cc=qemu-devel@nongnu.org \
    --cc=rth@twiddle.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.