From: Mika Kuoppala <mika.kuoppala@linux.intel.com>
To: Chris Wilson <chris@chris-wilson.co.uk>, intel-gfx@lists.freedesktop.org
Subject: Re: [PATCH] drm/i915/selftests: Use msecs_to_jiffies() for an explicit ms timeout
Date: Wed, 21 Nov 2018 14:26:23 +0200 [thread overview]
Message-ID: <871s7ehb0w.fsf@gaia.fi.intel.com> (raw)
In-Reply-To: <20181121115829.13114-1-chris@chris-wilson.co.uk>
Chris Wilson <chris@chris-wilson.co.uk> writes:
> Make the wait for the evict kthread use an explicit timeout rather than
> a handwaved jiffie value so it is consistent across all platforms.
>
> References: https://bugs.freedesktop.org/show_bug.cgi?id=108735
> Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
Reviewed-by: Mika Kuoppala <mika.kuoppala@linux.intel.com>
...there is one left in intel_workarounds.c
-Mika
> ---
> drivers/gpu/drm/i915/selftests/intel_hangcheck.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/i915/selftests/intel_hangcheck.c b/drivers/gpu/drm/i915/selftests/intel_hangcheck.c
> index defe671130ab..1f76257641f2 100644
> --- a/drivers/gpu/drm/i915/selftests/intel_hangcheck.c
> +++ b/drivers/gpu/drm/i915/selftests/intel_hangcheck.c
> @@ -1171,7 +1171,7 @@ static int __igt_reset_evict_vma(struct drm_i915_private *i915,
> struct igt_wedge_me w;
>
> /* The reset, even indirectly, should take less than 10ms. */
> - igt_wedge_on_timeout(&w, i915, HZ / 10 /* 100ms timeout*/)
> + igt_wedge_on_timeout(&w, i915, msecs_to_jiffies(100))
> err = kthread_stop(tsk);
>
> put_task_struct(tsk);
> --
> 2.19.1
>
> _______________________________________________
> Intel-gfx mailing list
> Intel-gfx@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/intel-gfx
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
next prev parent reply other threads:[~2018-11-21 12:27 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-11-21 11:58 [PATCH] drm/i915/selftests: Use msecs_to_jiffies() for an explicit ms timeout Chris Wilson
2018-11-21 12:26 ` Mika Kuoppala [this message]
2018-11-21 12:37 ` Chris Wilson
2018-11-21 12:33 ` ✓ Fi.CI.BAT: success for " Patchwork
2018-11-21 12:42 ` Chris Wilson
2018-11-21 20:33 ` ✓ Fi.CI.IGT: " Patchwork
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=871s7ehb0w.fsf@gaia.fi.intel.com \
--to=mika.kuoppala@linux.intel.com \
--cc=chris@chris-wilson.co.uk \
--cc=intel-gfx@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.