* [PATCH] drm/i915/selftests: Use msecs_to_jiffies() for an explicit ms timeout
@ 2018-11-21 11:58 Chris Wilson
2018-11-21 12:26 ` Mika Kuoppala
` (2 more replies)
0 siblings, 3 replies; 6+ messages in thread
From: Chris Wilson @ 2018-11-21 11:58 UTC (permalink / raw)
To: intel-gfx
Make the wait for the evict kthread use an explicit timeout rather than
a handwaved jiffie value so it is consistent across all platforms.
References: https://bugs.freedesktop.org/show_bug.cgi?id=108735
Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
---
drivers/gpu/drm/i915/selftests/intel_hangcheck.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/i915/selftests/intel_hangcheck.c b/drivers/gpu/drm/i915/selftests/intel_hangcheck.c
index defe671130ab..1f76257641f2 100644
--- a/drivers/gpu/drm/i915/selftests/intel_hangcheck.c
+++ b/drivers/gpu/drm/i915/selftests/intel_hangcheck.c
@@ -1171,7 +1171,7 @@ static int __igt_reset_evict_vma(struct drm_i915_private *i915,
struct igt_wedge_me w;
/* The reset, even indirectly, should take less than 10ms. */
- igt_wedge_on_timeout(&w, i915, HZ / 10 /* 100ms timeout*/)
+ igt_wedge_on_timeout(&w, i915, msecs_to_jiffies(100))
err = kthread_stop(tsk);
put_task_struct(tsk);
--
2.19.1
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply related [flat|nested] 6+ messages in thread* Re: [PATCH] drm/i915/selftests: Use msecs_to_jiffies() for an explicit ms timeout
2018-11-21 11:58 [PATCH] drm/i915/selftests: Use msecs_to_jiffies() for an explicit ms timeout Chris Wilson
@ 2018-11-21 12:26 ` Mika Kuoppala
2018-11-21 12:37 ` Chris Wilson
2018-11-21 12:33 ` ✓ Fi.CI.BAT: success for " Patchwork
2018-11-21 20:33 ` ✓ Fi.CI.IGT: " Patchwork
2 siblings, 1 reply; 6+ messages in thread
From: Mika Kuoppala @ 2018-11-21 12:26 UTC (permalink / raw)
To: Chris Wilson, intel-gfx
Chris Wilson <chris@chris-wilson.co.uk> writes:
> Make the wait for the evict kthread use an explicit timeout rather than
> a handwaved jiffie value so it is consistent across all platforms.
>
> References: https://bugs.freedesktop.org/show_bug.cgi?id=108735
> Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
Reviewed-by: Mika Kuoppala <mika.kuoppala@linux.intel.com>
...there is one left in intel_workarounds.c
-Mika
> ---
> drivers/gpu/drm/i915/selftests/intel_hangcheck.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/i915/selftests/intel_hangcheck.c b/drivers/gpu/drm/i915/selftests/intel_hangcheck.c
> index defe671130ab..1f76257641f2 100644
> --- a/drivers/gpu/drm/i915/selftests/intel_hangcheck.c
> +++ b/drivers/gpu/drm/i915/selftests/intel_hangcheck.c
> @@ -1171,7 +1171,7 @@ static int __igt_reset_evict_vma(struct drm_i915_private *i915,
> struct igt_wedge_me w;
>
> /* The reset, even indirectly, should take less than 10ms. */
> - igt_wedge_on_timeout(&w, i915, HZ / 10 /* 100ms timeout*/)
> + igt_wedge_on_timeout(&w, i915, msecs_to_jiffies(100))
> err = kthread_stop(tsk);
>
> put_task_struct(tsk);
> --
> 2.19.1
>
> _______________________________________________
> Intel-gfx mailing list
> Intel-gfx@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/intel-gfx
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] drm/i915/selftests: Use msecs_to_jiffies() for an explicit ms timeout
2018-11-21 12:26 ` Mika Kuoppala
@ 2018-11-21 12:37 ` Chris Wilson
0 siblings, 0 replies; 6+ messages in thread
From: Chris Wilson @ 2018-11-21 12:37 UTC (permalink / raw)
To: Mika Kuoppala, intel-gfx
Quoting Mika Kuoppala (2018-11-21 12:26:23)
> Chris Wilson <chris@chris-wilson.co.uk> writes:
>
> > Make the wait for the evict kthread use an explicit timeout rather than
> > a handwaved jiffie value so it is consistent across all platforms.
> >
> > References: https://bugs.freedesktop.org/show_bug.cgi?id=108735
> > Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
>
> Reviewed-by: Mika Kuoppala <mika.kuoppala@linux.intel.com>
>
> ...there is one left in intel_workarounds.c
Fortunately, we haven't yet exceeded it. HZ/5 should be
pretty stable, worst case is 20 jiffies. Even HZ/10 at 10 jiffies
shouldn't be much of a problem, just worrying about why the kthread
didn't wake up. Maybe I should just bump its prio.
-Chris
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 6+ messages in thread
* ✓ Fi.CI.BAT: success for drm/i915/selftests: Use msecs_to_jiffies() for an explicit ms timeout
2018-11-21 11:58 [PATCH] drm/i915/selftests: Use msecs_to_jiffies() for an explicit ms timeout Chris Wilson
2018-11-21 12:26 ` Mika Kuoppala
@ 2018-11-21 12:33 ` Patchwork
2018-11-21 12:42 ` Chris Wilson
2018-11-21 20:33 ` ✓ Fi.CI.IGT: " Patchwork
2 siblings, 1 reply; 6+ messages in thread
From: Patchwork @ 2018-11-21 12:33 UTC (permalink / raw)
To: Chris Wilson; +Cc: intel-gfx
== Series Details ==
Series: drm/i915/selftests: Use msecs_to_jiffies() for an explicit ms timeout
URL : https://patchwork.freedesktop.org/series/52820/
State : success
== Summary ==
= CI Bug Log - changes from CI_DRM_5180 -> Patchwork_10876 =
== Summary - SUCCESS ==
No regressions found.
External URL: https://patchwork.freedesktop.org/api/1.0/series/52820/revisions/1/mbox/
== Known issues ==
Here are the changes found in Patchwork_10876 that come from known issues:
=== IGT changes ===
==== Issues hit ====
igt@gem_ctx_create@basic-files:
fi-icl-u2: PASS -> DMESG-WARN (fdo#107724)
fi-bsw-kefka: PASS -> INCOMPLETE (fdo#108714)
igt@i915_selftest@live_coherency:
fi-gdg-551: NOTRUN -> DMESG-FAIL (fdo#107164)
igt@i915_selftest@live_hangcheck:
fi-bwr-2160: PASS -> DMESG-FAIL (fdo#108735)
igt@kms_pipe_crc_basic@read-crc-pipe-b:
fi-byt-clapper: PASS -> FAIL (fdo#107362)
igt@kms_pipe_crc_basic@suspend-read-crc-pipe-b:
fi-byt-clapper: PASS -> FAIL (fdo#107362, fdo#103191) +1
{igt@runner@aborted}:
{fi-icl-y}: NOTRUN -> FAIL (fdo#108070)
==== Possible fixes ====
igt@kms_pipe_crc_basic@suspend-read-crc-pipe-a:
fi-byt-clapper: FAIL (fdo#107362, fdo#103191) -> PASS +2
igt@kms_pipe_crc_basic@suspend-read-crc-pipe-b:
fi-blb-e6850: INCOMPLETE (fdo#107718) -> PASS
{name}: This element is suppressed. This means it is ignored when computing
the status of the difference (SUCCESS, WARNING, or FAILURE).
fdo#103191 https://bugs.freedesktop.org/show_bug.cgi?id=103191
fdo#107164 https://bugs.freedesktop.org/show_bug.cgi?id=107164
fdo#107362 https://bugs.freedesktop.org/show_bug.cgi?id=107362
fdo#107718 https://bugs.freedesktop.org/show_bug.cgi?id=107718
fdo#107724 https://bugs.freedesktop.org/show_bug.cgi?id=107724
fdo#108070 https://bugs.freedesktop.org/show_bug.cgi?id=108070
fdo#108714 https://bugs.freedesktop.org/show_bug.cgi?id=108714
fdo#108735 https://bugs.freedesktop.org/show_bug.cgi?id=108735
== Participating hosts (50 -> 45) ==
Additional (2): fi-icl-y fi-gdg-551
Missing (7): fi-kbl-soraka fi-ilk-m540 fi-hsw-4200u fi-byt-squawks fi-bsw-cyan fi-ctg-p8600 fi-icl-u3
== Build changes ==
* Linux: CI_DRM_5180 -> Patchwork_10876
CI_DRM_5180: 95de9a943571204eda4dc3156c3d984ba07c78e4 @ git://anongit.freedesktop.org/gfx-ci/linux
IGT_4723: 53bb24ad410b53cdd96f15ced8fd5921c8ab0eac @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools
Patchwork_10876: ce745cbd4d6a0e3141219c2ffa73395ad57e4084 @ git://anongit.freedesktop.org/gfx-ci/linux
== Linux commits ==
ce745cbd4d6a drm/i915/selftests: Use msecs_to_jiffies() for an explicit ms timeout
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_10876/issues.html
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: ✓ Fi.CI.BAT: success for drm/i915/selftests: Use msecs_to_jiffies() for an explicit ms timeout
2018-11-21 12:33 ` ✓ Fi.CI.BAT: success for " Patchwork
@ 2018-11-21 12:42 ` Chris Wilson
0 siblings, 0 replies; 6+ messages in thread
From: Chris Wilson @ 2018-11-21 12:42 UTC (permalink / raw)
To: Patchwork; +Cc: intel-gfx
Quoting Patchwork (2018-11-21 12:33:00)
> == Series Details ==
>
> Series: drm/i915/selftests: Use msecs_to_jiffies() for an explicit ms timeout
> URL : https://patchwork.freedesktop.org/series/52820/
> State : success
>
> == Summary ==
>
> = CI Bug Log - changes from CI_DRM_5180 -> Patchwork_10876 =
>
> == Summary - SUCCESS ==
>
> No regressions found.
>
> External URL: https://patchwork.freedesktop.org/api/1.0/series/52820/revisions/1/mbox/
>
> == Known issues ==
>
> Here are the changes found in Patchwork_10876 that come from known issues:
>
> === IGT changes ===
>
> ==== Issues hit ====
>
> igt@gem_ctx_create@basic-files:
> fi-icl-u2: PASS -> DMESG-WARN (fdo#107724)
> fi-bsw-kefka: PASS -> INCOMPLETE (fdo#108714)
>
> igt@i915_selftest@live_coherency:
> fi-gdg-551: NOTRUN -> DMESG-FAIL (fdo#107164)
>
> igt@i915_selftest@live_hangcheck:
> fi-bwr-2160: PASS -> DMESG-FAIL (fdo#108735)
Worrying proved right. Switching to 100ms isn't enough.
<0> [311.332381] igt/evic-2202 0.... 311291205us : reset_ring: rcs0 request global=1326, current=1325
<0> [311.332524] kworker/-165 1.... 311394694us : __igt_wedge_me: __igt_reset_evict_vma timed out.
100ms elapsed. Why didn't you wake up?
-Chris
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 6+ messages in thread
* ✓ Fi.CI.IGT: success for drm/i915/selftests: Use msecs_to_jiffies() for an explicit ms timeout
2018-11-21 11:58 [PATCH] drm/i915/selftests: Use msecs_to_jiffies() for an explicit ms timeout Chris Wilson
2018-11-21 12:26 ` Mika Kuoppala
2018-11-21 12:33 ` ✓ Fi.CI.BAT: success for " Patchwork
@ 2018-11-21 20:33 ` Patchwork
2 siblings, 0 replies; 6+ messages in thread
From: Patchwork @ 2018-11-21 20:33 UTC (permalink / raw)
To: Chris Wilson; +Cc: intel-gfx
== Series Details ==
Series: drm/i915/selftests: Use msecs_to_jiffies() for an explicit ms timeout
URL : https://patchwork.freedesktop.org/series/52820/
State : success
== Summary ==
= CI Bug Log - changes from CI_DRM_5180_full -> Patchwork_10876_full =
== Summary - SUCCESS ==
No regressions found.
== Known issues ==
Here are the changes found in Patchwork_10876_full that come from known issues:
=== IGT changes ===
==== Issues hit ====
igt@gem_ppgtt@blt-vs-render-ctxn:
shard-kbl: PASS -> INCOMPLETE (fdo#106887, fdo#103665, fdo#106023)
igt@kms_busy@extended-pageflip-modeset-hang-oldfb-render-b:
shard-snb: PASS -> DMESG-WARN (fdo#107956)
igt@kms_ccs@pipe-a-bad-aux-stride:
{shard-iclb}: PASS -> DMESG-WARN (fdo#107724) +8
igt@kms_draw_crc@draw-method-xrgb2101010-mmap-cpu-ytiled:
{shard-iclb}: NOTRUN -> WARN (fdo#108336)
igt@kms_flip@2x-flip-vs-expired-vblank-interruptible:
shard-glk: PASS -> FAIL (fdo#105363)
igt@kms_flip@flip-vs-expired-vblank-interruptible:
shard-skl: NOTRUN -> FAIL (fdo#105363)
igt@kms_frontbuffer_tracking@fbc-1p-primscrn-cur-indfb-onoff:
shard-apl: PASS -> FAIL (fdo#103167) +1
igt@kms_frontbuffer_tracking@fbc-2p-primscrn-spr-indfb-fullscreen:
shard-glk: PASS -> FAIL (fdo#103167) +3
igt@kms_frontbuffer_tracking@fbc-stridechange:
{shard-iclb}: PASS -> DMESG-FAIL (fdo#107724) +2
igt@kms_frontbuffer_tracking@fbcpsr-1p-shrfb-fliptrack:
{shard-iclb}: NOTRUN -> DMESG-FAIL (fdo#107724) +2
igt@kms_frontbuffer_tracking@psr-1p-primscrn-spr-indfb-fullscreen:
{shard-iclb}: PASS -> FAIL (fdo#103167)
igt@kms_pipe_crc_basic@suspend-read-crc-pipe-b:
shard-skl: PASS -> INCOMPLETE (fdo#104108, fdo#107773) +1
igt@kms_plane@plane-panning-bottom-right-suspend-pipe-b-planes:
shard-skl: PASS -> INCOMPLETE (fdo#104108)
igt@kms_plane@plane-position-covered-pipe-a-planes:
shard-apl: PASS -> FAIL (fdo#103166) +1
igt@kms_plane_alpha_blend@pipe-a-constant-alpha-max:
shard-skl: NOTRUN -> FAIL (fdo#108145)
igt@kms_plane_alpha_blend@pipe-c-alpha-7efc:
shard-skl: NOTRUN -> FAIL (fdo#107815, fdo#108145)
igt@kms_plane_alpha_blend@pipe-c-coverage-7efc:
{shard-iclb}: PASS -> DMESG-WARN (fdo#107724, fdo#108336) +4
igt@kms_plane_multiple@atomic-pipe-b-tiling-yf:
{shard-iclb}: PASS -> FAIL (fdo#103166)
igt@kms_plane_scaling@pipe-a-scaler-with-pixel-format:
{shard-iclb}: NOTRUN -> DMESG-WARN (fdo#107724) +2
igt@pm_rpm@modeset-non-lpsp-stress-no-wait:
shard-skl: SKIP -> INCOMPLETE (fdo#107807)
igt@pm_rpm@universal-planes:
shard-skl: PASS -> INCOMPLETE (fdo#107807) +1
==== Possible fixes ====
igt@gem_exec_whisper@normal:
shard-skl: TIMEOUT (fdo#108592) -> PASS
igt@kms_color@pipe-c-ctm-0-75:
shard-skl: FAIL (fdo#108682) -> PASS
igt@kms_cursor_crc@cursor-128x42-onscreen:
shard-apl: FAIL (fdo#103232) -> PASS
igt@kms_cursor_legacy@cursora-vs-flipa-toggle:
shard-glk: DMESG-WARN (fdo#106538, fdo#105763) -> PASS
igt@kms_draw_crc@draw-method-rgb565-blt-ytiled:
shard-glk: FAIL (fdo#103184) -> PASS
igt@kms_frontbuffer_tracking@fbc-1p-primscrn-spr-indfb-draw-pwrite:
{shard-iclb}: FAIL (fdo#103167) -> PASS +5
shard-apl: FAIL (fdo#103167) -> PASS +4
igt@kms_frontbuffer_tracking@fbc-2p-primscrn-spr-indfb-onoff:
shard-glk: FAIL (fdo#103167) -> PASS
igt@kms_plane_multiple@atomic-pipe-a-tiling-x:
shard-apl: FAIL (fdo#103166) -> PASS
igt@kms_rmfb@rmfb-ioctl:
{shard-iclb}: DMESG-WARN (fdo#107724) -> PASS +1
igt@pm_rpm@dpms-lpsp:
shard-skl: INCOMPLETE (fdo#107807) -> PASS
igt@pm_rpm@gem-execbuf-stress-pc8:
{shard-iclb}: INCOMPLETE -> SKIP
==== Warnings ====
igt@i915_suspend@shrink:
shard-skl: INCOMPLETE (fdo#106886) -> DMESG-WARN (fdo#108784)
igt@kms_fbcon_fbt@psr-suspend:
shard-skl: INCOMPLETE (fdo#104108, fdo#107773) -> FAIL (fdo#107882)
igt@pm_rpm@modeset-stress-extra-wait:
{shard-iclb}: INCOMPLETE -> DMESG-WARN (fdo#107724)
{name}: This element is suppressed. This means it is ignored when computing
the status of the difference (SUCCESS, WARNING, or FAILURE).
fdo#103166 https://bugs.freedesktop.org/show_bug.cgi?id=103166
fdo#103167 https://bugs.freedesktop.org/show_bug.cgi?id=103167
fdo#103184 https://bugs.freedesktop.org/show_bug.cgi?id=103184
fdo#103232 https://bugs.freedesktop.org/show_bug.cgi?id=103232
fdo#103665 https://bugs.freedesktop.org/show_bug.cgi?id=103665
fdo#104108 https://bugs.freedesktop.org/show_bug.cgi?id=104108
fdo#105363 https://bugs.freedesktop.org/show_bug.cgi?id=105363
fdo#105763 https://bugs.freedesktop.org/show_bug.cgi?id=105763
fdo#106023 https://bugs.freedesktop.org/show_bug.cgi?id=106023
fdo#106538 https://bugs.freedesktop.org/show_bug.cgi?id=106538
fdo#106886 https://bugs.freedesktop.org/show_bug.cgi?id=106886
fdo#106887 https://bugs.freedesktop.org/show_bug.cgi?id=106887
fdo#107724 https://bugs.freedesktop.org/show_bug.cgi?id=107724
fdo#107773 https://bugs.freedesktop.org/show_bug.cgi?id=107773
fdo#107807 https://bugs.freedesktop.org/show_bug.cgi?id=107807
fdo#107815 https://bugs.freedesktop.org/show_bug.cgi?id=107815
fdo#107882 https://bugs.freedesktop.org/show_bug.cgi?id=107882
fdo#107956 https://bugs.freedesktop.org/show_bug.cgi?id=107956
fdo#108145 https://bugs.freedesktop.org/show_bug.cgi?id=108145
fdo#108336 https://bugs.freedesktop.org/show_bug.cgi?id=108336
fdo#108592 https://bugs.freedesktop.org/show_bug.cgi?id=108592
fdo#108682 https://bugs.freedesktop.org/show_bug.cgi?id=108682
fdo#108784 https://bugs.freedesktop.org/show_bug.cgi?id=108784
== Participating hosts (7 -> 7) ==
No changes in participating hosts
== Build changes ==
* Linux: CI_DRM_5180 -> Patchwork_10876
CI_DRM_5180: 95de9a943571204eda4dc3156c3d984ba07c78e4 @ git://anongit.freedesktop.org/gfx-ci/linux
IGT_4723: 53bb24ad410b53cdd96f15ced8fd5921c8ab0eac @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools
Patchwork_10876: ce745cbd4d6a0e3141219c2ffa73395ad57e4084 @ git://anongit.freedesktop.org/gfx-ci/linux
piglit_4509: fdc5a4ca11124ab8413c7988896eec4c97336694 @ git://anongit.freedesktop.org/piglit
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_10876/shards.html
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2018-11-21 20:33 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2018-11-21 11:58 [PATCH] drm/i915/selftests: Use msecs_to_jiffies() for an explicit ms timeout Chris Wilson
2018-11-21 12:26 ` Mika Kuoppala
2018-11-21 12:37 ` Chris Wilson
2018-11-21 12:33 ` ✓ Fi.CI.BAT: success for " Patchwork
2018-11-21 12:42 ` Chris Wilson
2018-11-21 20:33 ` ✓ Fi.CI.IGT: " Patchwork
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.