* [PATCH net-next] ath10k: fix copy-paste error in ath10k_qmi_setup_msa_resources()
@ 2018-10-16 2:35 ` Wei Yongjun
0 siblings, 0 replies; 9+ messages in thread
From: Wei Yongjun @ 2018-10-16 2:35 UTC (permalink / raw)
To: Kalle Valo, Govind Singh
Cc: Wei Yongjun, ath10k, linux-wireless, kernel-janitors
The return value from devm_memremap() is not checked correctly.
The test is done against a wrong variable. This patch fix it.
Fixes: ba94c753ccb4 ("ath10k: add QMI message handshake for wcn3990 client")
Signed-off-by: Wei Yongjun <weiyongjun1@huawei.com>
---
drivers/net/wireless/ath/ath10k/qmi.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/wireless/ath/ath10k/qmi.c b/drivers/net/wireless/ath/ath10k/qmi.c
index 56cb183..c2cbb41 100644
--- a/drivers/net/wireless/ath/ath10k/qmi.c
+++ b/drivers/net/wireless/ath/ath10k/qmi.c
@@ -931,7 +931,7 @@ static int ath10k_qmi_setup_msa_resources(struct ath10k_qmi *qmi, u32 msa_size)
qmi->msa_mem_size = resource_size(&r);
qmi->msa_va = devm_memremap(dev, qmi->msa_pa, qmi->msa_mem_size,
MEMREMAP_WT);
- if (!qmi->msa_pa) {
+ if (!qmi->msa_va) {
dev_err(dev, "failed to map memory region: %pa\n", &r.start);
return -EBUSY;
}
^ permalink raw reply related [flat|nested] 9+ messages in thread* [PATCH net-next] ath10k: fix copy-paste error in ath10k_qmi_setup_msa_resources()
@ 2018-10-16 2:35 ` Wei Yongjun
0 siblings, 0 replies; 9+ messages in thread
From: Wei Yongjun @ 2018-10-16 2:35 UTC (permalink / raw)
To: Kalle Valo, Govind Singh
Cc: linux-wireless, kernel-janitors, Wei Yongjun, ath10k
The return value from devm_memremap() is not checked correctly.
The test is done against a wrong variable. This patch fix it.
Fixes: ba94c753ccb4 ("ath10k: add QMI message handshake for wcn3990 client")
Signed-off-by: Wei Yongjun <weiyongjun1@huawei.com>
---
drivers/net/wireless/ath/ath10k/qmi.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/wireless/ath/ath10k/qmi.c b/drivers/net/wireless/ath/ath10k/qmi.c
index 56cb183..c2cbb41 100644
--- a/drivers/net/wireless/ath/ath10k/qmi.c
+++ b/drivers/net/wireless/ath/ath10k/qmi.c
@@ -931,7 +931,7 @@ static int ath10k_qmi_setup_msa_resources(struct ath10k_qmi *qmi, u32 msa_size)
qmi->msa_mem_size = resource_size(&r);
qmi->msa_va = devm_memremap(dev, qmi->msa_pa, qmi->msa_mem_size,
MEMREMAP_WT);
- if (!qmi->msa_pa) {
+ if (!qmi->msa_va) {
dev_err(dev, "failed to map memory region: %pa\n", &r.start);
return -EBUSY;
}
^ permalink raw reply related [flat|nested] 9+ messages in thread* Re: [PATCH net-next] ath10k: fix copy-paste error in ath10k_qmi_setup_msa_resources()
2018-10-16 2:35 ` Wei Yongjun
(?)
@ 2018-10-24 8:38 ` Kalle Valo
-1 siblings, 0 replies; 9+ messages in thread
From: Kalle Valo @ 2018-10-24 8:38 UTC (permalink / raw)
To: Wei Yongjun; +Cc: kernel-janitors, Govind Singh, linux-wireless, ath10k
Wei Yongjun <weiyongjun1@huawei.com> writes:
> The return value from devm_memremap() is not checked correctly.
> The test is done against a wrong variable. This patch fix it.
>
> Fixes: ba94c753ccb4 ("ath10k: add QMI message handshake for wcn3990 client")
> Signed-off-by: Wei Yongjun <weiyongjun1@huawei.com>
Please don't mark wireless patches for net-next, by default ath10k
patches go to ath-next branch of my ath.git tree. But no need to resend
because of this.
--
Kalle Valo
_______________________________________________
ath10k mailing list
ath10k@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/ath10k
^ permalink raw reply [flat|nested] 9+ messages in thread* Re: [PATCH net-next] ath10k: fix copy-paste error in ath10k_qmi_setup_msa_resources()
@ 2018-10-24 8:38 ` Kalle Valo
0 siblings, 0 replies; 9+ messages in thread
From: Kalle Valo @ 2018-10-24 8:38 UTC (permalink / raw)
To: Wei Yongjun; +Cc: Govind Singh, linux-wireless, kernel-janitors, ath10k
Wei Yongjun <weiyongjun1@huawei.com> writes:
> The return value from devm_memremap() is not checked correctly.
> The test is done against a wrong variable. This patch fix it.
>
> Fixes: ba94c753ccb4 ("ath10k: add QMI message handshake for wcn3990 client")
> Signed-off-by: Wei Yongjun <weiyongjun1@huawei.com>
Please don't mark wireless patches for net-next, by default ath10k
patches go to ath-next branch of my ath.git tree. But no need to resend
because of this.
--
Kalle Valo
^ permalink raw reply [flat|nested] 9+ messages in thread* Re: [PATCH net-next] ath10k: fix copy-paste error in ath10k_qmi_setup_msa_resources()
@ 2018-10-24 8:38 ` Kalle Valo
0 siblings, 0 replies; 9+ messages in thread
From: Kalle Valo @ 2018-10-24 8:38 UTC (permalink / raw)
To: Wei Yongjun; +Cc: kernel-janitors, Govind Singh, linux-wireless, ath10k
Wei Yongjun <weiyongjun1@huawei.com> writes:
> The return value from devm_memremap() is not checked correctly.
> The test is done against a wrong variable. This patch fix it.
>
> Fixes: ba94c753ccb4 ("ath10k: add QMI message handshake for wcn3990 client")
> Signed-off-by: Wei Yongjun <weiyongjun1@huawei.com>
Please don't mark wireless patches for net-next, by default ath10k
patches go to ath-next branch of my ath.git tree. But no need to resend
because of this.
--
Kalle Valo
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH net-next] ath10k: fix copy-paste error in ath10k_qmi_setup_msa_resources()
2018-10-16 2:35 ` Wei Yongjun
@ 2018-11-05 10:12 ` Kalle Valo
-1 siblings, 0 replies; 9+ messages in thread
From: Kalle Valo @ 2018-11-05 10:12 UTC (permalink / raw)
To: Wei Yongjun; +Cc: Govind Singh, ath10k, linux-wireless, kernel-janitors
Wei Yongjun <weiyongjun1@huawei.com> wrote:
> The return value from devm_memremap() is not checked correctly.
> The test is done against a wrong variable. This patch fix it.
>
> Fixes: ba94c753ccb4 ("ath10k: add QMI message handshake for wcn3990 client")
> Signed-off-by: Wei Yongjun <weiyongjun1@huawei.com>
> Signed-off-by: Kalle Valo <kvalo@codeaurora.org>
Patch applied to ath-next branch of ath.git, thanks.
4ab7fd955e47 ath10k: fix copy-paste error in ath10k_qmi_setup_msa_resources()
--
https://patchwork.kernel.org/patch/10642589/
https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches
^ permalink raw reply [flat|nested] 9+ messages in thread* Re: [PATCH net-next] ath10k: fix copy-paste error in ath10k_qmi_setup_msa_resources()
2018-10-16 2:35 ` Wei Yongjun
` (3 preceding siblings ...)
(?)
@ 2018-11-05 10:12 ` Kalle Valo
-1 siblings, 0 replies; 9+ messages in thread
From: Kalle Valo @ 2018-11-05 10:12 UTC (permalink / raw)
To: Wei Yongjun; +Cc: linux-wireless, kernel-janitors, Govind Singh, ath10k
Wei Yongjun <weiyongjun1@huawei.com> wrote:
> The return value from devm_memremap() is not checked correctly.
> The test is done against a wrong variable. This patch fix it.
>
> Fixes: ba94c753ccb4 ("ath10k: add QMI message handshake for wcn3990 client")
> Signed-off-by: Wei Yongjun <weiyongjun1@huawei.com>
> Signed-off-by: Kalle Valo <kvalo@codeaurora.org>
Patch applied to ath-next branch of ath.git, thanks.
4ab7fd955e47 ath10k: fix copy-paste error in ath10k_qmi_setup_msa_resources()
--
https://patchwork.kernel.org/patch/10642589/
https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches
_______________________________________________
ath10k mailing list
ath10k@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/ath10k
^ permalink raw reply [flat|nested] 9+ messages in thread