Re: [RISU PATCH v3 05/22] risu: add zlib indication to help text

All of lore.kernel.org
 help / color / mirror / Atom feed

From: "Alex Bennée" <alex.bennee@linaro.org>
To: Richard Henderson <richard.henderson@linaro.org>
Cc: peter.maydell@linaro.org, qemu-arm@nongnu.org, qemu-devel@nongnu.org
Subject: Re: [RISU PATCH v3 05/22] risu: add zlib indication to help text
Date: Thu, 14 Jun 2018 09:34:53 +0100	[thread overview]
Message-ID: <871sd922c2.fsf@linaro.org> (raw)
In-Reply-To: <a24ec09d-9bf8-ea12-092f-9df1d4ad7786@linaro.org>

Richard Henderson <richard.henderson@linaro.org> writes:

> On 06/13/2018 02:55 AM, Alex Bennée wrote:
>> This is a simple aide-memoir as it can be tricky to determine this
>> with a simple statically compiled binary.
>>
>> Signed-off-by: Alex Bennée <alex.bennee@linaro.org>
>> ---
>>  risu.c | 5 ++++-
>>  1 file changed, 4 insertions(+), 1 deletion(-)
>
> Eh, sure.  Or we could simply require zlib...
>
> Reviewed-by: Richard Henderson <richard.henderson@linaro.org>

I would be some cross compilers (or more correctly multiarch setups) are
broken in this regard. There was a time before I moved to 18.04 that I
couldn't have multiple zlib1g-dev packages installed due to clashing
files.

As risu accepts stdin/stdout for trace files you can work around this
with pipes and native gzip so a non-zlib enabled risu is still usable.
But I'm happy to defer to Peter on this one.

--
Alex Bennée

WARNING: multiple messages have this Message-ID (diff)

From: "Alex Bennée" <alex.bennee@linaro.org>
To: Richard Henderson <richard.henderson@linaro.org>
Cc: peter.maydell@linaro.org, qemu-arm@nongnu.org, qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [RISU PATCH v3 05/22] risu: add zlib indication to help text
Date: Thu, 14 Jun 2018 09:34:53 +0100	[thread overview]
Message-ID: <871sd922c2.fsf@linaro.org> (raw)
In-Reply-To: <a24ec09d-9bf8-ea12-092f-9df1d4ad7786@linaro.org>

Richard Henderson <richard.henderson@linaro.org> writes:

> On 06/13/2018 02:55 AM, Alex Bennée wrote:
>> This is a simple aide-memoir as it can be tricky to determine this
>> with a simple statically compiled binary.
>>
>> Signed-off-by: Alex Bennée <alex.bennee@linaro.org>
>> ---
>>  risu.c | 5 ++++-
>>  1 file changed, 4 insertions(+), 1 deletion(-)
>
> Eh, sure.  Or we could simply require zlib...
>
> Reviewed-by: Richard Henderson <richard.henderson@linaro.org>

I would be some cross compilers (or more correctly multiarch setups) are
broken in this regard. There was a time before I moved to 18.04 that I
couldn't have multiple zlib1g-dev packages installed due to clashing
files.

As risu accepts stdin/stdout for trace files you can work around this
with pipes and native gzip so a non-zlib enabled risu is still usable.
But I'm happy to defer to Peter on this one.

--
Alex Bennée

next prev parent reply	other threads:[~2018-06-14  8:34 UTC|newest]

Thread overview: 76+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-06-13 12:55 [RISU PATCH v3 00/22] SVE support and various misc fixes Alex Bennée
2018-06-13 12:55 ` [Qemu-devel] " Alex Bennée
2018-06-13 12:55 ` [RISU PATCH v3 01/22] risu_reginfo_aarch64: include signal.h for FPSIMD_MAGIC Alex Bennée
2018-06-13 12:55   ` [Qemu-devel] " Alex Bennée
2018-06-14  5:40   ` Richard Henderson
2018-06-14  5:40     ` [Qemu-devel] " Richard Henderson
2018-06-13 12:55 ` [RISU PATCH v3 02/22] comms: include header for writev Alex Bennée
2018-06-13 12:55   ` [Qemu-devel] " Alex Bennée
2018-06-14  5:41   ` Richard Henderson
2018-06-14  5:41     ` [Qemu-devel] " Richard Henderson
2018-06-13 12:55 ` [RISU PATCH v3 03/22] build-all-arches: expand the range of docker images Alex Bennée
2018-06-13 12:55   ` [Qemu-devel] " Alex Bennée
2018-06-14  5:42   ` Richard Henderson
2018-06-14  5:42     ` [Qemu-devel] " Richard Henderson
2018-06-13 12:55 ` [RISU PATCH v3 04/22] build-all-arches: do a distclean $(SRC) configured Alex Bennée
2018-06-13 12:55   ` [Qemu-devel] " Alex Bennée
2018-06-14  5:43   ` Richard Henderson
2018-06-14  5:43     ` [Qemu-devel] " Richard Henderson
2018-06-13 12:55 ` [RISU PATCH v3 05/22] risu: add zlib indication to help text Alex Bennée
2018-06-13 12:55   ` [Qemu-devel] " Alex Bennée
2018-06-14  5:47   ` Richard Henderson
2018-06-14  5:47     ` [Qemu-devel] " Richard Henderson
2018-06-14  8:34     ` Alex Bennée [this message]
2018-06-14  8:34       ` Alex Bennée
2018-06-13 12:55 ` [RISU PATCH v3 06/22] Makefile: include risu_reginfo_$(ARCH) in HDRS Alex Bennée
2018-06-13 12:55   ` [Qemu-devel] " Alex Bennée
2018-06-14  5:50   ` Richard Henderson
2018-06-14  5:50     ` [Qemu-devel] " Richard Henderson
2018-06-13 12:55 ` [RISU PATCH v3 07/22] risugen: add --sve support Alex Bennée
2018-06-13 12:55   ` [Qemu-devel] " Alex Bennée
2018-06-13 12:55 ` [RISU PATCH v3 08/22] risugen: Initialize sve predicates with random data Alex Bennée
2018-06-13 12:55   ` [Qemu-devel] " Alex Bennée
2018-06-13 12:55 ` [RISU PATCH v3 09/22] risugen: use fewer insns for aarch64 immediate load Alex Bennée
2018-06-13 12:55   ` [Qemu-devel] " Alex Bennée
2018-06-13 12:55 ` [RISU PATCH v3 10/22] risugen: add reg_plus_imm_pl and reg_plus_imm_vl address helpers Alex Bennée
2018-06-13 12:55   ` [Qemu-devel] " Alex Bennée
2018-06-13 12:55 ` [RISU PATCH v3 11/22] risugen: add dtype_msz address helper Alex Bennée
2018-06-13 12:55   ` [Qemu-devel] " Alex Bennée
2018-06-13 12:55 ` [RISU PATCH v3 12/22] contrib/generate_all.sh: allow passing of arguments to risugen Alex Bennée
2018-06-13 12:55   ` [Qemu-devel] " Alex Bennée
2018-06-13 12:55 ` [RISU PATCH v3 13/22] risu: move optional args to each architecture Alex Bennée
2018-06-13 12:55   ` [Qemu-devel] " Alex Bennée
2018-06-14 20:20   ` Richard Henderson
2018-06-14 20:20     ` [Qemu-devel] " Richard Henderson
2018-06-13 12:55 ` [RISU PATCH v3 14/22] risu: add process_arch_opt Alex Bennée
2018-06-13 12:55   ` [Qemu-devel] " Alex Bennée
2018-06-13 12:55 ` [RISU PATCH v3 15/22] risu_reginfo_aarch64: drop stray ; Alex Bennée
2018-06-13 12:55   ` [Qemu-devel] " Alex Bennée
2018-06-14 20:23   ` Richard Henderson
2018-06-14 20:23     ` [Qemu-devel] " Richard Henderson
2018-06-13 12:55 ` [RISU PATCH v3 16/22] risu_reginfo_aarch64: unionify VFP regs Alex Bennée
2018-06-13 12:55   ` [Qemu-devel] " Alex Bennée
2018-06-14 20:24   ` Richard Henderson
2018-06-14 20:24     ` [Qemu-devel] " Richard Henderson
2018-06-13 12:55 ` [RISU PATCH v3 17/22] risu_reginfo: introduce reginfo_size() Alex Bennée
2018-06-13 12:55   ` [Qemu-devel] " Alex Bennée
2018-06-14 20:25   ` Richard Henderson
2018-06-14 20:25     ` [Qemu-devel] " Richard Henderson
2018-06-13 12:55 ` [RISU PATCH v3 18/22] risu_reginfo_aarch64: left justify regnums and drop masks Alex Bennée
2018-06-13 12:55   ` [Qemu-devel] " Alex Bennée
2018-06-14 20:26   ` Richard Henderson
2018-06-14 20:26     ` [Qemu-devel] " Richard Henderson
2018-06-13 12:55 ` [RISU PATCH v3 19/22] risu_reginfo_aarch64: add support for copying SVE register state Alex Bennée
2018-06-13 12:55   ` [Qemu-devel] " Alex Bennée
2018-06-14 20:33   ` Richard Henderson
2018-06-14 20:33     ` [Qemu-devel] " Richard Henderson
2018-06-13 12:55 ` [RISU PATCH v3 20/22] risu_reginfo_aarch64: add SVE support to reginfo_dump_mismatch Alex Bennée
2018-06-13 12:55   ` [Qemu-devel] " Alex Bennée
2018-06-14 20:42   ` Richard Henderson
2018-06-14 20:42     ` [Qemu-devel] " Richard Henderson
2018-06-13 12:56 ` [RISU PATCH v3 21/22] risu_reginfo_aarch64: limit SVE_VQ_MAX to current architecture Alex Bennée
2018-06-13 12:56   ` [Qemu-devel] " Alex Bennée
2018-06-13 12:56 ` [RISU PATCH v3 22/22] risu_reginfo_aarch64: handle variable VQ Alex Bennée
2018-06-13 12:56   ` [Qemu-devel] " Alex Bennée
2018-06-14 20:50   ` Richard Henderson
2018-06-14 20:50     ` [Qemu-devel] " Richard Henderson

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=871sd922c2.fsf@linaro.org \
    --to=alex.bennee@linaro.org \
    --cc=peter.maydell@linaro.org \
    --cc=qemu-arm@nongnu.org \
    --cc=qemu-devel@nongnu.org \
    --cc=richard.henderson@linaro.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

Be sure your reply has a Subject: header at the top and a blank line before the message body.

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.