From: Kalle Valo <kvalo@codeaurora.org>
To: s.gottschall@dd-wrt.com
Cc: Sebastian Gottschall <s.gottschall@newmedia-net.de>,
linux-wireless@vger.kernel.org, ath10k@lists.infradead.org
Subject: Re: [PATCH v12] ath10k: add LED and GPIO controlling support for various chipsets
Date: Thu, 05 Apr 2018 17:44:05 +0300 [thread overview]
Message-ID: <871sftemru.fsf@kamboji.qca.qualcomm.com> (raw)
In-Reply-To: <20180226084406.2093-1-s.gottschall@dd-wrt.com> (s. gottschall's message of "Mon, 26 Feb 2018 09:44:06 +0100")
s.gottschall@dd-wrt.com writes:
> Adds LED and GPIO Control support for 988x, 9887, 9888, 99x0, 9984
> based chipsets with on chipset connected led's using WMI Firmware API.
> The LED device will get available named as "ath10k-phyX" at sysfs and
> can be controlled with various triggers. adds also debugfs interface
> for gpio control.
>
> Signed-off-by: Sebastian Gottschall <s.gottschall@dd-wrt.com>
[...]
> @@ -1034,7 +1068,7 @@ ath10k_wmi_pdev_get_temperature(struct ath10k *ar)
> if (IS_ERR(skb))
> return PTR_ERR(skb);
>
> - return ath10k_wmi_cmd_send(ar, skb,
> + return ath10k_wmi_cmd_send_nowait(ar, skb,
> ar->wmi.cmd->pdev_get_temperature_cmdid);
> }
This looks odd, I don't think it belongs to this patch.
Also you made a some sort of record, your patch had 181 checkpatch
warnings! Do you use Word as your editor or what? :) But please do check
your editor settings and read the coding style documents.
https://wireless.wiki.kernel.org/en/users/drivers/ath10k/codingstyle
I'll send v13.
Here are the warnings from ath10k-check:
drivers/net/wireless/ath/ath10k/gpio.c:19: Please don't use multiple blank lines
drivers/net/wireless/ath/ath10k/gpio.c:30: Please don't use multiple blank lines
drivers/net/wireless/ath/ath10k/gpio.c:36: Prefer 'unsigned int' to bare use of 'unsigned'
drivers/net/wireless/ath/ath10k/gpio.c:38: line over 90 characters
drivers/net/wireless/ath/ath10k/gpio.c:39: line over 90 characters
drivers/net/wireless/ath/ath10k/gpio.c:39: Missing a blank line after declarations
drivers/net/wireless/ath/ath10k/gpio.c:45: Prefer 'unsigned int' to bare use of 'unsigned'
drivers/net/wireless/ath/ath10k/gpio.c:46: Alignment should match open parenthesis
drivers/net/wireless/ath/ath10k/gpio.c:48: line over 90 characters
drivers/net/wireless/ath/ath10k/gpio.c:50: line over 90 characters
drivers/net/wireless/ath/ath10k/gpio.c:58: Prefer 'unsigned int' to bare use of 'unsigned'
drivers/net/wireless/ath/ath10k/gpio.c:60: line over 90 characters
drivers/net/wireless/ath/ath10k/gpio.c:66: Prefer 'unsigned int' to bare use of 'unsigned'
drivers/net/wireless/ath/ath10k/gpio.c:68: line over 90 characters
drivers/net/wireless/ath/ath10k/gpio.c:74: Prefer 'unsigned int' to bare use of 'unsigned'
drivers/net/wireless/ath/ath10k/gpio.c:75: Alignment should match open parenthesis
drivers/net/wireless/ath/ath10k/gpio.c:77: line over 90 characters
drivers/net/wireless/ath/ath10k/gpio.c:86: trailing whitespace
drivers/net/wireless/ath/ath10k/gpio.c:86: please, no spaces at the start of a line
drivers/net/wireless/ath/ath10k/gpio.c:86: Blank lines aren't necessary after an open brace '{'
drivers/net/wireless/ath/ath10k/gpio.c:88: Missing a blank line after declarations
drivers/net/wireless/ath/ath10k/gpio.c:88: braces {} are not necessary for single statement blocks
drivers/net/wireless/ath/ath10k/gpio.c:113: trailing whitespace
drivers/net/wireless/ath/ath10k/gpio.c:114: Missing a blank line after declarations
drivers/net/wireless/ath/ath10k/gpio.c:114: braces {} are not necessary for single statement blocks
drivers/net/wireless/ath/ath10k/gpio.c:121: line over 90 characters
drivers/net/wireless/ath/ath10k/gpio.c:130: Please don't use multiple blank lines
drivers/net/wireless/ath/ath10k/gpio.c:132: Alignment should match open parenthesis
drivers/net/wireless/ath/ath10k/gpio.c:134: line over 90 characters
drivers/net/wireless/ath/ath10k/gpio.c:136: Missing a blank line after declarations
drivers/net/wireless/ath/ath10k/gpio.c:145: trailing whitespace
drivers/net/wireless/ath/ath10k/gpio.c:146: Missing a blank line after declarations
drivers/net/wireless/ath/ath10k/gpio.c:159: trailing whitespace
drivers/net/wireless/ath/ath10k/gpio.c:160: Missing a blank line after declarations
drivers/net/wireless/ath/ath10k/gpio.c:166: trailing whitespace
drivers/net/wireless/ath/ath10k/gpio.c:169: trailing whitespace
drivers/net/wireless/ath/ath10k/gpio.c:170: line over 90 characters
drivers/net/wireless/ath/ath10k/gpio.c:178: Missing a blank line after declarations
drivers/net/wireless/ath/ath10k/gpio.c:181: Prefer kzalloc(sizeof(*gpio)...) over kzalloc(sizeof(struct ath10k_gpiocontrol)...)
drivers/net/wireless/ath/ath10k/gpio.c:182: braces {} are not necessary for single statement blocks
drivers/net/wireless/ath/ath10k/gpio.c:192: trailing whitespace
drivers/net/wireless/ath/ath10k/gpio.c:194: line over 90 characters
drivers/net/wireless/ath/ath10k/gpio.c:196: trailing whitespace
drivers/net/wireless/ath/ath10k/core.h:865: trailing whitespace
drivers/net/wireless/ath/ath10k/core.h:865: line over 90 characters
drivers/net/wireless/ath/ath10k/core.h:871: trailing whitespace
drivers/net/wireless/ath/ath10k/core.h:890: Blank lines aren't necessary after an open brace '{'
drivers/net/wireless/ath/ath10k/core.h:891: Blank lines aren't necessary before a close brace '}'
drivers/net/wireless/ath/ath10k/core.h:892: Please use a blank line after function/struct/union/enum declarations
drivers/net/wireless/ath/ath10k/core.h:894: Blank lines aren't necessary after an open brace '{'
drivers/net/wireless/ath/ath10k/core.h:895: Blank lines aren't necessary before a close brace '}'
drivers/net/wireless/ath/ath10k/core.h:896: Please use a blank line after function/struct/union/enum declarations
drivers/net/wireless/ath/ath10k/core.h:905: trailing whitespace
drivers/net/wireless/ath/ath10k/core.h:907: Blank lines aren't necessary after an open brace '{'
drivers/net/wireless/ath/ath10k/core.h:908: Blank lines aren't necessary before a close brace '}'
drivers/net/wireless/ath/ath10k/core.c:29: Please don't use multiple blank lines
drivers/net/wireless/ath/ath10k/core.c:74: trailing whitespace
drivers/net/wireless/ath/ath10k/core.c:105: trailing whitespace
drivers/net/wireless/ath/ath10k/core.c:136: trailing whitespace
drivers/net/wireless/ath/ath10k/core.c:282: trailing whitespace
drivers/net/wireless/ath/ath10k/core.c:318: trailing whitespace
drivers/net/wireless/ath/ath10k/core.c:359: trailing whitespace
drivers/net/wireless/ath/ath10k/core.c:2396: trailing whitespace
drivers/net/wireless/ath/ath10k/core.c:2396: Please don't use multiple blank lines
drivers/net/wireless/ath/ath10k/core.c:2403: trailing whitespace
drivers/net/wireless/ath/ath10k/debug.c:1089: Alignment should match open parenthesis
drivers/net/wireless/ath/ath10k/debug.c:1092: trailing whitespace
drivers/net/wireless/ath/ath10k/debug.c:1095: Missing a blank line after declarations
drivers/net/wireless/ath/ath10k/debug.c:1098: line over 90 characters
drivers/net/wireless/ath/ath10k/debug.c:1103: Please don't use multiple blank lines
drivers/net/wireless/ath/ath10k/debug.c:1105: Alignment should match open parenthesis
drivers/net/wireless/ath/ath10k/debug.c:1109: trailing whitespace
drivers/net/wireless/ath/ath10k/debug.c:1113: Missing a blank line after declarations
drivers/net/wireless/ath/ath10k/debug.c:1130: Please don't use multiple blank lines
drivers/net/wireless/ath/ath10k/debug.c:1133: Please don't use multiple blank lines
drivers/net/wireless/ath/ath10k/debug.c:1149: Alignment should match open parenthesis
drivers/net/wireless/ath/ath10k/debug.c:1152: trailing whitespace
drivers/net/wireless/ath/ath10k/debug.c:1155: Missing a blank line after declarations
drivers/net/wireless/ath/ath10k/debug.c:1163: Please don't use multiple blank lines
drivers/net/wireless/ath/ath10k/debug.c:1165: Alignment should match open parenthesis
drivers/net/wireless/ath/ath10k/debug.c:1169: trailing whitespace
drivers/net/wireless/ath/ath10k/debug.c:1173: Missing a blank line after declarations
drivers/net/wireless/ath/ath10k/debug.c:1188: Please don't use multiple blank lines
drivers/net/wireless/ath/ath10k/debug.c:1191: Please don't use multiple blank lines
drivers/net/wireless/ath/ath10k/debug.c:1375: Please don't use multiple blank lines
drivers/net/wireless/ath/ath10k/wmi-ops.h:211: Please don't use multiple blank lines
drivers/net/wireless/ath/ath10k/wmi-ops.h:986: trailing whitespace
drivers/net/wireless/ath/ath10k/wmi-ops.h:986: Please use a blank line after function/struct/union/enum declarations
drivers/net/wireless/ath/ath10k/wmi-ops.h:987: line over 90 characters
drivers/net/wireless/ath/ath10k/wmi-ops.h:1001: trailing whitespace
drivers/net/wireless/ath/ath10k/wmi-tlv.c:3340: line over 90 characters
drivers/net/wireless/ath/ath10k/wmi-tlv.c:3342: please, no spaces at the start of a line
drivers/net/wireless/ath/ath10k/wmi-tlv.c:3343: please, no spaces at the start of a line
drivers/net/wireless/ath/ath10k/wmi-tlv.c:3344: please, no spaces at the start of a line
drivers/net/wireless/ath/ath10k/wmi-tlv.c:3345: trailing whitespace
drivers/net/wireless/ath/ath10k/wmi-tlv.c:3345: please, no spaces at the start of a line
drivers/net/wireless/ath/ath10k/wmi-tlv.c:3346: please, no spaces at the start of a line
drivers/net/wireless/ath/ath10k/wmi-tlv.c:3348: please, no spaces at the start of a line
drivers/net/wireless/ath/ath10k/wmi-tlv.c:3349: please, no spaces at the start of a line
drivers/net/wireless/ath/ath10k/wmi-tlv.c:3350: please, no spaces at the start of a line
drivers/net/wireless/ath/ath10k/wmi-tlv.c:3353: please, no spaces at the start of a line
drivers/net/wireless/ath/ath10k/wmi-tlv.c:3354: please, no spaces at the start of a line
drivers/net/wireless/ath/ath10k/wmi-tlv.c:3355: please, no spaces at the start of a line
drivers/net/wireless/ath/ath10k/wmi-tlv.c:3356: please, no spaces at the start of a line
drivers/net/wireless/ath/ath10k/wmi-tlv.c:3358: please, no spaces at the start of a line
drivers/net/wireless/ath/ath10k/wmi-tlv.c:3359: please, no spaces at the start of a line
drivers/net/wireless/ath/ath10k/wmi-tlv.c:3360: please, no spaces at the start of a line
drivers/net/wireless/ath/ath10k/wmi-tlv.c:3361: please, no spaces at the start of a line
drivers/net/wireless/ath/ath10k/wmi-tlv.c:3362: please, no spaces at the start of a line
drivers/net/wireless/ath/ath10k/wmi-tlv.c:3364: please, no spaces at the start of a line
drivers/net/wireless/ath/ath10k/wmi-tlv.c:3365: please, no spaces at the start of a line
drivers/net/wireless/ath/ath10k/wmi-tlv.c:3367: line over 90 characters
drivers/net/wireless/ath/ath10k/wmi-tlv.c:3367: please, no spaces at the start of a line
drivers/net/wireless/ath/ath10k/wmi-tlv.c:3368: please, no spaces at the start of a line
drivers/net/wireless/ath/ath10k/wmi-tlv.c:3374: please, no spaces at the start of a line
drivers/net/wireless/ath/ath10k/wmi-tlv.c:3375: please, no spaces at the start of a line
drivers/net/wireless/ath/ath10k/wmi-tlv.c:3376: please, no spaces at the start of a line
drivers/net/wireless/ath/ath10k/wmi-tlv.c:3377: trailing whitespace
drivers/net/wireless/ath/ath10k/wmi-tlv.c:3377: please, no spaces at the start of a line
drivers/net/wireless/ath/ath10k/wmi-tlv.c:3378: please, no spaces at the start of a line
drivers/net/wireless/ath/ath10k/wmi-tlv.c:3380: please, no spaces at the start of a line
drivers/net/wireless/ath/ath10k/wmi-tlv.c:3381: please, no spaces at the start of a line
drivers/net/wireless/ath/ath10k/wmi-tlv.c:3382: please, no spaces at the start of a line
drivers/net/wireless/ath/ath10k/wmi-tlv.c:3385: please, no spaces at the start of a line
drivers/net/wireless/ath/ath10k/wmi-tlv.c:3386: please, no spaces at the start of a line
drivers/net/wireless/ath/ath10k/wmi-tlv.c:3387: please, no spaces at the start of a line
drivers/net/wireless/ath/ath10k/wmi-tlv.c:3388: please, no spaces at the start of a line
drivers/net/wireless/ath/ath10k/wmi-tlv.c:3390: please, no spaces at the start of a line
drivers/net/wireless/ath/ath10k/wmi-tlv.c:3391: please, no spaces at the start of a line
drivers/net/wireless/ath/ath10k/wmi-tlv.c:3392: please, no spaces at the start of a line
drivers/net/wireless/ath/ath10k/wmi-tlv.c:3394: please, no spaces at the start of a line
drivers/net/wireless/ath/ath10k/wmi-tlv.c:3395: please, no spaces at the start of a line
drivers/net/wireless/ath/ath10k/wmi-tlv.c:3397: line over 90 characters
drivers/net/wireless/ath/ath10k/wmi-tlv.c:3397: please, no spaces at the start of a line
drivers/net/wireless/ath/ath10k/wmi-tlv.c:3398: please, no spaces at the start of a line
drivers/net/wireless/ath/ath10k/wmi-tlv.c:3401: Please don't use multiple blank lines
drivers/net/wireless/ath/ath10k/mac.c:4622: trailing whitespace
drivers/net/wireless/ath/ath10k/mac.c:4623: line over 90 characters
drivers/net/wireless/ath/ath10k/mac.c:4625: trailing whitespace
drivers/net/wireless/ath/ath10k/mac.c:4626: trailing whitespace
drivers/net/wireless/ath/ath10k/wmi.h:2934: please, no spaces at the start of a line
drivers/net/wireless/ath/ath10k/wmi.h:2935: please, no spaces at the start of a line
drivers/net/wireless/ath/ath10k/wmi.h:2936: please, no spaces at the start of a line
drivers/net/wireless/ath/ath10k/wmi.h:2940: please, no spaces at the start of a line
drivers/net/wireless/ath/ath10k/wmi.h:2941: please, no spaces at the start of a line
drivers/net/wireless/ath/ath10k/wmi.h:2942: please, no spaces at the start of a line
drivers/net/wireless/ath/ath10k/wmi.h:2943: please, no spaces at the start of a line
drivers/net/wireless/ath/ath10k/wmi.h:2944: please, no spaces at the start of a line
drivers/net/wireless/ath/ath10k/wmi.h:2945: please, no spaces at the start of a line
drivers/net/wireless/ath/ath10k/wmi.h:2950: please, no spaces at the start of a line
drivers/net/wireless/ath/ath10k/wmi.h:2951: please, no spaces at the start of a line
drivers/net/wireless/ath/ath10k/wmi.h:2952: please, no spaces at the start of a line
drivers/net/wireless/ath/ath10k/wmi.h:2953: please, no spaces at the start of a line
drivers/net/wireless/ath/ath10k/wmi.h:2958: please, no spaces at the start of a line
drivers/net/wireless/ath/ath10k/wmi.h:2959: please, no spaces at the start of a line
drivers/net/wireless/ath/ath10k/wmi.h:2964: please, no spaces at the start of a line
drivers/net/wireless/ath/ath10k/wmi.h:2967: Please don't use multiple blank lines
drivers/net/wireless/ath/ath10k/wmi.c:6957: line over 90 characters
drivers/net/wireless/ath/ath10k/wmi.c:6959: please, no spaces at the start of a line
drivers/net/wireless/ath/ath10k/wmi.c:6960: please, no spaces at the start of a line
drivers/net/wireless/ath/ath10k/wmi.c:6962: please, no spaces at the start of a line
drivers/net/wireless/ath/ath10k/wmi.c:6963: please, no spaces at the start of a line
drivers/net/wireless/ath/ath10k/wmi.c:6965: please, no spaces at the start of a line
drivers/net/wireless/ath/ath10k/wmi.c:6966: please, no spaces at the start of a line
drivers/net/wireless/ath/ath10k/wmi.c:6967: please, no spaces at the start of a line
drivers/net/wireless/ath/ath10k/wmi.c:6968: please, no spaces at the start of a line
drivers/net/wireless/ath/ath10k/wmi.c:6969: please, no spaces at the start of a line
drivers/net/wireless/ath/ath10k/wmi.c:6971: line over 90 characters
drivers/net/wireless/ath/ath10k/wmi.c:6971: please, no spaces at the start of a line
drivers/net/wireless/ath/ath10k/wmi.c:6972: please, no spaces at the start of a line
drivers/net/wireless/ath/ath10k/wmi.c:6978: please, no spaces at the start of a line
drivers/net/wireless/ath/ath10k/wmi.c:6979: please, no spaces at the start of a line
drivers/net/wireless/ath/ath10k/wmi.c:6981: please, no spaces at the start of a line
drivers/net/wireless/ath/ath10k/wmi.c:6982: please, no spaces at the start of a line
drivers/net/wireless/ath/ath10k/wmi.c:6984: please, no spaces at the start of a line
drivers/net/wireless/ath/ath10k/wmi.c:6985: please, no spaces at the start of a line
drivers/net/wireless/ath/ath10k/wmi.c:6986: please, no spaces at the start of a line
drivers/net/wireless/ath/ath10k/wmi.c:6987: line over 90 characters
drivers/net/wireless/ath/ath10k/wmi.c:6987: please, no spaces at the start of a line
drivers/net/wireless/ath/ath10k/wmi.c:6988: please, no spaces at the start of a line
drivers/net/wireless/ath/ath10k/wmi.c:8583: trailing whitespace
--
Kalle Valo
_______________________________________________
ath10k mailing list
ath10k@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/ath10k
WARNING: multiple messages have this Message-ID (diff)
From: Kalle Valo <kvalo@codeaurora.org>
To: s.gottschall@dd-wrt.com
Cc: linux-wireless@vger.kernel.org,
Sebastian Gottschall <s.gottschall@newmedia-net.de>,
ath10k@lists.infradead.org
Subject: Re: [PATCH v12] ath10k: add LED and GPIO controlling support for various chipsets
Date: Thu, 05 Apr 2018 17:44:05 +0300 [thread overview]
Message-ID: <871sftemru.fsf@kamboji.qca.qualcomm.com> (raw)
In-Reply-To: <20180226084406.2093-1-s.gottschall@dd-wrt.com> (s. gottschall's message of "Mon, 26 Feb 2018 09:44:06 +0100")
s.gottschall@dd-wrt.com writes:
> Adds LED and GPIO Control support for 988x, 9887, 9888, 99x0, 9984
> based chipsets with on chipset connected led's using WMI Firmware API.
> The LED device will get available named as "ath10k-phyX" at sysfs and
> can be controlled with various triggers. adds also debugfs interface
> for gpio control.
>
> Signed-off-by: Sebastian Gottschall <s.gottschall@dd-wrt.com>
[...]
> @@ -1034,7 +1068,7 @@ ath10k_wmi_pdev_get_temperature(struct ath10k *ar)
> if (IS_ERR(skb))
> return PTR_ERR(skb);
>
> - return ath10k_wmi_cmd_send(ar, skb,
> + return ath10k_wmi_cmd_send_nowait(ar, skb,
> ar->wmi.cmd->pdev_get_temperature_cmdid);
> }
This looks odd, I don't think it belongs to this patch.
Also you made a some sort of record, your patch had 181 checkpatch
warnings! Do you use Word as your editor or what? :) But please do check
your editor settings and read the coding style documents.
https://wireless.wiki.kernel.org/en/users/drivers/ath10k/codingstyle
I'll send v13.
Here are the warnings from ath10k-check:
drivers/net/wireless/ath/ath10k/gpio.c:19: Please don't use multiple blank lines
drivers/net/wireless/ath/ath10k/gpio.c:30: Please don't use multiple blank lines
drivers/net/wireless/ath/ath10k/gpio.c:36: Prefer 'unsigned int' to bare use of 'unsigned'
drivers/net/wireless/ath/ath10k/gpio.c:38: line over 90 characters
drivers/net/wireless/ath/ath10k/gpio.c:39: line over 90 characters
drivers/net/wireless/ath/ath10k/gpio.c:39: Missing a blank line after declarations
drivers/net/wireless/ath/ath10k/gpio.c:45: Prefer 'unsigned int' to bare use of 'unsigned'
drivers/net/wireless/ath/ath10k/gpio.c:46: Alignment should match open parenthesis
drivers/net/wireless/ath/ath10k/gpio.c:48: line over 90 characters
drivers/net/wireless/ath/ath10k/gpio.c:50: line over 90 characters
drivers/net/wireless/ath/ath10k/gpio.c:58: Prefer 'unsigned int' to bare use of 'unsigned'
drivers/net/wireless/ath/ath10k/gpio.c:60: line over 90 characters
drivers/net/wireless/ath/ath10k/gpio.c:66: Prefer 'unsigned int' to bare use of 'unsigned'
drivers/net/wireless/ath/ath10k/gpio.c:68: line over 90 characters
drivers/net/wireless/ath/ath10k/gpio.c:74: Prefer 'unsigned int' to bare use of 'unsigned'
drivers/net/wireless/ath/ath10k/gpio.c:75: Alignment should match open parenthesis
drivers/net/wireless/ath/ath10k/gpio.c:77: line over 90 characters
drivers/net/wireless/ath/ath10k/gpio.c:86: trailing whitespace
drivers/net/wireless/ath/ath10k/gpio.c:86: please, no spaces at the start of a line
drivers/net/wireless/ath/ath10k/gpio.c:86: Blank lines aren't necessary after an open brace '{'
drivers/net/wireless/ath/ath10k/gpio.c:88: Missing a blank line after declarations
drivers/net/wireless/ath/ath10k/gpio.c:88: braces {} are not necessary for single statement blocks
drivers/net/wireless/ath/ath10k/gpio.c:113: trailing whitespace
drivers/net/wireless/ath/ath10k/gpio.c:114: Missing a blank line after declarations
drivers/net/wireless/ath/ath10k/gpio.c:114: braces {} are not necessary for single statement blocks
drivers/net/wireless/ath/ath10k/gpio.c:121: line over 90 characters
drivers/net/wireless/ath/ath10k/gpio.c:130: Please don't use multiple blank lines
drivers/net/wireless/ath/ath10k/gpio.c:132: Alignment should match open parenthesis
drivers/net/wireless/ath/ath10k/gpio.c:134: line over 90 characters
drivers/net/wireless/ath/ath10k/gpio.c:136: Missing a blank line after declarations
drivers/net/wireless/ath/ath10k/gpio.c:145: trailing whitespace
drivers/net/wireless/ath/ath10k/gpio.c:146: Missing a blank line after declarations
drivers/net/wireless/ath/ath10k/gpio.c:159: trailing whitespace
drivers/net/wireless/ath/ath10k/gpio.c:160: Missing a blank line after declarations
drivers/net/wireless/ath/ath10k/gpio.c:166: trailing whitespace
drivers/net/wireless/ath/ath10k/gpio.c:169: trailing whitespace
drivers/net/wireless/ath/ath10k/gpio.c:170: line over 90 characters
drivers/net/wireless/ath/ath10k/gpio.c:178: Missing a blank line after declarations
drivers/net/wireless/ath/ath10k/gpio.c:181: Prefer kzalloc(sizeof(*gpio)...) over kzalloc(sizeof(struct ath10k_gpiocontrol)...)
drivers/net/wireless/ath/ath10k/gpio.c:182: braces {} are not necessary for single statement blocks
drivers/net/wireless/ath/ath10k/gpio.c:192: trailing whitespace
drivers/net/wireless/ath/ath10k/gpio.c:194: line over 90 characters
drivers/net/wireless/ath/ath10k/gpio.c:196: trailing whitespace
drivers/net/wireless/ath/ath10k/core.h:865: trailing whitespace
drivers/net/wireless/ath/ath10k/core.h:865: line over 90 characters
drivers/net/wireless/ath/ath10k/core.h:871: trailing whitespace
drivers/net/wireless/ath/ath10k/core.h:890: Blank lines aren't necessary after an open brace '{'
drivers/net/wireless/ath/ath10k/core.h:891: Blank lines aren't necessary before a close brace '}'
drivers/net/wireless/ath/ath10k/core.h:892: Please use a blank line after function/struct/union/enum declarations
drivers/net/wireless/ath/ath10k/core.h:894: Blank lines aren't necessary after an open brace '{'
drivers/net/wireless/ath/ath10k/core.h:895: Blank lines aren't necessary before a close brace '}'
drivers/net/wireless/ath/ath10k/core.h:896: Please use a blank line after function/struct/union/enum declarations
drivers/net/wireless/ath/ath10k/core.h:905: trailing whitespace
drivers/net/wireless/ath/ath10k/core.h:907: Blank lines aren't necessary after an open brace '{'
drivers/net/wireless/ath/ath10k/core.h:908: Blank lines aren't necessary before a close brace '}'
drivers/net/wireless/ath/ath10k/core.c:29: Please don't use multiple blank lines
drivers/net/wireless/ath/ath10k/core.c:74: trailing whitespace
drivers/net/wireless/ath/ath10k/core.c:105: trailing whitespace
drivers/net/wireless/ath/ath10k/core.c:136: trailing whitespace
drivers/net/wireless/ath/ath10k/core.c:282: trailing whitespace
drivers/net/wireless/ath/ath10k/core.c:318: trailing whitespace
drivers/net/wireless/ath/ath10k/core.c:359: trailing whitespace
drivers/net/wireless/ath/ath10k/core.c:2396: trailing whitespace
drivers/net/wireless/ath/ath10k/core.c:2396: Please don't use multiple blank lines
drivers/net/wireless/ath/ath10k/core.c:2403: trailing whitespace
drivers/net/wireless/ath/ath10k/debug.c:1089: Alignment should match open parenthesis
drivers/net/wireless/ath/ath10k/debug.c:1092: trailing whitespace
drivers/net/wireless/ath/ath10k/debug.c:1095: Missing a blank line after declarations
drivers/net/wireless/ath/ath10k/debug.c:1098: line over 90 characters
drivers/net/wireless/ath/ath10k/debug.c:1103: Please don't use multiple blank lines
drivers/net/wireless/ath/ath10k/debug.c:1105: Alignment should match open parenthesis
drivers/net/wireless/ath/ath10k/debug.c:1109: trailing whitespace
drivers/net/wireless/ath/ath10k/debug.c:1113: Missing a blank line after declarations
drivers/net/wireless/ath/ath10k/debug.c:1130: Please don't use multiple blank lines
drivers/net/wireless/ath/ath10k/debug.c:1133: Please don't use multiple blank lines
drivers/net/wireless/ath/ath10k/debug.c:1149: Alignment should match open parenthesis
drivers/net/wireless/ath/ath10k/debug.c:1152: trailing whitespace
drivers/net/wireless/ath/ath10k/debug.c:1155: Missing a blank line after declarations
drivers/net/wireless/ath/ath10k/debug.c:1163: Please don't use multiple blank lines
drivers/net/wireless/ath/ath10k/debug.c:1165: Alignment should match open parenthesis
drivers/net/wireless/ath/ath10k/debug.c:1169: trailing whitespace
drivers/net/wireless/ath/ath10k/debug.c:1173: Missing a blank line after declarations
drivers/net/wireless/ath/ath10k/debug.c:1188: Please don't use multiple blank lines
drivers/net/wireless/ath/ath10k/debug.c:1191: Please don't use multiple blank lines
drivers/net/wireless/ath/ath10k/debug.c:1375: Please don't use multiple blank lines
drivers/net/wireless/ath/ath10k/wmi-ops.h:211: Please don't use multiple blank lines
drivers/net/wireless/ath/ath10k/wmi-ops.h:986: trailing whitespace
drivers/net/wireless/ath/ath10k/wmi-ops.h:986: Please use a blank line after function/struct/union/enum declarations
drivers/net/wireless/ath/ath10k/wmi-ops.h:987: line over 90 characters
drivers/net/wireless/ath/ath10k/wmi-ops.h:1001: trailing whitespace
drivers/net/wireless/ath/ath10k/wmi-tlv.c:3340: line over 90 characters
drivers/net/wireless/ath/ath10k/wmi-tlv.c:3342: please, no spaces at the start of a line
drivers/net/wireless/ath/ath10k/wmi-tlv.c:3343: please, no spaces at the start of a line
drivers/net/wireless/ath/ath10k/wmi-tlv.c:3344: please, no spaces at the start of a line
drivers/net/wireless/ath/ath10k/wmi-tlv.c:3345: trailing whitespace
drivers/net/wireless/ath/ath10k/wmi-tlv.c:3345: please, no spaces at the start of a line
drivers/net/wireless/ath/ath10k/wmi-tlv.c:3346: please, no spaces at the start of a line
drivers/net/wireless/ath/ath10k/wmi-tlv.c:3348: please, no spaces at the start of a line
drivers/net/wireless/ath/ath10k/wmi-tlv.c:3349: please, no spaces at the start of a line
drivers/net/wireless/ath/ath10k/wmi-tlv.c:3350: please, no spaces at the start of a line
drivers/net/wireless/ath/ath10k/wmi-tlv.c:3353: please, no spaces at the start of a line
drivers/net/wireless/ath/ath10k/wmi-tlv.c:3354: please, no spaces at the start of a line
drivers/net/wireless/ath/ath10k/wmi-tlv.c:3355: please, no spaces at the start of a line
drivers/net/wireless/ath/ath10k/wmi-tlv.c:3356: please, no spaces at the start of a line
drivers/net/wireless/ath/ath10k/wmi-tlv.c:3358: please, no spaces at the start of a line
drivers/net/wireless/ath/ath10k/wmi-tlv.c:3359: please, no spaces at the start of a line
drivers/net/wireless/ath/ath10k/wmi-tlv.c:3360: please, no spaces at the start of a line
drivers/net/wireless/ath/ath10k/wmi-tlv.c:3361: please, no spaces at the start of a line
drivers/net/wireless/ath/ath10k/wmi-tlv.c:3362: please, no spaces at the start of a line
drivers/net/wireless/ath/ath10k/wmi-tlv.c:3364: please, no spaces at the start of a line
drivers/net/wireless/ath/ath10k/wmi-tlv.c:3365: please, no spaces at the start of a line
drivers/net/wireless/ath/ath10k/wmi-tlv.c:3367: line over 90 characters
drivers/net/wireless/ath/ath10k/wmi-tlv.c:3367: please, no spaces at the start of a line
drivers/net/wireless/ath/ath10k/wmi-tlv.c:3368: please, no spaces at the start of a line
drivers/net/wireless/ath/ath10k/wmi-tlv.c:3374: please, no spaces at the start of a line
drivers/net/wireless/ath/ath10k/wmi-tlv.c:3375: please, no spaces at the start of a line
drivers/net/wireless/ath/ath10k/wmi-tlv.c:3376: please, no spaces at the start of a line
drivers/net/wireless/ath/ath10k/wmi-tlv.c:3377: trailing whitespace
drivers/net/wireless/ath/ath10k/wmi-tlv.c:3377: please, no spaces at the start of a line
drivers/net/wireless/ath/ath10k/wmi-tlv.c:3378: please, no spaces at the start of a line
drivers/net/wireless/ath/ath10k/wmi-tlv.c:3380: please, no spaces at the start of a line
drivers/net/wireless/ath/ath10k/wmi-tlv.c:3381: please, no spaces at the start of a line
drivers/net/wireless/ath/ath10k/wmi-tlv.c:3382: please, no spaces at the start of a line
drivers/net/wireless/ath/ath10k/wmi-tlv.c:3385: please, no spaces at the start of a line
drivers/net/wireless/ath/ath10k/wmi-tlv.c:3386: please, no spaces at the start of a line
drivers/net/wireless/ath/ath10k/wmi-tlv.c:3387: please, no spaces at the start of a line
drivers/net/wireless/ath/ath10k/wmi-tlv.c:3388: please, no spaces at the start of a line
drivers/net/wireless/ath/ath10k/wmi-tlv.c:3390: please, no spaces at the start of a line
drivers/net/wireless/ath/ath10k/wmi-tlv.c:3391: please, no spaces at the start of a line
drivers/net/wireless/ath/ath10k/wmi-tlv.c:3392: please, no spaces at the start of a line
drivers/net/wireless/ath/ath10k/wmi-tlv.c:3394: please, no spaces at the start of a line
drivers/net/wireless/ath/ath10k/wmi-tlv.c:3395: please, no spaces at the start of a line
drivers/net/wireless/ath/ath10k/wmi-tlv.c:3397: line over 90 characters
drivers/net/wireless/ath/ath10k/wmi-tlv.c:3397: please, no spaces at the start of a line
drivers/net/wireless/ath/ath10k/wmi-tlv.c:3398: please, no spaces at the start of a line
drivers/net/wireless/ath/ath10k/wmi-tlv.c:3401: Please don't use multiple blank lines
drivers/net/wireless/ath/ath10k/mac.c:4622: trailing whitespace
drivers/net/wireless/ath/ath10k/mac.c:4623: line over 90 characters
drivers/net/wireless/ath/ath10k/mac.c:4625: trailing whitespace
drivers/net/wireless/ath/ath10k/mac.c:4626: trailing whitespace
drivers/net/wireless/ath/ath10k/wmi.h:2934: please, no spaces at the start of a line
drivers/net/wireless/ath/ath10k/wmi.h:2935: please, no spaces at the start of a line
drivers/net/wireless/ath/ath10k/wmi.h:2936: please, no spaces at the start of a line
drivers/net/wireless/ath/ath10k/wmi.h:2940: please, no spaces at the start of a line
drivers/net/wireless/ath/ath10k/wmi.h:2941: please, no spaces at the start of a line
drivers/net/wireless/ath/ath10k/wmi.h:2942: please, no spaces at the start of a line
drivers/net/wireless/ath/ath10k/wmi.h:2943: please, no spaces at the start of a line
drivers/net/wireless/ath/ath10k/wmi.h:2944: please, no spaces at the start of a line
drivers/net/wireless/ath/ath10k/wmi.h:2945: please, no spaces at the start of a line
drivers/net/wireless/ath/ath10k/wmi.h:2950: please, no spaces at the start of a line
drivers/net/wireless/ath/ath10k/wmi.h:2951: please, no spaces at the start of a line
drivers/net/wireless/ath/ath10k/wmi.h:2952: please, no spaces at the start of a line
drivers/net/wireless/ath/ath10k/wmi.h:2953: please, no spaces at the start of a line
drivers/net/wireless/ath/ath10k/wmi.h:2958: please, no spaces at the start of a line
drivers/net/wireless/ath/ath10k/wmi.h:2959: please, no spaces at the start of a line
drivers/net/wireless/ath/ath10k/wmi.h:2964: please, no spaces at the start of a line
drivers/net/wireless/ath/ath10k/wmi.h:2967: Please don't use multiple blank lines
drivers/net/wireless/ath/ath10k/wmi.c:6957: line over 90 characters
drivers/net/wireless/ath/ath10k/wmi.c:6959: please, no spaces at the start of a line
drivers/net/wireless/ath/ath10k/wmi.c:6960: please, no spaces at the start of a line
drivers/net/wireless/ath/ath10k/wmi.c:6962: please, no spaces at the start of a line
drivers/net/wireless/ath/ath10k/wmi.c:6963: please, no spaces at the start of a line
drivers/net/wireless/ath/ath10k/wmi.c:6965: please, no spaces at the start of a line
drivers/net/wireless/ath/ath10k/wmi.c:6966: please, no spaces at the start of a line
drivers/net/wireless/ath/ath10k/wmi.c:6967: please, no spaces at the start of a line
drivers/net/wireless/ath/ath10k/wmi.c:6968: please, no spaces at the start of a line
drivers/net/wireless/ath/ath10k/wmi.c:6969: please, no spaces at the start of a line
drivers/net/wireless/ath/ath10k/wmi.c:6971: line over 90 characters
drivers/net/wireless/ath/ath10k/wmi.c:6971: please, no spaces at the start of a line
drivers/net/wireless/ath/ath10k/wmi.c:6972: please, no spaces at the start of a line
drivers/net/wireless/ath/ath10k/wmi.c:6978: please, no spaces at the start of a line
drivers/net/wireless/ath/ath10k/wmi.c:6979: please, no spaces at the start of a line
drivers/net/wireless/ath/ath10k/wmi.c:6981: please, no spaces at the start of a line
drivers/net/wireless/ath/ath10k/wmi.c:6982: please, no spaces at the start of a line
drivers/net/wireless/ath/ath10k/wmi.c:6984: please, no spaces at the start of a line
drivers/net/wireless/ath/ath10k/wmi.c:6985: please, no spaces at the start of a line
drivers/net/wireless/ath/ath10k/wmi.c:6986: please, no spaces at the start of a line
drivers/net/wireless/ath/ath10k/wmi.c:6987: line over 90 characters
drivers/net/wireless/ath/ath10k/wmi.c:6987: please, no spaces at the start of a line
drivers/net/wireless/ath/ath10k/wmi.c:6988: please, no spaces at the start of a line
drivers/net/wireless/ath/ath10k/wmi.c:8583: trailing whitespace
--
Kalle Valo
next prev parent reply other threads:[~2018-04-05 14:44 UTC|newest]
Thread overview: 69+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-02-26 8:44 [PATCH v12] ath10k: add LED and GPIO controlling support for various chipsets s.gottschall
2018-02-26 8:44 ` s.gottschall
2018-02-27 17:03 ` Steve deRosier
2018-02-27 17:03 ` Steve deRosier
2018-02-27 17:43 ` Sebastian Gottschall
2018-02-27 17:43 ` Sebastian Gottschall
2018-02-27 22:08 ` Rafał Miłecki
2018-02-27 22:08 ` Rafał Miłecki
2018-02-28 1:49 ` Sebastian Gottschall
2018-02-28 1:49 ` Sebastian Gottschall
2018-03-02 9:03 ` Pavel Machek
2018-03-02 9:03 ` Pavel Machek
2018-03-02 9:22 ` Sebastian Gottschall
2018-03-02 9:22 ` Sebastian Gottschall
2018-03-02 9:22 ` Sebastian Gottschall
2018-03-07 16:22 ` Rafał Miłecki
2018-03-07 16:22 ` Rafał Miłecki
2018-03-07 17:54 ` Sebastian Gottschall
2018-03-07 17:54 ` Sebastian Gottschall
2018-03-08 9:02 ` Pavel Machek
2018-03-08 9:02 ` Pavel Machek
2018-03-08 12:33 ` Sebastian Gottschall
2018-03-08 12:33 ` Sebastian Gottschall
2018-03-08 14:05 ` Pavel Machek
2018-03-08 14:05 ` Pavel Machek
2018-03-08 14:29 ` Kalle Valo
2018-03-08 14:29 ` Kalle Valo
2018-03-08 14:29 ` Kalle Valo
2018-03-08 14:43 ` Sebastian Gottschall
2018-03-08 14:43 ` Sebastian Gottschall
2018-03-08 14:34 ` Sebastian Gottschall
2018-03-08 14:34 ` Sebastian Gottschall
2018-03-08 15:04 ` Pavel Machek
2018-03-08 15:04 ` Pavel Machek
2018-03-08 15:04 ` Pavel Machek
2018-03-08 15:31 ` Sebastian Gottschall
2018-03-08 15:31 ` Sebastian Gottschall
2018-03-08 15:46 ` Felix Fietkau
2018-03-08 15:46 ` Felix Fietkau
2018-03-10 7:44 ` Julian Calaby
2018-03-10 7:44 ` Julian Calaby
2018-03-10 7:56 ` Sebastian Gottschall
2018-03-10 7:56 ` Sebastian Gottschall
2018-03-12 7:53 ` Mathias Kresin
2018-03-12 7:53 ` Mathias Kresin
2018-03-12 7:53 ` Mathias Kresin
2018-03-12 9:09 ` Sebastian Gottschall
2018-03-12 9:09 ` Sebastian Gottschall
2018-03-12 9:09 ` Sebastian Gottschall
2018-04-05 14:44 ` Kalle Valo [this message]
2018-04-05 14:44 ` Kalle Valo
2018-04-05 18:01 ` Sebastian Gottschall
2018-04-05 18:01 ` Sebastian Gottschall
2018-04-05 20:00 ` Sebastian Gottschall
2018-04-05 20:00 ` Sebastian Gottschall
2018-04-06 8:07 ` Kalle Valo
2018-04-06 8:07 ` Kalle Valo
2018-04-06 8:10 ` Sebastian Gottschall
2018-04-06 8:10 ` Sebastian Gottschall
[not found] ` <1d917688-9f59-39ad-46a6-527d9e3dec03@dd-wrt.com>
2018-04-06 8:09 ` Kalle Valo
2018-04-06 8:09 ` Kalle Valo
2018-04-06 8:11 ` Sebastian Gottschall
2018-04-06 8:11 ` Sebastian Gottschall
2018-04-06 8:25 ` Kalle Valo
2018-04-06 8:25 ` Kalle Valo
[not found] ` <f3617290-34d5-0cca-6442-4a37c06701b1@dd-wrt.com>
2018-04-06 9:17 ` Kalle Valo
2018-04-06 9:17 ` Kalle Valo
2018-04-06 8:05 ` Kalle Valo
2018-04-06 8:05 ` Kalle Valo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=871sftemru.fsf@kamboji.qca.qualcomm.com \
--to=kvalo@codeaurora.org \
--cc=ath10k@lists.infradead.org \
--cc=linux-wireless@vger.kernel.org \
--cc=s.gottschall@dd-wrt.com \
--cc=s.gottschall@newmedia-net.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.