[PATCH] Allow non-desktop displays when not in strict mode

[PATCH] Allow non-desktop displays when not in strict mode

[Charles Lohr]

Considering the lukewarm reception of my last past request and Keith's recommendation, I've created and tested a new patch, to bring the intended functionality back, only prohibiting non-desktop devices if a regular desktop screen is present.

Previous email chain: https://lists.freedesktop.org/archives/dri-devel/2018-March/169558.html

I believe I've finally found a way of sending emails with word wrap turned off.

Thank you for your time and help understanding how this submission process works.

Charles



Signed-off-by: Charles Lohr <lohr85@gmail.com>

diff --git a/drivers/gpu/drm/drm_fb_helper.c b/drivers/gpu/drm/drm_fb_helper.c
index 035784ddd..ed08153ee 100644
--- a/drivers/gpu/drm/drm_fb_helper.c
+++ b/drivers/gpu/drm/drm_fb_helper.c
@@ -2109,7 +2109,7 @@ static bool drm_connector_enabled(struct drm_connector *connector, bool strict)
  {
      bool enable;

-    if (connector->display_info.non_desktop)
+    if (connector->display_info.non_desktop && strict)
          return false;

      if (strict)

[PATCH] Allow non-desktop displays when not in strict mode

[Charles Lohr]

Considering the lukewarm reception of my last past request and Keith's recommendation, I've created and tested a new patch, to bring the intended functionality back, only prohibiting non-desktop devices if a regular desktop screen is present.

Previous email chain: https://lists.freedesktop.org/archives/dri-devel/2018-March/169558.html

I believe I've finally found a way of sending emails with word wrap turned off.

Thank you for your time and help understanding how this submission process works.

Charles



Signed-off-by: Charles Lohr <lohr85@gmail.com>

diff --git a/drivers/gpu/drm/drm_fb_helper.c b/drivers/gpu/drm/drm_fb_helper.c
index 035784ddd..ed08153ee 100644
--- a/drivers/gpu/drm/drm_fb_helper.c
+++ b/drivers/gpu/drm/drm_fb_helper.c
@@ -2109,7 +2109,7 @@ static bool drm_connector_enabled(struct drm_connector *connector, bool strict)
  {
      bool enable;

-    if (connector->display_info.non_desktop)
+    if (connector->display_info.non_desktop && strict)
          return false;

      if (strict)
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

Re: [PATCH] Allow non-desktop displays when not in strict mode

[Keith Packard]

[-- Attachment #1: Type: text/plain, Size: 462 bytes --]

Charles Lohr <charles@cnlohr.com> writes:

> Considering the lukewarm reception of my last past request and Keith's
> recommendation, I've created and tested a new patch, to bring the
> intended functionality back, only prohibiting non-desktop devices if a
> regular desktop screen is present.
>
> Signed-off-by: Charles Lohr <lohr85@gmail.com>

This seems like a reasonable idea to me.

Reviewed-by: Keith Packard <keithp@keithp.com>

-- 
-keith

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 832 bytes --]

Re: [PATCH] Allow non-desktop displays when not in strict mode

[Keith Packard]

[-- Attachment #1.1: Type: text/plain, Size: 462 bytes --]

Charles Lohr <charles@cnlohr.com> writes:

> Considering the lukewarm reception of my last past request and Keith's
> recommendation, I've created and tested a new patch, to bring the
> intended functionality back, only prohibiting non-desktop devices if a
> regular desktop screen is present.
>
> Signed-off-by: Charles Lohr <lohr85@gmail.com>

This seems like a reasonable idea to me.

Reviewed-by: Keith Packard <keithp@keithp.com>

-- 
-keith

[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 832 bytes --]

[-- Attachment #2: Type: text/plain, Size: 160 bytes --]

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel