From: Kalle Valo <kvalo@codeaurora.org>
To: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
Cc: arend.vanspriel@broadcom.com, franky.lin@broadcom.com,
hante.meuleman@broadcom.com, rafal@milecki.pl,
pieter-paul.giesberts@broadcom.com,
linux-wireless@vger.kernel.org,
brcm80211-dev-list.pdl@broadcom.com, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org
Subject: Re: [PATCH] cfg80211: Fix a memory leak in error handling path in 'brcmf_cfg80211_attach'
Date: Tue, 20 Jun 2017 06:33:32 +0000 [thread overview]
Message-ID: <871sqfcgn7.fsf@codeaurora.org> (raw)
In-Reply-To: <20170620062205.16078-1-christophe.jaillet@wanadoo.fr> (Christophe JAILLET's message of "Tue, 20 Jun 2017 08:22:05 +0200")
Christophe JAILLET <christophe.jaillet@wanadoo.fr> writes:
> If 'wiphy_new()' fails, we leak 'ops'. Add a new label in the error
> handling path to free it in such a case.
>
> Fixes: 5c22fb85102a7 ("brcmfmac: add wowl gtk rekeying offload support")
> Signed-off-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
The prefix should be "brcmfmac:", like in the commit you are fixing.
"cfg80211:" is very misleading.
--
Kalle Valo
WARNING: multiple messages have this Message-ID (diff)
From: Kalle Valo <kvalo@codeaurora.org>
To: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
Cc: arend.vanspriel@broadcom.com, franky.lin@broadcom.com,
hante.meuleman@broadcom.com, rafal@milecki.pl,
pieter-paul.giesberts@broadcom.com,
linux-wireless@vger.kernel.org,
brcm80211-dev-list.pdl@broadcom.com, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org
Subject: Re: [PATCH] cfg80211: Fix a memory leak in error handling path in 'brcmf_cfg80211_attach'
Date: Tue, 20 Jun 2017 09:33:32 +0300 [thread overview]
Message-ID: <871sqfcgn7.fsf@codeaurora.org> (raw)
In-Reply-To: <20170620062205.16078-1-christophe.jaillet@wanadoo.fr> (Christophe JAILLET's message of "Tue, 20 Jun 2017 08:22:05 +0200")
Christophe JAILLET <christophe.jaillet@wanadoo.fr> writes:
> If 'wiphy_new()' fails, we leak 'ops'. Add a new label in the error
> handling path to free it in such a case.
>
> Fixes: 5c22fb85102a7 ("brcmfmac: add wowl gtk rekeying offload support")
> Signed-off-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
The prefix should be "brcmfmac:", like in the commit you are fixing.
"cfg80211:" is very misleading.
--
Kalle Valo
next prev parent reply other threads:[~2017-06-20 6:33 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-06-20 6:22 [PATCH] cfg80211: Fix a memory leak in error handling path in 'brcmf_cfg80211_attach' Christophe JAILLET
2017-06-20 6:22 ` Christophe JAILLET
2017-06-20 6:33 ` Kalle Valo [this message]
2017-06-20 6:33 ` Kalle Valo
2017-06-20 19:53 ` Arend van Spriel
2017-06-20 19:53 ` Arend van Spriel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=871sqfcgn7.fsf@codeaurora.org \
--to=kvalo@codeaurora.org \
--cc=arend.vanspriel@broadcom.com \
--cc=brcm80211-dev-list.pdl@broadcom.com \
--cc=christophe.jaillet@wanadoo.fr \
--cc=franky.lin@broadcom.com \
--cc=hante.meuleman@broadcom.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pieter-paul.giesberts@broadcom.com \
--cc=rafal@milecki.pl \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.