i-g-t/libdrm email tagging & patchwork

i-g-t/libdrm email tagging & patchwork

[Damien Lespiau]

Hi all,

I've added a feature to sort the patches sent to intel-gfx into 3
buckets: i915, intel-gpu-tools and libdrm. This sorting relies on
tagging patches, using the subject prefixes (which is what most people
do already anyway).

  - i915 (intel-gfx): catchall project, all mails not matching any of
    the other 2 projects will end up there

  - intel-gpu-tools: mails need to be tagged with i-g-t, igt or
    intel-gpu-tools

  - libdrm-intel: mails need to be tagged with libdrm

This tagging can be set up per git repository with:

  $ git config format.subjectprefix "PATCH i-g-t"

And use git send-email as usual. A note of caution though, using the
command line argument --subject-prefix will override the one configured,
so the tag will have to be repeated. To limit the number of things one
needs to think about I'd suggest to use --reroll-count to tag patches
with the v2/v3/... tags. I'm more and more thinking that wrapping the
sending logic for developers into the git-pw command would be a good
thing (especially for --in-reply-to) but that'd be for another time.

There are two new patchwork projects then:

  http://patchwork.freedesktop.org/project/intel-gpu-tools/
  http://patchwork.freedesktop.org/project/libdrm-intel/

I've also run the sorting on all the existing patches so the entries
that were historically in the intel-gfx project are now in those new
projects.

There is still some work left to limit the noise of those lists of
patches, eg. some patches are still marked as New but, in reality, they
have been merged. Solving that is quite important and high-ish the TODO
list.

HTH,

-- 
Damien
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/intel-gfx

Re: i-g-t/libdrm email tagging & patchwork

[Jani Nikula]

On Sun, 08 Nov 2015, Damien Lespiau <damien.lespiau@intel.com> wrote:
> There are two new patchwork projects then:
>
>   http://patchwork.freedesktop.org/project/intel-gpu-tools/
>   http://patchwork.freedesktop.org/project/libdrm-intel/
>
> I've also run the sorting on all the existing patches so the entries
> that were historically in the intel-gfx project are now in those new
> projects.

Is it possible to manually move patches between projects?

> There is still some work left to limit the noise of those lists of
> patches, eg. some patches are still marked as New but, in reality, they
> have been merged. Solving that is quite important and high-ish the TODO
> list.

This may be due to git am -3 subtly changing the patch, or the committer
not-so-subtly changing the patch [*], while applying, and the git hook
on fdo doesn't recognize the patch. Since we've started to add the Link:
tag to patches, we could use that extra bit of info in the hook to link
commits to patchwork.

BR,
Jani.


[*] I'd go for requiring resubmission even for the tiniest typo/comment
changes, but Daniel thinks the committers can do the fixups.


-- 
Jani Nikula, Intel Open Source Technology Center
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/intel-gfx

Re: i-g-t/libdrm email tagging & patchwork

[Damien Lespiau]

On Mon, Nov 09, 2015 at 10:45:14AM +0200, Jani Nikula wrote:
> On Sun, 08 Nov 2015, Damien Lespiau <damien.lespiau@intel.com> wrote:
> > There are two new patchwork projects then:
> >
> >   http://patchwork.freedesktop.org/project/intel-gpu-tools/
> >   http://patchwork.freedesktop.org/project/libdrm-intel/
> >
> > I've also run the sorting on all the existing patches so the entries
> > that were historically in the intel-gfx project are now in those new
> > projects.
> 
> Is it possible to manually move patches between projects?

Damn, you noticed! No, it's not (yet?) possible.

> > There is still some work left to limit the noise of those lists of
> > patches, eg. some patches are still marked as New but, in reality, they
> > have been merged. Solving that is quite important and high-ish the TODO
> > list.
> 
> This may be due to git am -3 subtly changing the patch, or the committer
> not-so-subtly changing the patch [*], while applying, and the git hook
> on fdo doesn't recognize the patch. Since we've started to add the Link:
> tag to patches, we could use that extra bit of info in the hook to link
> commits to patchwork.

That would work for us, but not in the general case (for other
projects). I was thinking of using some kind of other heuristic, eg.
(subject, commit message, files touched) with a levenshtein distance on
text to allow typo correction.

Just for us, we could take a shortcut and make dim do something always
correct based on the message-id, I'll have a think.

-- 
Damien
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/intel-gfx

Re: i-g-t/libdrm email tagging & patchwork

[Jani Nikula]

On Mon, 09 Nov 2015, Damien Lespiau <damien.lespiau@intel.com> wrote:
> That would work for us, but not in the general case (for other
> projects). I was thinking of using some kind of other heuristic, eg.
> (subject, commit message, files touched) with a levenshtein distance on
> text to allow typo correction.
>
> Just for us, we could take a shortcut and make dim do something always
> correct based on the message-id, I'll have a think.

Do you mean we'd move the patchwork update to client side rather than
server side?

BR,
Jani.

-- 
Jani Nikula, Intel Open Source Technology Center
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/intel-gfx

Re: i-g-t/libdrm email tagging & patchwork

[Damien Lespiau]

On Mon, Nov 09, 2015 at 01:21:33PM +0200, Jani Nikula wrote:
> On Mon, 09 Nov 2015, Damien Lespiau <damien.lespiau@intel.com> wrote:
> > That would work for us, but not in the general case (for other
> > projects). I was thinking of using some kind of other heuristic, eg.
> > (subject, commit message, files touched) with a levenshtein distance on
> > text to allow typo correction.
> >
> > Just for us, we could take a shortcut and make dim do something always
> > correct based on the message-id, I'll have a think.
> 
> Do you mean we'd move the patchwork update to client side rather than
> server side?

We could do it either way, have dim use git-pw to mark the patch as
accepted or have the post commit hook look at the brand new tag and
infer the id of the patch to close. I'm guessing you'd rather have the
second option.

-- 
Damien
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/intel-gfx

Re: i-g-t/libdrm email tagging & patchwork

[Daniel Vetter]

On Sun, Nov 08, 2015 at 12:31:36AM +0000, Damien Lespiau wrote:
> Hi all,
> 
> I've added a feature to sort the patches sent to intel-gfx into 3
> buckets: i915, intel-gpu-tools and libdrm. This sorting relies on
> tagging patches, using the subject prefixes (which is what most people
> do already anyway).
> 
>   - i915 (intel-gfx): catchall project, all mails not matching any of
>     the other 2 projects will end up there
> 
>   - intel-gpu-tools: mails need to be tagged with i-g-t, igt or
>     intel-gpu-tools
> 
>   - libdrm-intel: mails need to be tagged with libdrm
> 
> This tagging can be set up per git repository with:
> 
>   $ git config format.subjectprefix "PATCH i-g-t"

Is there any way we could push this out to users somehow? I have bazillion
of machines, I'll get this wrong eventually ... So will everyone else I
guess.
-Daniel

> 
> And use git send-email as usual. A note of caution though, using the
> command line argument --subject-prefix will override the one configured,
> so the tag will have to be repeated. To limit the number of things one
> needs to think about I'd suggest to use --reroll-count to tag patches
> with the v2/v3/... tags. I'm more and more thinking that wrapping the
> sending logic for developers into the git-pw command would be a good
> thing (especially for --in-reply-to) but that'd be for another time.
> 
> There are two new patchwork projects then:
> 
>   http://patchwork.freedesktop.org/project/intel-gpu-tools/
>   http://patchwork.freedesktop.org/project/libdrm-intel/
> 
> I've also run the sorting on all the existing patches so the entries
> that were historically in the intel-gfx project are now in those new
> projects.
> 
> There is still some work left to limit the noise of those lists of
> patches, eg. some patches are still marked as New but, in reality, they
> have been merged. Solving that is quite important and high-ish the TODO
> list.
> 
> HTH,
> 
> -- 
> Damien
> _______________________________________________
> Intel-gfx mailing list
> Intel-gfx@lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/intel-gfx

-- 
Daniel Vetter
Software Engineer, Intel Corporation
http://blog.ffwll.ch
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/intel-gfx

Re: i-g-t/libdrm email tagging & patchwork

[Paulo Zanoni]

2015-11-18 8:56 GMT-02:00 Daniel Vetter <daniel@ffwll.ch>:
> On Sun, Nov 08, 2015 at 12:31:36AM +0000, Damien Lespiau wrote:
>> Hi all,
>>
>> I've added a feature to sort the patches sent to intel-gfx into 3
>> buckets: i915, intel-gpu-tools and libdrm. This sorting relies on
>> tagging patches, using the subject prefixes (which is what most people
>> do already anyway).
>>
>>   - i915 (intel-gfx): catchall project, all mails not matching any of
>>     the other 2 projects will end up there
>>
>>   - intel-gpu-tools: mails need to be tagged with i-g-t, igt or
>>     intel-gpu-tools
>>
>>   - libdrm-intel: mails need to be tagged with libdrm
>>
>> This tagging can be set up per git repository with:
>>
>>   $ git config format.subjectprefix "PATCH i-g-t"
>
> Is there any way we could push this out to users somehow? I have bazillion
> of machines, I'll get this wrong eventually ... So will everyone else I
> guess.

I know it's not what you're looking for, but anyway: I solved this by
putting IGT on NFS and making all the bazillion machines just mount it
:)

> -Daniel
>
>>
>> And use git send-email as usual. A note of caution though, using the
>> command line argument --subject-prefix will override the one configured,
>> so the tag will have to be repeated. To limit the number of things one
>> needs to think about I'd suggest to use --reroll-count to tag patches
>> with the v2/v3/... tags. I'm more and more thinking that wrapping the
>> sending logic for developers into the git-pw command would be a good
>> thing (especially for --in-reply-to) but that'd be for another time.
>>
>> There are two new patchwork projects then:
>>
>>   http://patchwork.freedesktop.org/project/intel-gpu-tools/
>>   http://patchwork.freedesktop.org/project/libdrm-intel/
>>
>> I've also run the sorting on all the existing patches so the entries
>> that were historically in the intel-gfx project are now in those new
>> projects.
>>
>> There is still some work left to limit the noise of those lists of
>> patches, eg. some patches are still marked as New but, in reality, they
>> have been merged. Solving that is quite important and high-ish the TODO
>> list.
>>
>> HTH,
>>
>> --
>> Damien
>> _______________________________________________
>> Intel-gfx mailing list
>> Intel-gfx@lists.freedesktop.org
>> http://lists.freedesktop.org/mailman/listinfo/intel-gfx
>
> --
> Daniel Vetter
> Software Engineer, Intel Corporation
> http://blog.ffwll.ch
> _______________________________________________
> Intel-gfx mailing list
> Intel-gfx@lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/intel-gfx



-- 
Paulo Zanoni
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/intel-gfx

Re: i-g-t/libdrm email tagging & patchwork

[Jani Nikula]

On Wed, 18 Nov 2015, Daniel Vetter <daniel@ffwll.ch> wrote:
> On Sun, Nov 08, 2015 at 12:31:36AM +0000, Damien Lespiau wrote:
>> Hi all,
>> 
>> I've added a feature to sort the patches sent to intel-gfx into 3
>> buckets: i915, intel-gpu-tools and libdrm. This sorting relies on
>> tagging patches, using the subject prefixes (which is what most people
>> do already anyway).
>> 
>>   - i915 (intel-gfx): catchall project, all mails not matching any of
>>     the other 2 projects will end up there
>> 
>>   - intel-gpu-tools: mails need to be tagged with i-g-t, igt or
>>     intel-gpu-tools
>> 
>>   - libdrm-intel: mails need to be tagged with libdrm
>> 
>> This tagging can be set up per git repository with:
>> 
>>   $ git config format.subjectprefix "PATCH i-g-t"
>
> Is there any way we could push this out to users somehow? I have bazillion
> of machines, I'll get this wrong eventually ... So will everyone else I
> guess.

Googling around, I don't think we can automatically force this on
people. We could add a script to make it easier for people to set this
up. Either a setup that needs to be re-run every time there are changes,
or a setup that symlinks a git hook back into a file stored in the
repository so changes are deployed automatically. The latter has
security implications, so I'd go for the former.

BR,
Jani.


> -Daniel
>
>> 
>> And use git send-email as usual. A note of caution though, using the
>> command line argument --subject-prefix will override the one configured,
>> so the tag will have to be repeated. To limit the number of things one
>> needs to think about I'd suggest to use --reroll-count to tag patches
>> with the v2/v3/... tags. I'm more and more thinking that wrapping the
>> sending logic for developers into the git-pw command would be a good
>> thing (especially for --in-reply-to) but that'd be for another time.
>> 
>> There are two new patchwork projects then:
>> 
>>   http://patchwork.freedesktop.org/project/intel-gpu-tools/
>>   http://patchwork.freedesktop.org/project/libdrm-intel/
>> 
>> I've also run the sorting on all the existing patches so the entries
>> that were historically in the intel-gfx project are now in those new
>> projects.
>> 
>> There is still some work left to limit the noise of those lists of
>> patches, eg. some patches are still marked as New but, in reality, they
>> have been merged. Solving that is quite important and high-ish the TODO
>> list.
>> 
>> HTH,
>> 
>> -- 
>> Damien
>> _______________________________________________
>> Intel-gfx mailing list
>> Intel-gfx@lists.freedesktop.org
>> http://lists.freedesktop.org/mailman/listinfo/intel-gfx

-- 
Jani Nikula, Intel Open Source Technology Center
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/intel-gfx

Re: i-g-t/libdrm email tagging & patchwork

[Damien Lespiau]

On Thu, Nov 19, 2015 at 12:44:07PM +0200, Jani Nikula wrote:
> On Wed, 18 Nov 2015, Daniel Vetter <daniel@ffwll.ch> wrote:
> > On Sun, Nov 08, 2015 at 12:31:36AM +0000, Damien Lespiau wrote:
> >> Hi all,
> >> 
> >> I've added a feature to sort the patches sent to intel-gfx into 3
> >> buckets: i915, intel-gpu-tools and libdrm. This sorting relies on
> >> tagging patches, using the subject prefixes (which is what most people
> >> do already anyway).
> >> 
> >>   - i915 (intel-gfx): catchall project, all mails not matching any of
> >>     the other 2 projects will end up there
> >> 
> >>   - intel-gpu-tools: mails need to be tagged with i-g-t, igt or
> >>     intel-gpu-tools
> >> 
> >>   - libdrm-intel: mails need to be tagged with libdrm
> >> 
> >> This tagging can be set up per git repository with:
> >> 
> >>   $ git config format.subjectprefix "PATCH i-g-t"
> >
> > Is there any way we could push this out to users somehow? I have bazillion
> > of machines, I'll get this wrong eventually ... So will everyone else I
> > guess.
> 
> Googling around, I don't think we can automatically force this on
> people. We could add a script to make it easier for people to set this
> up. Either a setup that needs to be re-run every time there are changes,
> or a setup that symlinks a git hook back into a file stored in the
> repository so changes are deployed automatically. The latter has
> security implications, so I'd go for the former.

So, we could have:

  $ git pw init https://patchwork.freedesktop.org/ intel-gpu-tools

which would retrieve some server side config and shove it into
.gitconfig. That does require a step anyway though, not sure how ideal
this is or what else could be interesting to do with such a thing.

-- 
Damien
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/intel-gfx

Re: i-g-t/libdrm email tagging & patchwork

[Jani Nikula]

On Thu, 19 Nov 2015, Damien Lespiau <damien.lespiau@intel.com> wrote:
> On Thu, Nov 19, 2015 at 12:44:07PM +0200, Jani Nikula wrote:
>> On Wed, 18 Nov 2015, Daniel Vetter <daniel@ffwll.ch> wrote:
>> > On Sun, Nov 08, 2015 at 12:31:36AM +0000, Damien Lespiau wrote:
>> >> Hi all,
>> >> 
>> >> I've added a feature to sort the patches sent to intel-gfx into 3
>> >> buckets: i915, intel-gpu-tools and libdrm. This sorting relies on
>> >> tagging patches, using the subject prefixes (which is what most people
>> >> do already anyway).
>> >> 
>> >>   - i915 (intel-gfx): catchall project, all mails not matching any of
>> >>     the other 2 projects will end up there
>> >> 
>> >>   - intel-gpu-tools: mails need to be tagged with i-g-t, igt or
>> >>     intel-gpu-tools
>> >> 
>> >>   - libdrm-intel: mails need to be tagged with libdrm
>> >> 
>> >> This tagging can be set up per git repository with:
>> >> 
>> >>   $ git config format.subjectprefix "PATCH i-g-t"
>> >
>> > Is there any way we could push this out to users somehow? I have bazillion
>> > of machines, I'll get this wrong eventually ... So will everyone else I
>> > guess.
>> 
>> Googling around, I don't think we can automatically force this on
>> people. We could add a script to make it easier for people to set this
>> up. Either a setup that needs to be re-run every time there are changes,
>> or a setup that symlinks a git hook back into a file stored in the
>> repository so changes are deployed automatically. The latter has
>> security implications, so I'd go for the former.
>
> So, we could have:
>
>   $ git pw init https://patchwork.freedesktop.org/ intel-gpu-tools
>
> which would retrieve some server side config and shove it into
> .gitconfig. That does require a step anyway though, not sure how ideal
> this is or what else could be interesting to do with such a thing.

I like the idea of making this specific to patchwork (the git subcommand
and the server/project) rather than a some magic in the repository of a
project. Much more generic that way.

BR,
Jani.



-- 
Jani Nikula, Intel Open Source Technology Center
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/intel-gfx

Re: i-g-t/libdrm email tagging & patchwork

[Morton, Derek J]

You can put a .gitconfig file in the repository but the user needs to manually include it in the local gitconfig
http://stackoverflow.com/questions/18329621/storing-git-config-as-part-of-the-repository
A script could be included as well to automate as much as possible the process of including it.

Has the advantage at least of the config being with the repository and not stored separately on the server.

//Derek

-----Original Message-----
From: Intel-gfx [mailto:intel-gfx-bounces@lists.freedesktop.org] On Behalf Of Damien Lespiau
Sent: Thursday, November 19, 2015 3:08 PM
To: Jani Nikula
Cc: intel-gfx@lists.freedesktop.org
Subject: Re: [Intel-gfx] i-g-t/libdrm email tagging & patchwork

On Thu, Nov 19, 2015 at 12:44:07PM +0200, Jani Nikula wrote:
> On Wed, 18 Nov 2015, Daniel Vetter <daniel@ffwll.ch> wrote:
> > On Sun, Nov 08, 2015 at 12:31:36AM +0000, Damien Lespiau wrote:
> >> Hi all,
> >> 
> >> I've added a feature to sort the patches sent to intel-gfx into 3
> >> buckets: i915, intel-gpu-tools and libdrm. This sorting relies on 
> >> tagging patches, using the subject prefixes (which is what most 
> >> people do already anyway).
> >> 
> >>   - i915 (intel-gfx): catchall project, all mails not matching any of
> >>     the other 2 projects will end up there
> >> 
> >>   - intel-gpu-tools: mails need to be tagged with i-g-t, igt or
> >>     intel-gpu-tools
> >> 
> >>   - libdrm-intel: mails need to be tagged with libdrm
> >> 
> >> This tagging can be set up per git repository with:
> >> 
> >>   $ git config format.subjectprefix "PATCH i-g-t"
> >
> > Is there any way we could push this out to users somehow? I have 
> > bazillion of machines, I'll get this wrong eventually ... So will 
> > everyone else I guess.
> 
> Googling around, I don't think we can automatically force this on 
> people. We could add a script to make it easier for people to set this 
> up. Either a setup that needs to be re-run every time there are 
> changes, or a setup that symlinks a git hook back into a file stored 
> in the repository so changes are deployed automatically. The latter 
> has security implications, so I'd go for the former.

So, we could have:

  $ git pw init https://patchwork.freedesktop.org/ intel-gpu-tools

which would retrieve some server side config and shove it into .gitconfig. That does require a step anyway though, not sure how ideal this is or what else could be interesting to do with such a thing.

--
Damien
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/intel-gfx
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/intel-gfx