From: Jani Nikula <jani.nikula@linux.intel.com>
To: Takashi Iwai <tiwai@suse.de>
Cc: "daniel.vetter@ffwll.ch" <daniel.vetter@ffwll.ch>,
"alsa-devel@alsa-project.org" <alsa-devel@alsa-project.org>,
"intel-gfx@lists.freedesktop.org"
<intel-gfx@lists.freedesktop.org>
Subject: Re: [PATCH v6 4/4] drm/i915: set proper N/CTS in modeset
Date: Wed, 02 Sep 2015 16:44:34 +0300 [thread overview]
Message-ID: <871teh2awt.fsf@intel.com> (raw)
In-Reply-To: <s5h7fo9osh0.wl-tiwai@suse.de>
On Wed, 02 Sep 2015, Takashi Iwai <tiwai@suse.de> wrote:
> On Wed, 02 Sep 2015 11:02:42 +0200,
> Jani Nikula wrote:
>>
>> >> Nitpick. I'd prefer some sharing with the similar blocks from the
>> >> earlier patch. Also a debug message on n == 0 would be nice; you
>> >> probably didn't notice your audio_config_get_rate() wasn't working
>> >> right
>> >> because this silently fell back to the automatic mode here.
>> >
>> > OK, I will add the msg. As you and Ville are insisting on
>> > sharing code, I will do it in next version.
>>
>> Well, really, I'm fine with having that part duplicated as-is for now,
>> we can fix it later. More important to focus on getting
>> audio_config_get_rate() right.
>>
>> I don't know if you're still targeting v4.3 with this (up to Takashi I
>> guess) we'll really need to wrap this up soon.
>
> I'm in favor of merging this into 4.3, so it'd be appreciated if Libin
> can prepare the fixed version soonish, indeed.
IIUC patches 1-3 would be useful on their own already, and a fixed
version of patch 4 could follow. Just a thought.
BR,
Jani.
>
>
> thanks,
>
> Takashi
--
Jani Nikula, Intel Open Source Technology Center
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/intel-gfx
next prev parent reply other threads:[~2015-09-02 13:44 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-09-02 6:11 [PATCH v6 1/4] drm/i915: Add audio sync_audio_rate callback libin.yang
2015-09-02 6:11 ` [PATCH v6 2/4] drm/i915: implement " libin.yang
2015-09-02 7:52 ` Jani Nikula
2015-09-02 8:24 ` Yang, Libin
2015-09-02 8:42 ` Jani Nikula
2015-09-02 8:47 ` Yang, Libin
2015-09-02 6:11 ` [PATCH v6 3/4] ALSA: hda - display audio call " libin.yang
2015-09-02 6:11 ` [PATCH v6 4/4] drm/i915: set proper N/CTS in modeset libin.yang
2015-09-02 8:20 ` Jani Nikula
2015-09-02 8:42 ` Yang, Libin
2015-09-02 9:02 ` Jani Nikula
2015-09-02 13:34 ` Takashi Iwai
2015-09-02 13:44 ` Jani Nikula [this message]
2015-09-02 13:46 ` Takashi Iwai
2015-09-02 15:22 ` Daniel Vetter
2015-09-02 15:36 ` Takashi Iwai
2015-09-04 1:56 ` Yang, Libin
2015-09-04 4:50 ` Takashi Iwai
2015-10-19 8:25 ` Jani Nikula
2015-10-19 8:27 ` Takashi Iwai
2015-09-02 7:23 ` [PATCH v6 1/4] drm/i915: Add audio sync_audio_rate callback Jani Nikula
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=871teh2awt.fsf@intel.com \
--to=jani.nikula@linux.intel.com \
--cc=alsa-devel@alsa-project.org \
--cc=daniel.vetter@ffwll.ch \
--cc=intel-gfx@lists.freedesktop.org \
--cc=tiwai@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.