From: Robert Jarzmik <robert.jarzmik@free.fr>
To: Richard Weinberger <richard@nod.at>
Cc: dwmw2@infradead.org, Brian Norris <computersforpeace@gmail.com>,
linux-mtd@lists.infradead.org, maximlevitsky@gmail.com,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 6/6] mtd: docg3: Don't do ERR_PTR(0)
Date: Tue, 23 Jun 2015 22:41:33 +0200 [thread overview]
Message-ID: <871th2kvia.fsf@belgarion.home> (raw)
In-Reply-To: <5588FC61.5070202@nod.at> (Richard Weinberger's message of "Tue, 23 Jun 2015 08:27:45 +0200")
Richard Weinberger <richard@nod.at> writes:
> Am 17.06.2015 um 20:41 schrieb Brian Norris:
>> On Mon, Jun 01, 2015 at 11:10:54PM +0200, Richard Weinberger wrote:
>>> Don't return a obfuscated null pointer using ERR_PTR(0).
>>> If the no device is found clearly return -ENODEV.
>>> This makes the code more clear and matches the comment
>>> of doc_probe_device().
>>>
>>> Signed-off-by: Richard Weinberger <richard@nod.at>
>>> ---
>>
>> Have you tested this patch?
>
> nah, I don't own such a device.
But I do. If you resend a patch, please Cc me. You can even ask for a test from
time to time if you want a confirmation, I have a 2 floors docg3 device.
Cheers.
--
Robert
WARNING: multiple messages have this Message-ID (diff)
From: Robert Jarzmik <robert.jarzmik@free.fr>
To: Richard Weinberger <richard@nod.at>
Cc: Brian Norris <computersforpeace@gmail.com>,
linux-mtd@lists.infradead.org, dwmw2@infradead.org,
maximlevitsky@gmail.com, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 6/6] mtd: docg3: Don't do ERR_PTR(0)
Date: Tue, 23 Jun 2015 22:41:33 +0200 [thread overview]
Message-ID: <871th2kvia.fsf@belgarion.home> (raw)
In-Reply-To: <5588FC61.5070202@nod.at> (Richard Weinberger's message of "Tue, 23 Jun 2015 08:27:45 +0200")
Richard Weinberger <richard@nod.at> writes:
> Am 17.06.2015 um 20:41 schrieb Brian Norris:
>> On Mon, Jun 01, 2015 at 11:10:54PM +0200, Richard Weinberger wrote:
>>> Don't return a obfuscated null pointer using ERR_PTR(0).
>>> If the no device is found clearly return -ENODEV.
>>> This makes the code more clear and matches the comment
>>> of doc_probe_device().
>>>
>>> Signed-off-by: Richard Weinberger <richard@nod.at>
>>> ---
>>
>> Have you tested this patch?
>
> nah, I don't own such a device.
But I do. If you resend a patch, please Cc me. You can even ask for a test from
time to time if you want a confirmation, I have a 2 floors docg3 device.
Cheers.
--
Robert
next prev parent reply other threads:[~2015-06-23 20:44 UTC|newest]
Thread overview: 31+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-06-01 21:10 Some fixes for MTD drivers Richard Weinberger
2015-06-01 21:10 ` Richard Weinberger
2015-06-01 21:10 ` [PATCH 1/6] mtd: r852: Fix device_create_file() usage Richard Weinberger
2015-06-01 21:10 ` Richard Weinberger
2015-06-17 2:07 ` Brian Norris
2015-06-17 2:07 ` Brian Norris
2015-06-01 21:10 ` [PATCH 2/6] mtd: nandsim: Fix kasprintf() usage Richard Weinberger
2015-06-01 21:10 ` Richard Weinberger
2015-06-17 2:07 ` Brian Norris
2015-06-17 2:07 ` Brian Norris
2015-06-17 4:42 ` Joe Perches
2015-06-01 21:10 ` [PATCH 3/6] mtd: cs553x_nand: " Richard Weinberger
2015-06-01 21:10 ` Richard Weinberger
2015-06-01 21:10 ` [PATCH 4/6] mtd: docg3: Don't leak docg3->bbt in error path Richard Weinberger
2015-06-01 21:10 ` Richard Weinberger
2015-06-01 21:10 ` [PATCH 5/6] mtd: docg3: Fix kasprintf() usage Richard Weinberger
2015-06-01 21:10 ` Richard Weinberger
2015-06-01 21:10 ` [PATCH 6/6] mtd: docg3: Don't do ERR_PTR(0) Richard Weinberger
2015-06-01 21:10 ` Richard Weinberger
2015-06-17 18:41 ` Brian Norris
2015-06-17 18:41 ` Brian Norris
2015-06-23 6:27 ` Richard Weinberger
2015-06-23 6:27 ` Richard Weinberger
2015-06-23 20:41 ` Robert Jarzmik [this message]
2015-06-23 20:41 ` Robert Jarzmik
2015-06-25 2:29 ` Brian Norris
2015-06-25 2:29 ` Brian Norris
2015-06-25 17:14 ` Robert Jarzmik
2015-06-25 17:14 ` Robert Jarzmik
2015-06-26 0:23 ` Brian Norris
2015-06-26 0:23 ` Brian Norris
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=871th2kvia.fsf@belgarion.home \
--to=robert.jarzmik@free.fr \
--cc=computersforpeace@gmail.com \
--cc=dwmw2@infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mtd@lists.infradead.org \
--cc=maximlevitsky@gmail.com \
--cc=richard@nod.at \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.