Re: [PATCH next] bcma: add missing includes

[Kalle Valo <kvalo@codeaurora.org>]

Rafał Miłecki <zajec5@gmail.com> writes:

> On 3 March 2015 at 13:14, Kalle Valo <kvalo@codeaurora.org> wrote:
>> Rafał Miłecki <zajec5@gmail.com> writes:
>>
>>> Signed-off-by: Rafał Miłecki <zajec5@gmail.com>
>>
>> Please, no empty commit logs. I don't (yet) require that with all
>> patches, but this definitely needs one. Is this ok:
>>
>> bcma: add missing includes
>>
>> kbuild found out that commit 804e27dee49e ("bcma: support bringing up
>> bus hosted on PCIe Gen 2") broke the build on m68k:
>>
>>    drivers/bcma/driver_pcie2.c: In function 'bcma_core_pcie2_up':
>>>> drivers/bcma/driver_pcie2.c:196:2: error: implicit declaration of function 'pcie_set_readrq' [-Werror\
>> =implicit-function-declaration]
>>      err = pcie_set_readrq(dev, pcie2->reqsize);
>>      ^
>>    cc1: some warnings being treated as errors
>>
>> Reported-by: kbuild test robot <fengguang.wu@intel.com>
>> Signed-off-by: Rafał Miłecki <zajec5@gmail.com>
>
> You're right, I could to better :| Yes, your version looks OK.

Thanks, I applied with my modifications.

-- 
Kalle Valo