From: Kalle Valo <kvalo@codeaurora.org>
To: "Rafał Miłecki" <zajec5@gmail.com>
Cc: linux-wireless@vger.kernel.org
Subject: Re: [PATCH next] bcma: add missing includes
Date: Tue, 03 Mar 2015 14:14:23 +0200 [thread overview]
Message-ID: <87ioei9t28.fsf@kamboji.qca.qualcomm.com> (raw)
In-Reply-To: <1425364377-12771-1-git-send-email-zajec5@gmail.com> ("Rafał Miłecki"'s message of "Tue, 3 Mar 2015 07:32:57 +0100")
Rafał Miłecki <zajec5@gmail.com> writes:
> Signed-off-by: Rafał Miłecki <zajec5@gmail.com>
Please, no empty commit logs. I don't (yet) require that with all
patches, but this definitely needs one. Is this ok:
bcma: add missing includes
kbuild found out that commit 804e27dee49e ("bcma: support bringing up
bus hosted on PCIe Gen 2") broke the build on m68k:
drivers/bcma/driver_pcie2.c: In function 'bcma_core_pcie2_up':
>> drivers/bcma/driver_pcie2.c:196:2: error: implicit declaration of function 'pcie_set_readrq' [-Werror\
=implicit-function-declaration]
err = pcie_set_readrq(dev, pcie2->reqsize);
^
cc1: some warnings being treated as errors
Reported-by: kbuild test robot <fengguang.wu@intel.com>
Signed-off-by: Rafał Miłecki <zajec5@gmail.com>
--
Kalle Valo
next prev parent reply other threads:[~2015-03-03 12:14 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-03-03 6:32 [PATCH next] bcma: add missing includes Rafał Miłecki
2015-03-03 12:14 ` Kalle Valo [this message]
2015-03-03 13:18 ` Rafał Miłecki
2015-03-03 13:28 ` Kalle Valo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87ioei9t28.fsf@kamboji.qca.qualcomm.com \
--to=kvalo@codeaurora.org \
--cc=linux-wireless@vger.kernel.org \
--cc=zajec5@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.