All of lore.kernel.org
 help / color / mirror / Atom feed
From: Kalle Valo <kvalo@qca.qualcomm.com>
To: Michal Kazior <michal.kazior@tieto.com>
Cc: linux-wireless <linux-wireless@vger.kernel.org>,
	"ath10k@lists.infradead.org" <ath10k@lists.infradead.org>
Subject: Re: [PATCH v2 4/6] ath10k: make warm reset a bit safer and faster
Date: Thu, 23 Oct 2014 16:14:00 +0300	[thread overview]
Message-ID: <871tpzq67b.fsf@kamboji.qca.qualcomm.com> (raw)
In-Reply-To: <CA+BoTQ=P2XOaOsaVOj+=fEs=nGfhUCNQvDYx6qb=A=JRCnbQmg@mail.gmail.com> (Michal Kazior's message of "Thu, 23 Oct 2014 10:27:57 +0200")

Michal Kazior <michal.kazior@tieto.com> writes:

> On 20 October 2014 14:14, Michal Kazior <michal.kazior@tieto.com> wrote:
>> One of the problems with warm reset I've found is
>> that it must be guaranteed that copy engine
>> registers are not being accessed while being
>> reset. Otherwise in worst case scenario the host
>> may lock up.
>>
>> Instead of using sleeps and hoping the device is
>> operational in some arbitrary timeframes use
>> firmware indication register.
>>
>> As a side effect this makes driver
>> boot/stop/recovery faster.
>>
>> Signed-off-by: Michal Kazior <michal.kazior@tieto.com>
>> ---
>>
>> Notes:
>>     v2:
>>      * fix kernel panic on early fw crash due to CE not being fully initialized [Janusz]
>
> Marek reported he sees a memory leak and git bisect blames this patch.
> Please don't apply this patch yet.

Ok, thanks for letting me know. What about rest of the patches in the
patchset? I assume it's safe to apply them.

-- 
Kalle Valo

_______________________________________________
ath10k mailing list
ath10k@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/ath10k

WARNING: multiple messages have this Message-ID (diff)
From: Kalle Valo <kvalo@qca.qualcomm.com>
To: Michal Kazior <michal.kazior@tieto.com>
Cc: "ath10k@lists.infradead.org" <ath10k@lists.infradead.org>,
	linux-wireless <linux-wireless@vger.kernel.org>
Subject: Re: [PATCH v2 4/6] ath10k: make warm reset a bit safer and faster
Date: Thu, 23 Oct 2014 16:14:00 +0300	[thread overview]
Message-ID: <871tpzq67b.fsf@kamboji.qca.qualcomm.com> (raw)
In-Reply-To: <CA+BoTQ=P2XOaOsaVOj+=fEs=nGfhUCNQvDYx6qb=A=JRCnbQmg@mail.gmail.com> (Michal Kazior's message of "Thu, 23 Oct 2014 10:27:57 +0200")

Michal Kazior <michal.kazior@tieto.com> writes:

> On 20 October 2014 14:14, Michal Kazior <michal.kazior@tieto.com> wrote:
>> One of the problems with warm reset I've found is
>> that it must be guaranteed that copy engine
>> registers are not being accessed while being
>> reset. Otherwise in worst case scenario the host
>> may lock up.
>>
>> Instead of using sleeps and hoping the device is
>> operational in some arbitrary timeframes use
>> firmware indication register.
>>
>> As a side effect this makes driver
>> boot/stop/recovery faster.
>>
>> Signed-off-by: Michal Kazior <michal.kazior@tieto.com>
>> ---
>>
>> Notes:
>>     v2:
>>      * fix kernel panic on early fw crash due to CE not being fully initialized [Janusz]
>
> Marek reported he sees a memory leak and git bisect blames this patch.
> Please don't apply this patch yet.

Ok, thanks for letting me know. What about rest of the patches in the
patchset? I assume it's safe to apply them.

-- 
Kalle Valo

  reply	other threads:[~2014-10-23 13:14 UTC|newest]

Thread overview: 22+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-10-20 12:14 [PATCH v2 0/6] ath10k: pci related fixes 2014-10-09 Michal Kazior
2014-10-20 12:14 ` Michal Kazior
2014-10-20 12:14 ` [PATCH v2 1/6] ath10k: re-disable interrupts after target init Michal Kazior
2014-10-20 12:14   ` Michal Kazior
2014-10-20 12:14 ` [PATCH v2 2/6] ath10k: mask/unmask msi fw irq Michal Kazior
2014-10-20 12:14   ` Michal Kazior
2014-10-20 12:14 ` [PATCH v2 3/6] ath10k: split ce pipe init/alloc further Michal Kazior
2014-10-20 12:14   ` Michal Kazior
2014-10-20 12:14 ` [PATCH v2 4/6] ath10k: make warm reset a bit safer and faster Michal Kazior
2014-10-20 12:14   ` Michal Kazior
2014-10-23  8:27   ` Michal Kazior
2014-10-23  8:27     ` Michal Kazior
2014-10-23 13:14     ` Kalle Valo [this message]
2014-10-23 13:14       ` Kalle Valo
2014-10-23 13:19       ` Michal Kazior
2014-10-23 13:19         ` Michal Kazior
2014-10-20 12:14 ` [PATCH v2 5/6] ath10k: split reset logic from power up Michal Kazior
2014-10-20 12:14   ` Michal Kazior
2014-10-20 12:14 ` [PATCH v2 6/6] ath10k: don't reset chip on power_down Michal Kazior
2014-10-20 12:14   ` Michal Kazior
2014-10-23 13:46 ` [PATCH v2 0/6] ath10k: pci related fixes 2014-10-09 Kalle Valo
2014-10-23 13:46   ` Kalle Valo

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=871tpzq67b.fsf@kamboji.qca.qualcomm.com \
    --to=kvalo@qca.qualcomm.com \
    --cc=ath10k@lists.infradead.org \
    --cc=linux-wireless@vger.kernel.org \
    --cc=michal.kazior@tieto.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.