From: Andreas Schwab <schwab@linux-m68k.org>
To: Nicholas Krause <xerofoify@gmail.com>
Cc: geert@linux-m68k.org, linux-m68k@lists.linux-m68k.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] Fixes q40_irq_startup to return -ENXIO
Date: Mon, 30 Jun 2014 19:27:55 +0200 [thread overview]
Message-ID: <871tu6ux2c.fsf@igel.home> (raw)
In-Reply-To: <1404097610-5739-1-git-send-email-xerofoify@gmail.com> (Nicholas Krause's message of "Sun, 29 Jun 2014 23:06:50 -0400")
Nicholas Krause <xerofoify@gmail.com> writes:
> Fixes q40_irq_startup to return -ENXIO for cases 11-13 in the switch
> statement of this function to handle these failure cases.
>
> Signed-off-by: Nicholas Krause <xerofoify@gmail.com>
> ---
> arch/m68k/q40/q40ints.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/m68k/q40/q40ints.c b/arch/m68k/q40/q40ints.c
> index 513f9bb..9dfa1ea 100644
> --- a/arch/m68k/q40/q40ints.c
> +++ b/arch/m68k/q40/q40ints.c
> @@ -49,7 +49,7 @@ static unsigned int q40_irq_startup(struct irq_data *data)
> case 1: case 2: case 8: case 9:
> case 11: case 12: case 13:
> printk("%s: ISA IRQ %d not implemented by HW\n", __func__, irq);
> - /* FIXME return -ENXIO; */
> + return -ENXIO;
There must be more to it, given the FIXME.
Andreas.
--
Andreas Schwab, schwab@linux-m68k.org
GPG Key fingerprint = 58CA 54C7 6D53 942B 1756 01D3 44D5 214B 8276 4ED5
"And now for something completely different."
WARNING: multiple messages have this Message-ID (diff)
From: Andreas Schwab <schwab@linux-m68k.org>
To: Nicholas Krause <xerofoify@gmail.com>
Cc: geert@linux-m68k.org, linux-m68k@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] Fixes q40_irq_startup to return -ENXIO
Date: Mon, 30 Jun 2014 19:27:55 +0200 [thread overview]
Message-ID: <871tu6ux2c.fsf@igel.home> (raw)
In-Reply-To: <1404097610-5739-1-git-send-email-xerofoify@gmail.com> (Nicholas Krause's message of "Sun, 29 Jun 2014 23:06:50 -0400")
Nicholas Krause <xerofoify@gmail.com> writes:
> Fixes q40_irq_startup to return -ENXIO for cases 11-13 in the switch
> statement of this function to handle these failure cases.
>
> Signed-off-by: Nicholas Krause <xerofoify@gmail.com>
> ---
> arch/m68k/q40/q40ints.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/m68k/q40/q40ints.c b/arch/m68k/q40/q40ints.c
> index 513f9bb..9dfa1ea 100644
> --- a/arch/m68k/q40/q40ints.c
> +++ b/arch/m68k/q40/q40ints.c
> @@ -49,7 +49,7 @@ static unsigned int q40_irq_startup(struct irq_data *data)
> case 1: case 2: case 8: case 9:
> case 11: case 12: case 13:
> printk("%s: ISA IRQ %d not implemented by HW\n", __func__, irq);
> - /* FIXME return -ENXIO; */
> + return -ENXIO;
There must be more to it, given the FIXME.
Andreas.
--
Andreas Schwab, schwab@linux-m68k.org
GPG Key fingerprint = 58CA 54C7 6D53 942B 1756 01D3 44D5 214B 8276 4ED5
"And now for something completely different."
next prev parent reply other threads:[~2014-06-30 17:27 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-06-30 3:06 [PATCH] Fixes q40_irq_startup to return -ENXIO Nicholas Krause
2014-06-30 17:27 ` Andreas Schwab [this message]
2014-06-30 17:27 ` Andreas Schwab
2014-06-30 17:52 ` Geert Uytterhoeven
2014-07-01 1:56 ` Nick Krause
2014-07-01 1:56 ` Nick Krause
2014-06-30 17:52 ` Geert Uytterhoeven
-- strict thread matches above, loose matches on Subject: below --
2014-06-30 3:06 Nicholas Krause
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=871tu6ux2c.fsf@igel.home \
--to=schwab@linux-m68k.org \
--cc=geert@linux-m68k.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-m68k@lists.linux-m68k.org \
--cc=xerofoify@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.