From: Jani Nikula <jani.nikula@linux.intel.com>
To: Thomas Meyer <thomas@m3y3r.de>,
Linus Torvalds <torvalds@linux-foundation.org>,
"intel-gfx@lists.freedesktop.org"
<intel-gfx@lists.freedesktop.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
Chris Wilson <chris@chris-wilson.co.uk>
Subject: Re: Linux 3.16-rc2
Date: Tue, 24 Jun 2014 14:06:24 +0300 [thread overview]
Message-ID: <871tuea7nz.fsf@intel.com> (raw)
In-Reply-To: <1403564870.3091.6.camel@localhost.localdomain>
On Tue, 24 Jun 2014, Thomas Meyer <thomas@m3y3r.de> wrote:
> the i915 driver is still broken in 3.16-rc2. Resume from ram crashes the
> X server.
This is not new to 3.16-rc2; apparently we've had it since v3.15-rc4
[1]. Also related [2].
Chris, any fresh ideas?
Thomas, please consider filing a bug against DRM/Intel at [3]. They will
have a better chance of not being forgotten as the mail thread goes
cold.
Thanks,
Jani.
[1] http://thread.gmane.org/gmane.linux.kernel/1700872
[2] https://bugs.freedesktop.org/show_bug.cgi?id=76554
[3] https://bugs.freedesktop.org/enter_bug.cgi?product=DRI
>
> First bad commit is:
>
> # first bad commit: [78f2975eec9faff353a6194e854d3d39907bab68] drm/i915: Move all ring resets before setting the HWS page
>
> commit 78f2975eec9faff353a6194e854d3d39907bab68
> Author: Chris Wilson <chris@chris-wilson.co.uk>
> Date: Wed Apr 2 16:36:07 2014 +0100
>
> drm/i915: Move all ring resets before setting the HWS page
>
> In commit a51435a3137ad8ae75c288c39bd2d8b2696bae8f
> Author: Naresh Kumar Kachhi <naresh.kumar.kachhi@intel.com>
> Date: Wed Mar 12 16:39:40 2014 +0530
>
> drm/i915: disable rings before HW status page setup
>
> we reordered stopping the rings to do so before we set the HWS register.
> However, there is an extra workaround for g45 to reset the rings twice,
> and for consistency we should apply that workaround before setting the
> HWS to be sure that the rings are truly stopped.
>
> Reference: http://lkml.kernel.org/r/20140423202248.GA3621@amd.pavel.ucw.cz
> Tested-by: Pavel Machek <pavel@ucw.cz>
> Cc: Naresh Kumar Kachhi <naresh.kumar.kachhi@intel.com>
> Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
> Reviewed-by: Jesse Barnes <jbarnes@virtuousgeek.org>
> Signed-off-by: Daniel Vetter <daniel.vetter@ffwll.ch>
> Signed-off-by: Jani Nikula <jani.nikula@intel.com>
>
> Above commit is not revertable anymore on 3.16-rc2 without conflict.
>
>
>
> _______________________________________________
> Intel-gfx mailing list
> Intel-gfx@lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/intel-gfx
--
Jani Nikula, Intel Open Source Technology Center
WARNING: multiple messages have this Message-ID (diff)
From: Jani Nikula <jani.nikula@linux.intel.com>
To: Thomas Meyer <thomas@m3y3r.de>,
Linus Torvalds <torvalds@linux-foundation.org>,
"intel-gfx\@lists.freedesktop.org"
<intel-gfx@lists.freedesktop.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
"Chris Wilson" <chris@chris-wilson.co.uk>
Subject: Re: [Intel-gfx] Linux 3.16-rc2
Date: Tue, 24 Jun 2014 14:06:24 +0300 [thread overview]
Message-ID: <871tuea7nz.fsf@intel.com> (raw)
In-Reply-To: <1403564870.3091.6.camel@localhost.localdomain>
On Tue, 24 Jun 2014, Thomas Meyer <thomas@m3y3r.de> wrote:
> the i915 driver is still broken in 3.16-rc2. Resume from ram crashes the
> X server.
This is not new to 3.16-rc2; apparently we've had it since v3.15-rc4
[1]. Also related [2].
Chris, any fresh ideas?
Thomas, please consider filing a bug against DRM/Intel at [3]. They will
have a better chance of not being forgotten as the mail thread goes
cold.
Thanks,
Jani.
[1] http://thread.gmane.org/gmane.linux.kernel/1700872
[2] https://bugs.freedesktop.org/show_bug.cgi?id=76554
[3] https://bugs.freedesktop.org/enter_bug.cgi?product=DRI
>
> First bad commit is:
>
> # first bad commit: [78f2975eec9faff353a6194e854d3d39907bab68] drm/i915: Move all ring resets before setting the HWS page
>
> commit 78f2975eec9faff353a6194e854d3d39907bab68
> Author: Chris Wilson <chris@chris-wilson.co.uk>
> Date: Wed Apr 2 16:36:07 2014 +0100
>
> drm/i915: Move all ring resets before setting the HWS page
>
> In commit a51435a3137ad8ae75c288c39bd2d8b2696bae8f
> Author: Naresh Kumar Kachhi <naresh.kumar.kachhi@intel.com>
> Date: Wed Mar 12 16:39:40 2014 +0530
>
> drm/i915: disable rings before HW status page setup
>
> we reordered stopping the rings to do so before we set the HWS register.
> However, there is an extra workaround for g45 to reset the rings twice,
> and for consistency we should apply that workaround before setting the
> HWS to be sure that the rings are truly stopped.
>
> Reference: http://lkml.kernel.org/r/20140423202248.GA3621@amd.pavel.ucw.cz
> Tested-by: Pavel Machek <pavel@ucw.cz>
> Cc: Naresh Kumar Kachhi <naresh.kumar.kachhi@intel.com>
> Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
> Reviewed-by: Jesse Barnes <jbarnes@virtuousgeek.org>
> Signed-off-by: Daniel Vetter <daniel.vetter@ffwll.ch>
> Signed-off-by: Jani Nikula <jani.nikula@intel.com>
>
> Above commit is not revertable anymore on 3.16-rc2 without conflict.
>
>
>
> _______________________________________________
> Intel-gfx mailing list
> Intel-gfx@lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/intel-gfx
--
Jani Nikula, Intel Open Source Technology Center
next prev parent reply other threads:[~2014-06-24 11:06 UTC|newest]
Thread overview: 34+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-06-22 5:22 Linux 3.16-rc2 Linus Torvalds
2014-06-23 23:07 ` Thomas Meyer
2014-06-24 11:06 ` Jani Nikula [this message]
2014-06-24 11:06 ` [Intel-gfx] " Jani Nikula
2014-06-24 11:57 ` Chris Wilson
2014-06-24 11:57 ` [Intel-gfx] " Chris Wilson
2014-06-24 12:24 ` Thomas Meyer
2014-06-24 12:24 ` [Intel-gfx] " Thomas Meyer
2014-06-24 12:27 ` Chris Wilson
2014-06-24 12:27 ` [Intel-gfx] " Chris Wilson
2014-06-30 10:02 ` Pavel Machek
2014-06-30 10:02 ` [Intel-gfx] " Pavel Machek
2014-06-30 10:09 ` Chris Wilson
2014-06-30 10:09 ` [Intel-gfx] " Chris Wilson
2014-07-02 16:18 ` Thomas Meyer
2014-07-02 16:18 ` [Intel-gfx] " Thomas Meyer
2014-07-07 15:16 ` Daniel Vetter
2014-07-07 15:16 ` [Intel-gfx] " Daniel Vetter
2014-07-07 15:32 ` Jiri Kosina
2014-07-07 15:32 ` [Intel-gfx] " Jiri Kosina
2014-07-07 16:04 ` Chris Wilson
2014-07-07 16:04 ` [Intel-gfx] " Chris Wilson
2014-07-07 22:15 ` Jiri Kosina
2014-07-07 22:15 ` [Intel-gfx] " Jiri Kosina
2014-07-08 8:35 ` Daniel Vetter
2014-07-08 8:35 ` [Intel-gfx] " Daniel Vetter
2014-07-08 8:59 ` Chris Wilson
2014-07-08 8:59 ` [Intel-gfx] " Chris Wilson
2014-07-08 12:46 ` Jiri Kosina
2014-07-08 12:46 ` [Intel-gfx] " Jiri Kosina
2014-07-08 12:55 ` Chris Wilson
2014-07-08 12:55 ` [Intel-gfx] " Chris Wilson
2014-07-08 12:59 ` Jiri Kosina
2014-07-08 12:59 ` [Intel-gfx] " Jiri Kosina
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=871tuea7nz.fsf@intel.com \
--to=jani.nikula@linux.intel.com \
--cc=chris@chris-wilson.co.uk \
--cc=intel-gfx@lists.freedesktop.org \
--cc=linux-kernel@vger.kernel.org \
--cc=thomas@m3y3r.de \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.