All of lore.kernel.org
 help / color / mirror / Atom feed
From: ebiederm@xmission.com (Eric W. Biederman)
To: Al Viro <viro@ZenIV.linux.org.uk>
Cc: <linux-fsdevel@vger.kernel.org>,
	Andrew Morton <akpm@linux-foundation.org>,
	<linux-kernel@vger.kernel.org>
Subject: [PATCH] vfs: Don't leak a path when get_empty_filp in dentry_open
Date: Thu, 16 Jan 2014 15:45:38 -0800	[thread overview]
Message-ID: <871u07wkwt.fsf@xmission.com> (raw)


Normally in dentry_open the passed in path is placed on the new filp
removing the caller from needing to worry about it.  In the rare case
that we can not allocate a filp the path is not consumed.  None of the
callers of dentry_open call path_put in their error handling when
dentry_open fails so call path_put for them on error and keep everyone's
error handling simple.

Cc: stable@vger.kernel.org
Signed-off-by: "Eric W. Biederman" <ebiederm@xmission.com>
---
 fs/open.c |    2 ++
 1 files changed, 2 insertions(+), 0 deletions(-)

diff --git a/fs/open.c b/fs/open.c
index 4b3e1edf2fe4..0afa243941da 100644
--- a/fs/open.c
+++ b/fs/open.c
@@ -843,6 +843,8 @@ struct file *dentry_open(const struct path *path, int flags,
 			put_filp(f);
 			f = ERR_PTR(error);
 		}
+	} else {
+		path_put(path);
 	}
 	return f;
 }
-- 
1.7.5.4

             reply	other threads:[~2014-01-16 23:45 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-01-16 23:45 Eric W. Biederman [this message]
2014-01-16 23:59 ` [PATCH] vfs: Don't leak a path when get_empty_filp in dentry_open Al Viro
2014-01-17  0:17   ` Eric W. Biederman

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=871u07wkwt.fsf@xmission.com \
    --to=ebiederm@xmission.com \
    --cc=akpm@linux-foundation.org \
    --cc=linux-fsdevel@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=viro@ZenIV.linux.org.uk \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.