From: ebiederm-aS9lmoZGLiVWk0Htik3J/w@public.gmane.org (Eric W. Biederman)
To: mtk.manpages-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org
Cc: linux-man <linux-man-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>,
Linux Containers
<containers-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org>,
lkml <linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>,
Vasily Kulikov <segoon-cxoSlKxDwOJWk0Htik3J/w@public.gmane.org>
Subject: Re: For review: pid_namespaces(7) man page (draft 2)
Date: Tue, 12 Mar 2013 14:43:58 -0700 [thread overview]
Message-ID: <871ubkz42p.fsf@xmission.com> (raw)
In-Reply-To: <CAKgNAkgAT8vFr7hbEzOjJG5pCt8-kh_4Wh9yrzHHXrCJ3Fhh+w-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org> (Michael Kerrisk's message of "Tue, 12 Mar 2013 08:07:30 +0100")
"Michael Kerrisk (man-pages)" <mtk.manpages-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org> writes:
> Eric et al.,
>
> [CCing Li because of reboot(2) changes]
>
> I have (I think) addressed all previous comments in the current draft
> of the pid_namespaces(7) page. This is a final sanity check before I
> call this page complete (modulo any future kernel changes).
Baring the 3.9 reference to reboot(2) which should be 3.4 I don't see
any problems.
I think you have reached the point where if there are any problems left
I will just have to send you patches after you publish because my eyes
are glassing over and I am not going to see any more problems right now.
One of those patches I am going to have to send you is I am fixing the
case below for 3.10
> clone(..., CLONE_VM, ...);
> setns(fd, CLONE_NEWPID); /* Fails */
>
> clone(..., CLONE_VM, ...);
> unshare(CLONE_NEWPID); /* Fails */
>
It turns out that the check in fork/clone is sufficient.
The verbage about all of the namespaces is correct however since
unshare(CLONE_NEWPID) doesn't actually change the pid_namespace it
doesn't matter.
Eric
WARNING: multiple messages have this Message-ID (diff)
From: ebiederm@xmission.com (Eric W. Biederman)
To: mtk.manpages@gmail.com
Cc: Rob Landley <rob@landley.net>,
linux-man <linux-man@vger.kernel.org>,
Linux Containers <containers@lists.linux-foundation.org>,
lkml <linux-kernel@vger.kernel.org>,
Vasily Kulikov <segoon@openwall.com>,
Li Zefan <lizefan@huawei.com>
Subject: Re: For review: pid_namespaces(7) man page (draft 2)
Date: Tue, 12 Mar 2013 14:43:58 -0700 [thread overview]
Message-ID: <871ubkz42p.fsf@xmission.com> (raw)
In-Reply-To: <CAKgNAkgAT8vFr7hbEzOjJG5pCt8-kh_4Wh9yrzHHXrCJ3Fhh+w@mail.gmail.com> (Michael Kerrisk's message of "Tue, 12 Mar 2013 08:07:30 +0100")
"Michael Kerrisk (man-pages)" <mtk.manpages@gmail.com> writes:
> Eric et al.,
>
> [CCing Li because of reboot(2) changes]
>
> I have (I think) addressed all previous comments in the current draft
> of the pid_namespaces(7) page. This is a final sanity check before I
> call this page complete (modulo any future kernel changes).
Baring the 3.9 reference to reboot(2) which should be 3.4 I don't see
any problems.
I think you have reached the point where if there are any problems left
I will just have to send you patches after you publish because my eyes
are glassing over and I am not going to see any more problems right now.
One of those patches I am going to have to send you is I am fixing the
case below for 3.10
> clone(..., CLONE_VM, ...);
> setns(fd, CLONE_NEWPID); /* Fails */
>
> clone(..., CLONE_VM, ...);
> unshare(CLONE_NEWPID); /* Fails */
>
It turns out that the check in fork/clone is sufficient.
The verbage about all of the namespaces is correct however since
unshare(CLONE_NEWPID) doesn't actually change the pid_namespace it
doesn't matter.
Eric
next prev parent reply other threads:[~2013-03-12 21:43 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-03-12 7:07 For review: pid_namespaces(7) man page (draft 2) Michael Kerrisk (man-pages)
2013-03-12 7:07 ` Michael Kerrisk (man-pages)
[not found] ` <CAKgNAkgAT8vFr7hbEzOjJG5pCt8-kh_4Wh9yrzHHXrCJ3Fhh+w-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2013-03-12 21:43 ` Eric W. Biederman [this message]
2013-03-12 21:43 ` Eric W. Biederman
-- strict thread matches above, loose matches on Subject: below --
2013-03-12 7:07 Michael Kerrisk (man-pages)
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=871ubkz42p.fsf@xmission.com \
--to=ebiederm-as9lmozglivwk0htik3j/w@public.gmane.org \
--cc=containers-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org \
--cc=linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=linux-man-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=mtk.manpages-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org \
--cc=segoon-cxoSlKxDwOJWk0Htik3J/w@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.