Adding a i915 quirk (here: pipe A force quirk for testing purposes)?

Adding a i915 quirk (here: pipe A force quirk for testing purposes)?

[Sedat Dilek]

Hi,

>From [1]:
...
static struct intel_quirk intel_quirks[] = {
	/* HP Mini needs pipe A force quirk (LP: #322104) */
	{ 0x27ae, 0x103c, 0x361a, quirk_pipea_force },
...
}

Triple - which value is what?

00:02.0 VGA compatible controller [0300]: Intel Corporation 2nd
Generation Core Processor Family Integrated Graphics Controller
[8086:0116] (rev 09) (prog-if 00 [VGA controller])
        Subsystem: Samsung Electronics Co Ltd Device [144d:c0c7]
        Control: I/O+ Mem+ BusMaster+ SpecCycle- MemWINV- VGASnoop-
ParErr- Stepping- SERR- FastB2B- DisINTx+
        Status: Cap+ 66MHz- UDF- FastB2B+ ParErr- DEVSEL=fast >TAbort-
<TAbort- <MAbort- >SERR- <PERR- INTx-
        Latency: 0
        Interrupt: pin A routed to IRQ 49
        Region 0: Memory at f0000000 (64-bit, non-prefetchable) [size=4M]
        Region 2: Memory at e0000000 (64-bit, prefetchable) [size=256M]
        Region 4: I/O ports at 3000 [size=64]
        Expansion ROM at <unassigned> [disabled]
        Capabilities: <access denied>
        Kernel driver in use: i915

$ dmesg | egrep -i 'drm|i915' | grep dump_device_info
[   15.242823] [drm:i915_dump_device_info], i915 device info: gen=6,
pciid=0x0116 flags=is_mobile,need_gfx_hws,has_force_wake,has_fbc,has_hotplug,has_bsd_ring,has_blt_ring,has_llc,

OK, 0x0116 is the PCI-ID.

Seen also here...
Intel Corporation 2nd Generation Core Processor Family Integrated
Graphics Controller [8086:0116] (rev 09)

The two other values are from this line?

Subsystem: Samsung Electronics Co Ltd Device [144d:c0c7]

If so, what is what in triple :-)?

Thanks in advance.

Regards,
- Sedat -


http://cgit.freedesktop.org/~danvet/drm-intel/tree/drivers/gpu/drm/i915/intel_display.c?h=drm-intel-nightly#n8609

Re: Adding a i915 quirk (here: pipe A force quirk for testing purposes)?

[Sedat Dilek]

On Mon, Jan 28, 2013 at 12:52 AM, Sedat Dilek <sedat.dilek@gmail.com> wrote:
> Hi,
>
> From [1]:
> ...
> static struct intel_quirk intel_quirks[] = {
>         /* HP Mini needs pipe A force quirk (LP: #322104) */
>         { 0x27ae, 0x103c, 0x361a, quirk_pipea_force },
> ...
> }
>
> Triple - which value is what?
>
> 00:02.0 VGA compatible controller [0300]: Intel Corporation 2nd
> Generation Core Processor Family Integrated Graphics Controller
> [8086:0116] (rev 09) (prog-if 00 [VGA controller])
>         Subsystem: Samsung Electronics Co Ltd Device [144d:c0c7]
>         Control: I/O+ Mem+ BusMaster+ SpecCycle- MemWINV- VGASnoop-
> ParErr- Stepping- SERR- FastB2B- DisINTx+
>         Status: Cap+ 66MHz- UDF- FastB2B+ ParErr- DEVSEL=fast >TAbort-
> <TAbort- <MAbort- >SERR- <PERR- INTx-
>         Latency: 0
>         Interrupt: pin A routed to IRQ 49
>         Region 0: Memory at f0000000 (64-bit, non-prefetchable) [size=4M]
>         Region 2: Memory at e0000000 (64-bit, prefetchable) [size=256M]
>         Region 4: I/O ports at 3000 [size=64]
>         Expansion ROM at <unassigned> [disabled]
>         Capabilities: <access denied>
>         Kernel driver in use: i915
>
> $ dmesg | egrep -i 'drm|i915' | grep dump_device_info
> [   15.242823] [drm:i915_dump_device_info], i915 device info: gen=6,
> pciid=0x0116 flags=is_mobile,need_gfx_hws,has_force_wake,has_fbc,has_hotplug,has_bsd_ring,has_blt_ring,has_llc,
>
> OK, 0x0116 is the PCI-ID.
>
> Seen also here...
> Intel Corporation 2nd Generation Core Processor Family Integrated
> Graphics Controller [8086:0116] (rev 09)
>
> The two other values are from this line?
>
> Subsystem: Samsung Electronics Co Ltd Device [144d:c0c7]
>
> If so, what is what in triple :-)?
>
> Thanks in advance.
>

Something like the below is OK?

[ Xorg.0.log ]

[    16.421] (--) PCI:*(0:0:2:0) 8086:0116:144d:c0c7 rev 9, Mem @
0xf0000000/4194304, 0xe0000000/268435456, I/O @ 0x00003000/64

diff --git a/drivers/gpu/drm/i915/intel_display.c
b/drivers/gpu/drm/i915/intel_display.c
index 0e2030f..1f33994 100644
--- a/drivers/gpu/drm/i915/intel_display.c
+++ b/drivers/gpu/drm/i915/intel_display.c
@@ -8613,6 +8613,9 @@ static const struct intel_dmi_quirk intel_dmi_quirks[] = {
 };

 static struct intel_quirk intel_quirks[] = {
+       /* Samsung NP530U3B-A01DE needs pipe A force quirk */
+       { 0x0116, 0x144d, 0xc0c7, quirk_pipea_force },
+
        /* HP Mini needs pipe A force quirk (LP: #322104) */
        { 0x27ae, 0x103c, 0x361a, quirk_pipea_force },

- Sedat -

> Regards,
> - Sedat -
>
>
> http://cgit.freedesktop.org/~danvet/drm-intel/tree/drivers/gpu/drm/i915/intel_display.c?h=drm-intel-nightly#n8609

Re: Adding a i915 quirk (here: pipe A force quirk for testing purposes)?

[Sedat Dilek]

On Mon, Jan 28, 2013 at 1:16 AM, Sedat Dilek <sedat.dilek@gmail.com> wrote:
> On Mon, Jan 28, 2013 at 12:52 AM, Sedat Dilek <sedat.dilek@gmail.com> wrote:
>> Hi,
>>
>> From [1]:
>> ...
>> static struct intel_quirk intel_quirks[] = {
>>         /* HP Mini needs pipe A force quirk (LP: #322104) */
>>         { 0x27ae, 0x103c, 0x361a, quirk_pipea_force },
>> ...
>> }
>>
>> Triple - which value is what?
>>
>> 00:02.0 VGA compatible controller [0300]: Intel Corporation 2nd
>> Generation Core Processor Family Integrated Graphics Controller
>> [8086:0116] (rev 09) (prog-if 00 [VGA controller])
>>         Subsystem: Samsung Electronics Co Ltd Device [144d:c0c7]
>>         Control: I/O+ Mem+ BusMaster+ SpecCycle- MemWINV- VGASnoop-
>> ParErr- Stepping- SERR- FastB2B- DisINTx+
>>         Status: Cap+ 66MHz- UDF- FastB2B+ ParErr- DEVSEL=fast >TAbort-
>> <TAbort- <MAbort- >SERR- <PERR- INTx-
>>         Latency: 0
>>         Interrupt: pin A routed to IRQ 49
>>         Region 0: Memory at f0000000 (64-bit, non-prefetchable) [size=4M]
>>         Region 2: Memory at e0000000 (64-bit, prefetchable) [size=256M]
>>         Region 4: I/O ports at 3000 [size=64]
>>         Expansion ROM at <unassigned> [disabled]
>>         Capabilities: <access denied>
>>         Kernel driver in use: i915
>>
>> $ dmesg | egrep -i 'drm|i915' | grep dump_device_info
>> [   15.242823] [drm:i915_dump_device_info], i915 device info: gen=6,
>> pciid=0x0116 flags=is_mobile,need_gfx_hws,has_force_wake,has_fbc,has_hotplug,has_bsd_ring,has_blt_ring,has_llc,
>>
>> OK, 0x0116 is the PCI-ID.
>>
>> Seen also here...
>> Intel Corporation 2nd Generation Core Processor Family Integrated
>> Graphics Controller [8086:0116] (rev 09)
>>
>> The two other values are from this line?
>>
>> Subsystem: Samsung Electronics Co Ltd Device [144d:c0c7]
>>
>> If so, what is what in triple :-)?
>>
>> Thanks in advance.
>>
>
> Something like the below is OK?
>
> [ Xorg.0.log ]
>
> [    16.421] (--) PCI:*(0:0:2:0) 8086:0116:144d:c0c7 rev 9, Mem @
> 0xf0000000/4194304, 0xe0000000/268435456, I/O @ 0x00003000/64
>
> diff --git a/drivers/gpu/drm/i915/intel_display.c
> b/drivers/gpu/drm/i915/intel_display.c
> index 0e2030f..1f33994 100644
> --- a/drivers/gpu/drm/i915/intel_display.c
> +++ b/drivers/gpu/drm/i915/intel_display.c
> @@ -8613,6 +8613,9 @@ static const struct intel_dmi_quirk intel_dmi_quirks[] = {
>  };
>
>  static struct intel_quirk intel_quirks[] = {
> +       /* Samsung NP530U3B-A01DE needs pipe A force quirk */
> +       { 0x0116, 0x144d, 0xc0c7, quirk_pipea_force },
> +
>         /* HP Mini needs pipe A force quirk (LP: #322104) */
>         { 0x27ae, 0x103c, 0x361a, quirk_pipea_force },
>

/me makes the Becker F.a.u.s.t....

[   15.047921] [drm] applying pipe a force quirk

- Sedat -


> - Sedat -
>
>> Regards,
>> - Sedat -
>>
>>
>> http://cgit.freedesktop.org/~danvet/drm-intel/tree/drivers/gpu/drm/i915/intel_display.c?h=drm-intel-nightly#n8609

Re: [Intel-gfx] Adding a i915 quirk (here: pipe A force quirk for testing purposes)?

[Jani Nikula]

On Mon, 28 Jan 2013, Sedat Dilek <sedat.dilek@gmail.com> wrote:
> ...
> static struct intel_quirk intel_quirks[] = {
> 	/* HP Mini needs pipe A force quirk (LP: #322104) */
> 	{ 0x27ae, 0x103c, 0x361a, quirk_pipea_force },
> ...
> }
>
> Triple - which value is what?

I guess you figured it out, but just a few lines up there's [1]:

struct intel_quirk {
	int device;
	int subsystem_vendor;
	int subsystem_device;
	void (*hook)(struct drm_device *dev);
};

where device, subsystem_vendor, and subsystem_device map to Device,
SVendor, and SDevice of the gfx controller in 'lspci -vmnn' output.

HTH,
Jani.

[1] http://cgit.freedesktop.org/~danvet/drm-intel/tree/drivers/gpu/drm/i915/intel_display.c?h=drm-intel-nightly#n8574

Re: Adding a i915 quirk (here: pipe A force quirk for testing purposes)?

[Sedat Dilek]

On Mon, Jan 28, 2013 at 4:01 PM, Jani Nikula
<jani.nikula@linux.intel.com> wrote:
> On Mon, 28 Jan 2013, Sedat Dilek <sedat.dilek@gmail.com> wrote:
>> ...
>> static struct intel_quirk intel_quirks[] = {
>>       /* HP Mini needs pipe A force quirk (LP: #322104) */
>>       { 0x27ae, 0x103c, 0x361a, quirk_pipea_force },
>> ...
>> }
>>
>> Triple - which value is what?
>
> I guess you figured it out, but just a few lines up there's [1]:
>
> struct intel_quirk {
>         int device;
>         int subsystem_vendor;
>         int subsystem_device;
>         void (*hook)(struct drm_device *dev);
> };
>
> where device, subsystem_vendor, and subsystem_device map to Device,
> SVendor, and SDevice of the gfx controller in 'lspci -vmnn' output.
>

Oh, cool.
Did not know of these parameters...

Device: 00:02.0
Class:  VGA compatible controller [0300]
Vendor: Intel Corporation [8086]
Device: 2nd Generation Core Processor Family Integrated Graphics
Controller [0116]
SVendor:        Samsung Electronics Co Ltd [144d]
SDevice:        Device [c0c7]
Rev:    09

...together with the pasted code-snippet, it is clear to me!

Thanks for the explanation and hints!

- Sedat -

> HTH,
> Jani.
>
> [1] http://cgit.freedesktop.org/~danvet/drm-intel/tree/drivers/gpu/drm/i915/intel_display.c?h=drm-intel-nightly#n8574