From: Kevin Hilman <khilman@ti.com>
To: "Mark A. Greer" <mgreer@animalcreek.com>
Cc: paul@pwsan.com, linux-arm-kernel@lists.infradead.org,
linux-omap@vger.kernel.org
Subject: Re: [PATCH v2 2/2] arm: omap3: am35x: Disable hlt when using Davinci EMAC
Date: Thu, 31 May 2012 11:58:43 -0700 [thread overview]
Message-ID: <871um018kc.fsf@ti.com> (raw)
In-Reply-To: <1337105642-22711-3-git-send-email-mgreer@animalcreek.com> (Mark A. Greer's message of "Tue, 15 May 2012 11:14:02 -0700")
"Mark A. Greer" <mgreer@animalcreek.com> writes:
> From: "Mark A. Greer" <mgreer@animalcreek.com>
>
> The am35x family of SoCs has a Davinci EMAC ethernet
> controller on-chip. Unfortunately, the EMAC is unable
> to wake the PRCM when there is network activity which
> leads to a hung or extremely slow system when the MPU
> has executed a 'wfi' instruction (because of pm_idle
> or CPUidle). To prevent this, add hooks to the EMAC
> pm_runtime suspend/resume calls so that hlt is disabled
> whenever the EMAC is in use.
>
> Signed-off-by: Mark A. Greer <mgreer@animalcreek.com>
Looks good,
Acked-by: Kevin Hilman <khilman@ti.com>
WARNING: multiple messages have this Message-ID (diff)
From: khilman@ti.com (Kevin Hilman)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v2 2/2] arm: omap3: am35x: Disable hlt when using Davinci EMAC
Date: Thu, 31 May 2012 11:58:43 -0700 [thread overview]
Message-ID: <871um018kc.fsf@ti.com> (raw)
In-Reply-To: <1337105642-22711-3-git-send-email-mgreer@animalcreek.com> (Mark A. Greer's message of "Tue, 15 May 2012 11:14:02 -0700")
"Mark A. Greer" <mgreer@animalcreek.com> writes:
> From: "Mark A. Greer" <mgreer@animalcreek.com>
>
> The am35x family of SoCs has a Davinci EMAC ethernet
> controller on-chip. Unfortunately, the EMAC is unable
> to wake the PRCM when there is network activity which
> leads to a hung or extremely slow system when the MPU
> has executed a 'wfi' instruction (because of pm_idle
> or CPUidle). To prevent this, add hooks to the EMAC
> pm_runtime suspend/resume calls so that hlt is disabled
> whenever the EMAC is in use.
>
> Signed-off-by: Mark A. Greer <mgreer@animalcreek.com>
Looks good,
Acked-by: Kevin Hilman <khilman@ti.com>
next prev parent reply other threads:[~2012-05-31 18:58 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-05-15 18:14 [PATCH v2 0/2] arm: omap3: am35x: Convert emac to hwmod & disable hlt when open Mark A. Greer
2012-05-15 18:14 ` Mark A. Greer
2012-05-15 18:14 ` [PATCH v2 1/2] arm: omap3: am35x: Add Davinci EMAC/MDIO hwmod support Mark A. Greer
2012-05-15 18:14 ` Mark A. Greer
2012-06-27 21:19 ` Paul Walmsley
2012-06-27 21:19 ` Paul Walmsley
2012-06-27 21:24 ` Paul Walmsley
2012-06-27 21:24 ` Paul Walmsley
2012-05-15 18:14 ` [PATCH v2 2/2] arm: omap3: am35x: Disable hlt when using Davinci EMAC Mark A. Greer
2012-05-15 18:14 ` Mark A. Greer
2012-05-31 18:58 ` Kevin Hilman [this message]
2012-05-31 18:58 ` Kevin Hilman
2012-06-27 21:20 ` Paul Walmsley
2012-06-27 21:20 ` Paul Walmsley
2012-05-31 18:57 ` [PATCH v2 0/2] arm: omap3: am35x: Convert emac to hwmod & disable hlt when open Kevin Hilman
2012-05-31 18:57 ` Kevin Hilman
2012-06-27 21:58 ` Paul Walmsley
2012-06-27 21:58 ` Paul Walmsley
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=871um018kc.fsf@ti.com \
--to=khilman@ti.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-omap@vger.kernel.org \
--cc=mgreer@animalcreek.com \
--cc=paul@pwsan.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.